mstorsjo added a subscriber: rnk. mstorsjo added a comment. In D111457#3085273 <https://reviews.llvm.org/D111457#3085273>, @keith wrote:
> Yep this makes sense. I would rather not scope that into this if that's ok. > Since this test was already invalid and broken (actual fix in > https://reviews.llvm.org/D111579) I would rather land these and then take > that on to unblock my original use case (https://reviews.llvm.org/D111587) if > I can find some more time Ok, fair enough - I guess that sounds reasonable, so that'd be a +1 from me to this patch. Ideally it'd be good to find someone more authoritative around clang and these areas than me, but I guess reviewer attention is scarce and hard to come by. @rnk - does this seem sensible to you? Let's give it a little more time for someone else to comment on it, otherwise I guess I could approve it... Then for the future cleanup, one might be able to stop using the native substitutions, by keeping one test entirely using possibly-foreign posix style forward slashes, and one using the windows style paths (with that test possibly limited to only executed when on windows, if necessary - but being able to map things to a windows path while cross compiling is good too). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
