[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

mboehme created this revision. mboehme added a reviewer: sammccall. mboehme added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have no way to reason about the

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

mboehme updated this revision to Diff 328491. mboehme added a comment. Responses to review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98034/new/ https://reviews.llvm.org/D98034 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/docs/cl

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

mboehme marked 5 inline comments as done. mboehme added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:396 void UseAfterMoveCheck::registerMatchers(MatchFinder *Finder) { + auto StandardMapMatcher = + hasType(hasUnqualifiedDesugare

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked 3 inline comments as done. Closed by commit rGe67d91faec21: [clang-ti

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

mboehme added a comment. In D98034#2606488 , @njames93 wrote: > While `try_emplace` is a special case, it's may not be the only special case > in someone's codebase, this should be extended with options to let users > handle their special containers. So

[PATCH] D98034: [clang-tidy] Use-after-move: Ignore moves inside a try_emplace.

mboehme added a comment. First of all, sorry for submitting this change prematurely. I don't contribute to LLVM/Clang regularly and forgot that reviews should be kept open for a while after a reviewer has approved them to give others a chance to chime in. I jumped the gun here -- apologies. In

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme created this revision. mboehme added a reviewer: aaron.ballman. mboehme added a project: clang. mboehme requested review of this revision. Herald added a subscriber: cfe-commits. A typical use case would be to allow custom attributes for pointer types. See examples/Attribute/Attribute.cpp

[PATCH] D139935: [NFC] [Doc] Fix example for AnnotateTypeDocs

mboehme added a comment. Sorry for the delay. Just to confirm, yes this should of course be `annotate_type`. Thanks for catching my mistake. @aaron.ballman Thanks for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139935/new/ https://r

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme added a comment. Is there anything else that needs to happen on this change before it's ready to land? There is some breakage in the pre-merge checks, but it looks as if it's pre-existing breakage. See the comment-only change here that looks as if it exhibits similar breakage: https:/

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. @aaron.ballman Any further comments from you on this change? There is some breakage in the pre-merge checks, but it looks as if it's pre-existing breakage. See the comment-only change here that looks as if it exhibits similar breakage: https://reviews.llvm.org/D127494

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme updated this revision to Diff 436713. mboehme added a comment. Change attribute documentation so it's not specific to C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111548/new/ https://reviews.llvm.org/D111548 Files: clang/docs/Relea

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme updated this revision to Diff 436732. mboehme marked 2 inline comments as done. mboehme added a comment. Instead of allowing all type attributes on the decl-specifier-seq, allow only `annotate_type` for now. The more general change will be done in https://reviews.llvm.org/D126061. Reposi

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6501 + +The attribute does not have any effect on the semantics of C++ code, neither +type checking rules, nor runtime semantics. In particular:

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme marked 11 inline comments as done. mboehme added a comment. In D126061#3581350 , @aaron.ballman wrote: > Only thing left for me are the nits I pointed out in the last review, > otherwise I think this is all set. Thanks for the quick turnaround!

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme updated this revision to Diff 436764. mboehme marked an inline comment as done. mboehme added a comment. Fixed syntax error in ReleaseNotes.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111548/new/ https://reviews.llvm.org/D111548 Fil

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/docs/ReleaseNotes.rst:349 +- Added the `clang::annotate_type` attribute, which can be used to add + annotations to types (see documentation for details). aaron.ballman w

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme marked 2 inline comments as done. mboehme added a comment. Thank you @aaron.ballman and @rsmith for the careful and productive reviews! Comment at: clang/lib/Parse/ParseStmt.cpp:229 default: { +bool HaveAttrs = !(CXX11Attrs.empty() && GNUAttrs.empty()); +auto

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG665da187ccf3: [Clang] Add the `annotate_type` attribute (authored by mboehme). Repository: rG LLVM Githu

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. In D126061#3585681 , @nikic wrote: > FYI this change had a measurable effect on compile-time > (http://llvm-compile-time-tracker.com/compare.php?from=7acc88be0312c721bc082ed9934e381d297f4707&to=8c7b64b5ae2a09027c38db969a04fc9ddd0

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. In D126061#3590896 , @dyung wrote: > @mboehme, one of our internal tests started to fail to compile after this > change due to the compiler no longer accepting what I think should be a valid > attribute declaration. I have filed

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. In D126061#3585681 , @nikic wrote: > FYI this change had a measurable effect on compile-time > (http://llvm-compile-time-tracker.com/compare.php?from=7acc88be0312c721bc082ed9934e381d297f4707&to=8c7b64b5ae2a09027c38db969a04fc9ddd0

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

mboehme created this revision. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As noted by @nikic, D126061 causes a compile time regression of about 0.5% on -O0 builds

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. Fix for compile time regression submitted for review at https://reviews.llvm.org/D128097 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126061/new/ https://reviews.llvm.org/D126061 _

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

mboehme added a comment. CI breakage is the usual libomp breakage and appears to be unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128097/new/ https://reviews.llvm.org/D128097 ___ cfe-commits m

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d300da799b0: [Clang] Fix compile time regression caused by D126061. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

mboehme added a comment. Unfortunately, it looks as if this patch did not fix the compile-time regression entirely. It did so for the particular source file I tested above, but other source files are still slower to compile than before D126061 . For reference,

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. https://reviews.llvm.org/D128097 is now submitted. Unfortunately, it didn't fix the compile-time regression entirely (see detailed comments there). I'll do some more investigation to see where the rest of the slowdown is coming from. Repository: rG LLVM Github Monor

[PATCH] D128439: [Clang][WIP] Don't call distributeTypeAttrsFromDeclarator() on empty list.

mboehme created this revision. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This check was present before https://reviews.llvm.org/D126061. I eliminated it as part of that patch because it seemed supe

[PATCH] D128439: [Clang][WIP] Don't call distributeTypeAttrsFromDeclarator() on empty list.

mboehme added a comment. Marking as {WIP] for the time being because I'm uploading this change for discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128439/new/ https://reviews.llvm.org/D128439

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

mboehme added a comment. In D128097#3604295 , @yurai007 wrote: > Disclaimer: I'm not front-end guy. > > After running 7zip benchmark under perf and comparing origin (7acc88be031 > ) wit

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

mboehme added a comment. To add to the points that @yurai007 pointed out, I’ve done some more investigation of my own. **Compile-time regression does not seem to reproduce locally** Unfortunately, I still haven’t been able to get the test suite running locally. However, I’ve looked at some ind

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. In D126061#3605276 , @miyuki wrote: > Hi Martin, > > I think this patch caused a regression in diagnostics. Clang used to warn > about the following code: [snip] > And now it doesn't. Could you please have a look into it? Than

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

mboehme created this revision. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before D126061 , Clang would warn about this code struct X { [[deprecated]] stru

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. Fix in review at https://reviews.llvm.org/D128499 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126061/new/ https://reviews.llvm.org/D126061 ___ cfe-commits mailing list cfe-comm

[PATCH] D128439: [Clang][WIP] Don't call distributeTypeAttrsFromDeclarator() on empty list.

mboehme added a comment. In D128439#3605266 , @nikic wrote: > Not seeing a statistically significant impact from this change: > http://llvm-compile-time-tracker.com/compare.php?from=8b6f69a4da5baaf3748798a84dd16a2481b7ca7f&to=797ba50f5fd88017925fe765427b

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

mboehme added a comment. In D128097#3605307 , @nikic wrote: > @mboehme Cycle counts are very noisy, and it's pretty much impossible to > determine whether they changed by looking at a single commit, unless the > differences are huge (like 10%). In this

[PATCH] D128439: [Clang][WIP] Don't call distributeTypeAttrsFromDeclarator() on empty list.

mboehme added a comment. In D128439#3607350 , @nikic wrote: > In D128439#3607289 , @mboehme wrote: > >> Just a question for my understanding before I abandon the change: Shouldn't >> the "instructions" count be r

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

mboehme updated this revision to Diff 439708. mboehme added a comment. Changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128499/new/ https://reviews.llvm.org/D128499 Files: clang/include/clang/Sema/Sema.h cl

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:4633-4637 Sema::ParsedFreeStandingDeclSpec(Scope *S, AccessSpecifier AS, DeclSpec &DS, RecordDecl *&AnonRecord) { - return ParsedFr

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

mboehme updated this revision to Diff 431919. mboehme added a comment. Changes in response to review comments. One major change is that Declaration now has a reference to the declaration attributes instead of owning them by value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

mboehme updated this revision to Diff 431921. mboehme added a comment. Changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126061/new/ https://reviews.llvm.org/D126061 Files: clang/include/clang/Basic/AttributeC

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

mboehme updated this revision to Diff 431923. mboehme added a comment. Changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126061/new/ https://reviews.llvm.org/D126061 Files: clang/include/clang/Basic/AttributeC

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

mboehme updated this revision to Diff 431929. mboehme marked 2 inline comments as done. mboehme added a comment. Changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126061/new/ https://reviews.llvm.org/D126061 Fil

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

mboehme updated this revision to Diff 431948. mboehme marked 30 inline comments as done. mboehme added a comment. Changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126061/new/ https://reviews.llvm.org/D126061 Fi

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

mboehme marked 6 inline comments as done. mboehme added a comment. Thank you @rsmith and @aaron.ballman for the detailed review comments! I hope I've addressed everything -- do let me know if there's anything I've missed. In D126061#3528966 , @rsmith wr

[PATCH] D124081: [clang] [WIP] Reject non-declaration C++11 attributes on declarations.

mboehme added a comment. It appears that we are converging on the approach in https://reviews.llvm.org/D126061, so I'm abandoning this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124081/new/ https://reviews.llvm.org/D124081 __

[PATCH] D124083: [clang] [WIP] Reject C++ 11 attributes appertaining to the wrong entity type.

mboehme abandoned this revision. mboehme added a comment. It appears that we're converging on the approach in https://reviews.llvm.org/D126061, so I'm abandoning this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124083/new/ https://review

[PATCH] D124919: [clang] [WIP] Reject non-declaration C++11 attributes on declarations.

mboehme abandoned this revision. mboehme added a comment. It appears that we're converging on the approach in https://reviews.llvm.org/D126061, so I'm abandoning this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124919/new/ https://reviews.llvm.org/D124919 ___

[PATCH] D126062: [clang] Don't parse MS attributes in `ParseExportDeclaration()`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f4644d194da: [clang] Don't parse MS attributes in `ParseExportDeclaration()`. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126062/ne

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme marked 8 inline comments as done. mboehme added a comment. I notice that https://reviews.llvm.org/D111548, which this change is based on, has some failing flang tests in the CI. I'm pretty sure these are unrelated and stem from the base revision that I happen to be based off. Before reba

[PATCH] D126066: [clang] [WIP] Don't plumb access specifier attributes through Parser unnecessarily.

mboehme added a comment. I erroneously stated in the description that all tests pass, but as the CI shows, this is actually not true. Marking this as "WIP" until I figure out whether this change can be salvaged or should be abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D126066: [clang] [WIP] Don't plumb access specifier attributes through Parser unnecessarily.

mboehme abandoned this revision. mboehme added a comment. Apologies, I had thoroughly misunderstood how this works. Specifically, what wasn't clear to me is that attributes added to the access specifier are added to every member below it until the next access specifier. With that, all of this c

[PATCH] D126780: [clang-tidy] `bugprone-use-after-move`: Fix handling of moves in lambda captures

mboehme created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Previously, we were treating a move in the lambda capture as

[PATCH] D119165: [clang-tidy] Add processing lambda captures at bugprone-use-after-move check

mboehme added inline comments. Herald added a project: All. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:403 hasArgument(0, declRefExpr().bind("arg")), - anyOf(hasAncestor(lambdaExpr().bind("containing-lambda")), -

[PATCH] D126853: [clang-tidy] `bugprone-use-after-move`: Don't warn on self-moves.

mboehme created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.

[PATCH] D126855: [clang-tidy] check_clang_tidy.py: Print output nicely in Python 3.

mboehme created this revision. Herald added a subscriber: xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. In Python 3, `encode()` produces a `bytes`. The way this is printed makes

[PATCH] D126780: [clang-tidy] `bugprone-use-after-move`: Fix handling of moves in lambda captures

mboehme updated this revision to Diff 433972. mboehme added a comment. Added release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126780/new/ https://reviews.llvm.org/D126780 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck

[PATCH] D126780: [clang-tidy] `bugprone-use-after-move`: Fix handling of moves in lambda captures

mboehme added a comment. In D126780#3552999 , @njames93 wrote: > LGTM, But please add a note to ReleaseNotes before landing. Thanks for reminding me! Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126

[PATCH] D126780: [clang-tidy] `bugprone-use-after-move`: Fix handling of moves in lambda captures

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b90b2539048: [clang-tidy] `bugprone-use-after-move`: Fix handling of moves in lambda captures (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D119165: [clang-tidy] Add processing lambda captures at bugprone-use-after-move check

mboehme added a comment. Note: https://reviews.llvm.org/D126780, which fixes the same bug as this patch, has now been landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119165/new/ https://reviews.llvm.org/D119165 _

[PATCH] D126853: [clang-tidy] `bugprone-use-after-move`: Don't warn on self-moves.

mboehme updated this revision to Diff 434739. mboehme added a comment. Added release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126853/new/ https://reviews.llvm.org/D126853 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck

[PATCH] D126853: [clang-tidy] `bugprone-use-after-move`: Don't warn on self-moves.

mboehme added a comment. The reviewer on https://reviews.llvm.org/D126780 reminded me to add release notes, so I've done so here as well. I assume this does not require another round of review. In D126853#3556029 , @njames93 wrote: > LGTM. > > I feel t

[PATCH] D126853: [clang-tidy] `bugprone-use-after-move`: Don't warn on self-moves.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b664460fa4c: [clang-tidy] `bugprone-use-after-move`: Don't warn on self-moves. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126853/n

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme updated this revision to Diff 435524. mboehme added a comment. Rebased to a newer base revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111548/new/ https://reviews.llvm.org/D111548 Files: clang/docs/ReleaseNotes.rst clang/includ

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Sema/ParsedAttr.cpp:228 + switch (getParsedKind()) { + case AT_AddressSpace: + case AT_OpenCLPrivateAddressSpace: rsmith wrote: > I don't think this one really slide

[PATCH] D127494: [clang][please ignore] Comment-only change to test CI baseline status.

mboehme created this revision. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm trying to work out whether failures I'm seeing in the CI for https://reviews.llvm.org/D111548 also occur on a comment-on

[PATCH] D155067: [clang][dataflow] Strengthen flow condition assertions.

mboehme updated this revision to Diff 541454. mboehme added a comment. Adapted to `Formula` changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155067/new/ https://reviews.llvm.org/D155067 Files: clang/unittests/Analysis/FlowSensitive/Transfer

[PATCH] D155067: [clang][dataflow] Strengthen flow condition assertions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6236bf53418e: [clang][dataflow] Strengthen flow condition assertions. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

mboehme updated this revision to Diff 541980. mboehme added a comment. Various changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155446/new/ https://reviews.llvm.org/D155446 Files: clang/include/clang/Analysis/

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

mboehme marked 16 inline comments as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:337-338 + /// Returns the location of the result object that a prvalue `E` of record + /// type initializes. + ///

[PATCH] D155788: [clang][dataflow] Add an `operator<<` for `OptionalTypeIdentifier`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When tests fail in UncheckedOptionalAccessModelTest.cpp, this prints the name

[PATCH] D155788: [clang][dataflow] Add an `operator<<` for `OptionalTypeIdentifier`.

mboehme updated this revision to Diff 542330. mboehme added a comment. Format code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155788/new/ https://reviews.llvm.org/D155788 Files: clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessM

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

mboehme updated this revision to Diff 542337. mboehme marked 11 inline comments as done. mboehme added a comment. Changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155446/new/ https://reviews.llvm.org/D155446 Fil

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

mboehme marked 3 inline comments as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:466 + return; +Env.setStorageLocationStrict(*S, *MemberLoc); } ymandel wrote: > This diff makes me very happy. :) Me too

[PATCH] D155802: [clang][dataflow] Print the source line if we saw unexpected diagnostics in tests.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes it easier to determine which line the unexpected happened on; previ

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

mboehme marked an inline comment as done. mboehme added a comment. CI failures look unrelated: - Windows failure is in SemaCXX/static-assert-cxx26.cpp. I can't see a way in which this patch should affect the failure of this test (the dataflow framework isn't used in Clang itself) - check-format

[PATCH] D155813: [clang][dataflow] Remove checks that test for consistency between `StructValue` and `AggregateStorageLocation`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now that the redundancy between these two classes has been eliminated, these c

[PATCH] D155802: [clang][dataflow] Print the source line if we saw unexpected diagnostics in tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b5d3ba829c1: [clang][dataflow] Print the source line if we saw unexpected diagnostics in… (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D155788: [clang][dataflow] Add an `operator<<` for `OptionalTypeIdentifier`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG477ee05f83c6: [clang][dataflow] Add an `operator<<` for `OptionalTypeIdentifier`. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155788

[PATCH] D155921: [clang][dataflow] Reverse course on `getValue()` deprecation.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the value categories RFC

[PATCH] D155922: [clang][dataflow] Eliminate `ReferenceValue`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are no remaining uses of this class in the

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

mboehme marked 4 inline comments as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:201 -/// Models a value of `struct` or `class` type, with a flat map of fields to -/// child storage locations, containing all accessible memb

[PATCH] D155813: [clang][dataflow] Remove checks that test for consistency between `StructValue` and `AggregateStorageLocation`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3cf630d80a2: [clang][dataflow] Remove checks that test for consistency between `StructValue`… (authored by mboehme). Repository: rG LLVM Github M

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked 3 inline comments as done. Closed by commit rG44f98d0101fe: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and… (authored by

[PATCH] D156229: [clang][dataflow] Remove checks that test for consistency between `StructValue` and `AggregateStorageLocation`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now that the redundancy between these two classes has been eliminated, these c

[PATCH] D156230: [clang][dataflow][NFC] Eliminate variable only used in assertion.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This can break release builds that set `-Werror`

[PATCH] D156230: [clang][dataflow][NFC] Eliminate variable only used in assertion.

mboehme added a comment. Abandoning. Already fixed at head in https://github.com/llvm/llvm-project/commit/e71bae94b04391cb47680622666d448418c0d972 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156230/new/ https://reviews.llvm.org/D156230

[PATCH] D156254: [clang][dataflow] Add convenience function for analysing and `FunctionDecl` and diagnosing it.

mboehme accepted this revision. mboehme added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:244 +/// Runs a dataflow analysis over the given function and then runs `Diagnoser` +/// ove

[PATCH] D156255: [clang-tidy] Update unchecked-optional-access-check to use convenience function for diagnosing `FunctionDecl`s.

mboehme accepted this revision. mboehme added a comment. This revision is now accepted and ready to land. Note this appears to have clang-format errors Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:58-63 + if (llvm::Expected> Errors = +

[PATCH] D156229: [clang][dataflow] Remove checks that test for consistency between `StructValue` and `AggregateStorageLocation`.

mboehme abandoned this revision. mboehme added a comment. This is a duplicate of https://reviews.llvm.org/D155813 that I uploaded for some reason. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156229/new/ https://reviews.llvm.

[PATCH] D155921: [clang][dataflow] Reverse course on `getValue()` deprecation.

mboehme updated this revision to Diff 544335. mboehme added a comment. Rebase to head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155921/new/ https://reviews.llvm.org/D155921 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironmen

[PATCH] D155922: [clang][dataflow] Eliminate `ReferenceValue`.

mboehme updated this revision to Diff 544336. mboehme added a comment. Rebase to head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155922/new/ https://reviews.llvm.org/D155922 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironmen

[PATCH] D155921: [clang][dataflow] Reverse course on `getValue()` deprecation.

mboehme updated this revision to Diff 544337. mboehme added a comment. Rebase to head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155921/new/ https://reviews.llvm.org/D155921 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironmen

[PATCH] D156402: [clang][dataflow] Don't crash when constructing an array of records.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When I wrote https://reviews.llvm.org/D155446, I

[PATCH] D156411: [clang][dataflow] HTMLLogger: Don't crash if CFG contains unreachable blocks.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://r

[PATCH] D156402: [clang][dataflow] Don't crash when constructing an array of records.

mboehme added a comment. CI failures look unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156402/new/ https://reviews.llvm.org/D156402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D156402: [clang][dataflow] Don't crash when constructing an array of records.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6e83cbcc748: [clang][dataflow] Don't crash when constructing an array of records. (authored by mboehme). Repository: rG LLVM Github Monorepo CHA

[PATCH] D156411: [clang][dataflow] HTMLLogger: Don't crash if CFG contains unreachable blocks.

mboehme added a comment. Pre-merge failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156411/new/ https://reviews.llvm.org/D156411 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D156411: [clang][dataflow] HTMLLogger: Don't crash if CFG contains unreachable blocks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG771d7d71df41: [clang][dataflow] HTMLLogger: Don't crash if CFG contains unreachable blocks. (authored by mboehme). Repository: rG LLVM Github Mono

[PATCH] D155922: [clang][dataflow] Eliminate `ReferenceValue`.

mboehme added a comment. Pre-merge failure looks unrelated. It's in AST/Interp/literals.cpp, and this patch shouldn't affect that in any way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155922/new/ https://reviews.llvm.org/D155922 _

<    1   2   3   4   5   6   >