mboehme added a comment. Unfortunately, it looks as if this patch did not fix the compile-time regression entirely. It did so for the particular source file I tested above, but other source files are still slower to compile than before D126061 <https://reviews.llvm.org/D126061>.
For reference, here is the compile-time regression caused by D126061 <https://reviews.llvm.org/D126061>: http://llvm-compile-time-tracker.com/compare.php?from=7acc88be0312c721bc082ed9934e381d297f4707&to=8c7b64b5ae2a09027c38db969a04fc9ddd0cd6bb&stat=instructions This a 0.35% regression (geomean) on -O0 compiles. Here is the improvement due to this patch (D128097 <https://reviews.llvm.org/D128097>): http://llvm-compile-time-tracker.com/compare.php?from=1c2b756cd6f9f9408863fb0e91f55731f81b46d9&to=0d300da799b06931eb6b974198d683548a8c8392&stat=instructions This is only a 0.18% improvement (geomean) on -O0 compiles. Here’s the cumulative change from before D126061 <https://reviews.llvm.org/D126061> landed until after this patch (D128097 <https://reviews.llvm.org/D128097>) landed: http://llvm-compile-time-tracker.com/compare.php?from=7acc88be0312c721bc082ed9934e381d297f4707&to=0d300da799b06931eb6b974198d683548a8c8392&stat=instructions This confirms that we’re still seeing an 0.22% regression (geomean) on -O0 compiles. I’ll do some more investigation to see what else is causing the slowdown. I’ll also try to run the whole test suite locally, though I had some trouble with this the first time I tried it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128097/new/ https://reviews.llvm.org/D128097 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
