[libcxx] r269965 - Change the control flow in atomic_compare_exchange_strong to avoid a potential deadlock.

2016-05-18 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed May 18 12:50:13 2016 New Revision: 269965 URL: http://llvm.org/viewvc/llvm-project?rev=269965&view=rev Log: Change the control flow in atomic_compare_exchange_strong to avoid a potential deadlock. When you assign a shared_ptr, the deleter gets called and assigned. In t

[libcxx] r269973 - Mark LWG2583 as complete. I did this a while ago, and forgot to update the table.

2016-05-18 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed May 18 14:31:01 2016 New Revision: 269973 URL: http://llvm.org/viewvc/llvm-project?rev=269973&view=rev Log: Mark LWG2583 as complete. I did this a while ago, and forgot to update the table. Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cx

[libcxx] r265306 - Fix for Bug #27193; 'std::acos on complex does not agree with C'. Tests need work; so the bug will stay open.

2016-04-04 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Apr 4 11:08:54 2016 New Revision: 265306 URL: http://llvm.org/viewvc/llvm-project?rev=265306&view=rev Log: Fix for Bug #27193; 'std::acos on complex does not agree with C'. Tests need work; so the bug will stay open. Modified: libcxx/trunk/include/complex Modifi

[libcxx] r265358 - Put back the undefs that Richard removed. Boost won't build w/o these; specifically the file 'bytes_methods.h' in Apple's python framework defines these.

2016-04-04 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Apr 4 17:49:20 2016 New Revision: 265358 URL: http://llvm.org/viewvc/llvm-project?rev=265358&view=rev Log: Put back the undefs that Richard removed. Boost won't build w/o these; specifically the file 'bytes_methods.h' in Apple's python framework defines these. Modifi

[libcxx] r265363 - Remove unused internal routines. No functional change

2016-04-04 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Apr 4 18:23:35 2016 New Revision: 265363 URL: http://llvm.org/viewvc/llvm-project?rev=265363&view=rev Log: Remove unused internal routines. No functional change Modified: libcxx/trunk/include/algorithm Modified: libcxx/trunk/include/algorithm URL: http://llvm.org

[libcxx] r265672 - Fix bug #27260 - add missing swap(reference, reference) to vector.

2016-04-07 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Apr 7 09:20:31 2016 New Revision: 265672 URL: http://llvm.org/viewvc/llvm-project?rev=265672&view=rev Log: Fix bug #27260 - add missing swap(reference, reference) to vector. Added: libcxx/trunk/test/std/containers/sequences/vector.bool/reference.swap.pass.cpp Modi

[libcxx] r265674 - Added a noexcept test

2016-04-07 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Apr 7 09:24:16 2016 New Revision: 265674 URL: http://llvm.org/viewvc/llvm-project?rev=265674&view=rev Log: Added a noexcept test Modified: libcxx/trunk/test/std/containers/sequences/vector.bool/reference.swap.pass.cpp Modified: libcxx/trunk/test/std/containers/s

[libcxx] r265706 - Recommit r263036 with additional inlining, so that it will continue to work with existing system dylibs. Implements LWG#2583

2016-04-07 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Apr 7 13:13:41 2016 New Revision: 265706 URL: http://llvm.org/viewvc/llvm-project?rev=265706&view=rev Log: Recommit r263036 with additional inlining, so that it will continue to work with existing system dylibs. Implements LWG#2583 Modified: libcxx/trunk/include/s

[libcxx] r265914 - Implement LWG#680, which was missed lo these many moons ago, and was reported as bug #27259. As a drive-by fix, replace the hand-rolled equivalent to addressof in __wrap_iter with t

2016-04-10 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Apr 10 22:54:53 2016 New Revision: 265914 URL: http://llvm.org/viewvc/llvm-project?rev=265914&view=rev Log: Implement LWG#680, which was missed lo these many moons ago, and was reported as bug #27259. As a drive-by fix, replace the hand-rolled equivalent to addressof i

Re: [PATCH] D18637: Extract key to avoid preemptive mallocs in insert/emplace in associative containers

2016-04-13 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks good to me, except for the noisy tests. Comment at: test/std/containers/associative/set/insert_and_emplace_allocator_requirements.pass.cpp:29 @@ +28,3 @@

Re: [PATCH] D18217: [libcxx] Fix -Wdeprecated warnings

2016-04-13 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Let's retire this patch, then. I'll be watching for your replacement patches. http://reviews.llvm.org/D18217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

2016-04-13 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. This direction looks fine to me. All the test changes look fine to me. http://reviews.llvm.org/D17469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r266209 - Qualify calls to addressof to avoid getting ADL. Fixes PR#27254.

2016-04-13 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Apr 13 12:02:23 2016 New Revision: 266209 URL: http://llvm.org/viewvc/llvm-project?rev=266209&view=rev Log: Qualify calls to addressof to avoid getting ADL. Fixes PR#27254. Modified: libcxx/trunk/include/__mutex_base libcxx/trunk/include/shared_mutex Modified:

[libcxx] r267119 - Add missing include of

2016-04-22 Thread Marshall Clow via cfe-commits
Author: marshall Date: Fri Apr 22 02:39:05 2016 New Revision: 267119 URL: http://llvm.org/viewvc/llvm-project?rev=267119&view=rev Log: Add missing include of Modified: libcxx/trunk/test/std/numerics/rand/rand.dis/rand.dist.samp/rand.dist.samp.pconst/eval.pass.cpp libcxx/trunk/test/std/

[libcxx] r267287 - Rename a few tests that had typos in their names. No functional change. Thanks to STL for the catch

2016-04-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sat Apr 23 09:31:00 2016 New Revision: 267287 URL: http://llvm.org/viewvc/llvm-project?rev=267287&view=rev Log: Rename a few tests that had typos in their names. No functional change. Thanks to STL for the catch Added: libcxx/trunk/test/std/input.output/iostreams.base

[libcxx] r267567 - #include in all the regex tests, and remove all mentions of __cpluplus (use TEST_STD_VERS and/or XFAIL instead). No functional change

2016-04-26 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Apr 26 11:24:44 2016 New Revision: 267567 URL: http://llvm.org/viewvc/llvm-project?rev=267567&view=rev Log: #include in all the regex tests, and remove all mentions of __cpluplus (use TEST_STD_VERS and/or XFAIL instead). No functional change Modified: libcxx/trunk

[PATCH] D20660: Remove `auto_ptr` in C++17.

2016-05-25 Thread Marshall Clow via cfe-commits
mclow.lists created this revision. mclow.lists added a reviewer: EricWF. mclow.lists added a subscriber: cfe-commits. [[ http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4190 | N4190 ]] removed `auto_ptr` from C++1z. (and other stuff) Wrap all the auto_ptr bits in an #ifdef so they disap

Re: [PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow

2016-05-26 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Let's file a bug on this too - http://llvm.org/bugs (make it easier to find in the future) http://reviews.llvm.org/D20334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

2016-05-27 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. If you're really going to do this, you should probably empty out most of the routines in src/cxa_exception.cpp as well. http://reviews.llvm.org/D20677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

Re: [PATCH] D20730: [libcxx] Prefer UNSUPPORTED over conditional compilation for tests

2016-05-27 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a reviewer: mclow.lists. mclow.lists added a comment. LGTM. http://reviews.llvm.org/D20730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[libcxx] r271282 - Issues for Oulu

2016-05-31 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue May 31 09:29:38 2016 New Revision: 271282 URL: http://llvm.org/viewvc/llvm-project?rev=271282&view=rev Log: Issues for Oulu Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-project/l

Re: [PATCH] D19254: Implement P0033R1 - Re-enabling shared_from_this

2016-06-01 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Other than the versioning, this looks fine to me. Comment at: include/memory:5439 @@ -5438,1 +5438,3 @@ +_LIBCPP_INLINE_VISIBILITY +weak_ptr<_Tp> weak_from_this() _NOEXCEPT Shouldn't these be wrapped in `#ifdef _LIBCPP_VER

Re: [PATCH] D19250: Update libcxx.llvm.org documentation by linking to new docs.

2016-06-01 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D19250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

2016-06-02 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. In general, I'm OK with this - but I'm concerned about that there's not really any provision for the case where `strerror_r` does not exist. Also, there's no reason to have a thread local static array here, if you're going to immediately copy it into a `std::string`

[libcxx] r271794 - Don't call memmove when there's nothing to move. Fixes PR#27978.

2016-06-04 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sat Jun 4 11:16:59 2016 New Revision: 271794 URL: http://llvm.org/viewvc/llvm-project?rev=271794&view=rev Log: Don't call memmove when there's nothing to move. Fixes PR#27978. Modified: libcxx/trunk/include/fstream Modified: libcxx/trunk/include/fstream URL: http://l

[libcxx] r271897 - Remove arithmetic +/-127 on chars; results in UB when dealing with signed chars. Thanks to STL@microsoft for the report.

2016-06-06 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Jun 6 09:35:22 2016 New Revision: 271897 URL: http://llvm.org/viewvc/llvm-project?rev=271897&view=rev Log: Remove arithmetic +/-127 on chars; results in UB when dealing with signed chars. Thanks to STL@microsoft for the report. Modified: libcxx/trunk/test/std/str

[libcxx] r271919 - Rename some test data (and make it const) to rid us of some shadowing warnings in the test suite. No functional change. Thanks to STL@microsoft for the report and patch.

2016-06-06 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Jun 6 13:24:08 2016 New Revision: 271919 URL: http://llvm.org/viewvc/llvm-project?rev=271919&view=rev Log: Rename some test data (and make it const) to rid us of some shadowing warnings in the test suite. No functional change. Thanks to STL@microsoft for the report an

Re: [PATCH] D20922: [libcxx] [test] Rename global "x" to "testcases" in complex.number/cases.h and make it const for safety.

2016-06-06 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Landed as revision 271919 http://reviews.llvm.org/D20922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[libcxx] r272018 - Avoid Shadowing warnings in the associative containers tests. Thanks to STL for the patch.

2016-06-07 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jun 7 10:49:39 2016 New Revision: 272018 URL: http://llvm.org/viewvc/llvm-project?rev=272018&view=rev Log: Avoid Shadowing warnings in the associative containers tests. Thanks to STL for the patch. Modified: libcxx/trunk/test/std/containers/associative/map/map.sp

Re: [PATCH] D20921: [libcxx] [test] Slightly rearrange scopes in order to avoid shadowing M typedefs.

2016-06-07 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Landed as revision 272018 http://reviews.llvm.org/D20921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

2016-06-07 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Some nits while reading this. More to come. Also, I don't see how this can be retargeted "at runtime"; are you implying that someone can choose at program launch time what threading system to use? How could that work given (say) a constexpr constructor for a mutex t

[libcxx] r272029 - Added notes about the issues for Oulu

2016-06-07 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jun 7 12:54:38 2016 New Revision: 272029 URL: http://llvm.org/viewvc/llvm-project?rev=272029&view=rev Log: Added notes about the issues for Oulu Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org

[libcxx] r272050 - Added notes for a bunch of the issues

2016-06-07 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jun 7 15:05:57 2016 New Revision: 272050 URL: http://llvm.org/viewvc/llvm-project?rev=272050&view=rev Log: Added notes for a bunch of the issues Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org

[libcxx] r272150 - Patch ready for #2436

2016-06-08 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Jun 8 09:54:35 2016 New Revision: 272150 URL: http://llvm.org/viewvc/llvm-project?rev=272150&view=rev Log: Patch ready for #2436 Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-pro

[libcxx] r272202 - Mark 2441 as ready

2016-06-08 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Jun 8 16:25:38 2016 New Revision: 272202 URL: http://llvm.org/viewvc/llvm-project?rev=272202&view=rev Log: Mark 2441 as ready Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-projec

[libcxx] r272216 - Add notes for 2688

2016-06-08 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Jun 8 17:33:25 2016 New Revision: 272216 URL: http://llvm.org/viewvc/llvm-project?rev=272216&view=rev Log: Add notes for 2688 Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-projec

[libcxx] r272263 - Two more issues w/patches

2016-06-09 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jun 9 09:50:38 2016 New Revision: 272263 URL: http://llvm.org/viewvc/llvm-project?rev=272263&view=rev Log: Two more issues w/patches Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm

[libcxx] r272288 - Make the comparison objects that we pass in for various tests look more like actual comparison objects. No functional change.

2016-06-09 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jun 9 13:34:38 2016 New Revision: 272288 URL: http://llvm.org/viewvc/llvm-project?rev=272288&view=rev Log: Make the comparison objects that we pass in for various tests look more like actual comparison objects. No functional change. Modified: libcxx/trunk/test/st

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

2016-06-13 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. > Apologies, not at program launch time but link time. I'm OK with that; I think that's unnecessary complication, but not a deal-breaker. The choosing at program launch seems unworkable to me. [ I think that the threading implementation should be chosen by the prov

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

2016-06-13 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. > I've adopted a initialize-on-first-use policy to workaround this particular > problem. That's not constexpr. You say it in your comment "This prohibits any prospects of calling a runtime initialization routine", but then you have a runtime initialization routi

Re: [PATCH] D21260: Implement variadic lock_guard.

2016-06-13 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. You should only get the multi-mutex version in C++17. Comment at: include/mutex:579 @@ -578,2 +578,3 @@ #endif // _LIBCPP_HAS_NO_VARIADICS + You need to update the synopsis at the top of the file. http://reviews.llvm.org/D21260

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

2016-06-13 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D20903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D21260: Implement variadic lock_guard.

2016-06-13 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. Thanks. http://reviews.llvm.org/D21260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D21320: Alternative to D1332

2016-06-13 Thread Marshall Clow via cfe-commits
mclow.lists created this revision. mclow.lists added reviewers: EricWF, STL_MSFT. mclow.lists added a subscriber: cfe-commits. There's a bug in the standard, where the default deleter will always call `delete x`; even if `x` is an array type. This shows up for `shared_ptr`. Do the right thing,

Re: [PATCH] D21320: Alternative to D1332

2016-06-13 Thread Marshall Clow via cfe-commits
mclow.lists updated this revision to Diff 60651. mclow.lists added a comment. @EricWF pointed out that this didn't actually suppress the warning that we were trying to suppress. All I can say is that it did several weeks ago when I wrote it. Apparently clang has gotten pickier. Use tag dispatch

[libcxx] r272679 - Found a couple bugs in the test suite. No functionality change.

2016-06-14 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jun 14 10:25:46 2016 New Revision: 272679 URL: http://llvm.org/viewvc/llvm-project?rev=272679&view=rev Log: Found a couple bugs in the test suite. No functionality change. Modified: libcxx/trunk/test/std/containers/unord/unord.multiset/unord.multiset.swap/swap_noex

[PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

2016-06-14 Thread Marshall Clow via cfe-commits
mclow.lists created this revision. mclow.lists added reviewers: EricWF, howard.hinnant. mclow.lists added a subscriber: cfe-commits. These are probably going to end up in C++17 as well. This is a straight addition; no changes to existing code. http://reviews.llvm.org/D21343 Files: include/exp

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

2016-06-15 Thread Marshall Clow via cfe-commits
mclow.lists updated this revision to Diff 60856. mclow.lists added a comment. Updated based on comments here and elsewhere. - Do the abs once, rather than at every level of recursion - Add tests for `bool`. - Constexpr Also, add an assertion to detect overflow in `lcm`. I have not yet incorpora

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

2016-06-15 Thread Marshall Clow via cfe-commits
mclow.lists marked 8 inline comments as done. mclow.lists added a comment. http://reviews.llvm.org/D21343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

2016-06-16 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. I know that there are more tests needed. http://reviews.llvm.org/D21459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

2016-06-17 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: test/std/strings/string.view/string.view.template/nothing_to_do.pass.cpp:10 @@ +9,3 @@ + +#include + This should be `` http://reviews.llvm.org/D21459 ___ cfe-commits

[libcxx] r273121 - Test commit; remove some spaces at EOL. No functional change.

2016-06-19 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Jun 19 14:29:52 2016 New Revision: 273121 URL: http://llvm.org/viewvc/llvm-project?rev=273121&view=rev Log: Test commit; remove some spaces at EOL. No functional change. Modified: libcxx/trunk/include/utility Modified: libcxx/trunk/include/utility URL: http://llvm

Re: [PATCH] D21673: [libcxx] guard throw with exception enabling check

2016-06-25 Thread Marshall Clow via cfe-commits
mclow.lists added subscribers: EricWF, mclow.lists. mclow.lists added a comment. Just a reminder - the people who can approve patches for libc++ are @mclow.lists and @ericWF. Repository: rL LLVM http://reviews.llvm.org/D21673 ___ cfe-commits mai

[libcxx] r273861 - Fix bad link for P0006

2016-06-27 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Jun 27 06:14:34 2016 New Revision: 273861 URL: http://llvm.org/viewvc/llvm-project?rev=273861&view=rev Log: Fix bad link for P0006 Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/viewvc/llvm-project/li

[libcxx] r274016 - Updated C++1Z status page with new work from Oulu WG21 meeting

2016-06-28 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jun 28 09:11:54 2016 New Revision: 274016 URL: http://llvm.org/viewvc/llvm-project?rev=274016&view=rev Log: Updated C++1Z status page with new work from Oulu WG21 meeting Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

[libcxx] r274018 - Use WG21.link reflector to get to issues, rather than linking directly

2016-06-28 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jun 28 09:13:28 2016 New Revision: 274018 URL: http://llvm.org/viewvc/llvm-project?rev=274018&view=rev Log: Use WG21.link reflector to get to issues, rather than linking directly Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.h

Re: [PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow

2016-06-29 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks fine to me. http://reviews.llvm.org/D20334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[libcxx] r274235 - Implement LWG#2436: 'Comparators for associative containers should always be CopyConstructible'

2016-06-30 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jun 30 10:11:53 2016 New Revision: 274235 URL: http://llvm.org/viewvc/llvm-project?rev=274235&view=rev Log: Implement LWG#2436: 'Comparators for associative containers should always be CopyConstructible' Added: libcxx/trunk/test/std/containers/associative/map/map.

[libcxx] r274236 - Implement LWG#2441: 'Exact-width atomic typedefs should be provided'

2016-06-30 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jun 30 10:28:38 2016 New Revision: 274236 URL: http://llvm.org/viewvc/llvm-project?rev=274236&view=rev Log: Implement LWG#2441: 'Exact-width atomic typedefs should be provided' Modified: libcxx/trunk/include/atomic libcxx/trunk/test/std/atomics/atomics.types.gen

[libcxx] r274241 - Implement LWG#2596: 'vector::data() should use addressof'

2016-06-30 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jun 30 10:50:55 2016 New Revision: 274241 URL: http://llvm.org/viewvc/llvm-project?rev=274241&view=rev Log: Implement LWG#2596: 'vector::data() should use addressof' Modified: libcxx/trunk/test/std/containers/sequences/vector/vector.data/data.pass.cpp libcxx/tr

[libcxx] r274243 - Implement LWG#2684: 'priority_queue lacking comparator typedef'. We already did this, just added tests

2016-06-30 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jun 30 11:03:50 2016 New Revision: 274243 URL: http://llvm.org/viewvc/llvm-project?rev=274243&view=rev Log: Implement LWG#2684: 'priority_queue lacking comparator typedef'. We already did this, just added tests Modified: libcxx/trunk/test/std/containers/container.

[libcxx] r274252 - Implement LWG#2688: 'clamp misses preconditions and has extraneous condition on result'. We already did this, just added tests

2016-06-30 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jun 30 12:52:51 2016 New Revision: 274252 URL: http://llvm.org/viewvc/llvm-project?rev=274252&view=rev Log: Implement LWG#2688: 'clamp misses preconditions and has extraneous condition on result'. We already did this, just added tests Modified: libcxx/trunk/test/st

[libcxx] r274250 - Temporarily XFAIL the incomplete type tests for GCC while I figure out why adding a static_assert in r274235 broken them

2016-06-30 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jun 30 12:49:36 2016 New Revision: 274250 URL: http://llvm.org/viewvc/llvm-project?rev=274250&view=rev Log: Temporarily XFAIL the incomplete type tests for GCC while I figure out why adding a static_assert in r274235 broken them Modified: libcxx/trunk/test/std/cont

[libcxx] r274253 - Mark issues 2667, 2669, 2670, 2671, 2673 as complete. These issues are wording clarifications; no code changes required.

2016-06-30 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jun 30 12:59:01 2016 New Revision: 274253 URL: http://llvm.org/viewvc/llvm-project?rev=274253&view=rev Log: Mark issues 2667, 2669, 2670, 2671, 2673 as complete. These issues are wording clarifications; no code changes required. Modified: libcxx/trunk/www/cxx1z_sta

[libcxx] r274255 - Mark issues 2550, 2551, 2555, 2685, 2698 as complete. These issues are wording clarifications; no code changes required.

2016-06-30 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jun 30 13:05:19 2016 New Revision: 274255 URL: http://llvm.org/viewvc/llvm-project?rev=274255&view=rev Log: Mark issues 2550, 2551, 2555, 2685, 2698 as complete. These issues are wording clarifications; no code changes required. Modified: libcxx/trunk/www/cxx1z_sta

[libcxx] r274285 - Fix static assert problem on gcc; remove XFAILs that I put in in r274250

2016-06-30 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jun 30 17:05:45 2016 New Revision: 274285 URL: http://llvm.org/viewvc/llvm-project?rev=274285&view=rev Log: Fix static assert problem on gcc; remove XFAILs that I put in in r274250 Modified: libcxx/trunk/include/__hash_table libcxx/trunk/include/__tree libcx

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

2016-06-30 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Hal and I talked about this in Oulu. In general, I'm good with this approach. However, I think that the code could be made much clearer. (some naming changes, some code rearrangement) First off, I think the name `__fast_isinf` is a poor name. I think something like

Re: [PATCH] D21706: [libcxx] refactor for throw

2016-07-01 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. This is getting close. A nit, and a couple of non-trivial comments. Comment at: include/exception:262 @@ -261,3 +261,3 @@ _LIBCPP_INLINE_VISIBILITY -inline void __libcpp_throw(_Exception const& __e) { +inline __attribute__((noreturn)) void __libcpp

[libcxx] r274605 - Fix typo in #ifdef, and re-enable tests now that the green-dragon bots are no more

2016-07-05 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Jul 6 00:28:44 2016 New Revision: 274605 URL: http://llvm.org/viewvc/llvm-project?rev=274605&view=rev Log: Fix typo in #ifdef, and re-enable tests now that the green-dragon bots are no more Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop

Re: [PATCH] D21349: [libcxx] [test] Fix a typo in commented-out code.

2016-07-05 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Landed as r274605 http://reviews.llvm.org/D21349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[libcxx] r274880 - Implement LWG685 (which is from C++11!). Fixes PR#28421. Note: this (subtly) changes the return type of operator-(Iter1, Iter2) where Iter1 is a reverse iterator or a move_iterator,

2016-07-08 Thread Marshall Clow via cfe-commits
Author: marshall Date: Fri Jul 8 11:54:47 2016 New Revision: 274880 URL: http://llvm.org/viewvc/llvm-project?rev=274880&view=rev Log: Implement LWG685 (which is from C++11!). Fixes PR#28421. Note: this (subtly) changes the return type of operator-(Iter1, Iter2) where Iter1 is a reverse iterato

[libcxx] r274882 - Fix typo in #ifdef; leave tests commented out b/c gcc 4.8 harks on them.

2016-07-08 Thread Marshall Clow via cfe-commits
Author: marshall Date: Fri Jul 8 11:59:54 2016 New Revision: 274882 URL: http://llvm.org/viewvc/llvm-project?rev=274882&view=rev Log: Fix typo in #ifdef; leave tests commented out b/c gcc 4.8 harks on them. Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_constr

[libcxx] r275105 - Always use the allocator to construct/destruct elements of a deque/vector. Fixes PR#28412. Thanks to Jonathan Wakely for the report.

2016-07-11 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Jul 11 16:38:08 2016 New Revision: 275105 URL: http://llvm.org/viewvc/llvm-project?rev=275105&view=rev Log: Always use the allocator to construct/destruct elements of a deque/vector. Fixes PR#28412. Thanks to Jonathan Wakely for the report. Modified: libcxx/trunk/i

[libcxx] r275170 - Mark P0067 as 'postponed', because it will be revised before the next meeting

2016-07-12 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jul 12 09:37:39 2016 New Revision: 275170 URL: http://llvm.org/viewvc/llvm-project?rev=275170&view=rev Log: Mark P0067 as 'postponed', because it will be revised before the next meeting Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_s

[libcxx] r275171 - Put the status in the right column

2016-07-12 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jul 12 09:38:59 2016 New Revision: 275171 URL: http://llvm.org/viewvc/llvm-project?rev=275171&view=rev Log: Put the status in the right column Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/viewvc/llv

[libcxx] r275176 - mark issue #2181 as complete; this was just a wording clarification

2016-07-12 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jul 12 10:15:55 2016 New Revision: 275176 URL: http://llvm.org/viewvc/llvm-project?rev=275176&view=rev Log: mark issue #2181 as complete; this was just a wording clarification Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html

[libcxx] r275177 - mark issue #2422 as complete; this was just a wording clarification

2016-07-12 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jul 12 10:29:35 2016 New Revision: 275177 URL: http://llvm.org/viewvc/llvm-project?rev=275177&view=rev Log: mark issue #2422 as complete; this was just a wording clarification Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html

[libcxx] r275184 - Add tests for the meta.unary.props that do not require a complete type. This is part of LWG#2582

2016-07-12 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jul 12 10:50:53 2016 New Revision: 275184 URL: http://llvm.org/viewvc/llvm-project?rev=275184&view=rev Log: Add tests for the meta.unary.props that do not require a complete type. This is part of LWG#2582 Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/m

[libcxx] r275211 - Add more tests for LWG#2582. No code changes needed, just tests.

2016-07-12 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jul 12 15:15:46 2016 New Revision: 275211 URL: http://llvm.org/viewvc/llvm-project?rev=275211&view=rev Log: Add more tests for LWG#2582. No code changes needed, just tests. Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.cat/array.pass.cpp

Re: [PATCH] D21706: [libcxx] refactor for throw

2016-07-12 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. I just realized that this will break the following code: try { __cxxabiv1:: __cxa_bad_cast(); } catch ( std::bad_cast &ex ) {} because what gets thrown is a `const std::bad_cast &` Yes, people should catch by value or const reference. But that doesn't mean that

[libcxx] r275280 - Constuct a sentry object in istream::readsome, and handle failures appropriately. Fixes PR#28217.

2016-07-13 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Jul 13 11:58:48 2016 New Revision: 275280 URL: http://llvm.org/viewvc/llvm-project?rev=275280&view=rev Log: Constuct a sentry object in istream::readsome, and handle failures appropriately. Fixes PR#28217. Modified: libcxx/trunk/include/istream Modified: libcxx/tr

[libcxx] r275787 - Change a couple ifdefs from '#if __cplusplus >= 2011xxx' to '#ifndef _LIBCPP_CXX03_LANG'. No functionality change.

2016-07-18 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Jul 18 08:19:00 2016 New Revision: 275787 URL: http://llvm.org/viewvc/llvm-project?rev=275787&view=rev Log: Change a couple ifdefs from '#if __cplusplus >= 2011xxx' to '#ifndef _LIBCPP_CXX03_LANG'. No functionality change. Modified: libcxx/trunk/include/iterator

Re: [PATCH] D20786: Fix undefined behavior in __tree

2016-07-18 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. I'm not really happy with this situation, but I don't see how to improve this patch. https://reviews.llvm.org/D20786 ___ cfe-commits m

[libcxx] r275819 - Don't use pthread initializers in constexpr constructors. Patch by elram. Reviewed at https://reviews.llvm.org/D21637.

2016-07-18 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Jul 18 12:23:06 2016 New Revision: 275819 URL: http://llvm.org/viewvc/llvm-project?rev=275819&view=rev Log: Don't use pthread initializers in constexpr constructors. Patch by elram. Reviewed at https://reviews.llvm.org/D21637. Modified: libcxx/trunk/include/__mutex

Re: [PATCH] D21637: [libcxx] Don't use pthread initializers in constexpr constructors

2016-07-18 Thread Marshall Clow via cfe-commits
mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 275819. https://reviews.llvm.org/D21637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r262610 - Fix for PR26812: possible overflow issue in std::allocator::allocate

2016-03-03 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Mar 3 06:04:39 2016 New Revision: 262610 URL: http://llvm.org/viewvc/llvm-project?rev=262610&view=rev Log: Fix for PR26812: possible overflow issue in std::allocator::allocate Added: libcxx/trunk/test/std/utilities/memory/default.allocator/allocator.members/alloca

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

2016-03-03 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Yes, sorry. http://reviews.llvm.org/D15539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[libcxx] r262807 - Update with work items passed in Jacksonville

2016-03-06 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Mar 6 11:45:24 2016 New Revision: 262807 URL: http://llvm.org/viewvc/llvm-project?rev=262807&view=rev Log: Update with work items passed in Jacksonville Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org

[libcxx] r262866 - non-member swap for array was mistakenly taking const ref params. Fixed and added test. Thanks to Ben Craig for the catch

2016-03-07 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Mar 7 15:57:10 2016 New Revision: 262866 URL: http://llvm.org/viewvc/llvm-project?rev=262866&view=rev Log: non-member swap for array was mistakenly taking const ref params. Fixed and added test. Thanks to Ben Craig for the catch Modified: libcxx/trunk/include/arra

[libcxx] r262871 - Implement P0025R0: 'An algorithm to clamp a value between a pair of boundary values' for C++17

2016-03-07 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Mar 7 16:43:49 2016 New Revision: 262871 URL: http://llvm.org/viewvc/llvm-project?rev=262871&view=rev Log: Implement P0025R0: 'An algorithm to clamp a value between a pair of boundary values' for C++17 Added: libcxx/trunk/test/std/algorithms/alg.sorting/alg.clamp/

[libcxx] r262928 - Implement P0253R1: Fixing a design mistake in the searchers interface.

2016-03-08 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Mar 8 09:12:52 2016 New Revision: 262928 URL: http://llvm.org/viewvc/llvm-project?rev=262928&view=rev Log: Implement P0253R1: Fixing a design mistake in the searchers interface. Modified: libcxx/trunk/include/algorithm libcxx/trunk/include/experimental/algorith

[libcxx] r262931 - Implement P0272R1: Give 'std::string' a non-const '.data()' member function

2016-03-08 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Mar 8 09:44:30 2016 New Revision: 262931 URL: http://llvm.org/viewvc/llvm-project?rev=262931&view=rev Log: Implement P0272R1: Give 'std::string' a non-const '.data()' member function Modified: libcxx/trunk/include/string libcxx/trunk/test/std/strings/basic.str

[libcxx] r262932 - Remove a couple tabs that crept in

2016-03-08 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Mar 8 09:45:06 2016 New Revision: 262932 URL: http://llvm.org/viewvc/llvm-project?rev=262932&view=rev Log: Remove a couple tabs that crept in Modified: libcxx/trunk/test/std/strings/basic.string/string.ops/string.accessors/data.pass.cpp Modified: libcxx/trunk/te

[libcxx] r263029 - Add some more tests for the containers type requirements

2016-03-09 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Mar 9 11:19:07 2016 New Revision: 263029 URL: http://llvm.org/viewvc/llvm-project?rev=263029&view=rev Log: Add some more tests for the containers type requirements Modified: libcxx/trunk/test/std/containers/sequences/array/types.pass.cpp libcxx/trunk/test/std/c

[libcxx] r263036 - Implement LWG#2583: There is no way to supply an allocator for basic_string(str, pos)

2016-03-09 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Mar 9 11:51:43 2016 New Revision: 263036 URL: http://llvm.org/viewvc/llvm-project?rev=263036&view=rev Log: Implement LWG#2583: There is no way to supply an allocator for basic_string(str, pos) Modified: libcxx/trunk/include/string libcxx/trunk/test/std/strings

[libcxx] r263042 - Implement LWG#2579: Inconsistency wrt Allocators in basic_string assignment vs. basic_string::assign

2016-03-09 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Mar 9 12:08:29 2016 New Revision: 263042 URL: http://llvm.org/viewvc/llvm-project?rev=263042&view=rev Log: Implement LWG#2579: Inconsistency wrt Allocators in basic_string assignment vs. basic_string::assign Modified: libcxx/trunk/include/string libcxx/trunk/

[libcxx] r263043 - Update status to mark 2579 complete

2016-03-09 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Mar 9 12:09:07 2016 New Revision: 263043 URL: http://llvm.org/viewvc/llvm-project?rev=263043&view=rev Log: Update status to mark 2579 complete Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/viewvc/ll

[libcxx] r263405 - Mark exception-throwing test as XFAIL when exceptions are disabled

2016-03-13 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Mar 13 21:51:50 2016 New Revision: 263405 URL: http://llvm.org/viewvc/llvm-project?rev=263405&view=rev Log: Mark exception-throwing test as XFAIL when exceptions are disabled Modified: libcxx/trunk/test/std/utilities/memory/default.allocator/allocator.members/alloc

[libcxx] r263450 - Implement LWG#2566: Requirements on the first template parameter of container adaptors

2016-03-14 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Mar 14 12:58:11 2016 New Revision: 263450 URL: http://llvm.org/viewvc/llvm-project?rev=263450&view=rev Log: Implement LWG#2566: Requirements on the first template parameter of container adaptors Modified: libcxx/trunk/include/queue libcxx/trunk/include/stack

[libcxx] r263451 - Add failing tests that I forgot to add to the last commit

2016-03-14 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Mar 14 12:58:54 2016 New Revision: 263451 URL: http://llvm.org/viewvc/llvm-project?rev=263451&view=rev Log: Add failing tests that I forgot to add to the last commit Added: libcxx/trunk/test/std/containers/container.adaptors/priority.queue/types.fail.cpp libcx

<    3   4   5   6   7   8   9   10   >