Author: marshall
Date: Tue Feb 7 09:34:20 2017
New Revision: 294311
URL: http://llvm.org/viewvc/llvm-project?rev=294311&view=rev
Log:
Mark LWG2784 as ready
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-pro
Author: marshall
Date: Tue Feb 7 12:41:25 2017
New Revision: 294328
URL: http://llvm.org/viewvc/llvm-project?rev=294328&view=rev
Log:
Stop using random_shuffle in the libc++ test suite. It's going to be removed in
c++17. Use shuffle() instead. No change to libc++, just the tests.
Modified:
Author: marshall
Date: Wed Feb 8 01:40:59 2017
New Revision: 294417
URL: http://llvm.org/viewvc/llvm-project?rev=294417&view=rev
Log:
Temporarily disable the LCM/GCD tests under UBSAN.
Modified:
libcxx/trunk/test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp
libcxx/trunk/test/std
Author: marshall
Date: Wed Jun 28 11:18:30 2017
New Revision: 306580
URL: http://llvm.org/viewvc/llvm-project?rev=306580&view=rev
Log:
Added failing tests for index out of range for tuple_element> and
variant_alternative<>
Added:
libcxx/trunk/test/std/utilities/utility/pairs/pair.astuple/tu
Author: marshall
Date: Wed Jun 28 11:19:34 2017
New Revision: 306581
URL: http://llvm.org/viewvc/llvm-project?rev=306581&view=rev
Log:
Updated notest on 2974
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-pr
Author: marshall
Date: Wed Jul 5 09:37:19 2017
New Revision: 307171
URL: http://llvm.org/viewvc/llvm-project?rev=307171&view=rev
Log:
Fix a bug in regex_Iterator where it would report zero-length matches forever.
Reported as http://llvm.org/PR33681. Thanks to Karen Arutyunov for the report.
Mod
Author: marshall
Date: Sat Jul 15 08:22:21 2017
New Revision: 308097
URL: http://llvm.org/viewvc/llvm-project?rev=308097&view=rev
Log:
Update issues moved in Toronto
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc
Author: marshall
Date: Sun Jul 16 16:59:23 2017
New Revision: 308153
URL: http://llvm.org/viewvc/llvm-project?rev=308153&view=rev
Log:
Update libc++ status pages with results of the Toronto Meeting - and for C++2a
Added:
libcxx/trunk/www/cxx2a_status.html
Modified:
libcxx/trunk/www/cxx1z_
Author: marshall
Date: Sun Jul 16 20:02:27 2017
New Revision: 308159
URL: http://llvm.org/viewvc/llvm-project?rev=308159&view=rev
Log:
Add case for c++2a to libc++ and test macros
Modified:
libcxx/trunk/include/__config
libcxx/trunk/test/support/test_macros.h
Modified: libcxx/trunk/inclu
Author: marshall
Date: Mon Jul 24 07:05:10 2017
New Revision: 308880
URL: http://llvm.org/viewvc/llvm-project?rev=308880&view=rev
Log:
make sure that we don't call basic_streambuf::gbump with a value bigger than
INT_MAX, since it only takes an int. Related to, but not quite the same as
PR33725
Author: marshall
Date: Thu Jul 27 10:44:03 2017
New Revision: 309296
URL: http://llvm.org/viewvc/llvm-project?rev=309296&view=rev
Log:
Implement P0739R0: 'Some improvements to class template argument deduction
integration into the standard library' This is an API change (not ABI change)
due to a
Author: marshall
Date: Thu Jul 27 11:47:35 2017
New Revision: 309307
URL: http://llvm.org/viewvc/llvm-project?rev=309307&view=rev
Log:
Disable the deduction guide test I added in 309296 for the moment, while I
figure out which compilers don't support deduction guides
Modified:
libcxx/trunk/
Author: marshall
Date: Mon Jan 15 08:16:32 2018
New Revision: 322489
URL: http://llvm.org/viewvc/llvm-project?rev=322489&view=rev
Log:
First part of P0202: Adding constexpr modifiers to functions in and
. This commit is all the is_XXX algorithms.
Modified:
libcxx/trunk/include/algorithm
Author: marshall
Date: Mon Jan 15 09:20:36 2018
New Revision: 322492
URL: http://llvm.org/viewvc/llvm-project?rev=322492&view=rev
Log:
More constexpr algorithms from P0202. any_of/all_of/none_of.
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/test/std/algorithms/alg.nonmodifying/al
Author: marshall
Date: Mon Jan 15 09:53:34 2018
New Revision: 322493
URL: http://llvm.org/viewvc/llvm-project?rev=322493&view=rev
Log:
partition_point gets the P0202 treatment
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/test/std/algorithms/alg.modifying.operations/alg.partition
Author: marshall
Date: Mon Jan 15 11:26:05 2018
New Revision: 322504
URL: http://llvm.org/viewvc/llvm-project?rev=322504&view=rev
Log:
More P0202 constexpr-ifying. All the find_XXX algorithms in this commit.
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/test/std/algorithms/alg.no
Author: marshall
Date: Mon Jan 15 11:32:32 2018
New Revision: 322505
URL: http://llvm.org/viewvc/llvm-project?rev=322505&view=rev
Log:
Some of the tests from earlier today had 'int' as the return type when it
should have been 'bool'. Fix that. It doesn't change the behavior of any of the
tests,
Author: marshall
Date: Mon Jan 15 11:40:34 2018
New Revision: 322506
URL: http://llvm.org/viewvc/llvm-project?rev=322506&view=rev
Log:
More constexpr from P0202. count and count_if. Also fix a comment that Morwenn
noted.
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/test/std/algo
Author: marshall
Date: Mon Jan 15 11:59:09 2018
New Revision: 322507
URL: http://llvm.org/viewvc/llvm-project?rev=322507&view=rev
Log:
Fix constexpr failure on C++11-based buildbots.
Modified:
libcxx/trunk/test/std/algorithms/alg.nonmodifying/alg.find.end/find_end_pred.pass.cpp
Modified:
l
Author: marshall
Date: Mon Jan 15 18:04:10 2018
New Revision: 322527
URL: http://llvm.org/viewvc/llvm-project?rev=322527&view=rev
Log:
More constexpr (re P0202) - equal and mismatch
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/test/std/algorithms/alg.nonmodifying/alg.equal/equal.
Author: marshall
Date: Mon Jan 15 18:11:13 2018
New Revision: 322528
URL: http://llvm.org/viewvc/llvm-project?rev=322528&view=rev
Log:
Actually CALL the constexpr tests.
Modified:
libcxx/trunk/test/std/algorithms/alg.nonmodifying/mismatch/mismatch.pass.cpp
libcxx/trunk/test/std/algorithm
Author: marshall
Date: Mon Jan 15 18:34:41 2018
New Revision: 322529
URL: http://llvm.org/viewvc/llvm-project?rev=322529&view=rev
Log:
More constexpr algorithms from P0202: lower_bound, upper_bound, equal_range,
binary_search
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/test/std
Author: marshall
Date: Tue Jan 16 06:54:36 2018
New Revision: 322556
URL: http://llvm.org/viewvc/llvm-project?rev=322556&view=rev
Log:
Change an internal table of constants for the poisson distribution from
type 'result_type' to 'double'. The only thing that we ever do with
these numbers is to pro
Author: marshall
Date: Tue Jan 16 07:48:27 2018
New Revision: 322566
URL: http://llvm.org/viewvc/llvm-project?rev=322566&view=rev
Log:
More constexpr algorithms from P0202. search/search_n
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/include/functional
libcxx/trunk/include/ty
Author: marshall
Date: Thu Jan 18 08:52:19 2018
New Revision: 322863
URL: http://llvm.org/viewvc/llvm-project?rev=322863&view=rev
Log:
A simple program for testing OSS-Fuzz test cases locally.
Added:
libcxx/trunk/fuzzing/fuzz_test.cpp
Added: libcxx/trunk/fuzzing/fuzz_test.cpp
URL:
http://ll
Author: marshall
Date: Thu Jan 18 09:01:34 2018
New Revision: 322864
URL: http://llvm.org/viewvc/llvm-project?rev=322864&view=rev
Log:
Use high_resolution_clock instead of steady_clock. Also now builds with gcc 7.2
(for comparison purposes)
Modified:
libcxx/trunk/fuzzing/fuzz_test.cpp
Modif
Author: marshall
Date: Thu Jan 18 10:37:11 2018
New Revision: 322872
URL: http://llvm.org/viewvc/llvm-project?rev=322872&view=rev
Log:
Add memory tracking
Modified:
libcxx/trunk/fuzzing/fuzz_test.cpp
Modified: libcxx/trunk/fuzzing/fuzz_test.cpp
URL:
http://llvm.org/viewvc/llvm-project/libc
Author: marshall
Date: Thu Jan 18 19:17:45 2018
New Revision: 322920
URL: http://llvm.org/viewvc/llvm-project?rev=322920&view=rev
Log:
Wrote my own version of is_permutation; that was dominating the timings
Modified:
libcxx/trunk/fuzzing/fuzzing.cpp
Modified: libcxx/trunk/fuzzing/fuzzing.cpp
Author: marshall
Date: Fri Jan 19 09:45:39 2018
New Revision: 322970
URL: http://llvm.org/viewvc/llvm-project?rev=322970&view=rev
Log:
More P0202 constexpr-ifying in . This commit handles 'transform'.
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/test/std/algorithms/alg.modifying
Author: marshall
Date: Fri Jan 19 10:07:29 2018
New Revision: 322975
URL: http://llvm.org/viewvc/llvm-project?rev=322975&view=rev
Log:
More P0202 constexpr-ifying in . This commit handles
replace/replace_if/replace_copy/replace_copy_if.
Modified:
libcxx/trunk/include/algorithm
libcxx/tr
Author: marshall
Date: Sat Jan 20 12:14:32 2018
New Revision: 323050
URL: http://llvm.org/viewvc/llvm-project?rev=323050&view=rev
Log:
More P0202 constexpr work. This commit adds
fill/fill_n/generate/generate_n/unique/unique_copy. I removed a specialization
of fill_n that recognized when we were
Author: marshall
Date: Sun Jan 21 16:11:44 2018
New Revision: 323070
URL: http://llvm.org/viewvc/llvm-project?rev=323070&view=rev
Log:
implement (but leave commented out) the constexpr tests from P0202 for
std::merge. merge requires std::copy, which isn't constexpr yet.
Modified:
libcxx/trun
Author: marshall
Date: Sun Jan 21 16:17:48 2018
New Revision: 323071
URL: http://llvm.org/viewvc/llvm-project?rev=323071&view=rev
Log:
Change a static_assert to check for is_trivial instead of is_pod, as is
mandated by P0767.
Modified:
libcxx/trunk/include/string
libcxx/trunk/include/str
Author: marshall
Date: Sun Jan 21 17:51:49 2018
New Revision: 323072
URL: http://llvm.org/viewvc/llvm-project?rev=323072&view=rev
Log:
Really comment out the constexpr tests.
Modified:
libcxx/trunk/test/std/algorithms/alg.sorting/alg.merge/merge.pass.cpp
libcxx/trunk/test/std/algorithms/a
Author: marshall
Date: Mon Jan 22 10:38:18 2018
New Revision: 323137
URL: http://llvm.org/viewvc/llvm-project?rev=323137&view=rev
Log:
Add (commented out) constexpr tests for copy/copy_backwards/copy_if/copy_n.
These will be enabled when that part of P0202 is implemented. NFC at this time.
Modi
Author: marshall
Date: Mon Jan 22 12:44:33 2018
New Revision: 323147
URL: http://llvm.org/viewvc/llvm-project?rev=323147&view=rev
Log:
Still more P0202 constexpr-ifying. This batch is:
for_each/for_each_n/lexicographical_compare
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/test
Author: marshall
Date: Mon Jan 22 13:43:04 2018
New Revision: 323152
URL: http://llvm.org/viewvc/llvm-project?rev=323152&view=rev
Log:
Another batch of P0202 constepr algirithms.
remove/remove_if/remove_copy/remove_copy_if/reverse_copy, and tests (commented
out) for rotate_copy, because that dep
Author: marshall
Date: Mon Jan 22 15:10:40 2018
New Revision: 323159
URL: http://llvm.org/viewvc/llvm-project?rev=323159&view=rev
Log:
Last batch of P0202 constexpr additions: includes/set_intersection/exchange
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/include/utility
lib
Author: marshall
Date: Mon Jan 22 15:17:20 2018
New Revision: 323160
URL: http://llvm.org/viewvc/llvm-project?rev=323160&view=rev
Log:
Update cxx2a status
Modified:
libcxx/trunk/www/cxx2a_status.html
Modified: libcxx/trunk/www/cxx2a_status.html
URL:
http://llvm.org/viewvc/llvm-project/libcx
Author: marshall
Date: Tue Jan 23 17:53:24 2018
New Revision: 323296
URL: http://llvm.org/viewvc/llvm-project?rev=323296&view=rev
Log:
Implement P0463R1: 'Endian just Endian'. Reviewed as
https://reviews.llvm.org/D35472
Added:
libcxx/trunk/test/std/utilities/meta/meta.type.synop/endian.pass.
Author: marshall
Date: Tue Jan 23 21:38:51 2018
New Revision: 323306
URL: http://llvm.org/viewvc/llvm-project?rev=323306&view=rev
Log:
include to get uint32_t
Modified:
libcxx/trunk/test/std/utilities/meta/meta.type.synop/endian.pass.cpp
Modified: libcxx/trunk/test/std/utilities/meta/meta.t
Author: marshall
Date: Wed Jan 24 14:42:25 2018
New Revision: 323385
URL: http://llvm.org/viewvc/llvm-project?rev=323385&view=rev
Log:
Implement LWG2783: stack::emplace() and queue::emplace() should return
decltype(auto)
Modified:
libcxx/trunk/include/queue
libcxx/trunk/include/stack
Author: marshall
Date: Thu Jan 25 14:33:17 2018
New Revision: 323479
URL: http://llvm.org/viewvc/llvm-project?rev=323479&view=rev
Log:
Mark 2903 as complete; we already do this
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/vie
Author: marshall
Date: Mon Jan 29 13:28:46 2018
New Revision: 323694
URL: http://llvm.org/viewvc/llvm-project?rev=323694&view=rev
Log:
Minor updated to the main libcxx page; add a link to the deprecation page
Modified:
libcxx/trunk/www/index.html
Modified: libcxx/trunk/www/index.html
URL:
h
Author: marshall
Date: Mon Jan 29 16:47:43 2018
New Revision: 323719
URL: http://llvm.org/viewvc/llvm-project?rev=323719&view=rev
Log:
Add tests to make sure that provides std::size/data/empty in
C++17 mode. This is LWG#3009, coming up for a vote in JAX - but we already do
it, just don't have t
Author: marshall
Date: Mon Jan 29 16:48:39 2018
New Revision: 323720
URL: http://llvm.org/viewvc/llvm-project?rev=323720&view=rev
Log:
First cut at issue statuses for JAX
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/v
Author: marshall
Date: Tue Jan 30 13:49:17 2018
New Revision: 323822
URL: http://llvm.org/viewvc/llvm-project?rev=323822&view=rev
Log:
Add LWG3051
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-project/libcx
Author: marshall
Date: Wed Jan 31 13:42:39 2018
New Revision: 323918
URL: http://llvm.org/viewvc/llvm-project?rev=323918&view=rev
Log:
Implement LWG2870: Default value of parameter theta of polar should be dependent
Modified:
libcxx/trunk/include/complex
libcxx/trunk/test/std/numerics/co
Author: marshall
Date: Wed Jan 31 19:55:27 2018
New Revision: 323945
URL: http://llvm.org/viewvc/llvm-project?rev=323945&view=rev
Log:
Add static_asserts to basic_ios and basic_stream_buf to ensure that that the
traits match the character type. This is a requirement on the user - now we get
cons
Author: marshall
Date: Thu Feb 1 06:54:25 2018
New Revision: 323971
URL: http://llvm.org/viewvc/llvm-project?rev=323971&view=rev
Log:
Remove ; use instead. See
https://libcxx.llvm.org/TS_deprecation.html
Removed:
libcxx/trunk/test/libcxx/experimental/optional/
libcxx/trunk/test/std/exp
Author: marshall
Date: Thu Feb 1 07:21:14 2018
New Revision: 323972
URL: http://llvm.org/viewvc/llvm-project?rev=323972&view=rev
Log:
Remove ; use instead. See
https://libcxx.llvm.org/TS_deprecation.html
Removed:
libcxx/trunk/test/libcxx/experimental/any/
libcxx/trunk/test/std/experime
Author: marshall
Date: Thu Feb 1 07:49:27 2018
New Revision: 323975
URL: http://llvm.org/viewvc/llvm-project?rev=323975&view=rev
Log:
Remove ; use instead. See
https://libcxx.llvm.org/TS_deprecation.html
Removed:
libcxx/trunk/test/std/experimental/numeric/
Modified:
libcxx/trunk/includ
Author: marshall
Date: Thu Feb 1 08:36:08 2018
New Revision: 323979
URL: http://llvm.org/viewvc/llvm-project?rev=323979&view=rev
Log:
Remove std::experimental::sample; use std::sample instead. See
https://libcxx.llvm.org/TS_deprecation.html
Removed:
libcxx/trunk/test/std/experimental/algori
Author: marshall
Date: Thu Feb 1 10:45:57 2018
New Revision: 323989
URL: http://llvm.org/viewvc/llvm-project?rev=323989&view=rev
Log:
Put the exception classes for experimental::optional and experimental::any back
in the dylib for binary compatibility
Modified:
libcxx/trunk/src/any.cpp
Author: marshall
Date: Fri Feb 10 14:49:08 2017
New Revision: 294779
URL: http://llvm.org/viewvc/llvm-project?rev=294779&view=rev
Log:
Make lcm/gcd work better in edge cases. Fixes a UBSAN failure.
Modified:
libcxx/trunk/include/experimental/numeric
libcxx/trunk/include/numeric
libcx
Author: marshall
Date: Fri Feb 10 16:44:14 2017
New Revision: 294798
URL: http://llvm.org/viewvc/llvm-project?rev=294798&view=rev
Log:
Fix a bug I introduced in the tests for experimental::lcm and experimental::gcd.
Modified:
libcxx/trunk/test/std/experimental/numeric/numeric.ops/numeric.ops
Author: marshall
Date: Thu Feb 16 12:50:30 2017
New Revision: 295355
URL: http://llvm.org/viewvc/llvm-project?rev=295355&view=rev
Log:
Update a couple of issue statuses
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/llvm
Author: marshall
Date: Mon Mar 6 10:06:02 2017
New Revision: 297021
URL: http://llvm.org/viewvc/llvm-project?rev=297021&view=rev
Log:
Update list with changes from Kona meeting
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/vi
Author: marshall
Date: Mon Mar 6 10:09:02 2017
New Revision: 297022
URL: http://llvm.org/viewvc/llvm-project?rev=297022&view=rev
Log:
Header update with info about the current status of C++17
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
htt
Author: marshall
Date: Mon Nov 14 14:38:43 2016
New Revision: 286883
URL: http://llvm.org/viewvc/llvm-project?rev=286883&view=rev
Log:
Missed a test with exceptions disabled earlier. Oops.
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/T_size_size.pass.cpp
Modified:
libcxx
Author: marshall
Date: Mon Nov 14 14:41:17 2016
New Revision: 286884
URL: http://llvm.org/viewvc/llvm-project?rev=286884&view=rev
Log:
P0503R0, adopted in Issaquah, rewords some requirements on nullptr_t and
istream_iterator. No code changes were needed, but I updated a few tests. Also
resolved
Author: marshall
Date: Mon Nov 14 23:03:22 2016
New Revision: 286932
URL: http://llvm.org/viewvc/llvm-project?rev=286932&view=rev
Log:
Missed one of the try blocks the first time :-(. Thanks to Renato for the heads
up.
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/T_size_s
mclow.lists created this revision.
mclow.lists added a reviewer: rsmith.
mclow.lists added a subscriber: cfe-commits.
Last week, WG21 approved a paper (http://wg21.link/P0403) for allowing literal
suffixes for `string_view`. This means that should be able to write:
constexpr std::string_view s
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D26627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
mclow.lists added a comment.
I'm working on this, too.
Trying to decide what the right choice is here.
https://reviews.llvm.org/D26623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists added a comment.
We've been using a different pattern for this kind of tests (as we support more
and more noexcept cases). Something like this (for the second change):
template
void
test(const S& s, typename S::size_type pos, typename
mclow.lists added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:768
.Cases("il", "i", "if", true)
+ .Case("sv", true)
.Default(false);
malcolm.parsons wrote:
> This is in `NumericLiteralParser::isValidUDSuffix()`.
>
> If a change is
mclow.lists added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:768
.Cases("il", "i", "if", true)
+ .Case("sv", true)
.Default(false);
aaron.ballman wrote:
> malcolm.parsons wrote:
> > aaron.ballman wrote:
> > > mclow.lists wrote:
> >
mclow.lists added a comment.
I'll do some research.
https://reviews.llvm.org/D26376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists added a comment.
Ok - looking just at `kill_dependency`, this was added to the C standard in
C11. It's required to be a macro.
`atomic_is_lock_free` appears to be a function, as does `atomic_load`. Haven't
checked the rest.
I see that Bionic (sometimes) defines `atomic_is_lock_free`
mclow.lists added a comment.
More info - The following code:
#include
int main () {}
fails to compile on either gcc 6.2 (locally), gcc 7 head (online compiler) or
MSVC (online compiler).
https://reviews.llvm.org/D26376
___
cfe-commits mailin
mclow.lists added a comment.
Do these tests pass with the current `` implementation, or will they have
to wait?
Comment at: test/std/utilities/utility/utility.inplace/inplace.pass.cpp:40
-template
-struct CheckRet : std::false_type {};
-template
-struct CheckRet : std::tru
mclow.lists added inline comments.
Comment at: test/std/containers/associative/map/map.access/max_size.pass.cpp:24
+
+template size_t alloc_max_size(Alloc const &a) {
+ typedef std::allocator_traits AT;
How about a newline here? (after the `template<>`)
And wh
mclow.lists added a comment.
Tests look good; I'm still staring at the stuff in `<__string>`.
Comment at: include/__string:138
template
-inline
-const _CharT*
+_LIBCPP_CONSTEXPR_AFTER_CXX14 inline const _CharT*
char_traits<_CharT>::find(const char_type* __s, size_t __n, cons
Author: marshall
Date: Sat Nov 26 09:49:40 2016
New Revision: 287981
URL: http://llvm.org/viewvc/llvm-project?rev=287981&view=rev
Log:
Implement the 'detection idiom' from LFTS v2
Added:
libcxx/trunk/test/std/experimental/utilities/meta/meta.detect/
libcxx/trunk/test/std/experimental/uti
Author: marshall
Date: Sat Nov 26 12:45:03 2016
New Revision: 287988
URL: http://llvm.org/viewvc/llvm-project?rev=287988&view=rev
Log:
Implement conjuntion/disjuntion/negation for LFTS v2. Same code and tests for
the ones in std::
Added:
libcxx/trunk/test/std/experimental/utilities/meta/meta
Author: marshall
Date: Thu May 4 11:36:39 2017
New Revision: 302168
URL: http://llvm.org/viewvc/llvm-project?rev=302168&view=rev
Log:
Use lgamma_r instead of lgamma in binomial_distribution, because freakin' POSIX
took a perfectly fine call and made it not thread safe.
Modified:
libcxx/tru
Author: marshall
Date: Thu May 11 08:51:09 2017
New Revision: 302798
URL: http://llvm.org/viewvc/llvm-project?rev=302798&view=rev
Log:
Mark LWG#2796 as complete. No functionality change; we had tests that covered
it already. Just added comments to the tests
Modified:
libcxx/trunk/test/std/ut
Author: marshall
Date: Thu May 11 08:55:20 2017
New Revision: 302799
URL: http://llvm.org/viewvc/llvm-project?rev=302799&view=rev
Log:
Mark LWG#2850 as complete. No functionality change; we had tests that covered
it already. Just added comments to the tests. Thanks to K-ballo for the heads
up.
Author: marshall
Date: Thu May 11 09:00:54 2017
New Revision: 302800
URL: http://llvm.org/viewvc/llvm-project?rev=302800&view=rev
Log:
Replace a nested namespace used for overload resolution with a struct. Richard
Smith says that using the namespace results in an ODR violation, but I
disagree. N
Author: marshall
Date: Thu May 11 09:25:45 2017
New Revision: 302802
URL: http://llvm.org/viewvc/llvm-project?rev=302802&view=rev
Log:
Mark LWG#2782 as complete. No functionality change; we already do this. Just
added a few more tests.
Modified:
libcxx/trunk/test/std/utilities/allocator.ada
Author: marshall
Date: Wed May 17 10:30:01 2017
New Revision: 303268
URL: http://llvm.org/viewvc/llvm-project?rev=303268&view=rev
Log:
Mark the copy constructor and move
constructor to be constexpr. This only works when the contained type has a
constexpr copy/move ctor.
Modified:
libcxx/tru
Author: marshall
Date: Wed May 17 13:51:36 2017
New Revision: 303281
URL: http://llvm.org/viewvc/llvm-project?rev=303281&view=rev
Log:
Make next/prev/advance/distance operations on iterators be constexpr. I missed
this when I implemented the rest of P0031R0
Modified:
libcxx/trunk/include/ite
Author: marshall
Date: Tue May 23 13:55:32 2017
New Revision: 303675
URL: http://llvm.org/viewvc/llvm-project?rev=303675&view=rev
Log:
Implement LWG#2790: Remove istreambuf_iterator::operator->. It never did
anything useful.
Removed:
libcxx/trunk/test/std/iterators/stream.iterators/istreamb
mclow.lists added a comment.
> error: undefined reference to '__gxx_personality_v0'
means that you're not linking to an ABI library.
That symbol comes out of libc++abi, but you can also get that from libsupc.
My build setup is similar to yours (on Mac OS X):
cd $LLVM_BUILD ; rm -rf libcxx ;
mclow.lists added a comment.
I like this; I would like to see no mentions of `_WIN32` outside of
`<__config>`.
That being said, we usually write things in the negative in libc++.
So the flag would be `_LIBCPP_HAS_NO_OFF_T_FUNCTIONS`, and the tests would be
`#ifdef _LIBCPP_HAS_NO_OFF_T_FUNCTIONS
mclow.lists added a comment.
In https://reviews.llvm.org/D25403#573104, @jlebar wrote:
> Likewise, should I update the documentation to indicate that check-cxx may
> fail with a clang built from tip of tree, due to c++17 support being
> experimental? Or do you all want to change the target so
Author: marshall
Date: Wed Oct 19 10:12:50 2016
New Revision: 284602
URL: http://llvm.org/viewvc/llvm-project?rev=284602&view=rev
Log:
Implement constexpr support for reverse_iterator. Reviewed as
https://reviews.llvm.org/D25534
Modified:
libcxx/trunk/include/iterator
libcxx/trunk/test/
mclow.lists closed this revision.
mclow.lists marked 3 inline comments as done.
mclow.lists added a comment.
Landed as revision 284602
https://reviews.llvm.org/D25534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
mclow.lists added a comment.
In https://reviews.llvm.org/D25595#572043, @timshen wrote:
> BTW, `re.const/re.matchflag/match_flag_type.pass.cpp` contains match_not_bow,
> but it doesn't actually test the functionality.
It tests that it exists and that it has a sane value - which are a good thin
mclow.lists added a comment.
Do we need to test calling `regex_match` with `match_not_null`?
If not, then I think this is good to go.
Do you have commit access, or would you rather I committed it?
https://reviews.llvm.org/D25595
___
cfe-commits mai
mclow.lists added a comment.
I don't have a problem with this being marked as inline, as long as it doesn't
disappear out of the dylib.
There *has* to be a version of `basic_string,
Allocator>::~basic_string` in the dylib - existing applications depend
upon it. (same for `wchar_t`).
https://
mclow.lists added a comment.
This is the same problem as is facing https://reviews.llvm.org/D24991
https://reviews.llvm.org/D25624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D25595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: marshall
Date: Thu Oct 20 09:57:34 2016
New Revision: 284731
URL: http://llvm.org/viewvc/llvm-project?rev=284731&view=rev
Log:
Adding a missing constexpr test for reverse_iterator operator[].
Modified:
libcxx/trunk/test/std/iterators/predef.iterators/reverse.iterators/reverse.iter.op
mclow.lists created this revision.
mclow.lists added reviewers: EricWF, lefticus, AntonBikineev.
mclow.lists added a subscriber: cfe-commits.
This just does the `move_iterator` bits of http://wg21.link/P0031 - not any of
the other parts.
This duplicates some (but not all) of the work that was do
mclow.lists added inline comments.
Comment at: include/iterator:1559
struct __libcpp_is_trivial_iterator
- : public _LIBCPP_BOOL_CONSTANT(is_pointer<_Iter>::value) {};
-
+: public _LIBCPP_BOOL_CONSTANT(is_pointer<_Iter>::value) {};
+
These c
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
mclow.lists added a comment.
Looks better than before.
Repository:
rL LLVM
https://reviews.llvm.org/D24372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
401 - 500 of 905 matches
Mail list logo
