Author: marshall
Date: Thu May 4 11:36:39 2017
New Revision: 302168
URL: http://llvm.org/viewvc/llvm-project?rev=302168&view=rev
Log:
Use lgamma_r instead of lgamma in binomial_distribution, because freakin' POSIX
took a perfectly fine call and made it not thread safe.
Modified:
libcxx/trunk/include/random
Modified: libcxx/trunk/include/random
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/random?rev=302168&r1=302167&r2=302168&view=diff
==============================================================================
--- libcxx/trunk/include/random (original)
+++ libcxx/trunk/include/random Thu May 4 11:36:39 2017
@@ -3997,16 +3997,20 @@ public:
{return !(__x == __y);}
};
+extern "C" double lgamma_r(double, int *);
+
template<class _IntType>
-binomial_distribution<_IntType>::param_type::param_type(result_type __t,
double __p)
+binomial_distribution<_IntType>::param_type::param_type(const result_type __t,
const double __p)
: __t_(__t), __p_(__p)
{
if (0 < __p_ && __p_ < 1)
{
+ int __sign;
__r0_ = static_cast<result_type>((__t_ + 1) * __p_);
- __pr_ = _VSTD::exp(_VSTD::lgamma(__t_ + 1.) - _VSTD::lgamma(__r0_ +
1.) -
- _VSTD::lgamma(__t_ - __r0_ + 1.) + __r0_ *
_VSTD::log(__p_) +
- (__t_ - __r0_) * _VSTD::log(1 - __p_));
+ __pr_ = _VSTD::exp(lgamma_r(__t_ + 1., &__sign) -
+ lgamma_r(__r0_ + 1., &__sign) -
+ lgamma_r(__t_ - __r0_ + 1., &__sign) + __r0_ *
_VSTD::log(__p_) +
+ (__t_ - __r0_) * _VSTD::log(1 - __p_));
__odds_ratio_ = __p_ / (1 - __p_);
}
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
