[libcxx] r251247 - Fix LWG#2127: Move-construction with raw_storage_iterator.

2015-10-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Oct 25 13:58:07 2015 New Revision: 251247 URL: http://llvm.org/viewvc/llvm-project?rev=251247&view=rev Log: Fix LWG#2127: Move-construction with raw_storage_iterator. Modified: libcxx/trunk/include/memory libcxx/trunk/test/std/utilities/memory/storage.iterator/

[libcxx] r251250 - Add a test for LWG#2462: std::ios_base::failure is overspecified

2015-10-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Oct 25 14:20:14 2015 New Revision: 251250 URL: http://llvm.org/viewvc/llvm-project?rev=251250&view=rev Log: Add a test for LWG#2462: std::ios_base::failure is overspecified Modified: libcxx/trunk/test/std/input.output/iostreams.base/ios.base/ios.types/ios_failure/c

[libcxx] r251252 - Add a test for LWG#2466: allocator_traits::max_size() default behavior is incorrect

2015-10-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Oct 25 14:34:04 2015 New Revision: 251252 URL: http://llvm.org/viewvc/llvm-project?rev=251252&view=rev Log: Add a test for LWG#2466: allocator_traits::max_size() default behavior is incorrect Modified: libcxx/trunk/include/memory libcxx/trunk/test/std/utilitie

[libcxx] r251253 - Fix LWG#2476: scoped_allocator_adaptor is not assignable

2015-10-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Oct 25 14:52:47 2015 New Revision: 251253 URL: http://llvm.org/viewvc/llvm-project?rev=251253&view=rev Log: Fix LWG#2476: scoped_allocator_adaptor is not assignable Modified: libcxx/trunk/include/scoped_allocator Modified: libcxx/trunk/include/scoped_allocator URL:

[libcxx] r251254 - Add the tests for the last commit

2015-10-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Oct 25 14:53:29 2015 New Revision: 251254 URL: http://llvm.org/viewvc/llvm-project?rev=251254&view=rev Log: Add the tests for the last commit Added: libcxx/trunk/test/std/utilities/allocator.adaptor/scoped.adaptor.operators/copy_assign.pass.cpp libcxx/trunk/te

[libcxx] r251257 - Fix LWG#2489: mem_fn() should be noexcept

2015-10-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Oct 25 15:12:16 2015 New Revision: 251257 URL: http://llvm.org/viewvc/llvm-project?rev=251257&view=rev Log: Fix LWG#2489: mem_fn() should be noexcept Modified: libcxx/trunk/include/functional libcxx/trunk/test/std/utilities/function.objects/func.memfn/member_fu

[libcxx] r251258 - Mark LWG#2495 as complete. No code changes needed

2015-10-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Oct 25 15:12:58 2015 New Revision: 251258 URL: http://llvm.org/viewvc/llvm-project?rev=251258&view=rev Log: Mark LWG#2495 as complete. No code changes needed Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm

[libcxx] r251545 - Mark two Kona papers as 'in progress'

2015-10-28 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Oct 28 14:21:40 2015 New Revision: 251545 URL: http://llvm.org/viewvc/llvm-project?rev=251545&view=rev Log: Mark two Kona papers as 'in progress' Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/viewvc/

[libcxx] r251618 - Implement P0004R1 'Remove Deprecated iostreams aliases'

2015-10-28 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Oct 29 00:43:30 2015 New Revision: 251618 URL: http://llvm.org/viewvc/llvm-project?rev=251618&view=rev Log: Implement P0004R1 'Remove Deprecated iostreams aliases' Modified: libcxx/trunk/include/ios libcxx/trunk/test/std/depr/depr.ios.members/io_state.pass.cpp

[libcxx] r251767 - Improve the tests for 'is_literal_type'

2015-11-01 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Nov 1 15:13:10 2015 New Revision: 251767 URL: http://llvm.org/viewvc/llvm-project?rev=251767&view=rev Log: Improve the tests for 'is_literal_type' Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_literal_type.pass.cpp Modified: libcxx

[libcxx] r251768 - Add 'nostdinc++' to the flags used by testit. Makes the tests run better on Mac OS X with the new depr.c headers change

2015-11-01 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Nov 1 15:14:22 2015 New Revision: 251768 URL: http://llvm.org/viewvc/llvm-project?rev=251768&view=rev Log: Add 'nostdinc++' to the flags used by testit. Makes the tests run better on Mac OS X with the new depr.c headers change Modified: libcxx/trunk/test/testit M

[libcxx] r251802 - Remove undefined behavior from some tests. Thanks to Walter Brown for the heads-up.

2015-11-02 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Nov 2 09:25:53 2015 New Revision: 251802 URL: http://llvm.org/viewvc/llvm-project?rev=251802&view=rev Log: Remove undefined behavior from some tests. Thanks to Walter Brown for the heads-up. Modified: libcxx/trunk/test/std/utilities/memory/specialized.algorithms/

[libcxx] r251804 - Remove undefined behavior from some tests. Same pattern as the unitialized_copy tests

2015-11-02 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Nov 2 09:29:13 2015 New Revision: 251804 URL: http://llvm.org/viewvc/llvm-project?rev=251804&view=rev Log: Remove undefined behavior from some tests. Same pattern as the unitialized_copy tests Modified: libcxx/trunk/test/std/utilities/memory/specialized.algorithm

[libcxx] r251836 - Make reverse() call iter_swap like the standard says, instead of calling swap directly. No real change.

2015-11-02 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Nov 2 15:34:25 2015 New Revision: 251836 URL: http://llvm.org/viewvc/llvm-project?rev=251836&view=rev Log: Make reverse() call iter_swap like the standard says, instead of calling swap directly. No real change. Modified: libcxx/trunk/include/algorithm Modified: l

[libcxx] r252195 - Implement P0092R1 for C++1z

2015-11-05 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Nov 5 13:33:59 2015 New Revision: 252195 URL: http://llvm.org/viewvc/llvm-project?rev=252195&view=rev Log: Implement P0092R1 for C++1z Added: libcxx/trunk/test/std/utilities/time/time.duration/time.duration.alg/ libcxx/trunk/test/std/utilities/time/time.durati

[libcxx] r252199 - Mark LWG issue #2234. We already do this; no code change needed

2015-11-05 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Nov 5 13:57:50 2015 New Revision: 252199 URL: http://llvm.org/viewvc/llvm-project?rev=252199&view=rev Log: Mark LWG issue #2234. We already do this; no code change needed Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL

[libcxx] r252406 - More of P0006R0: type traits variable aliases for C++17.

2015-11-07 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sat Nov 7 11:44:36 2015 New Revision: 252406 URL: http://llvm.org/viewvc/llvm-project?rev=252406&view=rev Log: More of P0006R0: type traits variable aliases for C++17. Modified: libcxx/trunk/include/type_traits libcxx/trunk/test/std/utilities/meta/meta.unary/meta.

[libcxx] r252407 - Implement LWG#2353: std::next is over-constrained

2015-11-07 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sat Nov 7 11:48:49 2015 New Revision: 252407 URL: http://llvm.org/viewvc/llvm-project?rev=252407&view=rev Log: Implement LWG#2353: std::next is over-constrained Modified: libcxx/trunk/include/iterator libcxx/trunk/test/std/iterators/iterator.primitives/iterator.op

[libcxx] r252408 - Mark LWG#2224 as complete. Wording change only, no code changes required

2015-11-07 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sat Nov 7 11:56:51 2015 New Revision: 252408 URL: http://llvm.org/viewvc/llvm-project?rev=252408&view=rev Log: Mark LWG#2224 as complete. Wording change only, no code changes required Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status

[libcxx] r252509 - Mark LWG#2486 as complete. Eric did this as part of r242959

2015-11-09 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Nov 9 14:49:15 2015 New Revision: 252509 URL: http://llvm.org/viewvc/llvm-project?rev=252509&view=rev Log: Mark LWG#2486 as complete. Eric did this as part of r242959 Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: h

[libcxx] r252610 - Explicitly #include so that we get std::move. Thanks to Walter for the bug report.

2015-11-10 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Nov 10 09:22:08 2015 New Revision: 252610 URL: http://llvm.org/viewvc/llvm-project?rev=252610&view=rev Log: Explicitly #include so that we get std::move. Thanks to Walter for the bug report. Modified: libcxx/trunk/test/std/utilities/function.objects/func.invoke/in

[libcxx] r252612 - Walter pointed out some missing includes in the tests. Fixing the includes uncovered a couple bugs in the _v type traits. Fixed those, too

2015-11-10 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Nov 10 09:48:23 2015 New Revision: 252612 URL: http://llvm.org/viewvc/llvm-project?rev=252612&view=rev Log: Walter pointed out some missing includes in the tests. Fixing the includes uncovered a couple bugs in the _v type traits. Fixed those, too Modified: libcxx/t

[libcxx] r252613 - std:: qualify ptrdiff_t in the test. Thanks to Walter for the catch

2015-11-10 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Nov 10 10:04:13 2015 New Revision: 252613 URL: http://llvm.org/viewvc/llvm-project?rev=252613&view=rev Log: std:: qualify ptrdiff_t in the test. Thanks to Walter for the catch Modified: libcxx/trunk/test/std/depr/depr.c.headers/stdint_h.pass.cpp Modified: libcxx/tr

[libcxx] r252614 - Fix typo I just introduced.

2015-11-10 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Nov 10 10:10:17 2015 New Revision: 252614 URL: http://llvm.org/viewvc/llvm-project?rev=252614&view=rev Log: Fix typo I just introduced. Modified: libcxx/trunk/test/std/utilities/function.objects/func.invoke/invoke.pass.cpp Modified: libcxx/trunk/test/std/utilities

[libcxx] r252905 - Implement P0074: Making owner_less more flexible

2015-11-12 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Nov 12 09:56:44 2015 New Revision: 252905 URL: http://llvm.org/viewvc/llvm-project?rev=252905&view=rev Log: Implement P0074: Making owner_less more flexible Modified: libcxx/trunk/include/memory libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr

[libcxx] r275904 - Bump version # to 4.0.0

2016-07-18 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Jul 18 15:27:19 2016 New Revision: 275904 URL: http://llvm.org/viewvc/llvm-project?rev=275904&view=rev Log: Bump version # to 4.0.0 Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL: http://llvm.org/viewvc/llvm-project/libcxx/trun

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

2016-07-20 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/string:3216 @@ -3668,3 +3215,3 @@ { -return _VSTD::__str_find_last_not_of +return __str_find_last_not_of (data(), size(), __str.data(), __pos, __str.size()); EricWF wrote: > Why is this call

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

2016-07-20 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a reviewer: mclow.lists. mclow.lists added a comment. This revision is now accepted and ready to land. Landed as revision 276238. https://reviews.llvm.org/D21459 ___ cfe-commits mailing list cfe-

[libcxx] r276241 - Fix some string_view tests that were failing when exceptions were disabled. Also comment out a _LIBCPP_ASSERT that gcc4.9 was complaining about. Will revisit that later.

2016-07-20 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jul 21 01:24:04 2016 New Revision: 276241 URL: http://llvm.org/viewvc/llvm-project?rev=276241&view=rev Log: Fix some string_view tests that were failing when exceptions were disabled. Also comment out a _LIBCPP_ASSERT that gcc4.9 was complaining about. Will revisit tha

[libcxx] r276272 - Another fix to appease the no-exception bots.

2016-07-21 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jul 21 08:18:50 2016 New Revision: 276272 URL: http://llvm.org/viewvc/llvm-project?rev=276272&view=rev Log: Another fix to appease the no-exception bots. Modified: libcxx/trunk/test/std/strings/string.view/string.view.ops/substr.pass.cpp Modified: libcxx/trunk/tes

[libcxx] r276273 - Again, w/o the tabs

2016-07-21 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jul 21 08:19:36 2016 New Revision: 276273 URL: http://llvm.org/viewvc/llvm-project?rev=276273&view=rev Log: Again, w/o the tabs Modified: libcxx/trunk/test/std/strings/string.view/string.view.ops/substr.pass.cpp Modified: libcxx/trunk/test/std/strings/string.view/

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

2016-07-21 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + kimgr wrote: > I'm working from the paper at https://isocpp.org/files/

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

2016-07-21 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Maybe something like this? (untested) template _LIBCPP_ALWAYS_INLINE typename std::enable_if::value, bool>::type __libcpp_isfinite(_A1 __lcpp_x) _NOEXCEPT { return isfinite(__lcpp_x); } template _LIBCPP_ALWAYS_INLINE typename std::enable_i

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

2016-07-21 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. And is there any reason why `__libcpp_isinf` can't just return `false` for non-fp types? https://reviews.llvm.org/D18639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

2016-07-21 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + kimgr wrote: > mclow.lists wrote: > > kimgr wrote: > > > I'm working f

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

2016-07-21 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + mclow.lists wrote: > kimgr wrote: > > mclow.lists wrote: > > > kimgr w

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

2016-07-21 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + kimgr wrote: > mclow.lists wrote: > > mclow.lists wrote: > > > kimgr w

Re: [PATCH] D22782: Added 'inline' attribute to __init to inline the basic_string's constructor

2016-07-25 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Do we have a test for the problem that this is solving? https://reviews.llvm.org/D22782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

2016-07-25 Thread Marshall Clow via cfe-commits
mclow.lists updated this revision to Diff 65463. mclow.lists added a comment. Updated with Eric's constexpr tests. Once this is approved, it will be applied twice - once in ``, and once in `` https://reviews.llvm.org/D21343 Files: include/experimental/numeric test/std/experimental/numeric/

[libcxx] r276750 - Implement LCM and GCD for Library Fundamentals. Reviewed as https://reviews.llvm.org/D21343.

2016-07-26 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jul 26 09:28:34 2016 New Revision: 276750 URL: http://llvm.org/viewvc/llvm-project?rev=276750&view=rev Log: Implement LCM and GCD for Library Fundamentals. Reviewed as https://reviews.llvm.org/D21343. Added: libcxx/trunk/include/experimental/numeric libcxx/trun

[libcxx] r276751 - Implement LCM and GCD for C++17. Same code as for Library Fundamentals TS.

2016-07-26 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jul 26 09:29:45 2016 New Revision: 276751 URL: http://llvm.org/viewvc/llvm-project?rev=276751&view=rev Log: Implement LCM and GCD for C++17. Same code as for Library Fundamentals TS. Added: libcxx/trunk/test/std/numerics/numeric.ops/numeric.ops.gcd/ libcxx/trun

[libcxx] r276955 - Add a bunch of noexcepts to char_traits and string_view.

2016-07-27 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Jul 27 23:52:02 2016 New Revision: 276955 URL: http://llvm.org/viewvc/llvm-project?rev=276955&view=rev Log: Add a bunch of noexcepts to char_traits and string_view. Modified: libcxx/trunk/include/__string libcxx/trunk/include/string_view Modified: libcxx/trunk/

Re: [PATCH] D22834: Added 'inline' attribute to basic_string's destructor

2016-08-02 Thread Marshall Clow via cfe-commits
On Sat, Jul 30, 2016 at 12:47 PM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Jul 26, 2016 at 10:30:22PM +, Laxman Sole via cfe-commits > wrote: > > Currently basic_string's destructor is not getting inlined. So adding > 'inline' attribute to ~basic_string

Re: [PATCH] D23331: Implement LWG 2148: Make non-enum default hash specialization well-formed

2016-08-10 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. This looks good to me. However, we don't //usually// change libc++ for issue resolutions that have not yet adopted. We wait until they've "official". https://reviews.llvm.org/D23331 ___ cfe-commits mailing list cfe-comm

[libcxx] r278282 - std:: quailfy the calls for cend/crend/cbegin/cend. Fixes bug 28927.

2016-08-10 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Aug 10 15:04:46 2016 New Revision: 278282 URL: http://llvm.org/viewvc/llvm-project?rev=278282&view=rev Log: std:: quailfy the calls for cend/crend/cbegin/cend. Fixes bug 28927. Added: libcxx/trunk/test/std/iterators/iterator.range/begin-end.fail.cpp Modified: li

[libcxx] r278387 - Remove test for the sign of a NaN - doesn't work on MIPS, not strictly legal. Fixes bug 28936

2016-08-11 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Aug 11 13:46:24 2016 New Revision: 278387 URL: http://llvm.org/viewvc/llvm-project?rev=278387&view=rev Log: Remove test for the sign of a NaN - doesn't work on MIPS, not strictly legal. Fixes bug 28936 Modified: libcxx/trunk/test/std/numerics/complex.number/comple

Re: [PATCH] D23507: [libcxx] include/math.h: Re-enable missing C++11 decls on SunOS

2016-08-15 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. I can't vouch for the correctness (not having a sun system to play with), but this LGTM. at some point, the repeated expression `!(defined(_LIBCPP_MSVCRT) || defined(_AIX) || define

Re: [PATCH] D16467: [libcxx] re.results.form: Format out-of-range subexpression references as null

2016-02-03 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D16467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D10963: Implement LWG#2063: "Contradictory requirements for string move assignment"

2016-02-06 Thread Marshall Clow via cfe-commits
mclow.lists abandoned this revision. mclow.lists added a comment. This has been done via another means. http://reviews.llvm.org/D10963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r260115 - Clean up a test; get rid of hard-wired char/wchar_t code for template fns that take any char type. Prep work for PR#26503

2016-02-08 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Feb 8 11:38:23 2016 New Revision: 260115 URL: http://llvm.org/viewvc/llvm-project?rev=260115&view=rev Log: Clean up a test; get rid of hard-wired char/wchar_t code for template fns that take any char type. Prep work for PR#26503 Modified: libcxx/trunk/test/std/in

[libcxx] r260202 - Minor updates to failing tests. NFC

2016-02-08 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 9 00:38:56 2016 New Revision: 260202 URL: http://llvm.org/viewvc/llvm-project?rev=260202&view=rev Log: Minor updates to failing tests. NFC Modified: libcxx/trunk/test/std/input.output/iostream.format/quoted.manip/quoted_char.fail.cpp libcxx/trunk/test/std

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

2016-02-09 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. I think you've reduced the scope of the tests significantly with this change. If you want to make the objects smaller, that's fine - but please heed Howard's advice in the email thread: - Don't make them too small. (three digits is better than two) - Keep the objec

Re: [PATCH] D16639: [libcxx] Limit catopen usage to unix-like OSes

2016-02-09 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. I don't have a problem with this change (assuming that it is correct, and it looks correct), but I think it should stay in __config, with all the other configuration tests. (There are other configuration tests in the .cpp files, but users never see those). FWIW, l

Re: [PATCH] D17053: [libcxx]: vector: Use < instead of != to improve failure mode

2016-02-09 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Undefined behavior is just that, undefined. I'm not that interested in "fixing" this; I don't think it's broken. http://reviews.llvm.org/D17053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D17053: [libcxx]: vector: Use < instead of != to improve failure mode

2016-02-09 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. > Since `__new_last` and `__end_` are raw pointers, < should be the same cost > as !=. `pointer` is an alias for `allocator_traits<_Alloc>::pointer`, which might not be a raw pointer. http://reviews.llvm.org/D17053 _

Re: [libcxx] r259842 - Fix the search path for CMake files

2016-02-09 Thread Marshall Clow via cfe-commits
On Thu, Feb 4, 2016 at 3:17 PM, Niels Ole Salscheider via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: olesalscheider > Date: Thu Feb 4 17:17:20 2016 > New Revision: 259842 > > URL: http://llvm.org/viewvc/llvm-project?rev=259842&view=rev > Log: > Fix the search path for CMake files

Re: [PATCH] D16639: [libcxx] Limit catopen usage to unix-like OSes

2016-02-09 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks good to me. > Saving a larger locale refactor for later (but oh boy is it coming). Looking forward to it. http://reviews.llvm.org/D16639

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

2016-02-10 Thread Marshall Clow via cfe-commits
On Wed, Feb 10, 2016 at 2:46 PM, Duncan P. N. Exon Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I'm hoping only a year or two (or three...)? > As I pointed out to Eric on IRC, those files have had a "deprecation warning" every time they are included ... since 2010. -- Marshall __

[libcxx] r260527 - Add some tests to ensure that the __regex_word does not conflict with any of ctype_base's values.

2016-02-11 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Feb 11 09:23:04 2016 New Revision: 260527 URL: http://llvm.org/viewvc/llvm-project?rev=260527&view=rev Log: Add some tests to ensure that the __regex_word does not conflict with any of ctype_base's values. Hopefully this will catch cases like https://llvm.org/bugs/show

Re: [PATCH] D17132: [libcxx] Fix definition of regex_traits::__regex_word on big-endian glibc systems

2016-02-11 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. In r260527, I added some tests to catch this if it happens again. If those tests fail w/o this patch and succeed with, then I'm happy with applying it. http://reviews.llvm.org/D17132 ___ cfe-commits mailing list cfe-co

Re: [PATCH] D17146: [libcxx] locale portability refactor

2016-02-11 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. I am very much in favor of cleaning up this part of libc++. Thanks for taking this on. > I'm open to recommendations on ways to test this that are better than > "Submit, watch build bots, revert as necessary". My suggestion is to do this incrementally. Implement t

Re: [PATCH] D17132: [libcxx] Fix definition of regex_traits::__regex_word on big-endian glibc systems

2016-02-11 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. > ctype_base is defining graph by combining alnum and punct instead of using > the _IS* macro like the other bits. Because that's how the standard (22.4.1) shows to do it :-) > I'm not sure where it's getting the definition of classic_table. Presumably > it's comi

Re: [PATCH] D16946: Add link to llvm git documentation, and recommend always building libcxx on OSX

2016-02-11 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. This looks fine to me. I think this should be committed. http://reviews.llvm.org/D16946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r260964 - Added a (private) status page for the Jacksonville meeting

2016-02-16 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 16 08:35:56 2016 New Revision: 260964 URL: http://llvm.org/viewvc/llvm-project?rev=260964&view=rev Log: Added a (private) status page for the Jacksonville meeting Added: libcxx/trunk/www/upcoming_meeting.html Removed: libcxx/trunk/www/kona.html Removed: lib

[libcxx] r260966 - Add some comments

2016-02-16 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 16 08:42:23 2016 New Revision: 260966 URL: http://llvm.org/viewvc/llvm-project?rev=260966&view=rev Log: Add some comments Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-project

[libcxx] r260975 - Add some status

2016-02-16 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 16 10:05:15 2016 New Revision: 260975 URL: http://llvm.org/viewvc/llvm-project?rev=260975&view=rev Log: Add some status Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-project/l

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

2016-02-16 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. > Any objections to using the original sizes, but constructing the objects at > global scope? I think that should work. http://reviews.llvm.org/D15539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

Re: [PATCH] D17132: [libcxx] Fix definition of regex_traits::__regex_word on big-endian glibc systems

2016-02-16 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Let's wrap it in a MIPS ifdef for the moment, and then, post-release we can see if that can be relaxed. Given that, LGTM. http://reviews.llvm.org/D17132

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

2016-02-22 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. This looks fine to me; but I want to hear from @danalbert. http://reviews.llvm.org/D17416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17456: [libcxx] Reorganize _LIBCPP_LOCALE__L_EXTENSIONS

2016-02-22 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Actually, the prefix we use in the rest of libc++ for private functions is `__libcpp_` Take a look in type_traits for a bunch of examples. In general, I'm liking the way this is going. I suspect I will have more comments later today. http://reviews.llvm.org/D1745

[libcxx] r261581 - Fix __is_referenceable to work with vector types. Fixes PR#26654 and 26656. Thanks to Evgeniy for the reports, and to Eric for the suggestion on how to fix it.

2016-02-22 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Feb 22 16:13:03 2016 New Revision: 261581 URL: http://llvm.org/viewvc/llvm-project?rev=261581&view=rev Log: Fix __is_referenceable to work with vector types. Fixes PR#26654 and 26656. Thanks to Evgeniy for the reports, and to Eric for the suggestion on how to fix it.

[libcxx] r261647 - More updates; patch for 2583 ready

2016-02-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 23 10:20:24 2016 New Revision: 261647 URL: http://llvm.org/viewvc/llvm-project?rev=261647&view=rev Log: More updates; patch for 2583 ready Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/vi

[libcxx] r261648 - Add additional tests to ensure that we DTRT with short lists. This is LWG#2590, but there are no code changes, just additional tests

2016-02-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 23 10:25:20 2016 New Revision: 261648 URL: http://llvm.org/viewvc/llvm-project?rev=261648&view=rev Log: Add additional tests to ensure that we DTRT with short lists. This is LWG#2590, but there are no code changes, just additional tests Modified: libcxx/trunk/

[libcxx] r261653 - Add tests for LWG#2560. No code changes, just tests

2016-02-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 23 11:01:52 2016 New Revision: 261653 URL: http://llvm.org/viewvc/llvm-project?rev=261653&view=rev Log: Add tests for LWG#2560. No code changes, just tests Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_constructible.pass.cpp Modi

[libcxx] r261655 - More updates

2016-02-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 23 11:07:15 2016 New Revision: 261655 URL: http://llvm.org/viewvc/llvm-project?rev=261655&view=rev Log: More updates Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-project/libc

[libcxx] r261661 - These new tests fail on the green-dragon bots, which use an old Apple compiler.

2016-02-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 23 12:09:38 2016 New Revision: 261661 URL: http://llvm.org/viewvc/llvm-project?rev=261661&view=rev Log: These new tests fail on the green-dragon bots, which use an old Apple compiler. Since they're scheduled to be updated soon, we'll just comment out this test for th

[libcxx] r261677 - Fix a missing closing tag

2016-02-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 23 13:48:44 2016 New Revision: 261677 URL: http://llvm.org/viewvc/llvm-project?rev=261677&view=rev Log: Fix a missing closing tag Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm

[libcxx] r261676 - More updates

2016-02-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Feb 23 13:48:09 2016 New Revision: 261676 URL: http://llvm.org/viewvc/llvm-project?rev=261676&view=rev Log: More updates Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-project/libc

[libcxx] r261874 - Add test to ensure that the converting constructor in N4089 is present and working

2016-02-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Feb 25 09:25:29 2016 New Revision: 261874 URL: http://llvm.org/viewvc/llvm-project?rev=261874&view=rev Log: Add test to ensure that the converting constructor in N4089 is present and working Added: libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.dltr/

[libcxx] r261875 - No, really - test the constructor

2016-02-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Feb 25 09:27:13 2016 New Revision: 261875 URL: http://llvm.org/viewvc/llvm-project?rev=261875&view=rev Log: No, really - test the constructor Modified: libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.dltr/unique.ptr.dltr.dflt1/convert_ctor.pass.cpp Mo

[libcxx] r261894 - Another chunk of N4089

2016-02-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Feb 25 10:50:51 2016 New Revision: 261894 URL: http://llvm.org/viewvc/llvm-project?rev=261894&view=rev Log: Another chunk of N4089 Modified: libcxx/trunk/include/memory Modified: libcxx/trunk/include/memory URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/inc

[libcxx] r261896 - Update the status of a N4089 and a couple issues

2016-02-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Feb 25 10:55:58 2016 New Revision: 261896 URL: http://llvm.org/viewvc/llvm-project?rev=261896&view=rev Log: Update the status of a N4089 and a couple issues Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.

[libcxx] r261925 - Added tests to make sure that the categorization traits work on incomplete types

2016-02-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Feb 25 14:15:47 2016 New Revision: 261925 URL: http://llvm.org/viewvc/llvm-project?rev=261925&view=rev Log: Added tests to make sure that the categorization traits work on incomplete types Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.cat/arr

[libcxx] r261926 - more status updates

2016-02-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Feb 25 14:17:03 2016 New Revision: 261926 URL: http://llvm.org/viewvc/llvm-project?rev=261926&view=rev Log: more status updates Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-proje

[libcxx] r267591 - Apparently XFAIL tests that are supposed to fail to compile can be problematic. They still get compiled, and if the compile succeeds, the buildbots complain. Replace the XFAIL with

2016-04-26 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Apr 26 14:29:35 2016 New Revision: 267591 URL: http://llvm.org/viewvc/llvm-project?rev=267591&view=rev Log: Apparently XFAIL tests that are supposed to fail to compile can be problematic. They still get compiled, and if the compile succeeds, the buildbots complain. Rep

Re: [PATCH] D19565: [libc++] Fix an accidental assignment within assert() that should have been equality.

2016-04-26 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Whoops! LGTM. http://reviews.llvm.org/D19565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[libcxx] r267654 - Fix = that should have been == in test. Thanks to STL@microsoft for the catch

2016-04-26 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Apr 26 20:46:43 2016 New Revision: 267654 URL: http://llvm.org/viewvc/llvm-project?rev=267654&view=rev Log: Fix = that should have been == in test. Thanks to STL@microsoft for the catch Modified: libcxx/trunk/test/std/containers/associative/map/compare.pass.cpp Mod

Re: [PATCH] D19565: [libc++] Fix an accidental assignment within assert() that should have been equality.

2016-04-26 Thread Marshall Clow via cfe-commits
mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 267654. http://reviews.llvm.org/D19565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

2016-04-27 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. In general, I'm happy with this direction. I think we need to check that there are no ABI changes that happen here (I don't see any, but I'll keep looking), and I think the stuff in `<__os_support>` should be marked "always inline" On a bikeshed note: is `<__os_supp

Re: [PATCH] D19835: Tolerate incorrect return type for 'isinf' and 'isnan' in tests.

2016-05-02 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. How about not using XFAIL? Instead, just test for those two conditions. Psuedo-code: #if defined(GLIBC) #if GLIBC < 226 #error #elif TEST_STD_VER >= 11 #error #endif. http://reviews.llvm.org/D19835 ___ cfe-

Re: [PATCH] D19856: Create new library 'libc++experimental.a' for packaging TS symbols.

2016-05-03 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. I like this approach. LGTM. http://reviews.llvm.org/D19856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D19856: Create new library 'libc++experimental.a' for packaging TS symbols.

2016-05-03 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Q: Should the .a file get installed into /lib when you do a make install? That will make it easier to link against. http://reviews.llvm.org/D19856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[libcxx] r268510 - Fixed some spelling errors in assert messages. No functional change. Thanks to giffu...@yahoo.com for the report.

2016-05-04 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed May 4 10:35:50 2016 New Revision: 268510 URL: http://llvm.org/viewvc/llvm-project?rev=268510&view=rev Log: Fixed some spelling errors in assert messages. No functional change. Thanks to giffu...@yahoo.com for the report. Modified: libcxx/trunk/include/experimental

Re: [PATCH] D20014: [libc++] Explicit return in non-void function

2016-05-12 Thread Marshall Clow via cfe-commits
mclow.lists added a subscriber: mclow.lists. mclow.lists accepted this revision. mclow.lists added a reviewer: mclow.lists. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. `C` and `D` are different failure modes for `uses_allocator`, since the standard says th

[libcxx] r269298 - Apply D20014 - fix a missing return in a test. Fixes PR#27720

2016-05-12 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu May 12 09:31:35 2016 New Revision: 269298 URL: http://llvm.org/viewvc/llvm-project?rev=269298&view=rev Log: Apply D20014 - fix a missing return in a test. Fixes PR#27720 Modified: libcxx/trunk/test/std/utilities/memory/allocator.uses/allocator.uses.trait/uses_alloc

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

2016-05-16 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. A couple of packaging comments. In general, this looks fine to me - still waiting on someone from Android to chime in. -- I'll ping Dan. Comment at: include/support/xlocale/__posix_l_fallback.h:13 @@ +12,3 @@ +// extended locale support for libc's

[libcxx] r269663 - Add a couple of _LIBCPP_ASSERT calls. No functional change.

2016-05-16 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon May 16 11:55:32 2016 New Revision: 269663 URL: http://llvm.org/viewvc/llvm-project?rev=269663&view=rev Log: Add a couple of _LIBCPP_ASSERT calls. No functional change. Modified: libcxx/trunk/include/future Modified: libcxx/trunk/include/future URL: http://llvm.org

[libcxx] r269665 - Add a test for uniqueptr having either NULL and nullptr

2016-05-16 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon May 16 11:57:15 2016 New Revision: 269665 URL: http://llvm.org/viewvc/llvm-project?rev=269665&view=rev Log: Add a test for uniqueptr having either NULL and nullptr Modified: libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.cto

[libcxx] r269772 - Implement P0030R1: Introduce a 3-Argument Overload to std::hypot

2016-05-17 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue May 17 09:52:19 2016 New Revision: 269772 URL: http://llvm.org/viewvc/llvm-project?rev=269772&view=rev Log: Implement P0030R1: Introduce a 3-Argument Overload to std::hypot Modified: libcxx/trunk/include/cmath libcxx/trunk/test/std/numerics/c.math/cmath.pass.cpp

[libcxx] r269773 - Add some checking so that the TEST_HAS_XXX macros match up with the _LIBCPP_NO_HAS_XXX macros. No functional change

2016-05-17 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue May 17 09:58:09 2016 New Revision: 269773 URL: http://llvm.org/viewvc/llvm-project?rev=269773&view=rev Log: Add some checking so that the TEST_HAS_XXX macros match up with the _LIBCPP_NO_HAS_XXX macros. No functional change Modified: libcxx/trunk/test/libcxx/selfte

<    2   3   4   5   6   7   8   9   10   11   >