[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rG08196e0b2e1f: Implements [[likely]] and [[unlikely]] in IfStmt. (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D85091?vs=289979&id=2

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante updated this revision to Diff 290809. Mordante added a comment. Update the patch to match the behaviour where the attribute only affects the substatement of an if statement. This means the likelihood attributes on labels are accepted but are a no-op. Since they're a no-op the documentat

[PATCH] D90188: Add support for attribute 'using_if_exists'

Mordante added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5273 + namespace empty_namespace {}; + using empty_namespace::does_not_exist __attribute__((using_if_exists)); // no error! + erik.pilkington wrote: > aaron.ballman wrote: > > er

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

Mordante added a comment. Thanks for the patch! No further comments regarding the patch, except the items Aaron already mentioned. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D91630 ___ cfe-commits maili

[PATCH] D87561: [Sema] List conversion validate character array

Mordante marked 6 inline comments as done. Mordante added inline comments. Comment at: clang/test/CXX/drs/dr14xx.cpp:411-414 + void f(const char[4]); + void f(const wchar_t[4]); + void f(const char16_t[4]); + void f(const char32_t[4]); rsmith wrote: > Mordant

[PATCH] D87561: [Sema] List conversion validate character array

This revision was automatically updated to reflect the committed changes. Mordante marked 2 inline comments as done. Closed by commit rG0ce6d6b46eb7: [Sema] List conversion validate character array. (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D87561?vs=294556&id=29

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1622 EmitBranchOnBoolExpr(CondOp->getCond(), LHSBlock, RHSBlock, - getProfileCount(CondOp), Weights); +

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Mordante marked 2 inline comments as done. Closed by commit rG1113fbf44c22: [CodeGen] Improve likelihood branch weights (authored by Mordante). Changed prior to commit

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

Mordante added a comment. In D88363#2312129 , @jmorse wrote: > Hi -- We (Sony) are running into a bit of difficulty with the test for this > change, as it relies on the configuration of the -O1 optimisation pipeline. > Would it be possible to reduce down

[PATCH] D87565: [Sema] Improve const_cast conformance to N4261

Mordante marked 2 inline comments as done. Mordante added a comment. Thanks for the additional information. I agree that the current situation seems a bit arbitrary. I did some further research to see what GCC allows https://godbolt.org/. I've updated the patch to match that behavior. Reposito

[PATCH] D87565: [Sema] Improve const_cast conformance to N4261

Mordante updated this revision to Diff 297456. Mordante added a comment. Match the behavior of `const_cast` to match GCC's behavior. N4261 was proposed as solution to DR330. Since GCC allows the new `const_cast` behavior retroactively the patch also matches that behavior and no longer restricts

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

Mordante added a comment. In D88363#2319242 , @bdf wrote: > In D88363#2319157 , @jmorse wrote: > >> In D88363#2317241 , @Mordante wrote: >> >>> Can you explain the kind of is

[PATCH] D89204: Make likelihood lit test less brittle

Mordante created this revision. Mordante added a reviewer: jmorse. Mordante added a project: clang. Mordante requested review of this revision. Jeremy Morse discovered an issue with the lit test introduced in D88363 . The test gives different results for Sony's `

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

Mordante added a comment. I created D89204 which hopefully fixes Sony's issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88363/new/ https://reviews.llvm.org/D88363

[PATCH] D89210: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt

Mordante created this revision. Mordante added reviewers: aaron.ballman, rjmccall, rsmith. Mordante added a project: clang. Mordante requested review of this revision. This implements the likelihood attribute for the switch statement. Based on the discussion in D85091

[PATCH] D89204: Make likelihood lit test less brittle

Mordante added a comment. In D89204#2324563 , @jmorse wrote: > This fixes things for us, and by limiting to one optimisation pass it's much > less brittle for the future -- much appreciated! I'm glad to hear it fixes your issue. Thanks for testing! Rep

[PATCH] D89204: Make likelihood lit test less brittle

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG551caec4a8af: Make likelihood lit test less brittle (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D89210: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt

Mordante marked 8 inline comments as done. Mordante added a comment. In D89210#2328378 , @aaron.ballman wrote: > Thank you for the continued work on this feature! I'd like to better > understand the behavior of fallthrough labels because I think there ar

[PATCH] D89210: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt

Mordante updated this revision to Diff 298176. Mordante marked 3 inline comments as done. Mordante added a comment. Address review comments: - Improved the documentation - Enabled clang-format on the new code - Added unit tests - Removed some unneeded code from the unit tests due to -disable-llvm

[PATCH] D87565: [Sema] Improve const_cast conformance to N4261

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:1817-1819 + NeedToMaterializeTemporary = + SrcType->isRecordType() || SrcType->isArrayType() || + SrcType->isFunctionPointerType() || SrcType-

[PATCH] D87565: [Sema] Improve const_cast conformance to N4261

Mordante updated this revision to Diff 298838. Mordante marked an inline comment as done. Mordante added a comment. Removes the support for the pointer types. I adjusted the unit test for `void f()`, but I think it would be better remove this test now pointers are no longer allowed. Do you agree

[PATCH] D89210: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt

Mordante marked 2 inline comments as done. Mordante added a comment. In D89210#2332143 , @aaron.ballman wrote: > LGTM aside from a documentation request, but you may want to wait a few days > before committing in case Richard or John have opinions. Than

[PATCH] D89210: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt

This revision was automatically updated to reflect the committed changes. Mordante marked 2 inline comments as done. Closed by commit rG2bcda6bb2896: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D89

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante planned changes to this revision. Mordante added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6454 +static bool validateLikelihoodAttr(Sema &S, Decl *D, const ParsedAttr &A) { + if (!isa(D)) { aaron.ballman wrote: > Mordante wrote: > >

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

Mordante created this revision. Mordante added reviewers: aaron.ballman, rjmccall, rsmith. Mordante added a project: clang. Herald added a subscriber: dexonsmith. Mordante requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89899 Files: clang/incl

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

Mordante planned changes to this revision. Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1854 + for(int i = 0; i != size; ++i) [[likely]] { +... // The loop the likely path of execut

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

Mordante marked 10 inline comments as done. Mordante added a comment. Thanks for the feedback. I'll update the patch after making the requested changes. Comment at: clang/include/clang/Basic/AttrDocs.td:1866 + while(true) [[unlikely]] { +... // The attribute

[PATCH] D90188: Add support for attribute 'using_if_exists'

Mordante added a comment. A few questions. I'm not familiar enough with the code to accept the patch. Comment at: clang/include/clang/Basic/AttrDocs.td:5266 + let Content = [{ +The using_if_exists attribute applies to a using-declaration. It allows +programmers to import a dec

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

Mordante updated this revision to Diff 301332. Mordante marked an inline comment as done. Mordante added a comment. Addressed the review comments: - The likelhood attribute no longer affects the `do` statement. - Added a diagnotic when a likelihood attribute is used on an infinite while loop. No

[PATCH] D90336: [Sema] Diagnose annotating `if constexpr` with a likelihood attribute

Mordante created this revision. Mordante added reviewers: aaron.ballman, rjmccall, rsmith. Mordante added a project: clang. Mordante requested review of this revision. Adds a diagnostic when the user annotates an `if constexpr` with a likelihood attribute. The `if constexpr` statement is evaluate

[PATCH] D90336: [Sema] Diagnose annotating `if constexpr` with a likelihood attribute

Mordante marked an inline comment as done. Mordante added a comment. Thanks for the review! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3163 def note_attribute_has_no_effect_here : Note< - "annotating the %select{infinite loop}0 here">; + "annotating the %se

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

Mordante marked an inline comment as done. Mordante added a comment. Thanks for the review. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3161 + InGroup; +def note_attribute_has_no_effect_here : Note< + "annotating the %select{infinite loop}0 here">; -

[PATCH] D90336: [Sema] Diagnose annotating `if constexpr` with a likelihood attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rGb231396122f1: [Sema] Diagnose annotating `if constexpr` with a likelihood attribute (authored by Mordante)

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rGb46fddf75fc2: [CodeGen] Implement [[likely]] and [[unlikely]] for while and for loop. (authored by Mordante). Changed prior to commit: https://reviews.llvm.org

[PATCH] D87565: [Sema] Improve const_cast conformance to N4261

Mordante added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87565/new/ https://reviews.llvm.org/D87565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6454 +static bool validateLikelihoodAttr(Sema &S, Decl *D, const ParsedAttr &A) { + if (!isa(D)) { Mordante wrote: > aaron.ballman wrote: > > Mordante wrote: > > > aaron.ballman wrote:

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante updated this revision to Diff 302103. Mordante added a comment. `Sema::ActOnLabelStmt` now processes the statement attributes placed on the `LabelDecl`. Returning an `AttributedStmt` from this function seems to work as intended. This changes the behaviour of `[[nomerge]]` being allowed

[PATCH] D87563: [Sema] Improve overload resolution

Mordante added inline comments. Comment at: clang/include/clang/Sema/Overload.h:548-549 + +/// The std::initializer_list expression to convert from. +const InitListExpr *StandardInitializerListFrom{nullptr}; + rsmith wrote: > Storing the `IntListExpr` her

[PATCH] D87563: [Sema] Improve overload resolution

Mordante updated this revision to Diff 302140. Mordante added a comment. - No longer store the `InitListExpr` instead store the size difference between the array and initializer list. - Removed the dead code for P0388. - Don't add overloads where the initializer list has more elements than the

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante planned changes to this revision. Mordante marked 2 inline comments as done. Mordante added a comment. Then me try to clear up the confusion. The parser first parses the `LabelDecl` and tries to attach the attributes to this declaration. If that fails instead of issue a diagnostic for a

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

Mordante added a comment. Just a few minor nits. I'll leave the approving to the other reviewers. Comment at: clang/lib/AST/TextNodeDumper.cpp:1828 + if (D->isNested()) +OS << " nested"; if (!D->isOriginalNamespace()) Can you also modify `JSONNodeDumper

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante marked 2 inline comments as done. Mordante added a comment. In D86559#2371058 , @aaron.ballman wrote: > In D86559#2369317 , @Mordante wrote: > >> Then me try to clear up the confusion. >> >>> However, I co

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

Mordante added a comment. In D90568#2370079 , @njames93 wrote: > Added JsonNodeDumper and argument comments. Thanks, I've no further comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

Mordante added a comment. I tried to build the libc++ benchmarks locally and the benchmark with target `to_chars_libcxx` fails to properly execute. Bi-section let to this commit. Can the change in the linker flags affect libc++? I also see the scheduled builds of libc++ fail at Buildkite https:

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2c319fdc6b3: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR… (authored by gAlfonso-bit, committed by Mordante). Herald added a project: LLDB. Herald added a reviewer: libunwin

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#3126492 , @zixuan-wu wrote: > Is this going to be reviewed again or committed? This patch still requires approval by the libc++ group. The last build failed for multiple libc++ CI jobs, these should be fixed. (I haven

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

Mordante accepted this revision. Mordante added a comment. Thanks for working on this and landing the coroutines. LGTM after applying @ldionne's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113977/new/ https://reviews.llvm.org/D11397

[PATCH] D114649: [libc++] Implement not-yet-voted LWG3436

Mordante added a comment. Since this patch requires both an update to both Clang and libc++ I think it would land the Clang part in a separate patch. Then wait for the CI to have ToT with this version and land that separately. For now can you run the CI with the Bootstrap build? =

[PATCH] D131859: [clang-tidy] Adds QualifierAlignment to misc-const-correctness.

Mordante created this revision. Mordante added reviewers: aaron.ballman, alexfh, JonasToth, LegalizeAdulthood, njames93. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang-tools-extra. Herald ad

[PATCH] D131859: [clang-tidy] Adds QualifierAlignment to misc-const-correctness.

Mordante abandoned this revision. Mordante added a comment. In D131859#3721877 , @njames93 wrote: > Duplicate of D131386 Thanks for the information. Can you integrate the additional fixes of this patch in yours; specif

[PATCH] D131386: [clang-tidy] Added `ConstAlignment` option to `misc-const-correctness`

Mordante added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/ConstCorrectnessCheck.cpp:10 #include "ConstCorrectnessCheck.h" #include "../utils/FixItHintUtils.h" #include "clang/AST/ASTContext.h" This is already included in the header. =

[PATCH] D131386: [clang-tidy] Added `ConstAlignment` option to `misc-const-correctness`

Mordante added a comment. In D131386#3722749 , @aaron.ballman wrote: > We leave formatting decisions in clang-tidy to clang-format and I don't think > we should deviate from that policy here without a very clear understanding of > when we should relax

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Mordante added a comment. This change breaks libc++'s modular build see build https://buildkite.com/llvm-project/libcxx-ci/builds/12991 Reverting this commit on top of yesterday's build (before your revert) fixes the issue. libc++'s modular build uses Clang's pre-C++20 modules. It can be repro

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Mordante added a comment. In D126907#3737641 , @erichkeane wrote: > In D126907#3737375 , @Mordante > wrote: > >> This change breaks libc++'s modular build see build >> https://buildkite.com/llvm-project/libcxx-

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Mordante added a subscriber: aaron.ballman. Mordante added a comment. In D126907#3738383 , @erichkeane wrote: > There was a test I dealt with previously where a ton of the header files were > run with modules enabled (and an auto generated files), so I'

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Mordante added a comment. In D126907#3739923 , @aaron.ballman wrote: > In D126907#3739750 , @Mordante > wrote: > >> In D126907#3738383 , @erichkeane >> wrote: >> >>> Th

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Mordante added a comment. In D126907#3740536 , @erichkeane wrote: > For example, this enable-modules flag isn't covered by my local check-cxx, > which I went out of my way to run on this patch locally. Unfortunately there are a lot of different options

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante marked 24 inline comments as done. Mordante added inline comments. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. This dummy + file will also add the libc++ group to the list of reviewers. The status of + th

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante updated this revision to Diff 460827. Mordante marked 2 inline comments as done. Mordante added a comment. Addresses review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133249/new/ https://reviews.llvm.org/D133249 Files: clan

[PATCH] D131479: Handle explicitly defaulted consteval special members.

Mordante added a comment. In D131479#3755266 , @aaron.ballman wrote: > In D131479#3753586 , @Mordante > wrote: > >> So I think there's indeed a bug in libc++ which was hidden since Clang >> hadn't implemented s

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Mordante added a comment. In D126907#3805606 , @erichkeane wrote: > Now fully runs libcxx modules configuration as well, and passes the > minimization examples from @wlei . > > @wlei and anyone else: can you please try running this against your > work

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

Mordante added a comment. When I implemented P0479R5 I didn't look at earlier revisions of the paper. I'm a bit surprised to see revision 2 had a lot more information. (At that time I was less familiar with WG21 papers, so I didn't consider looking at older papers or notice the missing revision

[PATCH] D131963: [libc++] Add custom clang-tidy checks

Mordante added a subscriber: jwakely. Mordante added inline comments. Comment at: libcxx/test/tools/clang_tidy_checks/robust_against_adl.cpp:22 +AST_MATCHER(clang::UnresolvedLookupExpr, isCustomizationPoint) { + // TODO: Are make_error_code and make_error_condition actually cust

[PATCH] D134878: Update developer policy on potentially breaking changes

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. Thanks a lot for working on this! A few small nits, otherwise LGTM. Comment at: llvm/docs/DeveloperPolicy.rst:112 + +Please help notify users of potential disruptions whe

[PATCH] D134878: Update developer policy on potentially breaking changes

Mordante added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:129 + + People interested in joining the vendors group can do so by clicking the + "Join Project" link on the vendor's "Members" page in Phabricator. aaron.ballman wrote: > Mordante wrote

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

Mordante added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:525 +TYPE_TRAIT_1(__is_scoped_enum, IsScopedEnum, KEYCXX) +TYPE_TRAIT_1(__is_referenceable, IsReferenceable, KEYCXX) TYPE_TRAIT_2(__reference_binds_to_temporary, ReferenceBindsToTemporary, KEYCX

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Mordante added a comment. In D139986#4001180 , @Michael137 wrote: > Missed couple of test cases in libcxx > About to fix those There were more breakage due to this patch, which I fixed in D140272 . Next time please do

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Mordante added a comment. In D139986#4005997 , @dblaikie wrote: > In D139986#4003873 , @Mordante > wrote: > >> In D139986#4001180 , @Michael137 >> wrote: >> >>> Missed c

[PATCH] D131963: [libc++] Add custom clang-tidy checks

Mordante added inline comments. Comment at: libcxx/test/libcxx/clang_tidy.sh.cpp:15 // TODO: run clang-tidy with modules enabled once they are supported +// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* --checks='-*,libcpp-*' --load=%{test-tools}/clang_tidy_check

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Mordante added subscribers: erichkeane, ldionne, aaron.ballman. Mordante added a comment. In D139986#4017467 , @dblaikie wrote: > In D139986#4008169 , @Mordante > wrote: > >> In D139986#4005997

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Mordante added a comment. I think it would be better to have a meeting to discuss this further instead of posting in this review. I propose to do it after everybody's back from their holidays. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante created this revision. Herald added a reviewer: bollu. Herald added subscribers: Moerafaat, zero9178, Enna1, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiag

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante added a comment. In D137724#3917616 , @thieta wrote: > I think this is fine as we have discussed before. But I really dislike the > code duplication for the check. We could put it in a include() I guess - but > maybe it's not worth it. I wante

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante added a comment. In D137724#3917644 , @MaskRay wrote: > I think `if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)` checks for > standalone builds is not necessary. The check in `llvm/CMakeLists.txt` > suffices. > It's unlikely the users w

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante marked 6 inline comments as done. Mordante added a comment. Thanks for all feedback! Comment at: clang/www/hacking.html:311-312 + Unlike Clang, libc++ supports multiple versions of Clang. Therefore when a + patch changes the diagnostics it might be required to use a

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rG0c111dd86fff: [libc++] Documents details of the pre-commit CI. (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D133249?vs=460827&id=4

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

Mordante added a comment. FYI I tested this patch with libc++ and as expected it does not fix the libc++ modular build ICE. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142500/new/ https://reviews.llvm.org/D142500 ___ cfe-commits mailing li

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

Mordante added a comment. In D142500#4079669 , @erichkeane wrote: > In D142500#4079135 , @Mordante > wrote: > >> FYI I tested this patch with libc++ and as expected it does not fix the >> libc++ modular build I

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

Mordante added a comment. In D142500#4080317 , @erichkeane wrote: > In D142500#4080302 , @erichkeane > wrote: > >> In D142500#4080279 , @Mordante >> wrote: >> >>> In D1

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante created this revision. Herald added a project: All. Mordante requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. This attempts to fix the issue introduced in 12cb1cb3720d

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante added inline comments. Comment at: libcxx/include/module.modulemap.in:1421 + private header "__type_traits/integral_constant.h" + export type_traits.common_reference +} Note this looks wrong from libc++'s perspective. When this "solves" the

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492648. Mordante added a comment. Herald added a subscriber: arichardson. Fix CI run instead of libc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files: clan

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492779. Mordante added a comment. Rebased and improve fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files: clang/lib/run_the_clang_CI libcxx/include/mod

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492828. Mordante added a comment. Finalized patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files: clang/lib/run_the_clang_CI libcxx/include/module.module

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492834. Mordante added a comment. Removes uninteded include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files: libcxx/include/module.modulemap.in libcxx/uti

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492999. Mordante added a comment. Undo CI changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files: libcxx/include/module.modulemap.in Index: libcxx/includ

[PATCH] D142690: [libc++] Fixes the Clang modular build.

Mordante added a comment. https://buildkite.com/llvm-project/libcxx-ci/builds/18148 shows this patch fixes the Clang modular build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 ___

[PATCH] D142690: [libc++] Fixes the Clang modular build.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7f8ddc4e2e3: [libc++] Fixes the Clang modular build. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D141423: Trigger the Clang/libc++ CI pipeline even when libc++ has been modified

Mordante added a comment. Should this also fix the issue where the scheduled build sometimes picks the "clang build"? For example https://buildkite.com/llvm-project/libcxx-ci/builds/17300 but I noticed to at other times too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

Mordante added a comment. I see the current main pass for the module build in libc++. The error message seems different, from the message for missing parts of the module map. I'll dig a bit further to see whether I can find what's wrong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

Mordante added a comment. I just tested locally with the latest nightly build Debian clang version 16.0.0 (++20230116071901+2563ad8ef1a8-1~exp1~20230116072002.532) Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin and that passes the test that fails in the CI. Can

[PATCH] D142007: [NFC] Fix "form/from" typos

Mordante added a comment. In D142007#4071765 , @pfusik wrote: > @ldionne Can you check it in? Can you provide your name and email address to we can attribute the patch to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D142007: [NFC] Fix "form/from" typos

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG898b5c9f5e77: [NFC] Fix "form/from" typos (authored by pfusik, committed by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D142007: [NFC] Fix "form/from" typos

Mordante added a comment. Thanks for your contribution, I just landed this patch on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142007/new/ https://reviews.llvm.org/D142007 ___ cfe-commits

[PATCH] D112916: Confusable identifiers detection

Mordante added a comment. Herald added a project: All. In D112916#3113140 , @tstellar wrote: > The LLVM Board of Directors will do a legal review of this change. We will > give an update in 4-6 weeks. @tstellar, is there an update from the LLVM Board o

[PATCH] D112916: Confusable identifiers detection

Mordante added a comment. Thanks for the update! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. I noticed some of the CI jobs are still failing with the patch, I didn't look into them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Mordante added a comment. In D152003#4531404 , @Fznamznon wrote: >> should we try to land that today? > > I'm not sure. It causes failures in libc++ testing: > > Failed Tests (3): > llvm-libc++-shared.cfg.in :: std/ranges/range.access/end.pass.cpp >

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#4530916 , @wangpc wrote: > In D112921#4529182 , @Mordante > wrote: > >> I noticed some of the CI jobs are still failing with the patch, I didn't >> look into them. > > I don'

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Mordante added a subscriber: var-const. Mordante added a comment. In D152003#4534963 , @Fznamznon wrote: >> What do you mean with libstdc++ is fine? > > What I mean is when I do (current patch is applied to clang): > > source/llvm-project/build/bin/clan

<    1   2   3   4   5   >