[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon updated this revision to Diff 538531. Fznamznon added a comment. Rebase, add tests for dependent NameInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154689/new/ https://reviews.llvm.org/D154689 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0130fc51cbc: [clang] Correct calculation of MemberExpr's dependence (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon updated this revision to Diff 539502. Fznamznon added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaType.cpp clang

[PATCH] D155164: [clangd][NFC] Remove dead code

Fznamznon created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. Fznamznon requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. refactor/tweaks/ExtractVariable.cpp: Co

[PATCH] D155164: [clangd][NFC] Remove dead code

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b4a27f410ba: [clangd][NFC] Remove dead code (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155164/new/ https://reviews.llvm.org/D15

[PATCH] D158671: [NFC][Clang] Fix static analyzer concerns

Fznamznon added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:610-612 if (isa(Method)) { Name = Method->getNameAsString(); +if (cast(Method)->isExplicit()) Maybe we can just do this, so we don't `isa` two times. CHANGES

[PATCH] D158526: [clang] Properly print unnamed members in diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4c886b6aaea: [clang] Properly print unnamed members in diagnostics (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D15

[PATCH] D158827: [clang] Fix assertion fail when function has cleanups and fatal errors

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/48974 Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[PATCH] D158827: [clang] Fix assertion fail when function has cleanups and fatal errors

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ade434a7e74: [clang] Fix assertion fail when function has cleanups and fatal errors (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D158827?vs=553420&id=553872#toc Repositor

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

Fznamznon updated this revision to Diff 554220. Fznamznon added a comment. Apply suggestion, rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158615/new/ https://reviews.llvm.org/D158615 Files: clang/docs/ReleaseNotes

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

Fznamznon added a comment. The failures in CI are unrelated and caused by another patch - https://reviews.llvm.org/D112921. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158615/new/ https://reviews.llvm.org/D158615 ___

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbcc881161aeb: [clang] Emit an error if variable ends up with incomplete array type (authored by Fznamznon). Repository: rG LLVM Github Monorepo C

[PATCH] D159279: [clang] Emit `Wformat` for bool value and char specifier confusion in scanf

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/64987 Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[PATCH] D159279: [clang] Emit `Wformat` for bool value and char specifier confusion in scanf

Fznamznon updated this revision to Diff 555289. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159279/new/ https://reviews.llvm.org/D159279 Files: clang/docs/ReleaseNotes.rst clang/lib/A

[PATCH] D159279: [clang] Emit `Wformat` for bool value and char specifier confusion in scanf

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4e56f91df6a: [clang] Emit `Wformat` for bool value and char specifier confusion in scanf (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D137044: [ClangFE] Add support for option -mno-pic-data-is-text-relative

Fznamznon added a comment. In D137044#3943680 , @jonpa wrote: > In D137044#3942990 , @pcwang-thead > wrote: > >> The test `clang/test/Driver/pic.c` failed when we compiled Clang/LLVM with >> `-DCLANG_DEFAULT_PIE

[PATCH] D137044: [ClangFE] Add support for option -mno-pic-data-is-text-relative

Fznamznon added a comment. In D137044#3944010 , @jonpa wrote: > In D137044#3943829 , @Fznamznon > wrote: > >> In D137044#3943680 , @jonpa wrote: >> >>> In D137044#3942990

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon updated this revision to Diff 251735. Fznamznon added a comment. Herald added a subscriber: mgorny. Added diagnosing of __float128 type usage. See the summary of revision for details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon updated this revision to Diff 251982. Fznamznon edited the summary of this revision. Fznamznon added a comment. Fix the test by adding the target with __float128 support and make sure that no diagnostic are emitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ https://reviews.llvm.org/D74387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12248 + /// SYCLDiagIfDeviceCode(Loc, diag::err_type_unsupported) << "__float128"; + DeviceDiagBuilder SYCLDiagIfDeviceCode(SourceLocation Loc, unsigned DiagID); + rjmccall wrote: >

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon updated this revision to Diff 253615. Fznamznon added a comment. Herald added a reviewer: jdoerfert. Rebased to fresh version. Applied fixes after https://reviews.llvm.org/D70172 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ ht

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon updated this revision to Diff 253910. Fznamznon added a comment. Apply comments, rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ https://reviews.llvm.org/D74387 Files: clang/include/clang/Basic/Attr.td clang/include/

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon marked an inline comment as done. Fznamznon added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12248 + /// SYCLDiagIfDeviceCode(Loc, diag::err_type_unsupported) << "__float128"; + DeviceDiagBuilder SYCLDiagIfDeviceCode(SourceLocation Loc, unsigned Di

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

Fznamznon added a comment. @rjmccall, Thank you very much for so detailed response, It really helps. I started working on implementation and I have a couple of questions/problems with this particular appoach. > - If `foo` uses `__float128` (whether in its signature or internally), that > is in

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

Fznamznon added a comment. A couple of minor comments. Comment at: clang/include/clang/Basic/AttrDocs.td:313 + +- Function template with at least two template parameters is expected. The compiler +generates OpenCL kernel and uses first template parameter as unique name to the

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

Fznamznon accepted this revision. Fznamznon added a comment. LGTM with a couple of minor comments. Comment at: clang/include/clang/Basic/AttrDocs.td:273 +cgh.parallel_for(range<1>{1024}, [=](id<1> index) { + A[index] = index[0] * 2 + index[1] + foo(42); +}); --

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

Fznamznon created this revision. Herald added subscribers: cfe-commits, Anastasia, ebevhan, jfb, yaxunl, mgorny. Herald added a project: clang. Fznamznon added reviewers: bader, Naghasan, ABataev. All SYCL memory objects shared between host and device (buffers/images, these objects map to OpenCL b

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

Fznamznon updated this revision to Diff 233013. Fznamznon added a comment. Updated tests using address space attributes added by D71005 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71016/new/ https://reviews.llvm

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

Fznamznon marked an inline comment as done. Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaSYCL.cpp:417 + Util::DeclContextDesc{clang::Decl::Kind::ClassTemplateSpecialization, +"accessor"}}; + return matchQualifiedTypeName(Ty, Sc

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

Fznamznon created this revision. Herald added subscribers: cfe-commits, Anastasia, ebevhan. Herald added a project: clang. While SYCL does not support __float128 for some device targets, emitting the diagnostic here prevents the compilation of host header files with __float128 type usage. For now

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

Fznamznon added a comment. In D74387#1869819 , @ABataev wrote: > I would add a check for the use of unsupported types in kernels. They should > not be allowed to be used if target does not support it. Yeah, I think so. We tried to make it using deferred

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

Fznamznon added a comment. > In D74387#1869845 , @rjmccall wrote: > >> The right approach here is probably what we do in ObjC ARC when we see types >> that are illegal in ARC: in system headers, we allow the code but add a >> special `UnavailableAttr` to

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

Fznamznon added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1468 } - S.DeviceDeferredDiags.erase(It); This particular change causes duplication of deferred diagnostics. Consider the following example (please correct me if I'm doing something wrong,

[PATCH] D73104: [Attr][Doc][NFC] Fix code snippet formatting for attribute documentation

Fznamznon accepted this revision. Fznamznon added a comment. This revision is now accepted and ready to land. Thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73104/new/ https://reviews.llvm.org/D73104 __

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this patch it was expected that if there was several immediate invocations they all belong to the same expression

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17897 +if (SemaRef.FailedImmediateInvocations.contains(E)) + CurrentII->setInt(1); + } else { shafik wrote: > It is not obvious to me why this is correct, can you pleas

[PATCH] D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction()

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since each `DumpModuleInfoAction` can now contain a pointer to a `raw_ostream`, saving there a poiter that owned by a lo

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Fznamznon added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146234/new/ https://reviews.llvm.org/D146234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17979 + if (Rec.ImmediateInvocationCandidates.size() > 1 || + SemaRef.FailedImmediateInvocations.size()) { cor3ntin wrote: > Shouln't we clear `FailedImmediateInvocations` at the end

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a potential immediate invocation is met, it is immediately wrapped by a `ConstantExpr`. There is also a TreeTransfo

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

Fznamznon updated this revision to Diff 508082. Fznamznon added a comment. Apply the suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146801/new/ https://reviews.llvm.org/D146801 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaEx

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1593-1595 + if (ConstantExpr *CE = dyn_cast_or_null(Inner)) +if (CE->isImmediateInvocation()) + Inner = CE->getSubExpr(); aaron.ballman wrote: > This will need reformatting, but

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

Fznamznon updated this revision to Diff 508524. Fznamznon added a comment. Rebase, maybe this will get "pre-commit" started Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146801/new/ https://reviews.llvm.org/D146801 Files: clang/docs/ReleaseNotes

[PATCH] D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction()

Fznamznon added a comment. In D146412#4220021 , @kastiglione wrote: > I understand the potential for a use after free, since `OutputStream` is a > raw pointer, but I don't understand the fix. Okay, probably commit message is a little confusing. The pot

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG83c90e623a30: [clang] Fix consteval initializers of temporaries (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D146801?vs=508524&id=508963#toc Repository: rG LLVM Github M

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Fznamznon updated this revision to Diff 508974. Fznamznon added a comment. Rebase, add release note, fix grammar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146234/new/ https://reviews.llvm.org/D146234 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction()

Fznamznon added a comment. > Should OutputStream be made into a shared_ptr so we can clarify the memory > ownership instead of leaving it as a raw pointer? That should also address > the use-after-free. Well, I was thinking about that and wasn't sure about it either. https://reviews.llvm.org/D

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Fznamznon updated this revision to Diff 509039. Fznamznon added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146234/new/ https://reviews.llvm.org/D146234 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Se

[PATCH] D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction()

Fznamznon updated this revision to Diff 509285. Fznamznon added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use private shared_ptr in `DumpModuleInfoAction` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/n

[PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Fznamznon updated this revision to Diff 509372. Fznamznon added a comment. Add a little bit of safety. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412 Files: clang/include/clang/Frontend/FrontendActions

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Constant evaluator only considered access to `this` pointer to be possible if `this` poitners was captured. However `thi

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

Fznamznon updated this revision to Diff 501084. Fznamznon added a comment. Apply suggestions and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144866/new/ https://reviews.llvm.org/D144866 Files: clang/docs/ReleaseNotes.rst clang/lib/AS

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

Fznamznon added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ensure we actually have captured 'this'. (an error will have - // been previously reported if not). + // Ensure we actua

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

Fznamznon added a comment. Thanks for the review @shafik . Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ensure we actually have captured 'this'. (an error will have - // been previously reported if not

[PATCH] D144495: [NFC][clang] Refine tests by adding `:` to checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG831591b2a075: [NFC][clang] Refine tests by adding `:` to checks (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144495/new/ https://r

[PATCH] D145251: [clang] Treat function parameter scope as an immediate function context

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This results in expressions that appear in default function argument not being checked for being actual constant express

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fbf18b40026: [clang] Fix aggregate initialization inside lambda constexpr (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.

[PATCH] D145362: [clang] Update test according to P1937

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://wg21.link/p1937 proposes that in unevaluated contexts, consteval functions should not be immediately evaluated.

[PATCH] D145362: [clang] Update test according to P1937

Fznamznon updated this revision to Diff 502742. Fznamznon added a comment. Rebase and apply the nitpick Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145362/new/ https://reviews.llvm.org/D145362 Files: clang/test/CXX/expr/expr.const/p8-2a.cpp

[PATCH] D145362: [clang] Update test according to P1937

Fznamznon added inline comments. Comment at: clang/test/CXX/expr/expr.const/p8-2a.cpp:14 -// bad_assert_copyable is not needed for constant evaluation -// (and thus not instantiated) +// consteval assert is not instantiated as well. template consteval void assert_copyable() {

[PATCH] D145251: [clang] Treat function parameter scope as an immediate function context

Fznamznon updated this revision to Diff 502754. Fznamznon added a comment. Rebase and add quoting [expr.const] p15.1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145251/new/ https://reviews.llvm.org/D145251 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D145486: [clang] Fix single-element array initialization in constexpr

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D130791 added an improvement that in case array element has a trivial constructor, it is evalua

[PATCH] D145486: [clang] Fix single-element array initialization in constexpr

Fznamznon updated this revision to Diff 502992. Fznamznon added a comment. Check FinalSize instead of N since it is probably more obvious Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145486/new/ https://reviews.llvm.org/D145486 Files: clang/lib

[PATCH] D145486: [clang] Fix single-element array initialization in constexpr

Fznamznon updated this revision to Diff 503020. Fznamznon added a comment. Rebase and update test comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145486/new/ https://reviews.llvm.org/D145486 Files: clang/lib/AST/ExprConstant.cpp clang/t

[PATCH] D145486: [clang] Fix single-element array initialization in constexpr

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf682f0df83f: [clang] Fix single-element array initialization in constexpr (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145486/new/

[PATCH] D145486: [clang] Fix single-element array initialization in constexpr

Fznamznon added a comment. Filed https://github.com/llvm/llvm-project/issues/61243 to backport. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145486/new/ https://reviews.llvm.org/D145486 ___ cfe-commits

[PATCH] D145362: [clang] Update test according to P1937

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0db54e0dd32: [clang] Update test according to P1937 (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145362/new/ https://reviews.llvm

[PATCH] D145251: [clang] Treat function parameter scope as an immediate function context

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2739f111d97: [clang] Treat function parameter scope as an immediate function context (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

Fznamznon added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:887 + else { +assert(DeepestParsedCaseStmt && "DeepestParsedCaseStmt cannot be null"); Actions.ActOnCaseStmtBody(DeepestParsedCaseStmt, Case.get()); The assert that

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Immediate invocations do not need to run cleanups themselves and the destructors need to run after each full-expression

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

Fznamznon updated this revision to Diff 532831. Fznamznon added a comment. Rebase, fix nit, expand the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153294/new/ https://reviews.llvm.org/D153294 Files: clang/docs/ReleaseNotes.rst clang/lib

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

Fznamznon added a comment. > Thanks! We don't have any tests that break with this change, so I assume this > is not tested. I suppose it could also be that in most cases we have enough places in Sema adding `ExprWithCleanups`. While trying to figure out why we need `ExprWithCleanups` wrapping

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

Fznamznon added a comment. > While we wait for Richard's response... @Fznamznon what are your thoughts on > wrapping all ConstantExpr that span immediate invocations with redundant > ExprWithCleanups per Richard's suggestions? > This bug looks scary enough to me to warrant a fix asap. Agree. I

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

Fznamznon added a comment. > One thing we will need to be careful about is assigning any block / compound > literal cleanups to the right ExprWithCleanups node. We can figure out where > to put them by doing a traversal of the ConstantExpr's subexpression to see > if it contains the BlockDecl /

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Expressions like new struct A {}; struct A* b = (1 == 1) ? new struct A : new struct A; `` Were parsed as defin

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

Fznamznon added a comment. > With code like struct A {}; , the expressions > were parsed as redefining struct A and failed. However, as clarified by > CWG2141, new-expression cannot define a type, so both these expressions > should be considered as valid references to the previously declared st

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

Fznamznon added a comment. > What about > template > struct A { }; > > void foo() { > new struct A {}; > } > > I think this should be allowed, right? Yes, I think so. The patch helps to allow. Thanks, I'll add it to the test. > MSVC rejects the first but accepts the second which I think

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

Fznamznon updated this revision to Diff 535317. Fznamznon added a comment. Add comma and test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153857/new/ https://reviews.llvm.org/D153857 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Par

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

Fznamznon added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2221 +DSC_association, // A _Generic selection expression's type association +DSC_new // C++ new operator }; aaron.ballman wrote: > Adding the comma so the next pe

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since an immediate invocation is a full expression itself - it requires an additional ExprWithCleanups node, but it can

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

Fznamznon added a comment. > I believe we should make the proposed change (add potentially redundant > ExprWithCleanups without touching the cleanups objects or flags) without > blocking on Richard's approval. I posted https://reviews.llvm.org/D153962 . Repository: rG LLVM Github Monorepo

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

Fznamznon updated this revision to Diff 535419. Fznamznon added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153962/new/ https://reviews.llvm.org/D153962 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h c

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

Fznamznon updated this revision to Diff 535489. Fznamznon added a comment. Rebase, don't use MaybeCreateExprWithCleanups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153962/new/ https://reviews.llvm.org/D153962 Files: clang/docs/ReleaseNotes.rs

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

Fznamznon updated this revision to Diff 535687. Fznamznon added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153962/new/ https://reviews.llvm.org/D153962 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp clang

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:7374 auto *E = ExprWithCleanups::Create( Context, SubExpr, Cleanup.cleanupsHaveSideEffects(), Cleanups); ilya-biryukov wrote: > Because we may potentially pass some cleanups h

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

Fznamznon updated this revision to Diff 535721. Fznamznon added a comment. Update the comment, add blocks test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153962/new/ https://reviews.llvm.org/D153962 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

Fznamznon updated this revision to Diff 535779. Fznamznon added a comment. Move test cases to CXX/drs/dr21xx.cpp, update DR status page, add alignof/sizeof cases, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153857/new/ https://reviews.llvm

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8824 + if (auto *Cast = dyn_cast(E)) { +if (auto *SubInit = dyn_cast(Cast->getSubExpr())) { + const Type *InnerType = SubInit->getType().getTypePtr(); erichkeane wrote: > Fznamznon

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG550fa4eabd83: [clang] Do not discard cleanups while processing immediate invocation (authored by Fznamznon). Changed prior to commit: https://revi

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon updated this revision to Diff 536172. Fznamznon added a comment. Move changes to another place, check destination type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003 Files: clang/docs/Release

[PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Fznamznon updated this revision to Diff 509420. Fznamznon added a comment. Add comment explaining custom deleter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412 Files: clang/include/clang/Frontend/Fron

[PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Fznamznon added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:2182-2183 -clang::DumpModuleInfoAction dump_module_info; -dump_module_info.OutputStream = &result.GetOutputStream().AsRawOstream(); +std::shared_ptr Out( +&result.GetOu

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Fznamznon added a comment. Ping @shafik ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146234/new/ https://reviews.llvm.org/D146234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Fznamznon updated this revision to Diff 509580. Fznamznon added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412 Files: clang/include/clang/Frontend/FrontendActions.h clang/lib/Front

[PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Fznamznon added a comment. The test fail is unrelated, seem to be broken by https://reviews.llvm.org/D146811 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412

[PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42ae055b4c92: [NFC] Fix potential for use-after-free in DumpModuleInfoAction (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Fznamznon added a comment. @aaron.ballman , @cor3ntin are you ok with the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146234/new/ https://reviews.llvm.org/D146234 ___ cfe-commits mailing list cf

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Due not resetting that, clang still thinks that it is in immediate function context even if it is already entered non-co

<    1   2   3   4   5   >