Fznamznon marked an inline comment as done.
Fznamznon added inline comments.
================
Comment at: clang/lib/Sema/SemaSYCL.cpp:417
+ Util::DeclContextDesc{clang::Decl::Kind::ClassTemplateSpecialization,
+ "accessor"}};
+ return matchQualifiedTypeName(Ty, Scopes);
----------------
keryell wrote:
> After more thought, perhaps the solution proposed by Victor Lomüller during
> the last SYCL upstreaming meeting about marking accessor classes with some
> attribute instead of detecting concrete type names is a better generic
> approach.
> I am more convinced now by his argument allowing more experimenting with
> alternative runtimes, since it looks like it is the only place we detect type
> names. For example the kernels are marked with an attribute in the runtime
> instead of concretely detecting the `parallel_for()` functions and so on.
@Naghasan , what do you think about upstreaming the solution which you proposed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71016/new/
https://reviews.llvm.org/D71016
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
