[PATCH] D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation

malaperle added a comment. Herald added a subscriber: kadircet. I hadn't marked it as done because without symbols in main files I found it quite lacking. Repository: rL LLVM https://reviews.llvm.org/D50703 ___ cfe-commits mailing list cfe-commi

[PATCH] D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation

malaperle added a comment. In https://reviews.llvm.org/D50703#1205109, @kbobyrev wrote: > In https://reviews.llvm.org/D50703#1205049, @malaperle wrote: > > > I hadn't marked it as done because without symbols in main files I found it > > quite lacking. > > > Ah, I see, thank you for spotting it!

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

malaperle added a comment. Can there be an option for this? This seems very library specific and could break other code bases. Ideally, there would be a generic mechanism for this kind of filtering, i.e. specify a pattern of excluded files or symbol names. But I understand this would be cumbers

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

malaperle added a comment. In https://reviews.llvm.org/D46751#1095923, @ilya-biryukov wrote: > In https://reviews.llvm.org/D46751#1095894, @malaperle wrote: > > > Can there be an option for this? This seems very library specific and could > > break other code bases. Ideally, there would be a gen

[PATCH] D44954: [clangd] [RFC] Add more symbols to the index

malaperle updated this revision to Diff 146391. malaperle added a comment. Herald added a subscriber: jkorous. Rework to include member vars/functions and scoped enumerators. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44954 Files: clangd/CodeComplete.cpp clangd/index/In

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle added inline comments. Comment at: clangd/CodeComplete.cpp:932 Req.Query = Filter->pattern(); +Req.DeclContexts = {Decl::Kind::Namespace, Decl::Kind::TranslationUnit, +Decl::Kind::LinkageSpec, Decl::Kind::Enum}; I want t

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

malaperle added a comment. In https://reviews.llvm.org/D46751#1099097, @ioeric wrote: > > I think this is good if that's true that the comment is always there. I > > think it would be OK for this to be enabled by default, with a general > > option to turn heuristics off. Not sure what to call i

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

malaperle added a comment. In https://reviews.llvm.org/D46751#1099235, @sammccall wrote: > @malaperle to expand on what Eric said, adding proto hacks with false > positives and no way to turn them off is indeed not the way to go here! > There's probably going to be other places we want to filte

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

malaperle added a comment. In https://reviews.llvm.org/D46751#1099786, @sammccall wrote: > In https://reviews.llvm.org/D46751#1099633, @malaperle wrote: > > > In https://reviews.llvm.org/D46751#1099235, @sammccall wrote: > > > > > @malaperle to expand on what Eric said, adding proto hacks with fa

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle added a comment. @ioeric You mentioned in https://reviews.llvm.org/D46751 that it would make sense to add a flag to disable indexing members. Could you comment on that? What kind of granularity were you thinking? Would a "member" flag cover both class members (member vars and function

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle added a comment. In https://reviews.llvm.org/D44954#1102807, @ilya-biryukov wrote: > A few questions regarding class members. To pinpoint some interesting cases > and agree on how we want those to behave in the long run. > > How do we handle template specializations? What will the qual

[PATCH] D47063: [clangd] Keep only a limited number of idle ASTs in memory

malaperle added subscribers: arphaman, malaperle. malaperle added a comment. In https://reviews.llvm.org/D47063#1104417, @ilya-biryukov wrote: > Maybe we can even store enough information to not need the AST for navigation > at all and build it only for features like refactorings. > @sammccall,

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle added a comment. In https://reviews.llvm.org/D44954#1104178, @ilya-biryukov wrote: > In https://reviews.llvm.org/D44954#1103664, @malaperle wrote: > > > It's probably better to consider this in a future patch. Maybe something > > like the first suggestion: vector::push_back and match b

[PATCH] D47223: [clangd] Handle enumerators in named, unscoped enums similarly to scoped enums

malaperle created this revision. Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov, klimek. For enumerators in unscoped enums that have names, even if they are not scoped, we add the enum name to the scope so that users can find the enumerators when fully qualifying t

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle added a comment. In https://reviews.llvm.org/D44954#1104497, @malaperle wrote: > >>> What scopes will non-scoped enum members have? > >> > >> Hmm. I think all of them, since you can refer them like that in code too. > >> Case #1 doesn't work but that was the case before this patch so

[PATCH] D47272: [clangd] Build index on preamble changes instead of the AST changes

malaperle added a comment. > We do not to rely on symbols from the main file anyway, since any info hat > those provide can always be taken from the AST. I'll be adding those soon for workspace symbols... And also for document symbols. Repository: rCTE Clang Tools Extra https://reviews.llv

[PATCH] D47272: [clangd] Build index on preamble changes instead of the AST changes

malaperle added a comment. In https://reviews.llvm.org/D47272#1109914, @ilya-biryukov wrote: > In https://reviews.llvm.org/D47272#1109909, @malaperle wrote: > > > > We do not to rely on symbols from the main file anyway, since any info > > > hat those provide can always be taken from the AST. >

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle updated this revision to Diff 148329. malaperle added a comment. Use "SupportGlobalCompletion", white-list decl contexts, add more tests Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44954 Files: clangd/CodeComplete.cpp clangd/index/Index.h clangd/index/MemInde

[PATCH] D47223: [clangd] Handle enumerators in named, unscoped enums similarly to scoped enums

malaperle added a comment. In https://reviews.llvm.org/D47223#1109247, @ilya-biryukov wrote: > I'm not sure if we have tests for that, but I remember that we kept the > enumerators in the outer scope so that completion could find them.. > Am I right that this patch will change the behavior and

[PATCH] D47187: [clangd] Skip .inc headers when canonicalizing header #include.

malaperle added subscribers: ioeric, sammccall, malaperle. malaperle added a comment. I think this might have broken the "shared lib" build? Could you double check that you don't need to add "clangDriver" ? ../tools/clang/tools/extra/clangd/index/CanonicalIncludes.cpp:61: error: undefined refer

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle added inline comments. Comment at: clangd/index/SymbolCollector.cpp:158 + translationUnitDecl(), namespaceDecl(), linkageSpecDecl(), recordDecl(), + enumDecl(), objcProtocolDecl(), objcInterfaceDecl(), objcCategoryDecl(), + objcCategoryImplDecl(), objcImp

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle updated this revision to Diff 148834. malaperle marked 6 inline comments as done. malaperle added a comment. Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44954 Files: clangd/CodeComplete.cpp clangd/index/Index.h clangd/index/MemIndex.cpp cl

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle added inline comments. Comment at: unittests/clangd/SymbolCollectorTests.cpp:141 Args.insert(Args.end(), ExtraArgs.begin(), ExtraArgs.end()); +Args.push_back(TestFileName); + This allows to override the "-xc++" with something else, i.e. -xobjec

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

This revision was automatically updated to reflect the committed changes. Closed by commit rL314377: [clangd] LSP extension to switch between source/header file (authored by malaperle). Changed prior to commit: https://reviews.llvm.org/D36150?vs=116387&id=116919#toc Repository: rL LLVM http

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

malaperle added a comment. I submitted the patch. Thanks a lot William and Ilya! Repository: rL LLVM https://reviews.llvm.org/D36150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

malaperle requested changes to this revision. malaperle added inline comments. This revision now requires changes to proceed. Comment at: clangd/tool/ClangdMain.cpp:20 #include +#include William, did you perhaps miss this comment? I don't think unistd.h make

[PATCH] D38425: [clangd] Document highlights for clangd

malaperle added a comment. Just a few quick comments. Comment at: clangd/ClangdServer.cpp:295 + assert(FileContents.Draft && + "findDefinitions is called for non-added document"); + findDocumentHighlights? Comment at: clangd/ClangdSe

[PATCH] D38048: [clangd] Add textDocument/signatureHelp

malaperle added inline comments. Comment at: clangd/Protocol.h:458 +/// +/// A parameter can have a label and a doc-comment. +struct ParameterInformation { rwols wrote: > @malaperle I copied the sentences from the protocol markdown file over > [here](https://git

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle requested changes to this revision. malaperle added inline comments. This revision now requires changes to proceed. Comment at: clangd/ClangdUnit.cpp:81 + std::map takeIncludeMap() { +return std::move(IncludeMap); takeIncludeLocationMap? ==

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle added a comment. In https://reviews.llvm.org/D35894#903542, @ilya-biryukov wrote: > In https://reviews.llvm.org/D35894#895023, @Nebiroth wrote: > > > I would like some feedback/suggestions on whether it's possible to "append" > > information to a MarkedString to be displayed on client?

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle added a comment. In https://reviews.llvm.org/D35894#903594, @ilya-biryukov wrote: > In https://reviews.llvm.org/D35894#903552, @malaperle wrote: > > > I think he meant to have multiple sections in the hover, one C/C++ and one > > not. But we noticed you can have an array of MarkedStrin

[PATCH] D38939: [clangd] Handle exit notification (proper shutdown)

malaperle accepted this revision. malaperle added a comment. Nice! I had a fix locally for the same purpose but this is much better! https://reviews.llvm.org/D38939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D49523: [clangd] Add support for per-file override compilation command

malaperle added a comment. In https://reviews.llvm.org/D49523#1169000, @arphaman wrote: > In https://reviews.llvm.org/D49523#1167553, @malaperle wrote: > > > Interesting! We also have a need for passing compilation commands in a > > context where there is no compile_commands.json, but we were th

[PATCH] D49267: [clangd] Watch for changes in compile_commands.json

malaperle added inline comments. Comment at: clangd/ClangdLSPServer.cpp:430 CDB.clear(); - -reparseOpenedFiles(); +compileCommandsChangePost(CCChangeData); } ilya-biryukov wrote: > Maybe keep the old logic of reparsing all open files? This would m

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

malaperle created this revision. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. That way, as soon as the "initialize" is received by the server, it can start parsing/indexing with a valid compilation database and not have to wait for a an initial 'didCha

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

malaperle added a comment. In https://reviews.llvm.org/D49833#1176337, @ilya-biryukov wrote: > Not strictly opposed to this change, but is there any reason why the clients > can't guarantee they'll send didChangeConfiguration right after clangd is > initialized? LSP: > Until the server has r

[PATCH] D49920: [clangd] [WIP] Find references of local symbols

malaperle created this revision. Herald added subscribers: cfe-commits, arphaman, mgrang, jkorous, MaskRay, ioeric, ilya-biryukov. We do not have a global index of references but we can find the references of local symbols within the AST in the mean time. Also, since we will not record local symb

[PATCH] D49920: [clangd] [WIP] Find references of local symbols

malaperle updated this revision to Diff 157732. malaperle added a comment. Fix silly bug I introduced in last minute clean-up. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49920 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/

[PATCH] D49920: [clangd] [WIP] Find references of local symbols

malaperle planned changes to this revision. malaperle added a comment. Needs tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

malaperle added a comment. Was there any objection to this patch? It would have been nice to have this before the branching. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49833 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

malaperle added a comment. @simark would you mind finishing this patch and committing it? I won't be able to finish it given that I started it at a different company, etc. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49833 ___ cf

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

malaperle added a comment. In https://reviews.llvm.org/D48903#1187605, @simark wrote: > If somebody else could run the tests on Windows, it would make me a bit more > confident too. Which tests/targets exactly? If you know Repository: rC Clang https://reviews.llvm.org/D48903 __

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

malaperle added a comment. In https://reviews.llvm.org/D48903#1188437, @malaperle wrote: > In https://reviews.llvm.org/D48903#1187605, @simark wrote: > > > If somebody else could run the tests on Windows, it would make me a bit > > more confident too. > > > Which tests/targets exactly? If you kn

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

malaperle added a comment. Both check-clang and check-clang-tools pass successfully for me on Windows with the patch. Repository: rC Clang https://reviews.llvm.org/D48903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D39050: Add index-while-building support to Clang

malaperle added a comment. In https://reviews.llvm.org/D39050#1004937, @ioeric wrote: > I'm wondering if there is any further plan for this? ;) I'd like to comment on the amount of data that will be stored but that can be done outside this review. I still have a few things to figure out before

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle updated this revision to Diff 133978. malaperle added a comment. Herald added subscribers: ioeric, jkorous-apple. Move tests to XRefsTests, change IncludeReferenceMap to a vector and rename it. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38639 Files: clangd/Clang

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle added inline comments. Comment at: clangd/ClangdUnit.h:51 +using IncludeReferenceMap = std::unordered_map; + ilya-biryukov wrote: > We use `unordered_map` as a `vector>` here. (i.e. we never look up > values by key, because we don't only the range, m

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

malaperle added a comment. I haven't looked at the newest patch yet but I gave it a quick try and saw something odd. If I change the configuration to something invalid (say I specify the path to a CMakeLists.txt), then I get many errors/diagnostics, which is normal. But then when I change the c

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle added inline comments. Comment at: unittests/clangd/XRefsTests.cpp:53 +class IgnoreDiagnostics : public DiagnosticsConsumer { + void onDiagnosticsReady( ilya-biryukov wrote: > NIT: remove this class, use `IgnoreDiagnostics` from `Compiler.h` instead.

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle added inline comments. Comment at: unittests/clangd/XRefsTests.cpp:245 + const char *SourceContents = R"cpp( + #include "$2^invalid.h" + #include "^foo.h" ilya-biryukov wrote: > Could we also add tests for corner cases: cursor before opening quote, c

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle updated this revision to Diff 134296. malaperle added a comment. Fix some NITs, add more tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38639 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Protocol.h clangd/SourceCode.cpp clangd/SourceCode.h

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle updated this revision to Diff 134432. malaperle added a comment. Use EXPECT_THAT in a few places and clean-ups in tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38639 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Protocol.h clangd/SourceCode.c

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle updated this revision to Diff 134549. malaperle added a comment. Change some EXPECT_TRUE to ASSERT_TRUE Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38639 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Protocol.h clangd/SourceCode.cpp clangd/Sourc

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle updated this revision to Diff 134692. malaperle added a comment. Rebase. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D35894 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/Protocol.cpp clang

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle updated this revision to Diff 134708. malaperle added a comment. Add a missing std::move, fix some formatting. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D35894 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/Clangd

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle accepted this revision. malaperle added a comment. This revision is now accepted and ready to land. Works well and code looks good. There were only minor tweaks since the last approval. I'll land this since there are some issues with Simon's svn account. Repository: rCTE Clang Tools

[PATCH] D35894: [clangd] Code hover for Clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325395: [clangd] Implement textDocument/hover (authored by malaperle, committed by ). Changed prior to commit: https://reviews.llvm.org/D35894?vs=134708&id=134712#toc Repository: rCTE Clang Tools E

[PATCH] D35894: [clangd] Code hover for Clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rL325395: [clangd] Implement textDocument/hover (authored by malaperle, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D35894 Files: clang-tools-

[PATCH] D43411: [clangd] Rename some protocol field to lower case

malaperle created this revision. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, klimek. Also fixes a GCC compilation error. Signed-off-by: Marc-Andre Laperle Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43411 Files: clangd/Protocol.cpp cla

[PATCH] D43411: [clangd] Rename some protocol field to lower case

This revision was automatically updated to reflect the committed changes. Closed by commit rL325409: [clangd] Rename some protocol field to lower case (authored by malaperle, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43411 Files:

[PATCH] D43429: [clangd] Add missing library (clangLex) in a few places

malaperle created this revision. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, mgorny, klimek. Fixes undefined reference to 'clang::Preprocessor::addCommentHandler' when building with -DBUILD_SHARED_LIBS. Signed-off-by: Marc-Andre Laperle Repository: rCTE Clan

[PATCH] D43429: [clangd] Add missing library (clangLex) in a few places

malaperle abandoned this revision. malaperle added a comment. Already landed in another commit. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D38639: [clangd] #include statements support for Open definition

This revision was automatically updated to reflect the committed changes. Closed by commit rL325662: [clangd] #include statements support for Open definition (authored by malaperle, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D38639

[PATCH] D34269: [clangd] Add "Go to Declaration" functionality

malaperle-ericsson updated this revision to Diff 103405. malaperle-ericsson marked 12 inline comments as done. malaperle-ericsson added a comment. Address comments https://reviews.llvm.org/D34269 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/Clan

[PATCH] D34269: [clangd] Add "Go to Declaration" functionality

malaperle-ericsson added inline comments. Comment at: clangd/ClangdUnit.cpp:303 + // fo|o -> foo| good! + if (InputLocation == SourceLocationBeg && Pos.character > 0) { +SourceLocation PeekBeforeLocation = Unit->getLocation(FE, Pos.line + 1, ilya-biryukov

[PATCH] D34269: [clangd] Add "Go to Declaration" functionality

malaperle-ericsson added inline comments. Comment at: clangd/ClangdUnit.cpp:276 +class DeclarationLocationsFinder : public index::IndexDataConsumer { + std::unique_ptr> DeclarationLocations; + const SourceLocation &SearchedLocation; ilya-biryukov wrote: > Why d

[PATCH] D34269: [clangd] Add "Go to Declaration" functionality

malaperle-ericsson added inline comments. Comment at: clangd/ClangdUnit.cpp:276 +class DeclarationLocationsFinder : public index::IndexDataConsumer { + std::unique_ptr> DeclarationLocations; + const SourceLocation &SearchedLocation; malaperle-ericsson wrote: >

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle requested changes to this revision. malaperle added a comment. This revision now requires changes to proceed. Herald added a subscriber: mgrang. Needs to be rebased. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D35894 ___

[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

malaperle requested changes to this revision. malaperle added inline comments. This revision now requires changes to proceed. Comment at: include/clang/Frontend/PrecompiledPreamble.h:263 const MacroDirective *MD); + /// Adds list of Preprocesso

[PATCH] D40548: [clangd] Symbol index interfaces and an in-memory index implementation.

malaperle added a comment. In https://reviews.llvm.org/D40548#947081, @ioeric wrote: > Hi Marc, the patch is not ready for review yet. I am still cleaning up the > prototype and will let you know when it's ready for review. I guess it was ready to review since it was submitted? ;) =

[PATCH] D40548: [clangd] Symbol index interfaces and an in-memory index implementation.

malaperle added inline comments. Comment at: clangd/index/Index.h:134 + virtual bool + fuzzyFind(Context &Ctx, const FuzzyFindRequest &Req, +std::function Callback) const = 0; ioeric wrote: > malaperle wrote: > > I think a more generic std::function

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle requested changes to this revision. malaperle added inline comments. This revision now requires changes to proceed. Comment at: clangd/ClangdServer.cpp:454 + +IncludeReferenceMap IRM = std::move(AST->takeIRM()); +Result = clangd::findDefinitions(*AST, Pos, Logge

[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

malaperle accepted this revision. malaperle added a comment. Looks good to me. But this is not really my area :) Repository: rC Clang https://reviews.llvm.org/D39375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D40548: [clangd] Symbol index interfaces and an in-memory index implementation.

malaperle added inline comments. Comment at: clangd/index/Index.h:134 + virtual bool + fuzzyFind(Context &Ctx, const FuzzyFindRequest &Req, +std::function Callback) const = 0; sammccall wrote: > ioeric wrote: > > malaperle wrote: > > > ioeric wrote:

[PATCH] D41306: [clangd] Update documentation page with new features, instructions

malaperle created this revision. Herald added subscribers: cfe-commits, ilya-biryukov, klimek. - Some features were implemented so mark them as such. - Add installation instructions (LLVM debian packages) Signed-off-by: Marc-Andre Laperle Repository: rCTE Clang Tools Extra https://reviews.l

[PATCH] D41306: [clangd] Update documentation page with new features, instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rL320988: [clangd] Update documentation page with new features, instructions (authored by malaperle, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41306 Files: clang-tools-extra/trunk/

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle added a comment. @ilya-biryukov Hi! I'll be updating William's patches that were in progress. I just have a few comments/question before I send a new update. (I also don't know if I can update this diff or I have to create a new diff on Phabricator... I guess we'll see!!).

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle added inline comments. Comment at: clangd/ClangdUnit.cpp:113 + CppFilePreambleCallbacks(IncludeReferenceMap &IRM) + : IRM(IRM) {} ilya-biryukov wrote: > malaperle wrote: > > ilya-biryukov wrote: > > > ilya-biryukov wrote: > > > > Let's create a

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle updated this revision to Diff 129292. malaperle added a comment. Store map in PremableData and copy it on reparse. Convert SourceLoc to Position when comparing with include Positions. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38639 Files: clangd/ClangdUnit.cpp

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle updated this revision to Diff 129293. malaperle added a comment. Revert an unintentional white space change. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38639 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Protocol.h clangd/SourceCode.cpp clangd/

[PATCH] D39050: Add index-while-building support to Clang

malaperle added a comment. In https://reviews.llvm.org/D39050#949185, @malaperle wrote: > In https://reviews.llvm.org/D39050#948500, @akyrtzi wrote: > > > @malaperle, to clarify we are not suggesting that you write your own > > parser, the suggestion is to use clang in 'fast-scan' mode to get th

[PATCH] D44213: [clangd] Remove unused field in HandlerRegisterer

malaperle accepted this revision. malaperle added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D44247: [clangd] Use identifier range as the definition range.

malaperle added a comment. I was going to change the symbol index to do the opposite :) The range of definitions including the bodies of functions, etc is used in a "peek definition" feature by several LSP clients. So for example in VSCode, you can hold Ctrl and hover on a function call and see

[PATCH] D44251: [clangd] Early return for #include goto definition.

malaperle added a comment. In https://reviews.llvm.org/D44251#1031370, @ilya-biryukov wrote: > LGTM. > I think this was part of initial changed and I asked to make it this way, > but I don't remember why. I think it was just to have a single place that returns. I think it's OK to early retur

[PATCH] D44247: [clangd] Use identifier range as the definition range.

malaperle added a comment. In https://reviews.llvm.org/D44247#1031429, @sammccall wrote: > In https://reviews.llvm.org/D44247#1031366, @sammccall wrote: > > > In https://reviews.llvm.org/D44247#1031345, @malaperle wrote: > > > > > I was going to change the symbol index to do the opposite :) The r

[PATCH] D39050: Add index-while-building support to Clang

malaperle added a comment. In https://reviews.llvm.org/D39050#1021204, @malaperle wrote: > For computing the start/end-loc of function bodies, I tried the > SingleFileParseMode and SkipFunctionBodies separately ( as a start). The > source I use this on looks like this: > > Given the discuss

[PATCH] D39050: Add index-while-building support to Clang

malaperle added a comment. In https://reviews.llvm.org/D39050#1036394, @nathawes wrote: > @malaperle Just to clarify, what's the particular end-loc we're talking about > here? e.g. for a function call, would this be the end of the function's name, > or the closing paren? > For the end of the

[PATCH] D39050: Add index-while-building support to Clang

malaperle added a comment. In https://reviews.llvm.org/D39050#1037796, @akyrtzi wrote: > Hey Marc, > > > The fact that both clang and clangd have to agree on the format so that > > index-while-building can be used seems to make it inherently not possible > > to extend > > I don't think "not pos

[PATCH] D39050: Add index-while-building support to Clang

malaperle added a comment. In https://reviews.llvm.org/D39050#1040501, @akyrtzi wrote: > > That would be good. How would one go about asking Clang to generate this > > extra information? Would a Clang Plugin be suitable for this? > > That's an interesting idea that we could explore, but I don't

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle marked an inline comment as done. malaperle added inline comments. Comment at: clangd/index/Index.h:158 unsigned References = 0; - + /// Whether or not this is symbol is meant to be used for the global + /// completion. sammccall wrote: > ioeric wr

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle updated this revision to Diff 149206. malaperle added a comment. Update with suggestions. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44954 Files: clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/index/Index.h clangd/index/MemIndex.cpp clangd/index/Sy

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle added inline comments. Comment at: unittests/clangd/CodeCompleteTests.cpp:741 +TEST(CompletionTest, Enums) { + EXPECT_THAT(completions(R"cpp( ioeric wrote: > malaperle wrote: > > ioeric wrote: > > > It's not clear to me what the following tests (`Enu

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle updated this revision to Diff 149532. malaperle marked 4 inline comments as done. malaperle added a comment. Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44954 Files: clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/index/Index.h clangd

[PATCH] D47643: Rewrite JSON dispatcher loop using C IO (FILE*) instead of std::istream.

malaperle added a comment. In https://reviews.llvm.org/D47643#1119187, @sammccall wrote: > @malaperle: would you mind patching this in and checking whether attaching a > debugger still works on Mac (this was the reason for the EINTR loop, right?) > > I want to preserve this but now people other

[PATCH] D47737: [clangd] Remove unused variables

malaperle created this revision. Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov, klimek. Signed-off-by: Marc-Andre Laperle Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47737 Files: clangd/ClangdServer.cpp Index: clangd/ClangdServer.cpp ==

[PATCH] D47643: Rewrite JSON dispatcher loop using C IO (FILE*) instead of std::istream.

malaperle added a comment. In https://reviews.llvm.org/D47643#1120913, @ilya-biryukov wrote: > PS I've checked it on my Mac and lldb seems to attach just fine. Working fine in my setup too! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47643 __

[PATCH] D44954: [clangd] Add "member" symbols to the index

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE334017: [clangd] Add "member" symbols to the index (authored by malaperle, committed by ). Changed prior to commit: https://reviews.llvm.org/D44954?vs=149532&id=149970#toc Repository: rCTE Clang To

[PATCH] D44954: [clangd] Add "member" symbols to the index

This revision was automatically updated to reflect the committed changes. Closed by commit rL334017: [clangd] Add "member" symbols to the index (authored by malaperle, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44954 Files: clang-t

[PATCH] D47737: [clangd] Remove unused variables

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCTE334018: [clangd] Remove unused variables (authored by malaperle, committed by ). Changed prior to commit: https://rev

[PATCH] D47737: [clangd] Remove unused variables

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL334018: [clangd] Remove unused variables (authored by malaperle, committed by ). Herald added a subscriber: llvm-commits.

  1   2   3   4   >