malaperle added inline comments.
================
Comment at: clangd/Protocol.h:458
+///
+/// A parameter can have a label and a doc-comment.
+struct ParameterInformation {
----------------
rwols wrote:
> @malaperle I copied the sentences from the protocol markdown file over
> [here](https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md),
> but judging from your comment
> [here](https://reviews.llvm.org/D35894#inline-314196) that might a problem.
> Do you suggest to change this or is this okay as-is?
I'm not a lawyer and I have very limited understanding of how these things work
but I would maybe reword the longer ones and keep it a short summary of a few
words. I'll ask around what my other open source colleagues think though.
https://reviews.llvm.org/D38048
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
