[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

manas added a comment. In D140086#4010175 , @steakhal wrote: >> This test fails. >> >> void testfoo(unsigned char u, signed int s) { >> if (u >= 253 && u <= 255 && s < INT_MAX - 2) { >> // u: [253, 254], s: [INT_MIN, INT_MAX - 2] >> clan

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

manas updated this revision to Diff 486425. manas added a comment. Re-introduce bitwidth comparison Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140086/new/ https://reviews.llvm.org/D140086 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintMa

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

manas marked 5 inline comments as done. manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1638-1639 + if (LHS.isUnsigned() && (LHS.getBitWidth() >= RHS.getBitWidth())) { +if (RHS.getMaxValue().isNegative() || +

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

manas added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140086/new/ https://reviews.llvm.org/D140086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D142454: [analyzer] Update satest dependencies

manas created this revision. manas added a reviewer: steakhal. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. manas requested review of this revisi

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f02ad880e42: [analyzer][solver] Improve reasoning for not equal to operator (authored by manas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140086/new/

[PATCH] D142454: [analyzer] Update satest dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa037b85f3097: [analyzer] Update satest dependencies (authored by manas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. In D112621#3949400 , @steakhal wrote: > `Analysis/constant-folding.c` seems to fail. > Please run the `check-clang-analysis` build target to see what fails and > investigate it. @steakhal thank you for reviewing this! I investig

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 477934. manas added a comment. Fix test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

manas added a comment. Hi, I came across this due to changes in Static Analyzer. One of the changes is not related to the Github issue mentioned above. Maybe we can drop that file? Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1214-1215

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas marked 2 inline comments as done. manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1624 + if (LHS.isEmpty() || RHS.isEmpty()) +return RangeFactory.getEmptySet(); + steakhal wrote: > This branch is uncove

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 480542. manas marked an inline comment as done. manas added a comment. Add more tests for complete coverage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files: cla

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas marked 13 inline comments as done. manas added a comment. In D112621#3978285 , @steakhal wrote: > For the test cases where we should be able to prove the case but return > `Unknown` instead, should be marked by a FIXME stating the expected value. >

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 481545. manas added a comment. Assert over non-empty ranges and add fixme for not handled cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files: clang/lib/Stati

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 481560. manas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/test/Ana

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

manas created this revision. manas added a reviewer: steakhal. Herald added subscribers: ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. manas requested review of th

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

manas updated this revision to Diff 483135. manas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140086/new/ https://reviews.llvm.org/D140086 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/test/Ana

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

manas marked 2 inline comments as done. manas added a comment. In D140086#3998426 , @steakhal wrote: > Thanks for going the extra mile to address this last thing. I really > appreciate it. > I've got only a few minor comments and suggestions. > > I'd rec

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

manas updated this revision to Diff 483786. manas added a comment. Remove redundant branches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140086/new/ https://reviews.llvm.org/D140086 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.c

[PATCH] D120646: [clang][scan-build] Change mode of installation for scan-build.1

manas created this revision. Herald added a subscriber: mgorny. manas requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, manpage for scan-build is installed as a program, with permission of 755. This patch makes installation of scan

[PATCH] D120646: [clang][scan-build] Change mode of installation for scan-build.1

manas added a comment. This patch fixes #53967 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120646/new/ https://reviews.llvm.org/D120646 ___ cfe-comm

[PATCH] D120646: [clang][scan-build] Change mode of installation for scan-build.1

manas updated this revision to Diff 412112. manas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120646/new/ https://reviews.llvm.org/D120646 Files: clang/tools/scan-build/CMakeLists.txt Index: clang/tools/scan-build/CMa

[PATCH] D120646: [clang][scan-build] Change mode of installation for scan-build.1

manas added a comment. I rebased to see if it satisfies the buildbot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120646/new/ https://reviews.llvm.org/D120646 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D120646: [clang][scan-build] Change mode of installation for scan-build.1

manas added a comment. Herald added a project: All. Buildbots are happy. I think we can land this. @steakhal do you mind landing it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120646/new/ https://reviews.llvm.org/D120646 ___

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. I have received a failed build on clang-ppc64be-linux (https://lab.llvm.org/buildbot/#/builders/52/builds/11704). Although, I haven't verified the commit. Is there something wrong with this commit? Is the function VisitBinaryOperator reachable? Repository: rG LLVM Git

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. Based on the information from debugger, the logs show RangeSets `[0, 255]` and `[INT_MIN, 0]` from different types are causing the failure. I tried producing a compact test case

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas added a comment. Gentle ping! I think landing it will make collecting analyzer information easier (in terms of faster build) as more (appropriate) cmake options can be passed via cmdline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105447/

<    1   2