manas marked 13 inline comments as done. manas added a comment. In D112621#3978285 <https://reviews.llvm.org/D112621#3978285>, @steakhal wrote:
> For the test cases where we should be able to prove the case but return > `Unknown` instead, should be marked by a FIXME stating the expected value. > Approximating a concrete value with `Unknown` is (almost) always correct. So, > in this case, you don't need to go and fix them unless you want to do the > extra mile. I have added FIXME in `constant-folding.c` test file for now. I will fix it in a new review. I have also opened a Discourse thread <https://discourse.llvm.org/t/missing-optimization-case-in-not-equal-binary-operator/67097> on the missing optimization opportunity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
