[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

ldionne updated this revision to Diff 547950. ldionne added a comment. Try to fix build on queue=linux builders Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157324/new/ https://reviews.llvm.org/D157324 Files: clang/utils/ci/buildkite-pipeline.y

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

This revision was automatically updated to reflect the committed changes. Closed by commit rG042abb477c3f: [clang] Move the Clang CI jobs off of the libc++ builders (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157324/new/ htt

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. The libc++ changes are reasonable. We could discuss more around how to handle C++03 in `__libcpp_is_constant_evaluated` but I don't think it's worth delaying this patch for that.

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

ldionne resigned from this revision. ldionne added a subscriber: philnik. ldionne added a comment. Herald added a subscriber: wangpc. Herald added a project: All. @philnik you might be interested by this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

ldionne added a comment. Ping. What's missing to land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D143524: Make the -Wunused-template default.

ldionne removed reviewers: ldionne, libc++. ldionne added a comment. Herald added a subscriber: wangpc. [Github PR transition cleanup] Dropping libc++ since this shouldn't affect libc++ since D144667 . Repository: rC Clang CHANGES SINCE LAST ACTION https:

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

ldionne added inline comments. Comment at: runtimes/CMakeLists.txt:20 +set(RUNTIMES_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) + This shouldn't be necessary, CMake already creates a `Project_SOURCE_DIR` variable for each declared `project()` IIRC. Repository:

[PATCH] D72959: Relative VTables ABI on Fuchsia

ldionne added a comment. Herald added subscribers: abrachet, jdoerfert, pengfei, MaskRay. Herald added a project: All. [Github PR transition cleanup] I think this work has landed as multiple separate patches, right? If so, can we please close this to clear up the review queue? Repository: rG

[PATCH] D140538: [Clang][CodeGen] Use poison instead of undef for dummy values in CGExpr [NFC]

ldionne added a comment. Ping. This should be updated to avoid touching libcxxabi. Comment at: libcxxabi/test/test_demangle.pass.cpp:3172 {"_ZN5clang7CodeGen15CodeGenFunction24EmitComplexPrePostIncDecEPKNS_13UnaryOperatorENS0_6LValueEbb", "clang::CodeGen::CodeGenFunctio

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

ldionne resigned from this revision. ldionne added a comment. Unfortunately I am too backed up with libc++ stuff to review with the PR transition, so I'm resigning from this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://re

[PATCH] D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag

ldionne added a comment. Herald added a subscriber: ekilmer. What is the status of this? We now require CMake 3.20, can this be rebased and landed in some form? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143052/new/ https://reviews.llvm.org/D14

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

ldionne added a comment. LGTM, but as a matter of process, please try to wait for someone from the libc++ review group before submitting. Thanks for the fix! Comment at: libcxx/include/__tree:379-380 _LIBCPP_ASSERT_UNCATEGORIZED(__z != nullptr, "The node to remove should

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. I really like where this is going, this will create a framework where Clang can add more pre-commit CI checks if they desire. Comment at: clang/utils/ci/run-buil

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. This LGTM but the CI has to pass! Also don't forget to undo the changes to `buildkite-pipeline.yml` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a3322bab069: [clang] Create a buildkite-pipeline.yml file for clang (authored by philnik, committed by ldionne). Changed prior to commit: https:/

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne updated this revision to Diff 539526. ldionne added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Touch a file inside Clang to test the triggering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/

[PATCH] D138042: [libc++] Trigger both Clang and libc++ CI when there are changes to both

ldionne abandoned this revision. ldionne added a comment. This will be superseded by D155078 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138042/new/ https://reviews.llvm.org/D138042 ___

[PATCH] D141423: Trigger the Clang/libc++ CI pipeline even when libc++ has been modified

ldionne abandoned this revision. ldionne added a comment. Superseded by D155078 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141423/new/ https://reviews.llvm.org/D141423 _

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne updated this revision to Diff 539534. ldionne added a comment. Poke CI after fixing pipeline settings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/ https://reviews.llvm.org/D155078 Files: .ci/generate-buildkite-pipeline-prem

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne added a comment. Ok, this is ready to go. More context around this change: I created a clang-specific CI pipeline (https://buildkite.com/llvm-project/clang-ci) and Clang CI jobs will now trigger inside that pipeline instead of inside the libc++ pipeline (https://buildkite.com/llvm-proj

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne updated this revision to Diff 539553. ldionne added a comment. Poke CI after fixing Clang CI pipeline clone URL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/ https://reviews.llvm.org/D155078 Files: .ci/generate-buildkite-pip

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne added a comment. See https://github.com/google/llvm-premerge-checks/pull/452 for the other side of this change. https://github.com/google/llvm-premerge-checks/pull/452 must land after this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne added a comment. In D155078#4493995 , @aaron.ballman wrote: > In D155078#4493468 , @ldionne wrote: > >> Ok, this is ready to go. More context around this change: >> >> I created a clang-specific CI pipeli

[PATCH] D155081: Specify the developer policy around links to external resources

ldionne added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345"; to automate closing + the issue in GitHub. If the patch has been reviewed,

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne added a comment. I will land this because I can tell this is correct after following the CI pipeline's execution, and https://github.com/google/llvm-premerge-checks/pull/452 has already landed so the CI could start becoming red anytime now. If there are concerns about Clang having its

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG298f207e0649: [ci] Make libc++ and Clang CI scripts independent (authored by ldionne). Changed prior to commit: https://reviews.llvm.org/D155078?v

[PATCH] D152632: [Clang] Add warnings for CWG2521

ldionne added a comment. This breaks libc++: https://buildkite.com/llvm-project/clang-ci/builds/26#01894b7d-8d6f-4893-ab14-1147229390dc Doesn't mean don't land it, but please try to address the issues in this patch to keep everyone green. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM. I think what we discussed in https://reviews.llvm.org/D157757#inline-1534166 makes sense and we should do it, but it belongs to a different patch for sure. Anybody wants to take that

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

ldionne added a comment. Also we should figure out why the Clang modules build is failing on top of this, it doesn't look like a false positive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 __

[PATCH] D158690: [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We made some changes to the libc++ CI pipeline that take for granted that we're running on libc++'s own Docker images. This

[PATCH] D158690: [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Along with aa60b2687ce3b67e454ba7c8c58a8688247df0b8 , this will make the Clang CI green again. We'll figure out what's th

[PATCH] D158690: [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb6073c7e32b: [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline (authored by ldionne). Repository: rG LLVM Github M

[PATCH] D158690: [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline

ldionne added a comment. The follow-up to the temporary workaround is going to be done tomorrow in D158694 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158690/new/ https://reviews.llvm.org/D158690

[PATCH] D158694: [libc++] Re-enable the __std_module test

ldionne updated this revision to Diff 553120. ldionne added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also touch a Clang file just to trigger their CI pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D158765: [clang] Also run the clang tests as part of the Clang-specific CI pipeline

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We used to rely on the monorepo-wide premerge checks for running Clang tests, but I think it makes more sense to run the Cla

[PATCH] D158765: [clang] Also run the clang tests as part of the Clang-specific CI pipeline

ldionne updated this revision to Diff 553255. ldionne added a comment. Only run check-clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158765/new/ https://reviews.llvm.org/D158765 Files: clang/utils/ci/buildkite-pipeline.yml clang/utils/ci/

[PATCH] D158765: [clang] Also run the clang tests as part of the Clang-specific CI pipeline

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5e603450bb33: [clang] Also run the clang tests as part of the Clang-specific CI pipeline (authored by ldionne). Repositor

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a CI job for Clang on Windows that is separate from the monolithic job that gets added automatically via the

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne added a subscriber: aaron.ballman. ldionne added a comment. @aaron.ballman for awareness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 ___ cfe-commits

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 553968. ldionne added a comment. Run script through bash on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.yml

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

ldionne accepted this revision. ldionne added a comment. Sorry for missing a couple of direct pings. I have no concerns with the patch, perhaps I should not have marked my review as blocking in the first place. Thanks for doing this work, it's about time we updated this default! Repository:

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 553995. ldionne added a comment. Poke CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.yml clang/utils/ci/run-buildbot

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 554015. ldionne added a comment. Set VC variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.yml clang/utils/ci/run-

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne updated this revision to Diff 554016. ldionne marked an inline comment as done. ldionne added a comment. Herald added a reviewer: bollu. Herald added subscribers: cfe-commits, libc-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, Enna1, yota9, ayermolo, jvesely. Herald ad

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne added a comment. Herald added a subscriber: JDevlieghere. Sorry for spamming everyone, I'm trying to ensure that the CI will work with all the sub-projects in the monorepo once we move to GH PRs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 554115. ldionne added a comment. Poke CI -- it seemed to time out this afternoon due to Phab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 554277. ldionne added a comment. Don't upload the Windows build artifacts cause we don't use them and it fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files:

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 554295. ldionne added a comment. Poke CI -- Phabricator keeps timing out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.y

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne marked an inline comment as done. ldionne added inline comments. Comment at: .ci/generate-buildkite-pipeline-premerge:163 + +if [[ ! ${SPECIFIC_PIPELINE_AVAILABLE} -eq 1 ]]; then + # Figure out which projects need to be built on each platform goncharov w

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne updated this revision to Diff 554420. ldionne marked an inline comment as done. ldionne added a comment. Address review comments. I did some testing using GH PRs and this should work, but some tweaks might be necessary. After discussing with Mikhail, I'll merge this now and we can make t

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf1a3d93581f: Implement the monolithic CI pipeline in the monorepo (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne added a comment. This looks good, the Windows CI is failing with the original premerge checks in exactly the same way as this new job, so I guess it's a current issue on `main`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ htt

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb27be95a4c6: [clang] Add a Windows build in the Clang pre-commit

[PATCH] D159197: [clang][ci] Don't block all jobs on clang-format

ldionne created this revision. ldionne added a reviewer: aaron.ballman. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It was expressed in some reviews that Clang folks didn't want to hold off other tes

[PATCH] D159197: [clang][ci] Don't block all jobs on clang-format

ldionne added a comment. In D159197#4628232 , @aaron.ballman wrote: > Thank you for this! I'm not qualified to say the changes are correct (they > look sensible to me though), but I am really appreciative of the change. Yup this is mostly for awareness

[PATCH] D159197: [clang][ci] Don't block all jobs on clang-format

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe34ddb1b5da4: [clang][ci] Don't block all jobs on clang-format (authored by ldionne). Repository: rG LLVM Github Monore

[PATCH] D106339: Add support to generate Sphinx DOCX documentation

ldionne commandeered this revision. ldionne added a reviewer: t-tye. ldionne added a comment. Herald added a subscriber: jplehr. Herald added a project: All. [GitHub PR transition cleanup] This has been open for 2 years with multiple subscribers able to see this discussion, but there doesn't see

[PATCH] D137338: Fix dupe word typos

ldionne added a comment. Herald added subscribers: wangpc, gysit, Dinistro, hoy, bviyer, wlei, jplehr, PiotrZSL, luke, sunshaoce. Herald added a reviewer: springerm. Herald added a reviewer: kiranchandramohan. Herald added a project: clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks

[PATCH] D114903: [clang] Support array placement new in constant expressions

ldionne abandoned this revision. ldionne added a comment. Herald added a project: All. I've run out of time to work on this. It's also not clear that it's supported by the Standard right now since there's a not-voted-yet LWG issue about it (http://wg21.link/LWG3436). Abandoning. This isn't bloc

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

ldionne added a comment. (sorry, no idea why it says "this revision is now accepted and ready to land on my behalf, I was just removing the libc++ review group to clear our review queue) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ h

[PATCH] D155713: [clang] Fix interaction between dllimport and exclude_from_explicit_instantiation

ldionne abandoned this revision. ldionne added a comment. In D155713#4592852 , @hans wrote: >> I think this does actually matter for libc++, I think I have seen this >> pattern: >> >> template >> struct Foo { >> _LIBCPP_FUNC_VIS _LIBCPP_EXCLUDE_

[PATCH] D114649: [libc++] Implement not-yet-voted LWG3436

ldionne abandoned this revision. ldionne added a comment. Herald added a project: All. Abandoning since this LWG issue isn't voted yet and we don't need this to implement other features. I've moved it to https://github.com/ldionne/llvm-project/tree/wip/LWG3436-construct_at-arrays and create a G

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM w/ normalization. I suggest trying to land these changes sooner rather than later since this is bound to merge conflict and become stale. CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D131963: [libc++] Add custom clang-tidy checks

ldionne added a comment. Herald added a reviewer: njames93. Let's make those checks optional until we can figure out the packaging stuff, and land this (with green CI). This is going to become way too stale otherwise. Comment at: clang/cmake/modules/ClangConfigVersion.cmake.in

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM at high level, but I'm not really familiar with the code. Comment at: clang/lib/AST/ExprConstant.cpp:6365 +const llvm::fltSemantics &Semantics = Info.Ctx.getFloatT

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. I think the direction works, but I have questions about some thing I don't understand (mostly in the tests). Comment at: libcxx/include/stddef.h:58 !defined

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne added inline comments. Comment at: libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/aligned_storage.pass.cpp:275 +#if TEST_STD_VER >= 11 +const size_t alignment = TEST_ALIGNOF(std::max_align_t) > 16 ? +16 : TEST_ALIGNOF(std::max_align_t); --

[PATCH] D43159: Modernize: Use nullptr more.

ldionne added a comment. Ping -- is there still interest in moving forward with this? If so, please address the comments and update the patch, otherwise you can abandon the revision to clean up the libc++ review queue. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

ldionne added a comment. > Closed by commit rG703a1b8caf09 > : > [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy > CallDescriptionMap (authored by ldionne, committed by Szelethus). · Explain > Why This is reall

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

ldionne added a comment. In D68165#1950357 , @Szelethus wrote: > Ugh, I squashed my local commits and pushed, it seems like for some reason it > made you the author... it has happened to me before (always with you, for > some reason), but was able to not

[PATCH] D72959: Relative VTables ABI on Fuchsia

ldionne requested changes to this revision. ldionne added inline comments. Comment at: libcxxabi/src/private_typeinfo.cpp:617 // Get (dynamic_ptr, dynamic_type) from static_ptr +#ifndef __Fuchsia__ void **vtable = *static_cast(static_ptr); Please introd

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fa3894c4e77: [clang] Fix search path logic for C_INCLUDE_DIRS (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69221/new/ https://revie

[PATCH] D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared

ldionne accepted this revision. ldionne added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66178/new/ https://reviews.llvm.org/D66178 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne added a comment. In D73245#1894420 , @EricWF wrote: > @ldionne Since this has the possibility of breaking existing users of > `std::max_align_t`, can you test this against your c++03 codebases? I have no opinion about this patch, but I generally

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

ldionne added a reviewer: kledzik. ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. This looks good to me, but I must admit I'm surprised this problem has never come up before (this code is very old), and also I don't know what the code is

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne added a comment. In D73245#1896786 , @ldionne wrote: > In D73245#1894420 , @EricWF wrote: > > > @ldionne Since this has the possibility of breaking existing users of > > `std::max_align_t`, can you test thi

[PATCH] D51762: First part of the calendar stuff

ldionne accepted this revision. ldionne added a comment. Herald added subscribers: Charusso, dexonsmith. Committed in 5b08c1742a536f54bd5e270b00ff851cbc7314ef CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51762/new/ https://reviews.llvm.org/D51762

[PATCH] D51762: First part of the calendar stuff

ldionne closed this revision. ldionne added a comment. Like I said, this was committed in 5b08c1742a536f54bd5e270b00ff851cbc7314ef CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51762/new/ https://reviews.llvm.org/D51762 ___ cfe-commits mail

[PATCH] D14411: Use __attribute__((internal_linkage)) when available.

ldionne added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. I think this should be closed since the work we did on `internal_linkage` in 2018. @eugenis Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14411/new/ https://reviews.ll

[PATCH] D45805: [libcxx] Remove redundant specializations in type_traits.

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Herald added subscribers: libcxx-commits, dexonsmith. LGTM, but you'll need to rebase this Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45805/new/ https:

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne added a comment. In D73245#1918148 , @EricWF wrote: > I've already stated my disapproval of this patch. Libc++ has never and will > never provide nor value C++03 conformance. > Moving backwards to C++03 is inconsistent with the libraries general

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne added inline comments. Comment at: libcxx/include/new:240 return __align > __STDCPP_DEFAULT_NEW_ALIGNMENT__; +#elif defined(_LIBCPP_CXX03_LANG) + return __align > alignment_of<__libcpp_max_align_t>::value; So, IIUC what you're saying, `__STDCPP_DEFAUL

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne requested changes to this revision. ldionne added inline comments. Herald added a subscriber: dexonsmith. Comment at: libcxx/include/new:240 return __align > __STDCPP_DEFAULT_NEW_ALIGNMENT__; +#elif defined(_LIBCPP_CXX03_LANG) + return __align > alignment_of<__libcpp_

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne added inline comments. Comment at: libcxx/include/new:240 return __align > __STDCPP_DEFAULT_NEW_ALIGNMENT__; +#elif defined(_LIBCPP_CXX03_LANG) + return __align > alignment_of<__libcpp_max_align_t>::value; krytarowski wrote: > ldionne wrote: > > joerg

[PATCH] D48680: Add missing visibility annotation for __base

This revision was automatically updated to reflect the committed changes. Closed by commit rG30ccc2e8d24b: [libc++] Add missing visibility annotation for __base (authored by yunlian, committed by ldionne). Herald added a project: libc++. Herald added a reviewer: libc++. Changed prior to commit:

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

ldionne added a comment. I think this was addressed by https://reviews.llvm.org/D71997. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73138/new/ https://reviews.llvm.org/D73138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. In D73138#1881198 , @BillyONeal wrote: > @ldionne I think you're correct, though the test there is more complex than > it needs to be (because the ==

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7dcbe90cc2d: [libc++] Fix overly complicated test of std::span's extent (authored by ldionne). Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Changed prior to commit: https:

[PATCH] D70099: [libcxx][test] Only call valarray::min and ::max on empty containers when testing libc++

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. You can go ahead and commit this. Comment at: test/std/numerics/numarray/template.valarray/valarray.members/min.pass.cpp:29 } +#ifdef _LIBCPP_VERSION // Not portable:

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Do you have commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69221/new/ https://reviews.llvm.org/D69221 ___ cfe-commits ma

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

ldionne added a comment. It's weird to mix Clang and libc++ test options because they test fundamentally different things. But I don't mind about this patch since it doesn't touch libc++ directly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7271

[PATCH] D35820: [Driver] Search compiler-rt paths in -print-file-name=

ldionne added inline comments. Herald added a project: All. Comment at: cfe/trunk/include/clang/Driver/ToolChain.h:312 + virtual std::string getCompilerRTPath() const; + By introducing a second way of getting the path to compiler-rt, this created inconsistenc

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While it's apparently valid to place Bash redirections anywhere in a command-line, it is by far most frequently placed last.

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

ldionne added a reviewer: aaron.ballman. ldionne added a comment. Gentle ping, this was likely a copy-paste error. Adding Aaron in case he has time to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146155/new/ https://reviews.llvm.org/

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG731264b0c2af: [clang][NFC] Fix location of 2>&1 in a few -print tests (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146155/new/ https

[PATCH] D144196: [C2x] Remove the ATOMIC_VAR_INIT macro from stdatomic.h

ldionne added a comment. Thanks for the heads up. As noted in another comment, I don't think this impacts libc++ because C++23 (unfortunately) still provides the macro AFAICT. We define it ourselves in `libcxx/include/__atomic/atomic_init.h`. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D143524: Make the -Wunused-template default.

ldionne added inline comments. Comment at: clang/test/SemaCXX/warn-func-not-needed.cpp:13 namespace test1_template { -template static void f() {} +template static void f() {} // expected-warning {{unused function template}} template <> void f() {} // expected-warning {{funct

[PATCH] D129951: adds `__disable_adl` attribute

ldionne added a comment. This is a really neat attribute! FWIW, I think we would most likely have used it in `` if it were available back then. Assuming that GCC implemented it, I think we could consider changing to use this attribute. However: 1. This would technically be an ABI break, but thi

[PATCH] D129951: adds `__disable_adl` attribute

ldionne added a comment. In D129951#4179467 , @cjdb wrote: > I'm deeply disappointed that libc++ moved away from using `__function_like`: > that was an important part of preventing niebloid misuse. It isn't conforming > to treat niebloids as function ob

[PATCH] D151963: [clang][NFC] Remove trailing whitespaces and enforce it in lib, include and docs

ldionne added inline comments. Comment at: libcxx/utils/ci/buildkite-pipeline-clang.yml:20-31 + - label: "Format" +commands: + - "! grep -rnI '[[:blank:]]$' clang/lib clang/include clang/docs || false" + +agents: + queue: "libcxx-builders" + os: "linux" -

<    2   3   4   5   6   7   8   >