[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

kwk requested changes to this revision. kwk added a comment. This revision now requires changes to proceed. As much as I would like this to be fixed. I vote against this patch because in `lld/CMakeLists.txt` there's an almost (if not entirely) identical piece of code

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

kwk added inline comments. Comment at: clang/CMakeLists.txt:103 if (LLVM_LIT AND LLVM_UTILS_PROVIDED) - set(UNITTEST_DIR ${LLVM_THIRD_PARTY_DIR}/utils/unittest) - if(EXISTS ${UNITTEST_DIR}/googletest/include/gtest/gtest.h - AND NOT EXISTS ${LLVM_LIBRARY_DI

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

kwk added a comment. @tbaeder I have a small suggestion. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1121-1138 +static unsigned getNumDisplayWidth(unsigned N) { + if (N < 10) +return 1; + if (N < 100) +return 2; + if (N < 1'000) +return 3;

[PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

kwk accepted this revision. kwk added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149641/new/ https://reviews.llvm.org/D149641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

kwk created this revision. kwk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Analogous to https://reviews.llvm.org/D93758, this patch uses `unsigned char` for all enums in `FormatStyle`. Repository: rG LLVM Github Monorepo https://re

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

kwk updated this revision to Diff 411105. kwk added a comment. Rebased on upstream/main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120398/new/ https://reviews.llvm.org/D120398 Files: clang/include/clang/Format/Format.h Index: clang/include/

[PATCH] D120712: [clang-format][docs] handle explicit enum values

kwk created this revision. kwk added a reviewer: FederAndInk. kwk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If there was this enum definition before: struct FormatStyle { //... /// Different styles for aligning after ope

[PATCH] D120712: [clang-format][docs] handle explicit enum values

kwk added a comment. In D120712#3351014 , @MyDeveloperDay wrote: > I'm not quite sure how I feel about adding functionality that doesn't > actually do anything. I hear you. My reasoning was that I'm going to introduce an explicit enum value sometime s

[PATCH] D120712: [clang-format][docs] handle explicit enum values

kwk added inline comments. Comment at: clang/docs/tools/dump_format_style.py:174-175 return '* ``%s`` (in configuration: ``%s``)\n%s' % ( -self.name, -re.sub('.*_', '', self.config), +self.clean_name, +self.clean_config, doxygen2rst(i

[PATCH] D120712: [clang-format][docs] handle explicit enum values

kwk added a comment. In D120712#3351889 , @MyDeveloperDay wrote: >> My reasoning was that I'm going to introduce an explicit enum value > > Any reason why? Yes, I but where's the fun if I told you now ;) . Just kidding. I don't want to go into the deta

[PATCH] D120712: [clang-format][docs] handle explicit enum values

kwk added a comment. In D120712#3352051 , @MyDeveloperDay wrote: > Does it need to be so "cloak and dagger"? ;-) No, you're right it doesn't have to be this way. > We always welcome patches, but please think about logging the idea in github > issues

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

kwk added a comment. In D120398#3352436 , @HazardyKnusperkeks wrote: > > That being said, I don't care that much that we declare the enums with a > type. But I care about consistency. Either land this, or revert D93758 >

[PATCH] D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle

kwk created this revision. kwk added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius. Herald added a project: All. kwk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It was requested here (https://reviews.llvm.org/D120398#3353053)

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

kwk abandoned this revision. kwk added a comment. I abandon this revision in favor of https://reviews.llvm.org/D120884. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120398/new/ https://reviews.llvm.org/D120398

[PATCH] D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle

kwk added a comment. In D120884#3356746 , @HazardyKnusperkeks wrote: > Please use the clang-format tag. Yes, sorry that I forgot it again. And thank you for approving. Shall I wait for the others to approve this or land the patch? Repository: rG LL

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

kwk added a comment. @saiislam please have a look into why this happens. Is the `-debug-only=CodeObjectCompatibility` maybe a left-over of some sort? Comment at: clang/test/Driver/clang-offload-bundler.c:405 +// Tests to check compatibility between Bundle Entry ID formats i.e.

<    1   2