[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

keith created this revision. Herald added a project: All. keith requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Starting with the SDKs provided with Xcode 14.3, this library no longer exists. Before this change this results in an op

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

keith updated this revision to Diff 523899. keith added a comment. Improve test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/new/ https://reviews.llvm.org/D150988 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driv

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

keith updated this revision to Diff 527261. keith added a comment. Improve error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/new/ https://reviews.llvm.org/D150988 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

This revision was automatically updated to reflect the committed changes. Closed by commit rG2129cc1b3a14: [clang][Darwin] Error out when missing requested libarclite library (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/n

[PATCH] D117730: [DNM][VFS] Do not overwrite the path when nesting RedirectingFileSystems

keith added a comment. In D117730#3262622 , @dexonsmith wrote: > @keith, any thoughts on this? IIRC, you'd found a few other bugs while you > were in there which you'd left for later; not sure if this is related to them > or not. This issue wasn't one

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

keith accepted this revision. keith added a comment. This revision is now accepted and ready to land. I'm definitely not a VFS expert, but I do think this is much nicer than trying to do the other workarounds with multiple VFSs that you described, I left some minor comments, I reviewed carefully

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

keith added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:575 +/// instead> +/// 'redirecting-with': bnbarham wrote: > keith wrote: > > I think `redirecting-with` is fine, and I can't come up with something > > b

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith added inline comments. Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': +root_sep = 'C:\\' +else: compnerd wrote: > This isn't really a separator, this is the root itself. I think that it > makes sense to name it accordingly.

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith updated this revision to Diff 409849. keith added a comment. Update to read CPU from sysctl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp ll

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith added a comment. Thanks for the tips! I left the default as generic here, but I totally take your point on defaulting to the newest and I'm happy to update if you feel strongly, lmk what you think Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith updated this revision to Diff 410040. keith marked 2 inline comments as done. keith added a comment. Code review improvements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 Files: clang/lib/Drive

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith added inline comments. Comment at: llvm/lib/Support/Host.cpp:1326 + case CPUFAMILY_ARM_CYCLONE: +return "apple-a7"; + case CPUFAMILY_ARM_TYPHOON: jrtc27 wrote: > ARM only calls it cyclone, AArch64 allows both but apple-a7 is the canonical > name (the

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

keith added a comment. In D102669#3325467 , @steakhal wrote: > Hi @keith, I've seen you commented on a clang driver-related issue: "Why does > march=native not work on Apple M1?" >

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith updated this revision to Diff 411573. keith added a comment. Herald added subscribers: llvm-commits, delcypher. Herald added a project: LLVM. Move config to llvm lit config, add docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ h

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith updated this revision to Diff 411575. keith marked 3 inline comments as done. keith added a comment. Add more test path changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 Files: clang/lib/Cod

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 411576. keith added a comment. Update test with new specifiers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/C

[PATCH] D111457: [test] Add lit helper for windows paths

keith updated this revision to Diff 411921. keith marked 3 inline comments as done. keith edited the summary of this revision. keith added a comment. Use the actual drive on windows, split out into fssrcroot and fstmproot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith updated this revision to Diff 411922. keith added a comment. Update tests with new syntax and FileCheck variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 Files: clang/lib/CodeGen/CGDebugIn

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 411923. keith added a comment. Update test with new variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/te

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 411926. keith added a comment. Fix parent revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/rela

[PATCH] D111457: [test] Add lit helper for windows paths

keith added inline comments. Comment at: llvm/utils/lit/lit/TestRunner.py:1124 +if kIsWindows: +fs_root = 'C:\\' +substitutions.extend([ probinson wrote: > rnk wrote: > > It is pretty common to run the LLVM test suite on secondary drives, > > esp

[PATCH] D111457: [test] Add lit helper for windows paths

keith added a comment. For reference here's an example of a test that uses this https://reviews.llvm.org/D111579 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457 __

[PATCH] D101037: [clang-tidy] Change shebang from python to python3

keith added a comment. I also have this patch https://reviews.llvm.org/D100692 which changes run-clang-tidy.py this way as well, specifically because it utilizes some python3 features in shutil.which Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D116174: [clang] support relative roots to vfs overlays

keith added a comment. This LGTM but I'm interested to hear from folks with more knowledge about the VFS' desired behavior to comment on if this will have any unexpected side effects Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https

[PATCH] D83154: clang: Add -fprofile-prefix-map

keith added a comment. Yes sorry, big company reviews month. I will try to land Friday Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83154/new/ https://reviews.llvm.org/D83154 ___ cfe-commits mailing lis

[PATCH] D111267: [clang] Fix darwin REQUIRES test annotation (NFC)

keith created this revision. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some subprojects like compiler-rt define the `darwin` feature in their lit config, but clang does not do that, so we need to use the global `system-darwin` h

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

keith created this revision. Herald added a reviewer: JDevlieghere. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When building a multiarch MachO binary, previously the intermediate output file names would contain random characters.

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

keith updated this revision to Diff 377674. keith added a comment. Remove debug comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111269/new/ https://reviews.llvm.org/D111269 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/darwin-dsym

[PATCH] D111267: [clang] Fix darwin REQUIRES test annotation (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9f9ed7a81ab8: [clang] Fix darwin REQUIRES test annotation (NFC) (authored by keith). Repository: rG LLVM Github Monorep

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

keith updated this revision to Diff 377983. keith added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111269/new/ https://reviews.llvm.org/D111269 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/darwin-dsymutil.c I

[PATCH] D111352: [clang] Fix absolute file paths with -fdebug-prefix-map

keith created this revision. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously if you passed an absolute path to clang, where only part of the path to the file was remapped, it would result in the file's DIFile being stored w

[PATCH] D111352: [clang] Fix absolute file paths with -fdebug-prefix-map

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa23a59679322: [clang] Fix absolute file paths with -fdebug-prefix-map (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D111444: Revert "[clang] Fix absolute file paths with -fdebug-prefix-map"

keith created this revision. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit a23a5967932292b82e9a7e4b37817d1b3f5be5ec . This broke a windows te

[PATCH] D111444: Revert "[clang] Fix absolute file paths with -fdebug-prefix-map"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68e49aea9ac4: Revert "[clang] Fix absolute file paths with -fdebug

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith created this revision. keith added reviewers: jroelofs, rmaz. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds 2 new lit helpers (only to the clang config) `%{rootsep}` and `%{sep}`, these allow writing tests that corre

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith updated this revision to Diff 378380. keith added a comment. Herald added a subscriber: ormris. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457 Files: clang/test/CodeGen/debug-prefix-map

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith added inline comments. Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': +root_sep = 'C:\\' +else: rmaz wrote: > `c:\`? Do you mean lowercase or a single slash? I see ~2x the number of uppercase vs lowercase in this codebase now,

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith updated this revision to Diff 378725. keith marked 2 inline comments as done. keith added a comment. Allow empty leading on windows This behavior is currently broken, the directory should never be `/` or `C:\` but the logic is broken and only handles `/` Repository: rG LLVM Github Mono

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

keith updated this revision to Diff 378796. keith added a comment. Fix slashes for windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111269/new/ https://reviews.llvm.org/D111269 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/darwin-d

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith created this revision. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On unix systems this logic would not separate the file and directory of the DIFile unless they shared more components at the start than just the root path ch

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith added a reviewer: compnerd. keith added a comment. Adding since you might be interested in this, I think the Swift logic is also derived from this so it might have the same difference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith created this revision. keith added a reviewer: probinson. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously if you passed an absolute path to clang, where only part of the path to the file was remapped, it would result

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. This broke tests on windows (see the new parent revisions in the stack) otherwise the actual change's behavior, outside of the tests, is unchanged Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llv

[PATCH] D111352: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. https://reviews.llvm.org/D111587 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111352/new/ https://reviews.llvm.org/D111352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 379559. keith marked 4 inline comments as done. keith added a comment. Update to remap file paths after fetching them from the external FS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. Ok I've updated the diff here based on @dexonsmith's original suggestion, and some offline discussion with @JDevlieghere The new logic remaps the files and statuses, in the fallback to the external FS case, to use the originally requested path. I opted not to use the seco

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

keith updated this revision to Diff 379570. keith added a comment. Fix windows test paths Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111269/new/ https://reviews.llvm.org/D111269 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/darwin-ds

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1179-1180 + if (ExternalFS) +ExternalFS->setCurrentWorkingDirectory(Path); + JDevlieghere wrote: > I'm pretty sure there was a reason we stopped doing this. There should be >

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 379881. keith marked an inline comment as done. keith added a comment. Extract fallback status logic to another function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 379882. keith added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files: clang/test/VFS/relative-path-errors.c llvm/include/llvm/Support/Vir

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 380125. keith added a comment. Improve lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files: clang/test/VFS/relative-path-errors.c llvm/include/llvm/Suppo

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith added inline comments. Comment at: clang/test/CodeGen/debug-prefix-map.c:24 +// CHECK-NO-MAIN-FILE-NAME: !DIFile(filename: "{{/|C:}}UNLIKELY_PATH{{/|}}empty{{/|}}{{.*}}", +// CHECK-NO-MAIN-FILE-NAME-SAME:directory: "") +// CHECK-NO-MAIN-FILE-NAME: !DIFile(f

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17386cb4dc89: [clang][Driver] Make multiarch output file basenames reproducible (authored by keith). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith added a comment. In D111457#3066508 , @mstorsjo wrote: > Wouldn't this one also be solved pretty much the same, but differently, by > changing `if (llvm::sys::path::is_absolute(RemappedFile)) {` into > `is_absolute_gnu`? I think it //could// but

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith added inline comments. Comment at: clang/test/CodeGen/debug-prefix-map.c:24 +// CHECK-NO-MAIN-FILE-NAME: !DIFile(filename: "{{/|C:}}UNLIKELY_PATH{{/|}}empty{{/|}}{{.*}}", +// CHECK-NO-MAIN-FILE-NAME-SAME:directory: "") +// CHECK-NO-MAIN-FILE-NAME: !DIFile(f

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 380802. keith marked 2 inline comments as done. keith added a comment. Remove `cd` of ExternalFS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files: clang/test/VFS

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1179-1180 + if (ExternalFS) +ExternalFS->setCurrentWorkingDirectory(Path); + dexonsmith wrote: > keith wrote: > > JDevlieghere wrote: > > > I'm pretty sure there was a reason w

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 380821. keith added a comment. Fix test paths on windows Otherwise this resulted in a json string with non-escaped backslashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added inline comments. Comment at: llvm/unittests/Support/VirtualFileSystemTest.cpp:1738 + +TEST_F(VFSFromYAMLTest, RelativePathHitWithoutCWD) { + IntrusiveRefCntPtr BaseFS( So this test case is actually failing. The difference between it and the others i

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith added a comment. In D111457#3082398 , @mstorsjo wrote: > In D111457#3073726 , @keith wrote: > >> In D111457#3066508 , @mstorsjo >> wrote: >> >>> Wouldn't this one a

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith created this revision. keith added a reviewer: JDevlieghere. Herald added subscribers: dexonsmith, hiraditya. keith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is a follow up to 0be9ca7c0f9a733f846bb6bc4e8e3

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 370155. keith added a comment. Some of the other checks were invalid given the current tests, these seem to be enough to solve this issue without breaking existing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 370480. keith marked 2 inline comments as done. keith added a comment. Update variable name and add unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files: c

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. In D109128#2982780 , @JDevlieghere wrote: > I'm sure I'm missing something, but after rereading the patch several times I > still don't see the functional change. It just looks like it's renaming every > instance of `Path` to `Ca

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. I think I might have to apply this same logic to the other functions changed in the original commit as well, this seems to solve this isolated case, but I think there are some more cases that aren't currently fixed by this Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. I'm realizing more now that these changes break the original intent of rG0be9ca7c0f9a733f846bb6bc4e8e36d46b518162 as well, given that it seems like the core canonicalization of the path before passing

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

keith created this revision. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This uses darwin's default libtool since llvm-ar isn't normally available. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109461 Files:

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 372041. keith added a comment. Handle all cases by passing relative path to ExternalFS first Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files: clang/test/VFS/rel

[PATCH] D101037: [clang-tidy] Change shebang from python to python3

keith added a comment. @hokein any plans to land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101037/new/ https://reviews.llvm.org/D101037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

keith added reviewers: ashi1, tra, yaxunl. keith added a comment. Since you all were involved in adding this feature in the beginning I'd appreciate a review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109461/new/ https://reviews.llvm.org/D1094

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. In D109128#2997588 , @JDevlieghere wrote: > If I understand correctly, this patch does that, but swaps 2 and 3. What's > the motivation for trying the non-canonical path first? If we treat the > current working directory as a pro

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

keith updated this revision to Diff 372286. keith marked an inline comment as done. keith added a comment. Fix formatting and comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109461/new/ https://reviews.llvm.org/D109461 Files: clang/lib/Dri

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

keith updated this revision to Diff 372287. keith added a comment. Revert unrelated formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109461/new/ https://reviews.llvm.org/D109461 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Dri

<    1   2