keith added inline comments.
================
Comment at: clang/test/CodeGen/debug-prefix-map.c:24
+// CHECK-NO-MAIN-FILE-NAME: !DIFile(filename:
"{{/|C:\\\\}}UNLIKELY_PATH{{/|\\\\}}empty{{/|\\\\}}{{.*}}",
+// CHECK-NO-MAIN-FILE-NAME-SAME: directory: "")
+// CHECK-NO-MAIN-FILE-NAME: !DIFile(filename:
"{{/|C:\\\\}}UNLIKELY_PATH{{/|\\\\}}empty{{/|\\\\}}Inputs{{/|\\\\}}stdio.h",
----------------
mstorsjo wrote:
> I presume that this patch goes on top of D111457? It might be good to set
> that one as the parent revision of this one, so that the premerge test runs
> applies them on top of each other (right now, this one failed to apply).
>
> Isn't this particular change present (`directory` being `""` here) already
> after the previous patch?
>
>
That is marked as the parent of this patch in phab, but maybe I need to do
something else to get them to apply?
================
Comment at: clang/test/CodeGen/debug-prefix-map.c:24
+// CHECK-NO-MAIN-FILE-NAME: !DIFile(filename:
"{{/|C:\\\\}}UNLIKELY_PATH{{/|\\\\}}empty{{/|\\\\}}{{.*}}",
+// CHECK-NO-MAIN-FILE-NAME-SAME: directory: "")
+// CHECK-NO-MAIN-FILE-NAME: !DIFile(filename:
"{{/|C:\\\\}}UNLIKELY_PATH{{/|\\\\}}empty{{/|\\\\}}Inputs{{/|\\\\}}stdio.h",
----------------
keith wrote:
> mstorsjo wrote:
> > I presume that this patch goes on top of D111457? It might be good to set
> > that one as the parent revision of this one, so that the premerge test runs
> > applies them on top of each other (right now, this one failed to apply).
> >
> > Isn't this particular change present (`directory` being `""` here) already
> > after the previous patch?
> >
> >
> That is marked as the parent of this patch in phab, but maybe I need to do
> something else to get them to apply?
> Isn't this particular change present (directory being "" here) already after
> the previous patch?
This does still require this change since otherwise directory still gets `C:`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111579/new/
https://reviews.llvm.org/D111579
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
