[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

kadircet added inline comments. Comment at: clang/include/clang/Sema/Scope.h:323 /// declared in. - bool isDeclScope(Decl *D) { -return DeclsInScope.count(D) != 0; - } + bool isDeclScope(const Decl *D) { return DeclsInScope.count(D) != 0; } also mark

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 252841. kadircet added a comment. - Invalidate cached AST in case of preamble/input changes when building golden ASTs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76725/new/ https://reviews.llvm.org/D76725

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM. thanks! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4984 +if (Q && isApprox(Q->getAsType(), T)) + addType(NNS->getAsIdentifier()); + } ---

[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

kadircet updated this revision to Diff 253325. kadircet added a comment. - Rebase, update comments for spelledForExpanded and add tests for multiple arguments. - Do not dive into macro bodies while looking for a common expansion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 253347. kadircet marked 26 inline comments as done. kadircet added a comment. Herald added a subscriber: jfb. - Update description and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76725/new/

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:623 std::string TaskName = llvm::formatv("Update ({0})", Inputs.Version); auto Task = [=]() mutable { auto RunPublish = [&](llvm::function_ref Publish) { sammccall wro

[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG9619c2cc9a22: [clang][Syntax] Handle macro arguments in spelledForExpanded (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D75446?vs=

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:206 + tooling::Replacements R; + if (auto Err = R.add(tooling::Replacement( + SM, CharSourceRange::getTokenRange(NNSL.getSourceRange()), "", sammccall wro

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 253552. kadircet added a comment. - Make use of a separate queue for golden ASTs to prevent any races that might occur due PreambleThread finishing multiple preambles before ASTWorker gets to process others. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 253556. kadircet added a comment. - Add assertion to explicitly spell out scheduling for golden ASTs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76725/new/ https://reviews.llvm.org/D76725 Files: clang-to

[PATCH] D77063: [WIP][clangd] Dont block for preamble builds

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble. k

[PATCH] D77063: [WIP][clangd] Dont block for preamble builds

kadircet added a comment. This requires patched-up ASTs and getting rid of consistent preamble needs first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77063/new/ https://reviews.llvm.org/D77063 ___

[PATCH] D77194: [clang] Persist Attr::IsPackExpansion into the serialized AST

kadircet added a comment. oh wow! thanks for looking into this. Looking at the history, it seems like an oversight. The patch that introduced packexpansion bit: https://github.com/llvm/llvm-project/commit/44c247f0f009eec70a193335c8a353d6f8602bfd. it didn't add that field to pchattr serializat

[PATCH] D77194: [clang] Persist Attr::IsPackExpansion into the serialized AST

kadircet added a comment. also please update the commit message to mention "PCH" rather than "serialized ast". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77194/new/ https://reviews.llvm.org/D77194

[PATCH] D77176: [clangd] Force delayed-template-parsing off in code completion.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77176/new/ https://reviews.llvm.org/D77176 __

[PATCH] D77204: [clangd] Run semaCodeComplete only with a preamble

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. It is used by code completion and signature help. Code completion already uses a special no-compile mod

[PATCH] D77204: [clangd] Run semaCodeComplete only with a preamble

This revision was automatically updated to reflect the committed changes. Closed by commit rG43aa04eb7a61: [clangd] Run semaCodeComplete only with a preamble (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D77204?vs=254133&id=254165#toc Repository: rG LLVM Github Mo

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 254439. kadircet marked 31 inline comments as done. kadircet added a comment. - Update comments and re-order functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76725/new/ https://reviews.llvm.org/D76725

[PATCH] D77063: [WIP][clangd] Dont block for preamble builds

kadircet updated this revision to Diff 254442. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77063/new/ https://reviews.llvm.org/D77063 Files: clang-tools-extra/clangd/TUScheduler.cpp clang-tools-extra/clangd

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet added a comment. preambleReady part is a little bit different than you've described, it looks more like: ASTWorker::preambleReady(): enqueue({ if(preamble!=lastPreamble) { lastPreamble = preamble cache.get(); // force next read to use this preamble } build as

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet updated this revision to Diff 254516. kadircet added a comment. - Start preambleworker in sync mode instead of blocking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76125/new/ https://reviews.llvm.org/D76125 Files: clang-tools-extra/cl

[PATCH] D76304: [clangd] Update TUStatus api to accommodate preamble thread

kadircet updated this revision to Diff 254519. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76304/new/ https://reviews.llvm.org/D76304 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/cl

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 254520. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76725/new/ https://reviews.llvm.org/D76725 Files: clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/Pr

[PATCH] D77309: [clangd] Get rid of ASTWorker::getCurrentFileInputs

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D76725: [clangd] Build ASTs only with fresh preambles or

[PATCH] D77194: [clang] Persist Attr::IsPackExpansion into the serialized AST

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77194/new/ https://reviews.llvm.org/D77194 ___

[PATCH] D77355: [clangd] show layout info when hovering on a class/field definition.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:571 +if (auto Size = Ctx.getTypeSizeInCharsIfKnown(RD->getTypeForDecl())) + HI.Size = Size->getQuantity(); + QuantityType seems to be an alias for int64_t, not sure how likely

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Replace usage of RawLexer with syntax tokens inside ReplayPreamble. Repository: rG LLVM Github Mono

[PATCH] D74844: [clangd] Get rid of Lexer usage in CodeComplete

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74844 Files: clang-tools-extra/clan

[PATCH] D74850: [clangd] Migrate Lexer usages in TypeHierarchy to TokenBuffers

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Also fixes a bug, resulting from directly using ND.getEndLoc() for end location of the range. As ND.get

[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

kadircet added inline comments. Comment at: clang/lib/Index/IndexingContext.cpp:217 +// Fallback to primary template if this is an incomplete specialization. +if (SD->getTemplateSpecializationKind() == TSK_Undeclared) + return SD->getSpecializedTemplate()->getTemplat

[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

kadircet added inline comments. Comment at: clang/lib/Index/IndexingContext.cpp:175 + if (TKind == TSK_Undeclared) +return dyn_cast(D); + i believe this might as well be an explicit instantiation, e.g. ``` template struct Foo{}; template <> struct Foo; vo

[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

kadircet added inline comments. Comment at: clang/lib/Index/IndexingContext.cpp:217 +// Fallback to primary template if this is an incomplete specialization. +if (SD->getTemplateSpecializationKind() == TSK_Undeclared) + return SD->getSpecializedTemplate()->getTemplat

[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, please fix the formatting warnings though (at least the ones in the implementation) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7483

[PATCH] D74844: [clangd] Get rid of Lexer usage in CodeComplete

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:593 + llvm::StringRef SpelledSpecifier = + syntax::FileRange(CCSema.SourceMgr, SemaSpecifier->getBeginLoc(), +SemaSpecifi

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:70 size_t UTF8Length = llvm::countLeadingOnes(C); -// 0xxx is ASCII, handled above. 10xxx is a trailing byte, invalid here. -// 1xxx is not valid UTF-8 at all. Assert because it's

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

kadircet added a comment. also could you clang-format your changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74731/new/ https://reviews.llvm.org/D74731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D74962: [clang][Tooling] Add a way to tokenize a FileRange

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74962 Files: clang/include/clang/Tooling/Syntax/Tokens.h clang/lib/Tooling/Syntax/Token

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

kadircet marked 7 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:138 + : Includes(Includes), Delegate(Delegate), SM(SM), PP(PP) { +MainFileTokens = syntax::tokenize(SM.getMainFileID(), SM, LangOpts); + } -

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

kadircet updated this revision to Diff 245960. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments. - Add tests by mimicking a clang-tidy check. - only tokenize the preamble section, not the whole file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

kadircet updated this revision to Diff 245962. kadircet added a comment. - Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74842/new/ https://reviews.llvm.org/D74842 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/

[PATCH] D71284: [clangd] Consider () part of the FunctionDecl, not the FunctionTypeLoc

kadircet resigned from this revision. kadircet added a comment. This revision now requires review to proceed. Herald added a subscriber: kadircet. I believe this revision is obsolete since D71345 has landed. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D75053: [clangd] Disable ExtractVariable for C

kadircet created this revision. kadircet added a reviewer: usaxena95. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Currently extract variable doesn't spell the type explicitly and just uses an `auto` instead, which is not availab

[PATCH] D75106: [clangd] Fix early selection for non-vardecl declarators

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Selection tree was performing an early claim only for VarDecls, but there are other cases where we can

[PATCH] D75053: [clangd] Disable ExtractVariable for C

kadircet updated this revision to Diff 246406. kadircet marked an inline comment as done. kadircet added a comment. - Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75053/new/ https://reviews.llvm.org/D75053 Files: clang-tools-extr

[PATCH] D75106: [clangd] Fix early selection for non-vardecl declarators

kadircet updated this revision to Diff 246405. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75106/new/ https://reviews.llvm.org/D75106 Files: clang-tools-ex

[PATCH] D75053: [clangd] Disable ExtractVariable for C

This revision was automatically updated to reflect the committed changes. Closed by commit rG555d5ad85a49: [clangd] Disable ExtractVariable for C (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75053/new/ https://reviews.llvm.o

[PATCH] D74850: [clangd] Migrate Lexer usages in TypeHierarchy to TokenBuffers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe09754ccefc8: [clangd] Migrate Lexer usages in TypeHierarchy to TokenBuffers (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74850/new/

[PATCH] D74850: [clangd] Migrate Lexer usages in TypeHierarchy to TokenBuffers

kadircet updated this revision to Diff 246439. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74850/new/ https://reviews.llvm.org/D74850 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/cl

[PATCH] D75106: [clangd] Fix early selection for non-vardecl declarators

kadircet updated this revision to Diff 246635. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75106/new/ https://reviews.llvm.org/D75106 Files: clang-tools-ex

[PATCH] D75019: Strip preceeding -Xclang when stripping -fcolor-diagnostics or -fdiagnostics-color

This revision was automatically updated to reflect the committed changes. Closed by commit rGda236f235028: Strip preceeding -Xclang when stripping -fcolor-diagnostics or -fdiagnostics… (authored by kadircet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

[PATCH] D74962: [clang][Tooling] Add a way to tokenize a FileRange

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:335 clang::Token T; - while (!L.LexFromRawLexer(T)) + while (!L.LexFromRawLexer(T) && L.getCurrentBufferOffset() < FR.endOffset()) AddToken(T); ---

[PATCH] D74962: [clang][Tooling] Add a way to tokenize a FileRange

kadircet updated this revision to Diff 246646. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74962/new/ https://reviews.llvm.org/D74962 Files: clang/include/clang/Tooling/Syntax/Tokens.h clang/lib/T

[PATCH] D75166: [clangd] Clean-up locateSymbolAt

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Get rid of calls to lexer and unnecessary source location transformations. Repository: rG LLVM Gith

[PATCH] D74962: [clang][Tooling] Add a way to tokenize a FileRange

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c2cf499e611: [clang][Tooling] Add a way to tokenize a FileRange (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74962/new/ https://re

[PATCH] D75166: [clangd] Clean-up locateSymbolAt

kadircet updated this revision to Diff 246682. kadircet added a comment. Add more cleaning. getDeclAtPosition builds a SelectionTree underneath and it only operates on spelling locations inside main file. So it is invalid to pass any expansion locations to it. There is no need to call getBeginni

[PATCH] D75166: [clangd] Clean-up locateSymbolAt

kadircet updated this revision to Diff 246690. kadircet added a comment. - Also clean usage in getSymbolInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75166/new/ https://reviews.llvm.org/D75166 Files: clang-tools-extra/clangd/XRefs.cpp Inde

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

kadircet updated this revision to Diff 246701. kadircet added a comment. - Handle llvm::Expected failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75166/new/ https://reviews.llvm.org/D75166 Files: clang-tools-extra/clangd/XRefs.cpp Index:

[PATCH] D75176: [clangd] Get rid of getBeginningOfIdentifier helper

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary

[PATCH] D75176: [clangd] Get rid of getBeginningOfIdentifier helper

kadircet updated this revision to Diff 246729. kadircet marked 4 inline comments as done. kadircet added a comment. - Only use special locations for deducedtype and macros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75176/new/ https://reviews.ll

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:432 auto References = findRefs( - getDeclAtPosition(AST, - SM.getMacroArgExpandedLocation(getBeginningOfIdentifier( -Pos, SM, AST.getLangOpts

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

kadircet updated this revision to Diff 246734. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75166/new/ https://reviews.llvm.org/D75166 Files: clang-tools-ex

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

kadircet updated this revision to Diff 246750. kadircet marked 3 inline comments as done. kadircet added a comment. - Add tests for non-identifier cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75166/new/ https://reviews.llvm.org/D75166 File

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

This revision was automatically updated to reflect the committed changes. Closed by commit rG2011d14296ee: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc… (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D75193: [clangd] Get rid of lexer usage in AST.cpp

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D75176: [clangd] Get rid of getBeginningOfIdentifier helper. Reposit

[PATCH] D75230: [clangd] Get rid of lexer usage in ObjCLocalizeStringLiteral tweak

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75230 Files: clang-tools-extra/clangd/

[PATCH] D75249: [clangd] Use tokenize instead of raw lexer in SourceCode/lex

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75249 Files: clang-tools-ext

[PATCH] D75259: [clangd] Get rid of unnecssary source transformations in locateMacroAt

kadircet created this revision. kadircet added reviewers: sammccall, hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. All callers are already passing spelling locations to locateMacroAt. Also there's no point at lo

[PATCH] D75176: [clangd] Get rid of getBeginningOfIdentifier helper

This revision was automatically updated to reflect the committed changes. kadircet marked 2 inline comments as done. Closed by commit rG2bb7774ddf00: [clangd] Get rid of getBeginningOfIdentifier helper (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D75176?vs=246729&id

[PATCH] D75193: [clangd] Get rid of lexer usage in AST.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGf31fc1043d38: [clangd] Get rid of lexer usage in AST.cpp (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75193/new/ https://reviews.ll

[PATCH] D75331: [clangd] Get rid of lexer usage in locateMacroAt

kadircet created this revision. kadircet added reviewers: sammccall, hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D75259: [clangd] Get rid of unnecssary source transformations

[PATCH] D75249: [clangd] Use tokenize instead of raw lexer in SourceCode/lex

kadircet updated this revision to Diff 247175. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75249/new/ https://reviews.llvm.org/D75249 Files: clang-tools-ex

[PATCH] D75249: [clangd] Use tokenize instead of raw lexer in SourceCode/lex

This revision was automatically updated to reflect the committed changes. Closed by commit rG98bb094c1e05: [clangd] Use tokenize instead of raw lexer in SourceCode/lex (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75249/new/

[PATCH] D75230: [clangd] Get rid of lexer usage in ObjCLocalizeStringLiteral tweak

This revision was automatically updated to reflect the committed changes. Closed by commit rG48fad110e08a: [clangd] Get rid of lexer usage in ObjCLocalizeStringLiteral tweak (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75230/

[PATCH] D75331: [clangd] Get rid of lexer usage in locateMacroAt

kadircet updated this revision to Diff 247213. kadircet added a comment. - Update forgotten call site Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75331/new/ https://reviews.llvm.org/D75331 Files: clang-tools-extra/clangd/Hover.cpp clang-tool

[PATCH] D75259: [clangd] Get rid of unnecssary source transformations in locateMacroAt

kadircet updated this revision to Diff 247438. kadircet marked an inline comment as done. kadircet added a comment. - Drop semicolon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75259/new/ https://reviews.llvm.org/D75259 Files: clang-tools-extr

[PATCH] D75331: [clangd] Get rid of lexer usage in locateMacroAt

kadircet updated this revision to Diff 247439. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75331/new/ https://reviews.llvm.org/D75331 Files: clang-tools-ex

[PATCH] D75429: [clangd] DefineOutline removes `override` specified from overridden methods.

kadircet added a comment. Thanks for working on this! A few comments on macro handling and coding style. Apart from that mostly needs more testing. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:216 + // Remove the virtual, override and final specifie

[PATCH] D75414: [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:96 Mangler.adjust(Cmd); - EXPECT_EQ("unknown-binary", Cmd.front()); + EXPECT_EQ("/clangd-test/fake/unknown-binary", Cmd.front()); i suppose you rather w

[PATCH] D75414: [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:145 +// Otherwise try to look it up on PATH. This won't change basename. +if (auto Absolute = llvm::sys::findProgramByName(Driver)) + Driver = Storage = *Absolute; --

[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. kadircet added a child revision: D75447: [clangd] Make use of token buffers in semantic highlighting. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D75447: [clangd] Make use of token buffers in semantic highlighting

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D75446: [clang][Syntax] Handle macro arguments in spelledForEx

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

kadircet added a comment. In D75429#1900709 , @njames93 wrote: > I'm not entirely sure how to get the spelledTokens working in a good macro > safe way? I don't really follow this comment, could you elaborate? `TB.expandedTokens` always refer to a subse

[PATCH] D75331: [clangd] Get rid of lexer usage in locateMacroAt

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ae2fc7a8bb3: [clangd] Get rid of lexer usage in locateMacroAt (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75331/new/ https://revi

[PATCH] D75259: [clangd] Get rid of unnecssary source transformations in locateMacroAt

This revision was automatically updated to reflect the committed changes. Closed by commit rGc24c89d6f0f5: [clangd] Get rid of unnecessary source transformations in locateMacroAt (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D75447: [clangd] Make use of token buffers in semantic highlighting

kadircet updated this revision to Diff 247612. kadircet added a comment. - Add forgetten macroid check, before looking for an macroargexpansion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75447/new/ https://reviews.llvm.org/D75447 Files: clan

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:244 +bool Any = false; +// Clang allows duplicating virtual specifiers so check for multiple +// occurances. njames93 wrote: > kadircet wrote: > > k

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

kadircet added a comment. In D75429#1901018 , @njames93 wrote: > - Fixed clang tidy warning, wont fix format as it's contradicting with the > style of the rest of the function I believe the formatting linter messages results from the fact that you are

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:232 +} +CharSourceRange DelRange = CharSourceRange::getTokenRange( +AttrTokens->front().location(), AttrTokens->back().location()); let's use `s

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

kadircet added a comment. In D75429#1901120 , @njames93 wrote: > In D75429#1901073 , @kadircet wrote: > > > In D75429#1901018 , @njames93 > > wrote: > > > > > - Fixed clang

[PATCH] D75474: [clangd] Get rid of getTokenRange helper

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. kadircet added a parent revision: D75447: [clangd] Make use of token buffers in semantic highli

[PATCH] D75447: [clangd] Make use of token buffers in semantic highlighting

kadircet updated this revision to Diff 247695. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75447/new/ https://reviews.llvm.org/D75447 Files: clang-tools-ex

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM with a few small comments, please address those before landing. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:262 + } + as

[PATCH] D75447: [clangd] Make use of token buffers in semantic highlighting

kadircet updated this revision to Diff 247805. kadircet added a comment. - Use spelledTokenAt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75447/new/ https://reviews.llvm.org/D75447 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp Ind

[PATCH] D75503: [clang][Syntax] Add spelledTokenAt helper to TokenBuffer

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75503 Files: clang/include/clang/Tooling/Syntax/Tokens.h clang/lib/Tooling/Syntax/Token

[PATCH] D75474: [clangd] Get rid of getTokenRange helper

kadircet updated this revision to Diff 247808. kadircet added a comment. - Also get rid of the call in collectmacros by using clang::Token's endlocation instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75474/new/ https://reviews.llvm.org/D75

[PATCH] D75474: [clangd] Get rid of getTokenRange helper

kadircet updated this revision to Diff 247849. kadircet marked 8 inline comments as done. kadircet added a comment. - Use getFileLoc instead of spelledForExpanded Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75474/new/ https://reviews.llvm.org/D75

[PATCH] D75474: [clangd] Get rid of getTokenRange helper

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:155 const SourceManager &SourceMgr = AST.getSourceManager(); - const FileEntry *F = SourceMgr.getFileEntryForID(SourceMgr.getFileID(TokLoc)); + auto Tok = syntax::tokenize(syntax::FileRange(Sourc

[PATCH] D75474: [clangd] Get rid of getTokenRange helper

kadircet updated this revision to Diff 247861. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75474/new/ https://reviews.llvm.org/D75474 Files: clang-tools-ex

[PATCH] D75474: [clangd] Get rid of getTokenRange helper

This revision was automatically updated to reflect the committed changes. Closed by commit rG3755039c99d8: [clangd] Get rid of getTokenRange helper (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75474/new/ https://reviews.llvm

[PATCH] D75447: [clangd] Make use of token buffers in semantic highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit rG3302af83ef79: [clangd] Make use of token buffers in semantic highlighting (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75447/new/ h

<    25   26   27   28   29   30   31   32   33   34   >