[PATCH] D48908: [clang-doc] Pass over function-internal declarations

juliehockett created this revision. juliehockett added reviewers: ioeric, lebedev.ri. juliehockett added a project: clang-tools-extra. Things declared internally to functions shouldn't be documented, and so bail early if encountered. https://reviews.llvm.org/D48908 Files: clang-tools-extra/c

[PATCH] D48909: [clang-doc] Update BitcodeReader to use llvm::Error

juliehockett created this revision. juliehockett added reviewers: ioeric, lebedev.ri. juliehockett added a project: clang-tools-extra. Replace booleans with the more descriptive llvm::Error or llvm::Expected https://reviews.llvm.org/D48909 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp

[PATCH] D49158: [clang-tidy] Fixing segfault when there's no IdentifierInfo

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Bug 36150 found a segfault on mac when a CXXRecordDecl has no IdentifierInfo, this fixes it. https://rev

[PATCH] D48395: Added PublicOnly flag

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. Remember to mark comments as done when they are. Otherwise, LGTM unless @ioeric has any concerns. https://reviews.llvm.org/D48395 __

[PATCH] D49268: [clang-doc] Create a script to generate tests

juliehockett added a comment. In https://reviews.llvm.org/D49268#1161268, @lebedev.ri wrote: > Did you meant to commit `clang-tools-extra/clang-doc/test_cases/` ? > I can't tell whether it is a temporary directory or not. It is, it's the code for the actual test cases that are generated (so th

[PATCH] D48395: Added PublicOnly flag

juliehockett added inline comments. Comment at: clang-tools-extra/test/clang-doc/yaml-module.cpp:14 +// CHECK-A: --- +// CHECK-A-NEXT: USR: '{{[0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

juliehockett added a comment. ping Comment at: clang-tools-extra/test/clang-doc/yaml-comments.cpp:30 +// CHECK: --- +// CHECK-NEXT: USR: '{{[0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 124397. juliehockett marked 7 inline comments as done. juliehockett added a comment. Added new tests and updated wording in warning. https://reviews.llvm.org/D40108 Files: clang-tidy/CMakeLists.txt clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuc

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 124421. juliehockett marked an inline comment as done. juliehockett added a comment. Updating docs https://reviews.llvm.org/D40108 Files: clang-tidy/CMakeLists.txt clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/DefaultArgumentsCheck.cpp c

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 124586. juliehockett marked an inline comment as done. juliehockett added a comment. Added missing newline https://reviews.llvm.org/D40108 Files: clang-tidy/CMakeLists.txt clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/DefaultArgumentsCheck

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett added a comment. If you could, that'd be great! Thank you! https://reviews.llvm.org/D40108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett created this revision. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to the Fuchsia module to warn when a class inheritsfrom multiple classes that are not pure virtual. See https://fuchsia.googlesource.com/zircon/+/master/

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 124662. juliehockett marked 6 inline comments as done. https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInheritanceCheck.cpp clang-tidy/fuchsia/MultipleIn

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 124669. juliehockett marked 4 inline comments as done. https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInheritanceCheck.cpp clang-tidy/fuchsia/MultipleIn

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 124675. juliehockett added a comment. Fixing typo https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInheritanceCheck.cpp clang-tidy/fuchsia/MultipleInher

[PATCH] D40611: Add has definition AST matcher

juliehockett created this revision. Herald added a subscriber: klimek. Adds AST matcher for the definition of a CXXRecordDecl. https://reviews.llvm.org/D40611 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 124772. juliehockett marked 11 inline comments as done. juliehockett added a comment. Moved AST matcher to ASTMatchers.h (see D40611 ), addressing comments. https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/C

[PATCH] D40611: Add has definition AST matcher

juliehockett added a comment. That'd be great -- thank you! I did request commit rights, so hopefully I'll be able to do it myself next time. https://reviews.llvm.org/D40611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 124853. juliehockett added a comment. Rebasing for updated Release Notes -- so much nicer :) https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInheritanceC

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett added inline comments. Comment at: docs/clang-tidy/checks/fuchsia-multiple-inheritance.rst:46 + +See the features disallowed in Fuchsia at https://fuchsia.googlesource.com/zircon/+/master/docs/cxx.md alexfh wrote: > This is not about the check, rath

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 124949. juliehockett added a comment. Updated warning wording to more accurately reflect guidelines https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInher

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 125000. juliehockett marked 4 inline comments as done. https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInheritanceCheck.cpp clang-tidy/fuchsia/MultipleIn

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 125215. juliehockett marked 7 inline comments as done. juliehockett added a comment. Updating tests https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInher

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:60 + // To be an interface, all base classes must be interfaces as well. + for (const auto &I : Node->bases()) { +const auto *Ty = I.getType()->getAs(); aaron.ba

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

juliehockett created this revision. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to the Fuchsia module to warn if classes are defined or created with virtual inheritance. See https://fuchsia.googlesource.com/zircon/+/master/docs/cxx.m

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 125449. juliehockett marked an inline comment as done. https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInheritanceCheck.cpp clang-tidy/fuchsia/MultipleIn

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett added inline comments. Comment at: test/clang-tidy/fuchsia-multiple-inheritance.cpp:48 +}; + +// Inherits from multiple concrete classes. aaron.ballman wrote: > The virtual base test cases I was thinking of were: > ``` > struct Base { virtual void fo

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

juliehockett updated this revision to Diff 125560. juliehockett marked 5 inline comments as done. https://reviews.llvm.org/D40813 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/VirtualInheritanceCheck.cpp clang-tidy/fuchsia/VirtualInhe

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett created this revision. juliehockett added a project: clang. Herald added a subscriber: mgorny. Setting up a basic frontend framework for a clang-doc tool. It creates a frontend action for traversing the AST to extract comments and declarations, with a flag to only extract documentat

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 126645. juliehockett marked 15 inline comments as done. juliehockett added a comment. Fixed comments and updated YAML output to use a StringMap. https://reviews.llvm.org/D41102 Files: tools/CMakeLists.txt tools/clang-doc/CMakeLists.txt tools/cla

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 126657. juliehockett added a comment. Updating formatting https://reviews.llvm.org/D41102 Files: tools/CMakeLists.txt tools/clang-doc/CMakeLists.txt tools/clang-doc/ClangDoc.cpp tools/clang-doc/ClangDoc.h tools/clang-doc/ClangDocReporter.cpp

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: tools/clang-doc/ClangDocReporter.cpp:228 + for (comments::Comment *Child : + llvm::make_range(C->child_begin(), C->child_end())) { +CommentInfo ChildCI; JonasToth wrote: > Extract range into utility metho

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 126797. juliehockett marked 10 inline comments as done. juliehockett added a comment. Fixing comments https://reviews.llvm.org/D41102 Files: tools/CMakeLists.txt tools/clang-doc/CMakeLists.txt tools/clang-doc/ClangDoc.cpp tools/clang-doc/ClangD

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

juliehockett updated this revision to Diff 126804. juliehockett marked an inline comment as done. juliehockett added a comment. Updated matcher to only match direct virtual base classes. https://reviews.llvm.org/D40813 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyM

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

juliehockett added inline comments. Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:34-36 + // CHECK-MESSAGES: [[@LINE-1]]:28: warning: constructing a class that inherits a virtual base class is disallowed [fuchsia-virtual-inheritance] + // CHECK-NEXT: D(int value

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 126814. juliehockett marked 5 inline comments as done. juliehockett added a comment. Fixing typos https://reviews.llvm.org/D41102 Files: tools/CMakeLists.txt tools/clang-doc/CMakeLists.txt tools/clang-doc/ClangDoc.cpp tools/clang-doc/ClangDoc.h

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: tools/clang-doc/ClangDocReporter.cpp:171 + CurrentCI->Name = getCommandName(C->getCommandID()); + for (unsigned i = 0, e = C->getNumArgs(); i > e; ++i) +CurrentCI->Args.push_back(C->getArgText(i)); JonasToth w

[PATCH] D66502: [clang-doc] Switch Generator::CreateResources to use llvm::Error

juliehockett created this revision. juliehockett added reviewers: DiegoAstiazaran, jakehehrlich. juliehockett added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. https://reviews.llvm.org/D66502 Files: clang-tools-extra/clang-doc/Generators.cpp clang-tools-extra/c

[PATCH] D66681: [clang-doc] Bump BitcodeWriter max line number to 32U

juliehockett created this revision. juliehockett added a reviewer: phosek. juliehockett added a project: clang-tools-extra. b43039 reports hitting the assert on a very large file, so bumping this to allow for larger files. https://reviews.llvm.org/D66681 Files: clang-tools-extra/clang-doc/Bi

[PATCH] D66681: [clang-doc] Bump BitcodeWriter max line number to 32U

This revision was automatically updated to reflect the committed changes. Closed by commit rL369811: [clang-doc] Bump BitcodeWriter max line number to 32U (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D66502: [clang-doc] Switch Generator::CreateResources to use llvm::Error

This revision was automatically updated to reflect the committed changes. Closed by commit rG72e1f7f960d5: [clang-doc] Switch Generator::CreateResources to use llvm::Error (authored by juliehockett). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66783: [clang-doc] Use llvm::createStringError and canonicalize error messages

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM -- thank you! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66783/new/ https://reviews.llvm.org/D66783 __

[PATCH] D113828: [clang-tidy] Fix false positives in `fuchsia-trailing-return` check involving deduction guides

juliehockett resigned from this revision. juliehockett added a comment. Apologies, i's been a good long while since I was active in this area. @phosek is the most likely to know who would be the best contact in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

juliehockett created this revision. juliehockett added reviewers: alexfh, mgorny. juliehockett added a project: clang-tools-extra. Adding the config initialization (the footer) to clang-tools-extra so that tests that use REQUIRES, UNSUPPORTED, and XFAIL based on platform or target triple work pr

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. After much digging, it looks like the lit config is never initialized in clang-tools-extra like it is in the other projects. REQUIRES et.al. work properly once that's in there (see D44708 ). Once that lands I'll reland this and *hop

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

This revision was automatically updated to reflect the committed changes. Closed by commit rL328060: [lit] Adding config initialization to lit tests in clang-tools-extra (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https://r

[PATCH] D44743: [clang-tidy] Marking hicpp-no-assembler-msvc unsupported on Windows

juliehockett created this revision. juliehockett added reviewers: zturner, phosek. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. After changes to lit.site.cfg.in, the test is now running (and failing) on windows, so temporarily marking it unsupported. See

[PATCH] D44743: [clang-tidy] Marking hicpp-no-assembler-msvc unsupported on Windows

juliehockett closed this revision. juliehockett added a comment. Committed in r328127. https://reviews.llvm.org/D44743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 139644. juliehockett added a comment. Rebasing and updating. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt clang-d

[PATCH] D44912: [clang-doc] Removing -Wunused-variable warning

juliehockett created this revision. juliehockett added reviewers: jakehehrlich, lebedev.ri, sammccall. juliehockett added a project: clang-tools-extra. Herald added subscribers: JDevlieghere, aprantl. Warning was appearing in release with debug info build, this removes it. https://reviews.llvm.o

[PATCH] D44912: [clang-doc] Removing -Wunused-variable warning

This revision was automatically updated to reflect the committed changes. Closed by commit rL328588: [clang-doc] Removing -Wunused-variable warning (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https://reviews.llvm.org/D44912

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 139869. juliehockett marked 13 inline comments as done. juliehockett added a comment. Addressing comments https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/Bitcode

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 139972. juliehockett marked 4 inline comments as done. juliehockett added a comment. Small fixes to address comments https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeReader.cpp:27 + assert(Record[0] == 20); + for (int I = 0, E = Record[0]; I < E; ++I) +Field[I] = Record[I + 1]; lebedev.ri wrote: > Ok, i don't understand what is going on here. > Where is th

[PATCH] D43667: [clang-doc] Implement a YAML generator

juliehockett updated this revision to Diff 140021. juliehockett added a comment. Updating to for adjustments to the internal representation & cleaning up duplication. https://reviews.llvm.org/D43667 Files: clang-doc/CMakeLists.txt clang-doc/Representation.h clang-doc/generators/CMakeList

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 140275. juliehockett added a comment. Fixing assert on vector size. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt

[PATCH] D45447: [clang-tidy] Adding alias for anon namespaces in header (fuchsia module)

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Adding alias to google-build-namespaces to the Fuchsia module (checks for anonymous namespaces in headers)

[PATCH] D45468: [clang-tidy] Adding Fuchsia checker for human-readable logging

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a checker to the Fuchsia module to flag instances of attempting to log the system's numerical

[PATCH] D43667: [clang-doc] Implement a YAML generator

juliehockett added a comment. In https://reviews.llvm.org/D43667#1062746, @Athosvk wrote: > I'm a bit late on this, but I'd say that YAML is usually not a 'final' > format. What would be the use-cases for this? And if is meant as an > alternative intermediate format, why not instead of having o

[PATCH] D45447: [clang-tidy] Adding alias for anon namespaces in header (fuchsia module)

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE329720: [clang-tidy] Adding alias for anon namespaces in header (fuchsia module) (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D45447?vs=141679&id=141874

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett created this revision. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. This adds a Fuchsia module to clang-tidy to warn for features that are disallowed. The following checks were added to the new module: fuchsia-default-arguments: Check

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 123231. juliehockett marked an inline comment as done. juliehockett edited the summary of this revision. https://reviews.llvm.org/D40108 Files: clang-tidy/CMakeLists.txt clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/DefaultArgumentsCheck.cpp

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 123278. juliehockett edited the summary of this revision. juliehockett added a comment. Updated docs https://reviews.llvm.org/D40108 Files: clang-tidy/CMakeLists.txt clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/DefaultArgumentsCheck.cpp

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett marked 2 inline comments as done. juliehockett added a comment. We do need to figure out what the right prefix for these checks is (whether fuchsia-* since they'll be used under the Fuchsia umbrella, zircon-* since the follow the Zircon section of the style guide linked above, or th

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 123446. juliehockett marked 2 inline comments as done. juliehockett added a comment. Updated docs and added tests to check class methods. https://reviews.llvm.org/D40108 Files: clang-tidy/CMakeLists.txt clang-tidy/fuchsia/CMakeLists.txt clang-tid

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett added a comment. In https://reviews.llvm.org/D40108#928224, @Eugene.Zelenko wrote: > > I think it should use project-specific prefix, since it's open source > project. Google may have different coding guidelines for other projects. Reasonable. It makes sense to consider it on a

[PATCH] D40261: Add default argument AST matcher

juliehockett created this revision. Herald added a subscriber: klimek. Adds AST matcher for declarations with default arguments. https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersNarrowingTest.

[PATCH] D40261: Add default argument AST matcher

juliehockett updated this revision to Diff 123646. juliehockett added a comment. Updated Registry.cpp to include new matcher. https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/A

[PATCH] D40261: Add default argument AST matcher

juliehockett updated this revision to Diff 123654. juliehockett added a comment. Removed spurious semicolons https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMat

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/DefaultArgumentsCheck.cpp:22 + // Calling a function which uses default arguments is disallowed. + Finder->addMatcher(cxxDefaultArgExpr().bind("stmt"), this); + // Declaring default parameters is disallowed. --

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 123677. juliehockett marked 8 inline comments as done. juliehockett added a comment. Moved AST matcher out to ASTMatchers.h (see D40261 ), fixing comments https://reviews.llvm.org/D40108 Files: clang-tidy/CMakeLists.

[PATCH] D40261: Add default argument AST matcher

juliehockett updated this revision to Diff 123701. juliehockett marked an inline comment as done. https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersNarrowin

[PATCH] D40261: Add default argument AST matcher

juliehockett added a comment. It'd be great if you could commit it -- I don't have commit privileges. Much appreciated! https://reviews.llvm.org/D40261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett added a comment. We're going to go with fuchsia-* for the module name, since the style applies to the broader project. Also, there may be zircon-specific checks at some point, so we want to leave the door open for that. Comment at: clang-tidy/fuchsia/DefaultArgum

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 123857. juliehockett marked 6 inline comments as done. juliehockett added a comment. Disabled the fix-it for `getDefaultArgRange()` that returns an empty range and for default args that come from a macro. https://reviews.llvm.org/D40108 Files: clang

[PATCH] D41546: [clang-tidy] Adding Fuchsia checker for statically constructed objects

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322310: [clang-tidy] Adding Fuchsia checker for statically constructed objects (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D41546?vs=129208&id=129505#t

[PATCH] D41963: [clang-tidy] Adding Fuchsia checker for thread local storage.

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, alexfh, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to the Fuchsia module to warn if thread-local storage is used. See https://fuc

[PATCH] D41963: [clang-tidy] Adding Fuchsia checker for thread local storage.

juliehockett updated this revision to Diff 129647. juliehockett marked 3 inline comments as done. juliehockett added a comment. Fixing comments https://reviews.llvm.org/D41963 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/ThreadLocalC

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, alexfh, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to the Fuchsia module to warn if a function has a trailing return. See https:/

[PATCH] D42120: [clang-tidy] Fixing Fuchsia overloaded operator warning message

juliehockett created this revision. juliehockett added a reviewer: alexfh. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Updating Fuchsia overloaded operator warning message for clarity. https://reviews.llvm.org/D42120 Files: clang-tidy/fuchsia/Overloa

[PATCH] D41708: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

juliehockett added a comment. The update to the message is also up for review here: D42120 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41708 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett updated this revision to Diff 130027. juliehockett marked an inline comment as done. juliehockett added a comment. Updating checker to not warn for trailing returns on lambdas. https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTi

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett added a comment. In https://reviews.llvm.org/D42116#977347, @aaron.ballman wrote: > Can you give some background on what problem the coding standard is trying to > avoid by banning this? For instance, if trailing return types are bad, are > deduced return types similarly bad, or ar

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett updated this revision to Diff 130058. juliehockett added a comment. Good point -- updating checker to allow trailing returns if the decltype specifier is used. https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp c

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett updated this revision to Diff 130200. juliehockett marked 8 inline comments as done. juliehockett added a comment. Updating matchers & fixing comments https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/

[PATCH] D42120: [clang-tidy] Fixing Fuchsia overloaded operator warning message

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322692: [clang-tidy] Fixing Fuchsia overloaded operator warning message (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D42120?vs=129998&id=130205#toc Rep

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett updated this revision to Diff 130242. juliehockett added a comment. Rebasing and updating decltypeType matcher https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/TrailingReturnCheck.cpp clang-

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

This revision was automatically updated to reflect the committed changes. Closed by commit rL322759: [clang-tidy] Adding Fuchsia checker for trailing returns (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https://reviews.llvm.

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322759: [clang-tidy] Adding Fuchsia checker for trailing returns (authored by juliehockett, committed by ). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42116 Files: clang-tidy/fuc

[PATCH] D41963: [clang-tidy] Adding Fuchsia checker for thread local storage.

juliehockett abandoned this revision. juliehockett added a comment. After some discussion, we decided that the false positive risk for non-kernel code isn't worth the check. https://reviews.llvm.org/D41963 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 130427. juliehockett added a comment. Rebasing from trunk https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInheritanceCheck.cpp clang-tidy/fuchsia/Multi

[PATCH] D42273: Add hasTrailingReturn AST matcher

juliehockett created this revision. juliehockett added a reviewer: aaron.ballman. Herald added a subscriber: klimek. Adds AST matcher for a FunctionDecl that has a trailing return type. https://reviews.llvm.org/D42273 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMat

[PATCH] D42273: Add hasTrailingReturn AST matcher

juliehockett updated this revision to Diff 130671. juliehockett marked 2 inline comments as done. juliehockett added a comment. Updating matcher and fixing semicolons https://reviews.llvm.org/D42273 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMa

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. juliehockett marked 4 inline comments as done. Closed by commit rCTE323011: [clang-tidy] Adding Fuchsia checker for multiple inheritance (aut

[PATCH] D42273: Add hasTrailingReturn AST matcher

juliehockett added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:5904 +return F->hasTrailingReturn(); + return false; +} lebedev.ri wrote: > There are no negative tests in the unittest that cover this false path. Is there a test case y

[PATCH] D42273: Add hasTrailingReturn AST matcher

juliehockett updated this revision to Diff 130908. juliehockett added a comment. Adding test case -- thank you for the advice! https://reviews.llvm.org/D42273 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/

[PATCH] D42273: Add hasTrailingReturn AST matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rC323158: Add hasTrailingReturn AST matcher (authored by juliehockett, committed by ). Repository: rC Clang https://reviews.llvm.org/D42273 Files: docs/LibASTMatchersReference.html include/clang/AST

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 131481. juliehockett added a comment. Herald added a subscriber: hintonda. Cleaning up a few unnecessary copyings https://reviews.llvm.org/D41102 Files: test/CMakeLists.txt test/Tooling/clang-doc-basic.cpp test/lit.cfg.py tools/CMakeLists.txt

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 132075. juliehockett edited the summary of this revision. juliehockett added a reviewer: jakehehrlich. juliehockett added a comment. 1. Updating and expanding tests 2. Updating output options (can now write to files) 3. Cleaning up pointers and whatnot

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 132306. juliehockett marked 47 inline comments as done. juliehockett added a comment. 1. Changing the traversal pattern from using `RecursiveASTVisitor` to using matchers instead. This will allow for a more flexible API (e.g. allowing access to individu

<    1   2   3   4   5   >