juliehockett added inline comments.

================
Comment at: clang-tidy/fuchsia/DefaultArgumentsCheck.cpp:22
+  // Calling a function which uses default arguments is disallowed.
+  Finder->addMatcher(cxxDefaultArgExpr().bind("stmt"), this);
+  // Declaring default parameters is disallowed.
----------------
aaron.ballman wrote:
> Isn't this case already covered by the other matcher? Or do you have system 
> header files which have default arguments and those functions are disallowed 
> by the style guide, but cannot be removed from the system header?
The latter -- there's a bunch of third-party code and the like that could have 
default arguments, but shouldn't be used like that in the project.


https://reviews.llvm.org/D40108



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to