[PATCH] D59974: [clang-doc] Build as clang_tool

This revision was automatically updated to reflect the committed changes. Closed by commit rL357274: [clang-doc] Build as clang_tool (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D59975: [fuchsia] Add clang-doc to Fuchsia distribution

juliehockett closed this revision. juliehockett added a comment. Closed and submitted in r357275 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59975/new/ https://reviews.llvm.org/D59975 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

juliehockett added a comment. This is also making our Mac builders fail on configuration, and looks like a directory wasn't included properly when a test moved to a subdirectory -- would you mind taking a look? The CMake command we're running is at the top of the attached log. CMake Error at

[PATCH] D52313: [clang-doc] Avoid parsing undefined base classes

juliehockett created this revision. juliehockett added reviewers: jakehehrlich, leonardchan, lebedev.ri. juliehockett added a project: clang-tools-extra. Don't try to parse base classes for declarations that are not definitions (segfaults, as there is no DefinitionData to access). https://revie

[PATCH] D52313: [clang-doc] Avoid parsing undefined base classes

juliehockett updated this revision to Diff 166526. juliehockett added a comment. Adding test case https://reviews.llvm.org/D52313 Files: clang-tools-extra/clang-doc/Serialize.cpp clang-tools-extra/test/clang-doc/bc-record.cpp clang-tools-extra/test/clang-doc/mapper-record.cpp clang-tool

[PATCH] D52753: [tooling] Create executor by name

juliehockett created this revision. juliehockett added a reviewer: ioeric. juliehockett added a project: clang. Allow creation of a ToolExecutor given a name and a set of parsed options. This is useful in the case where the calling tool always wants to use a particular non-default implementation

[PATCH] D52754: [clang-doc] Clean up Markdown output

juliehockett created this revision. juliehockett added reviewers: jakehehrlich, leonardchan, lebedev.ri. juliehockett added a project: clang-tools-extra. Make the output for the MDGenerator cleaner and more readable. https://reviews.llvm.org/D52754 Files: clang-tools-extra/clang-doc/MDGenerat

[PATCH] D52313: [clang-doc] Avoid parsing undefined base classes

This revision was automatically updated to reflect the committed changes. Closed by commit rL343703: [clang-doc] Avoid parsing undefined base classes (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52313?vs=1

[PATCH] D52847: [clang-doc] Handle anonymous namespaces

juliehockett updated this revision to Diff 168200. juliehockett marked 2 inline comments as done. https://reviews.llvm.org/D52847 Files: clang-tools-extra/clang-doc/Representation.cpp clang-tools-extra/clang-doc/Representation.h clang-tools-extra/clang-doc/Serialize.cpp clang-tools-extra/

[PATCH] D52754: [clang-doc] Clean up Markdown output

This revision was automatically updated to reflect the committed changes. Closed by commit rL343818: [clang-doc] Clean up Markdown output (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52754?vs=167851&id=168

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

juliehockett added a comment. Sorry for the delay! Comment at: clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsCallsCheck.cpp:24 + const auto *S = Result.Nodes.getNodeAs("stmt"); + if (S == nullptr) +return; Just `if (!S)` should be sufficient here.

[PATCH] D62970: [clang-doc] De-duplicate comments

juliehockett added a comment. Please add a test case to `unittests/clang-doc/MergeTest.cpp`. Comment at: clang-tools-extra/clang-doc/Representation.cpp:124-127 +bool IsCommentUnique = std::find(Description.begin(), Description.end(), + Co

[PATCH] D62970: [clang-doc] De-duplicate comments

juliehockett added a comment. In D62970#1533229 , @jakehehrlich wrote: > Actually if we can make Description a hash set that would be best. I think > using std::set would require an awkward < operator to be defined. There > should be standard ways of ge

[PATCH] D63367: [clang-doc] Add basic support for templates and typedef

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:244 // interface). + bool IsTypeDef = false; // Indicates if record was declared using typedef llvm::SmallVector Run

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363712: [clang-tidy] Split fuchsia-default-arguments (authored by juliehockett, committed by ). Herald added a project: LL

[PATCH] D63663: [clang-doc] Add html links to references

This revision was automatically updated to reflect the committed changes. Closed by commit rL365937: [clang-doc] Add html links to references (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D64669: [clang-doc] Fix failing tests on Windows

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64669/new/ https://reviews.llvm.org/D64669 ___ cfe-commits mailing list c

[PATCH] D64669: [clang-doc] Fix failing tests on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL365967: [clang-doc] Fix failing tests on Windows (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D64813: [clang-tidy] Exclude forward decls from fuchsia-multiple-inheritance

This revision was automatically updated to reflect the committed changes. Closed by commit rL366354: [clang-tidy] Exclude forward decls from fuchsia-multiple-inheritance (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett accepted this revision. juliehockett added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/D64539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett accepted this revision. juliehockett added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/D64539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D64938: [clang-doc] Add option for user provided stylesheets

juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:26 + ClangDocContext CDCtx; + CDCtx.UserStylesheets = {"../share/clang/clang-doc-default-stylesheet.css"}; + return CDCtx; Can you write a test for the

[PATCH] D65107: [clang-doc] Fix html entities in rendered text

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65107/new/ https://reviews.llvm.org/D65107 ___ cfe-commits mailing list c

[PATCH] D64958: [clang-doc] Fix link generation

juliehockett added a comment. Under what circumstances, exactly, is the path not set where you would need to create a link despite that? Is it only in the global namespace case? If so, could you special-case that and ignore other empty paths? Comment at: clang-tools-extra/cla

[PATCH] D65003: [clang-doc] Add index in each info html file

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Generators.h:28 + static Index genIndex(const std::vector> &Infos); + Add a comment here indicating that this should be created before calling any `generateDocForInfo`s. Also add a fi

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

juliehockett added a comment. Looks mostly good to me, with a small formatting thing Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:490 Out.emplace_back(llvm::make_unique(HTMLTag::TAG_H3, I.Name)); + Out.back()->Attributes.try_emplace("id", +

[PATCH] D64938: [clang-doc] Add option for user provided stylesheets

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64938/new/ https://reviews.llvm.org/D64938 ___ cfe-commits mailing list c

[PATCH] D65306: [clang-doc] Fix failing tests on Windows

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. Make sure you update the other stylesheet patch, as well, before landing that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65306/new/ https://reviews.llvm.org/D65306

[PATCH] D65309: [clang-format] Fix style of css file paths

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM after adding a comment to explain Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:234 llvm::sys::path::filename(FilePa

[PATCH] D65628: [clang-doc] Parallelize reducing phase

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:72 +static llvm::cl::opt ThreadCount( +"thread-count", Can we use the pre-existing concurrency flag instead (https://github.com/llvm/llvm-project/blob/91e5cdf

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:377-378 + "href", (FileURL + "#" + std::to_string(L.LineNumber)).str()); + Node->Children.emplace_back(std::move(LocNumberNode)); + Node->Children.emplace_back(llvm::make_unique("

[PATCH] D64958: [clang-doc] Fix link generation

juliehockett accepted this revision. juliehockett added a comment. LGTM with a comment correction Comment at: clang-tools-extra/clang-doc/Representation.h:117 Reference(llvm::StringRef Name) : Name(Name) {} - Reference(llvm::StringRef Name, StringRef Path) : Name(Name), Pat

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:47-52 + + Namespaces + Records + Functions + OneFunction + DiegoAstiazaran wrote: > juliehockett wrote: > > Formatting is a bit weird for sublists > Fi

[PATCH] D65690: [clang-doc] Add index in each info html file

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Generators.cpp:79 + +bool Generator::createResources(ClangDocContext &CDCtx) { + std::error_code OK; Why is this implementation in the generic Generator? It's fairly HTML-specific -- ne

[PATCH] D65622: [clang-doc] Update documentation

juliehockett added a comment. Sorry for the delayed review, but a few things I caught :) Also, please make sure to update the the release notes/flag documentation for the patches you have in progress that add features or flags. Comment at: clang-tools-extra/trunk/docs/Release

[PATCH] D65690: [clang-doc] Add index in each info html file

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65690/new/ https://reviews.llvm.org/D65690 ___ cfe-commits mailing list c

[PATCH] D65827: [clang-doc] Fix paths of js in import tags

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM (let's make sure we double check this next time) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65827/new/ https://reviews.llvm.org/D65827 _

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

juliehockett added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65030/new/ https://reviews.llvm.org/D65030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:385 +SourceRoot(SourceRoot), UserStylesheets(UserStylesheets), +JsScripts(JsScripts) { +if (!RepositoryUrl.empty()) { Move to .cpp file (now that it h

[PATCH] D65628: [clang-doc] Parallelize reducing phase

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM (after comment nit addressed) Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:249 + Error = false; + llvm::ThreadPool Pool(ExecutorConcurrenc

[PATCH] D65915: [clang-doc] Protect Index with mutex during reducing and generation stage

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65915/new/ https://reviews.llvm.org/D65915 ___ cfe-commits mailing list c

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/ https://reviews.llvm.org/D65483 ___ cfe-commits mailing list c

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250 + // The resulting path is "../../../A/B/D" instead of a "../D". It is correct + // but it would be better to have the shorter version. StringRef Dir = Directory; --

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

juliehockett accepted this revision. juliehockett marked an inline comment as done. juliehockett added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250 + // The resulting path is "../../../A/B/D" ins

[PATCH] D66151: [clang-doc] Fix bitcode writer

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. One comment then LGTM Comment at: clang-tools-extra/clang-doc/Serialize.cpp:507 Reference{ParentUSR, Parent->getNameAsString(), InfoType::IT_record}; - Fu

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeWriter.h:33 // BitCodeConstants, though they can be added without breaking it. static const unsigned VersionNumber = 2; I definitely haven't been particularly good about bumpin

[PATCH] D66298: [clang-doc] Fix records in global namespace

juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:299 RecordInfo *G = InfoAsRecord(Infos[2].get()); - RecordInfo ExpectedG(EmptySID, /*Name=*/"G", /*Path=*/"E"); + RecordInfo ExpectedG(EmptySID, /*Name=*/"G", /*Path=*/"Gl

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:487-489 +static std::unique_ptr +genFileMainNode(StringRef InfoPath, +std::vector> &MainContentInnerNodes, Would you be able to briefly comment on each o

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66353/new/ https://reviews.llvm.org/D66353 ___ cfe-commits mailing list c

[PATCH] D66378: [clang-doc] Fix casting not working in gcc 5.4.0

juliehockett added a comment. LGTM, for posterity Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66378/new/ https://reviews.llvm.org/D66378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D63180: [clang-doc] Adds HTML generator

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:87 +std::string CloseTag = I.SelfClosing ? "/>" : ">"; +writeLine("<" + I.Name + Attrs.str() + CloseTag, OS); + } else if (I.Kind == "HTMLEndTagComment") { You

[PATCH] D63663: [clang-doc] Add html links to the parents of a RecordInfo

juliehockett added a comment. General design thought: could we move the path name construction to `Serialize.cpp`? Essentially, move the logic that builds the path name from the namespaces and name to the serialize step (you'll have to add the `OutDirectory` to the `ClangDocContext` so that you

[PATCH] D63666: [clang-doc] Add templates to HTML generator

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:59 + Items += + applyHTMLTemplate(HTMLTemplates::BlockItem, M.str().str().c_str()); +} Put `FIXME: Transition Members from llvm::SmallString to std::st

[PATCH] D63734: Update CODE_OWNERS.txt for clang-doc

juliehockett created this revision. juliehockett added a reviewer: klimek. juliehockett added a project: clang-tools-extra. https://reviews.llvm.org/D63734 Files: clang-tools-extra/CODE_OWNERS.TXT Index: clang-tools-extra/CODE_OWNERS.TXT ===

[PATCH] D63367: [clang-doc] Add basic support for templates and typedef

This revision was automatically updated to reflect the committed changes. Closed by commit rL364222: [clang-doc] Add basic support for templates and typedef (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63663: [clang-doc] Add html links to the parents of a RecordInfo

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:21 namespace { Eugene.Zelenko wrote: > Anonymous namespace is used for functions when LLVM Coding Guidelines tells > using static for same purpose. Actually, since

[PATCH] D63734: Update CODE_OWNERS.txt for clang-doc

juliehockett added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63734/new/ https://reviews.llvm.org/D63734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D63857: [clang-doc] Structured HTML generator

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:21 +class HTMLTag { +public: Put the class definitions in an anonymous namespace (https://llvm.org/docs/CodingStandards.html#anonymous-namespaces)

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:341 + Parent->USR = ParentUSR; + Parent->ChildNamespaces.emplace_back(I->USR, I->Name, InfoType::IT_namespace); + return {std::unique_ptr{std::move(I)}, You're probably

[PATCH] D52847: [clang-doc] Handle anonymous namespaces

juliehockett updated this revision to Diff 206979. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52847/new/ https://reviews.llvm.org/D52847 Files: clang-tools-extra/clang-doc/Representation.cpp clang-tools-extra/clang-doc/Representation.h clang-tools-extra/clang-doc/Serialize.cpp

[PATCH] D63734: Update CODE_OWNERS.txt for clang-doc

This revision was automatically updated to reflect the committed changes. Closed by commit rL364663: Update CODE_OWNERS.txt for clang-doc (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D62970: [clang-doc] De-duplicate comments and locations

This revision was automatically updated to reflect the committed changes. Closed by commit rL364670: [clang-doc] De-duplicate comments and locations (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D52847: [clang-doc] Handle anonymous namespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rL364674: [clang-doc] Handle anonymous namespaces (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:366 + + if (I->Namespace[0].RefType == InfoType::IT_namespace) { +auto Parent = llvm::make_unique(); Can you make this a switch statement, doing the appropriate things

[PATCH] D63180: [clang-doc] Adds HTML generator

juliehockett added a comment. In D63180#1562982 , @jakehehrlich wrote: > I'm getting confused in all the different patches. I reviewed the HTML > generator one like yesterday and was awaiting changes. Doesn't this do the > same thing? Diego, why don't

[PATCH] D63962: [clang-doc] Fix segfault in comment sorting

juliehockett created this revision. juliehockett added a reviewer: jakehehrlich. juliehockett added a project: clang-tools-extra. https://reviews.llvm.org/D63962 Files: clang-tools-extra/clang-doc/Representation.h Index: clang-tools-extra/clang-doc/Representation.h ===

[PATCH] D63962: [clang-doc] Fix segfault in comment sorting

This revision was automatically updated to reflect the committed changes. Closed by commit rL364949: [clang-doc] Fix segfault in comment sorting (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

This revision was automatically updated to reflect the committed changes. Closed by commit rL364963: [clang-doc] Serialize child namespaces and records (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[PATCH] D64381: Update libc++ include path detection to use VFS on Linux

juliehockett created this revision. juliehockett added reviewers: dlj, phosek. Herald added a reviewer: EricWF. The DetectLibcxxIncludePath function had been using llvm::sys::fs::directory_iterator, and this updates it to use llvm::vfs::directory_iterator. https://reviews.llvm.org/D64381 File

[PATCH] D63857: [clang-doc] Add a structured HTML generator

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM, unless Jake has further comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:503 + } + // std::move(Nodes.begin(), Nodes.end(), std::back_

[PATCH] D63663: [clang-doc] Add html links to references

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:206 + llvm::SmallString<128> Path = Type.Path; + ::llvm::sys::path::append(Path, Type.Name + ".html"); + return genLink(Type.Name, Path); You shouldn't need the prefi

[PATCH] D63663: [clang-doc] Add html links to references

juliehockett added a comment. I've also just noticed that the YAML generator is missing from this -- could you add the `Path` fields to hat output as well? Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:213 + llvm::SmallString<128> Path = Type.Path; + llvm::sys::p

[PATCH] D64381: Update libc++ include path detection to use VFS on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL365682: Update libc++ include path detection to use VFS on Linux (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63857: [clang-doc] Add a structured HTML generator

This revision was automatically updated to reflect the committed changes. Closed by commit rL365687: [clang-doc] Add a structured HTML generator (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:246-271 +auto StylesheetPathWrite = getInfoOutputFile( +OutDirectory, "", "clang-doc-default-stylesheet", ".css"); +if (!StylesheetPathWrite) { + llvm::errs() <<

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:247 +auto StylesheetPathWrite = getInfoOutputFile( +OutDirectory, "", "clang-doc-default-stylesheet", ".css"); +if (!StylesheetPathWrite) { Eventuall

[PATCH] D63663: [clang-doc] Add html links to references

juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:110-113 +Inherits from +F +, +G This text should be rendered inline Comment at: clang-tools-extra/unittests/clang-doc/

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:242 + // Generate css stylesheet + if (Format == "html") { On second thought, can you create a virtual method to the Generator along the lines of `Generator::cr

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

juliehockett created this revision. juliehockett added reviewers: alexfh, hokein. juliehockett added a project: clang-tools-extra. This removes the else clause that adds a default `-header-filter` flag to clang-tidy invocations from the run_clang_tidy.py script. If this clause is present, any He

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

juliehockett abandoned this revision. juliehockett added a comment. @hintonda Aha so it is :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62157/new/ https://reviews.llvm.org/D62157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D55848: [clang-tidy] Add export-fixes flag to clang-tidy-diff

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, alexfh. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. So that you can export the fixes generated. https://reviews.llvm.org/D55848 Files: clang-tools-extra/clang-ti

[PATCH] D55848: [clang-tidy] Add export-fixes flag to clang-tidy-diff

This revision was automatically updated to reflect the committed changes. Closed by commit rL349930: [clang-tidy] Add export-fixes flag to clang-tidy-diff (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55848

[PATCH] D52847: [clang-doc] Handle anonymous namespaces

juliehockett updated this revision to Diff 180182. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52847/new/ https://reviews.llvm.org/D52847 Files: clang-tools-extra/clang-doc/Representation.cpp clang-tools-extra/clang-doc/Representation.h clang-tools-extra/clang-doc/Serialize.cpp

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 144011. juliehockett marked 17 inline comments as done. juliehockett added a comment. Reorganizing and streamlining, particularly in decoupling the reader from the reduce process and redesigning a bit to allow for more flexible reducing. Currently imple

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett marked 5 inline comments as done. juliehockett added inline comments. Comment at: clang-doc/BitcodeReader.h:59 + + void storeData(llvm::SmallVectorImpl &Field, llvm::StringRef Blob); + void storeData(bool &Field, llvm::StringRef Blob); sammccall wr

[PATCH] D46281: [clang-doc] Attaching a name to reference data

juliehockett created this revision. juliehockett added reviewers: sammccall, jakehehrlich, lebedev.ri. juliehockett added a project: clang-tools-extra. This adds the name of the referenced decl, in addition to its USR, to the saved data, so that the backend can look at an info in isolation and st

[PATCH] D46281: [clang-doc] Attaching a name to reference data

juliehockett updated this revision to Diff 144615. juliehockett marked 3 inline comments as done. juliehockett added a comment. Addressing comments https://reviews.llvm.org/D46281 Files: clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/Representation.h clang-doc/Serialize

[PATCH] D46281: [clang-doc] Attaching a name to reference data

juliehockett updated this revision to Diff 144747. juliehockett marked 3 inline comments as done. juliehockett added a comment. Addressing a fixme and updating tests https://reviews.llvm.org/D46281 Files: clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/Representation.h c

[PATCH] D46281: [clang-doc] Attaching a name to reference data

juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:382 + emitRecord(R.USR, REFERENCE_USR); + emitRecord(R.Name, REFERENCE_NAME); + emitRecord((unsigned)R.RefType, REFERENCE_TYPE); lebedev.ri wrote: > >>! In D46281#1083806, @lebedev.ri

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 144948. juliehockett marked 17 inline comments as done. juliehockett added a comment. Cleaning up and clarifying the merging process, and addressing comments https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader

[PATCH] D46281: [clang-doc] Attaching a name to reference data

This revision was automatically updated to reflect the committed changes. juliehockett marked 2 inline comments as done. Closed by commit rL331539: [clang-doc] Attaching a name to reference data (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed pri

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added inline comments. Comment at: clang-doc/Representation.cpp:53 + move(Namespace, std::move(Other.Namespace)); + extend(Description, std::move(Other.Description)); + return true; sammccall wrote: > is plain concatenation of comments what you wa

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/RestrictIncludesCheck.cpp:75 +for (const auto &Include : FileDirectives) { + auto D = Check.diag(Include.Loc, "restricted include found"); + aaron.ballman wrote: > I believe this check wi

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett updated this revision to Diff 145547. juliehockett marked 9 inline comments as done. juliehockett edited the summary of this revision. juliehockett added a comment. Sorry for the delay in updating this -- check now restricts includes to a whitelist, rather than a blacklist, and only

[PATCH] D48710: [CMake] Don't build Linux targets on Darwin in Fuchsia toolchain

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D48710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D48341: [clang-doc] Adding a second reduce pass

juliehockett updated this revision to Diff 153787. juliehockett marked 12 inline comments as done. juliehockett added a comment. Refactoring second reduce code into the library, and adding bitcode reader/writer support https://reviews.llvm.org/D48341 Files: clang-tools-extra/clang-doc/Bitcod

[PATCH] D48341: [clang-doc] Adding a second reduce pass

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:249 +if (EnclosingScope.get().RefType == doc::InfoType::IT_function) + continue; + ioeric wrote: > Are symbols declared in functions indexed by the tool

[PATCH] D48395: Added PublicOnly flag

juliehockett added a reviewer: ioeric. juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/ClangDoc.h:27 +struct ClangDocContext { +tooling::ExecutionContext *ECtx; Can we put this in `Representation.h`? Here, you have a potential ci

[PATCH] D48395: Added PublicOnly flag

juliehockett added a comment. Please run clang-format and clang-tidy on the patch. Comment at: clang-tools-extra/clang-doc/ClangDoc.cpp:25 #include "clang/Frontend/FrontendActions.h" +#include "Representation.h" Sort includes (this should be at the top) ==

[PATCH] D48395: Added PublicOnly flag

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:322-324 + if(PublicOnly && ! isPublic(D->getAccess(), D->getLinkageInternal())){ +return ""; + } anniecherk wrote: > juliehockett wrote: > > Since this is the same for

<    1   2   3   4   5   >