juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land.
LGTM after adding a comment to explain ================ Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:234 llvm::sys::path::filename(FilePath)); + llvm::sys::path::native(StylesheetPath, llvm::sys::path::Style::posix); LinkNode->Attributes.try_emplace("href", StylesheetPath); ---------------- Comment here why you're explicitly using posix (i.e. HTML uses posix-style paths) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65309/new/ https://reviews.llvm.org/D65309 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits