[clang] b4c0307 - Fix clang-interpreter build after 2487db1f286222e2501c2fa8e8244eda13f6afc3

2021-08-05 Thread Jon Roelofs via cfe-commits
Author: Jon Roelofs Date: 2021-08-05T10:05:36-07:00 New Revision: b4c0307d598004cfd96c770d2a4a84a37c838ba9 URL: https://github.com/llvm/llvm-project/commit/b4c0307d598004cfd96c770d2a4a84a37c838ba9 DIFF: https://github.com/llvm/llvm-project/commit/b4c0307d598004cfd96c770d2a4a84a37c838ba9.diff L

[clang] a24644b - Revert "Run non-filechecked commands in update_cc_test_checks.py"

2021-03-08 Thread Jon Roelofs via cfe-commits
Author: Jon Roelofs Date: 2021-03-08T17:26:24-08:00 New Revision: a24644bb1ce09b40c2d751569dd5bb37ea9c995d URL: https://github.com/llvm/llvm-project/commit/a24644bb1ce09b40c2d751569dd5bb37ea9c995d DIFF: https://github.com/llvm/llvm-project/commit/a24644bb1ce09b40c2d751569dd5bb37ea9c995d.diff L

[clang] [Clang][CodeGen] Add __builtin_bcopy (PR #67130)

2023-09-22 Thread Jon Roelofs via cfe-commits
@@ -3703,6 +3703,20 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, Builder.CreateMemSet(Dest, Builder.getInt8(0), SizeVal, false); return RValue::get(nullptr); } + + case Builtin::BIbcopy: jroelofs wrote: Is thi

[clang] [Clang][CodeGen] Add __builtin_bcopy (PR #67130)

2023-09-22 Thread Jon Roelofs via cfe-commits
@@ -3703,6 +3703,20 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, Builder.CreateMemSet(Dest, Builder.getInt8(0), SizeVal, false); return RValue::get(nullptr); } + + case Builtin::BIbcopy: jroelofs wrote: never

[clang] [Clang][CodeGen] Add __builtin_bcopy (PR #67130)

2023-09-22 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs resolved https://github.com/llvm/llvm-project/pull/67130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clang][CodeGen] Add __builtin_bcopy (PR #67130)

2023-09-22 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs resolved https://github.com/llvm/llvm-project/pull/67130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Add __builtin_bcopy (PR #67130)

2023-09-22 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ObjC] Add optionality to property attribute strings. (PR #66507)

2023-09-26 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs closed https://github.com/llvm/llvm-project/pull/66507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1a135bc - [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets.

2023-08-14 Thread Jon Roelofs via cfe-commits
Author: Jon Roelofs Date: 2023-08-14T16:22:48-07:00 New Revision: 1a135bceb66b2d448ba4363af2f8626b6e4110bd URL: https://github.com/llvm/llvm-project/commit/1a135bceb66b2d448ba4363af2f8626b6e4110bd DIFF: https://github.com/llvm/llvm-project/commit/1a135bceb66b2d448ba4363af2f8626b6e4110bd.diff L

[clang] 1e4d612 - [CMake] Add a few more missing dependencies on ClangDriverOptions

2023-08-15 Thread Jon Roelofs via cfe-commits
Author: Jon Roelofs Date: 2023-08-15T16:56:31-07:00 New Revision: 1e4d6122cda6529781ecf467c2ae84e5dd41acdf URL: https://github.com/llvm/llvm-project/commit/1e4d6122cda6529781ecf467c2ae84e5dd41acdf DIFF: https://github.com/llvm/llvm-project/commit/1e4d6122cda6529781ecf467c2ae84e5dd41acdf.diff L

[clang] [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (PR #69078)

2023-10-17 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/69078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ed83797 - [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

2023-08-01 Thread Jon Roelofs via cfe-commits
Author: Jon Roelofs Date: 2023-08-01T18:02:00-07:00 New Revision: ed83797f3cbfc8fb2a1af63542f97d7ec1d5505a URL: https://github.com/llvm/llvm-project/commit/ed83797f3cbfc8fb2a1af63542f97d7ec1d5505a DIFF: https://github.com/llvm/llvm-project/commit/ed83797f3cbfc8fb2a1af63542f97d7ec1d5505a.diff L

[clang] 2fb1c10 - cmake: add missing dependencies on ClangDriverOptions tablegen

2023-08-04 Thread Jon Roelofs via cfe-commits
Author: Jon Roelofs Date: 2023-08-04T10:27:19-07:00 New Revision: 2fb1c1082c01ddf9b2531083196ff2dace1fdab7 URL: https://github.com/llvm/llvm-project/commit/2fb1c1082c01ddf9b2531083196ff2dace1fdab7 DIFF: https://github.com/llvm/llvm-project/commit/2fb1c1082c01ddf9b2531083196ff2dace1fdab7.diff L

[clang] 3d756c3 - cmake: add missing dependencies on ClangDriverOptions tablegen

2023-08-04 Thread Jon Roelofs via cfe-commits
Author: Jon Roelofs Date: 2023-08-04T10:43:31-07:00 New Revision: 3d756c32cdf005d0f4c05f561fec4a37b64b7ddd URL: https://github.com/llvm/llvm-project/commit/3d756c32cdf005d0f4c05f561fec4a37b64b7ddd DIFF: https://github.com/llvm/llvm-project/commit/3d756c32cdf005d0f4c05f561fec4a37b64b7ddd.diff L

[clang] f5326fb - clang: add a missing dependency on ClangDriverOptions

2023-07-11 Thread Jon Roelofs via cfe-commits
Author: Jon Roelofs Date: 2023-07-11T10:07:09-07:00 New Revision: f5326fbe12d7ed006262d35c90803d3dd3907f82 URL: https://github.com/llvm/llvm-project/commit/f5326fbe12d7ed006262d35c90803d3dd3907f82 DIFF: https://github.com/llvm/llvm-project/commit/f5326fbe12d7ed006262d35c90803d3dd3907f82.diff L

Re: [PATCH] D73904: [clang] stop baremetal driver to append .a to lib

2020-02-12 Thread Jon Roelofs via cfe-commits
> I'm also not sure if `-L` is a feature that is relied upon at the moment by anybody that uses the baremetal driver Unlikely, IMO. There aren’t that many users of this stuff yet, and it’s still quite rough around the edges in comparison to the GNU toolchain. Also, the compiler support libraries r

Re: [PATCH] D41316: [libcxx] Allow random_device to be built optionally

2018-04-06 Thread Jon Roelofs via cfe-commits
> the targets where you would want to use this can't run the libcxx testsuite anyway (because they don't have an operating system to run the test programs under). I used to run libcxx tests for an arm baremetal toolchain I was building via semihosted QEMU. It was awkward and slow (especially for

[clang-tools-extra] b857645 - [clangd] Fix missing dependency on clang/Driver/Options.inc's tblgen target

2023-05-06 Thread Jon Roelofs via cfe-commits
Author: Jon Roelofs Date: 2023-05-06T10:11:39-07:00 New Revision: b8576450c7c7469483fe01c3129071b307b7e6b5 URL: https://github.com/llvm/llvm-project/commit/b8576450c7c7469483fe01c3129071b307b7e6b5 DIFF: https://github.com/llvm/llvm-project/commit/b8576450c7c7469483fe01c3129071b307b7e6b5.diff L

Re: [PATCH] [scan-build] Add an option to skip overriding CC and CXX make vars

2018-01-19 Thread Jon Roelofs via cfe-commits
Sorry, I forgot to commit this before heading off on vacation. I'll be back on monday. Jon On Fri, Jan 19, 2018 at 1:53 AM, Paul Fertser wrote: > Hello Jonathan, > > On Mon, Jan 15, 2018 at 08:36:03AM -0700, Jonathan Roelofs wrote: > > LGTM. Would you like me to commit it for you? > > Yes, ple

Re: [PATCH] [analyzer] Fix -x language argument for C preprocessed sources

2018-01-29 Thread Jon Roelofs via cfe-commits
r323664 On Mon, Jan 15, 2018 at 8:35 AM, Jonathan Roelofs wrote: > LGTM. Would you like me to commit it for you? > > > Jon > > > On 1/14/18 3:50 AM, Paul Fertser wrote: > >> clang's -x option doesn't accept c-cpp-output as a language (even though >> 463eb6ab was merged, the driver still doesn't

[clang] bad error message on incorrect string literal #18079 (PR #81670)

2024-02-14 Thread Jon Roelofs via cfe-commits
jroelofs wrote: Feel free to keep it open and push more commits to the branch. https://github.com/llvm/llvm-project/pull/81670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bad error message on incorrect string literal #18079 (PR #81670)

2024-02-14 Thread Jon Roelofs via cfe-commits
@@ -102,6 +102,9 @@ def err_raw_delim_too_long : Error< def err_invalid_char_raw_delim : Error< "invalid newline character in raw string delimiter" "; use PREFIX( )PREFIX to delimit raw string">; +def err_invalid_nexline_raw_delim : Error< jroelofs wrote:

[clang] bad error message on incorrect string literal #18079 (PR #81670)

2024-02-14 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,5 @@ +// RUN: not %clang_cc1 -E %s 2>&1 | grep 'error: invalid newline character in raw string delimiter; use PREFIX( )PREFIX to delimit raw string' jroelofs wrote: Please use `-fsyntax-only -verify` instead of `grep` for checking diagnostics. There

[clang] bad error message on incorrect string literal #18079 (PR #81670)

2024-02-14 Thread Jon Roelofs via cfe-commits
@@ -2270,10 +2270,12 @@ bool Lexer::LexRawStringLiteral(Token &Result, const char *CurPtr, const char *PrefixEnd = &CurPtr[PrefixLen]; if (PrefixLen == 16) { Diag(PrefixEnd, diag::err_raw_delim_too_long); - } else { + } else if (*PrefixEnd != '\n'

[clang] bad error message on incorrect string literal #18079 (PR #81670)

2024-02-14 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,5 @@ +// RUN: not %clang_cc1 -E %s 2>&1 | grep 'error: invalid newline character in raw string delimiter; use PREFIX( )PREFIX to delimit raw string' jroelofs wrote: mind also adding a test for the `err_invalid_char_raw_delim` case while you're here?

[clang] bad error message on incorrect string literal #18079 (PR #81670)

2024-02-14 Thread Jon Roelofs via cfe-commits
@@ -2270,9 +2270,11 @@ bool Lexer::LexRawStringLiteral(Token &Result, const char *CurPtr, const char *PrefixEnd = &CurPtr[PrefixLen]; if (PrefixLen == 16) { Diag(PrefixEnd, diag::err_raw_delim_too_long); - } else { + } else if (*PrefixEnd != '\n')

[clang] bad error message on incorrect string literal #18079 (PR #81670)

2024-02-14 Thread Jon Roelofs via cfe-commits
@@ -100,7 +100,10 @@ def err_raw_delim_too_long : Error< "raw string delimiter longer than 16 characters" "; use PREFIX( )PREFIX to delimit raw string">; def err_invalid_char_raw_delim : Error< - "invalid character '%0' character in raw string delimiter" + "invalid newlin

[clang] [clang][CodeGen] Add missing error check (PR #81777)

2024-02-14 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/81777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bad error message on incorrect string literal #18079 (PR #81670)

2024-02-14 Thread Jon Roelofs via cfe-commits
@@ -2270,9 +2270,11 @@ bool Lexer::LexRawStringLiteral(Token &Result, const char *CurPtr, const char *PrefixEnd = &CurPtr[PrefixLen]; if (PrefixLen == 16) { Diag(PrefixEnd, diag::err_raw_delim_too_long); - } else { + } else if (*PrefixEnd != '\n')

[clang] bad error message on incorrect string literal #18079 (PR #81670)

2024-02-14 Thread Jon Roelofs via cfe-commits
@@ -2270,9 +2270,11 @@ bool Lexer::LexRawStringLiteral(Token &Result, const char *CurPtr, const char *PrefixEnd = &CurPtr[PrefixLen]; if (PrefixLen == 16) { Diag(PrefixEnd, diag::err_raw_delim_too_long); - } else { + } else if (*PrefixEnd != '\n')

[clang] bad error message on incorrect string literal #18079 (PR #81670)

2024-02-14 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,5 @@ +// RUN: %clang_cc1 -E -fsyntax-only -verify %s + +// expected-error@+2{{invalid character ')' character in raw string delimiter; use PREFIX( )PREFIX to delimit raw string}} jroelofs wrote: This has the old spelling of that diagnostic. Also, mig

[clang] bad error message on incorrect string literal #18079 (PR #81670)

2024-02-15 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,5 @@ +// RUN: %clang_cc1 -E -fsyntax-only -verify %s + +// expected-error@+2{{invalid character ')' character in raw string delimiter; use PREFIX( )PREFIX to delimit raw string}} jroelofs wrote: Before this change, the message used to say `character '

[clang] bad error message on incorrect string literal #18079 (PR #81670)

2024-02-15 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. LGTM. Let me know if you need me to press the "merge" button for you. https://github.com/llvm/llvm-project/pull/81670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [clang] Define SwiftInfo for RISCVTargetCodeGenInfo (PR #82152)

2024-02-19 Thread Jon Roelofs via cfe-commits
jroelofs wrote: > Can this be tested? I don't know what the affects are. Might be as simple as adding another `RUN:` line to `clang/test/CodeGenCXX/arm-swiftcall.{c,cpp}` with a riscv triple. https://github.com/llvm/llvm-project/pull/82152 ___ cfe-co

[clang] [Driver] Improve error when a compiler-rt library is not found (PR #81037)

2024-02-20 Thread Jon Roelofs via cfe-commits
@@ -44,9 +43,8 @@ // CHECK-V6M-DEFAULTCXX: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]" // CHECK-V6M-DEFAULTCXX: ld{{(.exe)?}}" "{{.*}}.o" "-Bstatic" "-EL" // CHECK-V6M-DEFAULTCXX-SAME: "-L{{[^"]*}}{{[/\\]+}}Inputs{{[/\\]+}}baremetal_arm{{[/\\]+}}lib" -// CHECK-V6M-DEFAULTCXX-SAME

[clang] [compiler-rt] [AArch64] Implement __builtin_cpu_supports, compiler-rt tests. (PR #82378)

2024-02-20 Thread Jon Roelofs via cfe-commits
@@ -14025,6 +14028,19 @@ Value *CodeGenFunction::EmitX86CpuInit() { return Builder.CreateCall(Func); } +Value *CodeGenFunction::EmitAArch64CpuSupports(const CallExpr *E) { + const Expr *ArgExpr = E->getArg(0)->IgnoreParenCasts(); + StringRef ArgStr = cast(ArgExpr)->getStri

[clang] [Driver] Improve error when a compiler-rt library is not found (PR #81037)

2024-02-20 Thread Jon Roelofs via cfe-commits
@@ -44,9 +43,8 @@ // CHECK-V6M-DEFAULTCXX: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]" // CHECK-V6M-DEFAULTCXX: ld{{(.exe)?}}" "{{.*}}.o" "-Bstatic" "-EL" // CHECK-V6M-DEFAULTCXX-SAME: "-L{{[^"]*}}{{[/\\]+}}Inputs{{[/\\]+}}baremetal_arm{{[/\\]+}}lib" -// CHECK-V6M-DEFAULTCXX-SAME

[clang] [compiler-rt] [AArch64] Implement __builtin_cpu_supports, compiler-rt tests. (PR #82378)

2024-02-20 Thread Jon Roelofs via cfe-commits
@@ -14025,6 +14028,19 @@ Value *CodeGenFunction::EmitX86CpuInit() { return Builder.CreateCall(Func); } +Value *CodeGenFunction::EmitAArch64CpuSupports(const CallExpr *E) { + const Expr *ArgExpr = E->getArg(0)->IgnoreParenCasts(); + StringRef ArgStr = cast(ArgExpr)->getStri

[clang] [compiler-rt] [AArch64] Implement __builtin_cpu_supports, compiler-rt tests. (PR #82378)

2024-02-20 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/82378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver,BareMetal] Replace -lclang_rt.builtins{,-$arch}.a with an absolute path (PR #82424)

2024-02-20 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/82424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][SME] Detect always_inline used with mismatched streaming attributes (PR #77936)

2024-02-21 Thread Jon Roelofs via cfe-commits
@@ -814,6 +820,43 @@ Address AArch64ABIInfo::EmitMSVAArg(CodeGenFunction &CGF, Address VAListAddr, /*allowHigherAlign*/ false); } +static bool isStreaming(const FunctionDecl *F) { + if (F->hasAttr()) +return true; + if (const auto *T = F->getTy

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

2024-07-03 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,18 @@ +// RUN: %clang_cc1 %s -Wobjc-prefixes=NS,NSCF,NSURL -fsyntax-only -verify jroelofs wrote: is it worth adding a `-Wobjc-forbidden-prefixes=NS`, so you can e.g. forbid things outside of Foundation from defining things with the `NS` prefix? https

[clang] [llvm] [AArch64][RISCV] Improve the tests for --print-enabled-extensions and --print-supported-extensions (PR #97829)

2024-07-05 Thread Jon Roelofs via cfe-commits
jroelofs wrote: > The new tests are autogenerated, but I am not merging the script that creates > them because there isn't a good place for it. Mind sticking it in a gist at least so folks can use it for downstream subtargets? https://github.com/llvm/llvm-project/pull/97829 __

[clang] [llvm] [AArch64][RISCV] Improve the tests for --print-enabled-extensions and --print-supported-extensions (PR #97829)

2024-07-05 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,24 @@ +// REQUIRES: aarch64-registered-target jroelofs wrote: these should probably all go in an `aarch64` folder with a `lit.local.cfg`: ``` targets = set(config.root.targets_to_build.split()) if not "AArch64" in targets: config.unsupported = Tru

[clang] [llvm] [AArch64][RISCV] Improve the tests for --print-enabled-extensions and --print-supported-extensions (PR #97829)

2024-07-05 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/97829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FMV][AArch64] Do not emit ifunc resolver on use. (PR #97761)

2024-07-05 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/97761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Add missing SME/SVE2.1 feature macros (PR #98058)

2024-07-08 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/98058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][AArch64] Add customisable immediate range checking to NEON (PR #100278)

2024-09-06 Thread Jon Roelofs via cfe-commits
@@ -404,142 +370,174 @@ enum ArmSMEState : unsigned { ArmZT0Mask = 0b11 << 2 }; -bool SemaARM::ParseSVEImmChecks( -CallExpr *TheCall, SmallVector, 3> &ImmChecks) { - // Perform all the immediate checks for this builtin call. +bool SemaARM::CheckImmediateArg(CallExpr *Th

[clang] [llvm] [Clang][AArch64] Add customisable immediate range checking to NEON (PR #100278)

2024-09-06 Thread Jon Roelofs via cfe-commits
@@ -216,6 +216,36 @@ namespace clang { } bool isUnsigned() const { return (Flags & UnsignedFlag) != 0; } bool isQuad() const { return (Flags & QuadFlag) != 0; } +unsigned getEltSizeInBits() const { + switch (getEltType()) { + case Int8: + case Pol

[clang] [llvm] [Clang][AArch64] Add customisable immediate range checking to NEON (PR #100278)

2024-09-06 Thread Jon Roelofs via cfe-commits
@@ -216,6 +216,36 @@ namespace clang { } bool isUnsigned() const { return (Flags & UnsignedFlag) != 0; } bool isQuad() const { return (Flags & QuadFlag) != 0; } +unsigned getEltSizeInBits() const { + switch (getEltType()) { + case Int8: + case Pol

[clang] [llvm] [Clang][AArch64] Add customisable immediate range checking to NEON (PR #100278)

2024-09-06 Thread Jon Roelofs via cfe-commits
@@ -404,142 +370,174 @@ enum ArmSMEState : unsigned { ArmZT0Mask = 0b11 << 2 }; -bool SemaARM::ParseSVEImmChecks( -CallExpr *TheCall, SmallVector, 3> &ImmChecks) { - // Perform all the immediate checks for this builtin call. +bool SemaARM::CheckImmediateArg(CallExpr *Th

[clang] [llvm] [Clang][AArch64] Add customisable immediate range checking to NEON (PR #100278)

2024-09-06 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs deleted https://github.com/llvm/llvm-project/pull/100278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-12 Thread Jon Roelofs via cfe-commits
@@ -2397,6 +2397,1262 @@ class UnsafeBufferUsageReporter : public UnsafeBufferUsageHandler { }; } // namespace +// = + +namespace FXAnalysis { + +enum class DiagnosticID : uint8_t { + None = 0, // s

[clang] [clang][AArch64] Point the nofp ABI check diagnostics at the callee (PR #103392)

2024-08-13 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs created https://github.com/llvm/llvm-project/pull/103392 ... whereever we have the Decl for it, and even when we don't keep the SourceLocation of it aimed at the call site. Fixes: #102983 >From a6af41dd6da847237e79ce57b3847bbc241b2cba Mon Sep 17 00:00:00 2001 From:

[clang] [clang][AArch64] Point the nofp ABI check diagnostics at the callee (PR #103392)

2024-08-13 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs milestoned https://github.com/llvm/llvm-project/pull/103392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AArch64] Point the nofp ABI check diagnostics at the callee (PR #103392)

2024-08-13 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/103392 >From a6af41dd6da847237e79ce57b3847bbc241b2cba Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Tue, 13 Aug 2024 10:59:25 -0700 Subject: [PATCH 1/2] [clang][AArch64] Point the nofp ABI check diagnostics at the

[clang] [clang][AArch64] Point the nofp ABI check diagnostics at the callee (PR #103392)

2024-08-14 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs closed https://github.com/llvm/llvm-project/pull/103392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AArch64] Point the nofp ABI check diagnostics at the callee (PR #103392)

2024-08-14 Thread Jon Roelofs via cfe-commits
jroelofs wrote: /cherry-pick 019ef522756886caa258daf68d877f84abc1b878 https://github.com/llvm/llvm-project/pull/103392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [cmake] Build executables with -no_exported_symbols when building Apple toolchain (PR #87684)

2024-04-04 Thread Jon Roelofs via cfe-commits
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE option(LLVM_EXTERNALIZE_DEBUGINFO "Generate dSYM files and strip executables and libraries (Darwin Only)" OFF) +option(LLVM_ENABLE_NO_EXPORTED_SYMBOLS jroelofs wrote: The double negative is confusing. Maybe inver

[clang] [llvm] [driver] Make --version show if assertions, etc. are enabled (PR #87585)

2024-04-04 Thread Jon Roelofs via cfe-commits
jroelofs wrote: > The result of those refactors I now have a new build option to support hiding > the version, should I be touching the `utils/bazel` with this patch? cc @nico https://github.com/llvm/llvm-project/pull/87585 ___ cfe-commits mailing li

[clang] [lldb] [llvm] [cmake] Build executables with -no_exported_symbols when building Apple toolchain (PR #87684)

2024-04-04 Thread Jon Roelofs via cfe-commits
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE option(LLVM_EXTERNALIZE_DEBUGINFO "Generate dSYM files and strip executables and libraries (Darwin Only)" OFF) +option(LLVM_ENABLE_NO_EXPORTED_SYMBOLS jroelofs wrote: Flags like this shouldn't have `DISABLE` in t

[clang] [llvm] [driver] Make --version show if assertions, etc. are enabled (PR #87585)

2024-04-04 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,6 @@ +# REQUIRES: asserts +# RUN: %clang --version 2>&1 | FileCheck %s + +# CHECK: clang version +# When assertions are enabled, we should have a build configuration line that reflects that +# CHECK: Build configuration: {{.*}}+assertions jroelofs wrot

[clang] [llvm] [driver] Make --version show if assertions, etc. are enabled (PR #87585)

2024-04-04 Thread Jon Roelofs via cfe-commits
@@ -2734,6 +2734,40 @@ void cl::PrintHelpMessage(bool Hidden, bool Categorized) { CommonOptions->CategorizedHiddenPrinter.printHelp(); } +ArrayRef cl::CompilerBuildConfig = { +#if LLVM_IS_DEBUG_BUILD +"+unoptimized", +#endif +#ifndef NDEBUG +"+assertions", +#endif

[clang] [clang][FMV] Pass the '+fmv' target-feature when FMV is enabled. (PR #87942)

2024-04-07 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/87942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] set AppleA14 architecture version to v8.4-a (PR #92600)

2024-06-05 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/92600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Driver] Rearrange some Apple version testing (PR #94514)

2024-06-05 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/94514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] set AppleA14 architecture version to v8.4-a (PR #92600)

2024-06-10 Thread Jon Roelofs via cfe-commits
jroelofs wrote: > @jroelofs Can we please merge this? It's up to @tmatheson-arm, it's their patch. I've already given an 'LGTM'. https://github.com/llvm/llvm-project/pull/92600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [llvm] [AArch64] set AppleA14 architecture version to v8.4-a (PR #92600)

2024-06-13 Thread Jon Roelofs via cfe-commits
jroelofs wrote: > @jroelofs on a slight tangent, when do we get to add information on the M4 > chip? https://github.com/llvm/llvm-project/pull/95478 https://github.com/llvm/llvm-project/pull/92600 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [llvm] [llvm][AArch64] Support -mcpu=apple-m4 (PR #95478)

2024-06-13 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/95478 >From 1461be872bf26e2e0f2572f688a45af795421432 Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Thu, 13 Jun 2024 10:27:52 -0700 Subject: [PATCH 1/2] [llvm][AArch64] Support -mcpu=apple-m4 --- .../llvm/TargetPa

[clang] [llvm] [llvm][AArch64] Support -mcpu=apple-m4 (PR #95478)

2024-06-14 Thread Jon Roelofs via cfe-commits
@@ -521,7 +521,14 @@ inline constexpr CpuInfo CpuInfos[] = { AArch64::ExtensionBitset({AArch64::AEK_AES, AArch64::AEK_SHA2, AArch64::AEK_SHA3, AArch64::AEK_FP16, AArch64::AEK_FP16FML})}, - +// Technically ap

[clang] [llvm] [llvm][AArch64] Support -mcpu=apple-m4 (PR #95478)

2024-06-14 Thread Jon Roelofs via cfe-commits
@@ -1010,6 +1034,9 @@ def : ProcessorModel<"apple-a16", CycloneModel, ProcessorFeatures.AppleA16, [TuneAppleA16]>; def : ProcessorModel<"apple-a17", CycloneModel, ProcessorFeatures.AppleA17, [TuneAppleA17]>; +def : ProcessorModel<"appl

[clang] [llvm] [llvm][AArch64] Support -mcpu=apple-m4 (PR #95478)

2024-06-14 Thread Jon Roelofs via cfe-commits
@@ -1010,6 +1034,9 @@ def : ProcessorModel<"apple-a16", CycloneModel, ProcessorFeatures.AppleA16, [TuneAppleA16]>; def : ProcessorModel<"apple-a17", CycloneModel, ProcessorFeatures.AppleA17, [TuneAppleA17]>; +def : ProcessorModel<"appl

[clang] [llvm] [llvm][AArch64] Rearrange Apple CPUs by generation, not product class. NFC (PR #95579)

2024-06-14 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs created https://github.com/llvm/llvm-project/pull/95579 None >From 1461be872bf26e2e0f2572f688a45af795421432 Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Thu, 13 Jun 2024 10:27:52 -0700 Subject: [PATCH 1/3] [llvm][AArch64] Support -mcpu=apple-m4 --- .../llvm/Ta

[clang] [llvm] [llvm][AArch64] Support -mcpu=apple-m4 (PR #95478)

2024-06-14 Thread Jon Roelofs via cfe-commits
@@ -1010,6 +1034,9 @@ def : ProcessorModel<"apple-a16", CycloneModel, ProcessorFeatures.AppleA16, [TuneAppleA16]>; def : ProcessorModel<"apple-a17", CycloneModel, ProcessorFeatures.AppleA17, [TuneAppleA17]>; +def : ProcessorModel<"appl

[clang] [llvm] [llvm][AArch64] Rearrange Apple CPUs by generation, not product class. NFC (PR #95579)

2024-06-14 Thread Jon Roelofs via cfe-commits
jroelofs wrote: stacked PR: https://github.com/llvm/llvm-project/pull/95478 https://github.com/llvm/llvm-project/pull/95579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][AArch64] Rearrange Apple CPUs by generation, not product class. NFC (PR #95579)

2024-06-14 Thread Jon Roelofs via cfe-commits
@@ -983,50 +1007,58 @@ def : ProcessorModel<"thunderx3t110", ThunderX3T110Model, def : ProcessorModel<"tsv110", TSV110Model, ProcessorFeatures.TSV110, [TuneTSV110]>; +// iPhone, iPad, Mac and Watch CPUs jroelofs wrote: works for me https

[clang] [llvm] [llvm][AArch64] Support -mcpu=apple-m4 (PR #95478)

2024-06-14 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs closed https://github.com/llvm/llvm-project/pull/95478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][AArch64] Rearrange Apple CPUs by generation, not product class. NFC (PR #95579)

2024-06-14 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/95579 >From 1461be872bf26e2e0f2572f688a45af795421432 Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Thu, 13 Jun 2024 10:27:52 -0700 Subject: [PATCH 1/4] [llvm][AArch64] Support -mcpu=apple-m4 --- .../llvm/TargetPa

[clang] [llvm] [llvm][AArch64] Rearrange Apple CPUs by generation, not product class. NFC (PR #95579)

2024-06-14 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/95579 >From 1461be872bf26e2e0f2572f688a45af795421432 Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Thu, 13 Jun 2024 10:27:52 -0700 Subject: [PATCH 1/4] [llvm][AArch64] Support -mcpu=apple-m4 --- .../llvm/TargetPa

[clang] [llvm] [llvm][AArch64] Rearrange Apple CPUs by generation, not product class. NFC (PR #95579)

2024-06-14 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs closed https://github.com/llvm/llvm-project/pull/95579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-17 Thread Jon Roelofs via cfe-commits
@@ -13,3 +13,57 @@ // RUN: %clang --target=aarch64_be -mbig-endian -march=armv8.6a -### -c %s 2>&1 | FileCheck -check-prefix=GENERICV86A-BE %s // RUN: %clang --target=aarch64_be -mbig-endian -march=armv8.6-a -### -c %s 2>&1 | FileCheck -check-prefix=GENERICV86A-BE %s // GENER

[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-18 Thread Jon Roelofs via cfe-commits
@@ -19,3 +19,19 @@ // RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1a -### -c %s 2>&1 | FileCheck -check-prefix=ARM64-GENERICV81A %s // RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1-a -### -c %s 2>&1 | FileCheck -check-prefix=ARM64-GENERICV81A %s // ARM

[clang] [Clang][AArch64] Use 'uint64_t*' for _arm_get_sme_state builtin. (PR #95982)

2024-06-18 Thread Jon Roelofs via cfe-commits
jroelofs wrote: > I've tested this change locally, but wasn't sure how to write a test for it. how about: ``` void check(uint64_t *a, uint64_t *b) { __builtin_arm_get_sme_state(a, b); } ``` with a couple of run lines for various platforms? if `a` and `b` were `unsigned long *` you'd get an

[clang] [Clang][AArch64] Use 'uint64_t*' for _arm_get_sme_state builtin. (PR #95982)

2024-06-18 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/95982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][AArch64] SVE2 is an optional feature in ARMv9.0a (PR #96007)

2024-06-19 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/96007 >From b18411c28ed9b89660fac6311596408dafb7f40e Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Tue, 18 Jun 2024 15:26:32 -0700 Subject: [PATCH 1/2] [llvm][AArch64] SVE2 is an optional feature in ARMv9.0a ---

[clang] [llvm] [llvm][AArch64] SVE2 is an optional feature in ARMv9.0a (PR #96007)

2024-06-20 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/96007 >From b18411c28ed9b89660fac6311596408dafb7f40e Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Tue, 18 Jun 2024 15:26:32 -0700 Subject: [PATCH 1/3] [llvm][AArch64] SVE2 is an optional feature in ARMv9.0a ---

[clang] [llvm] [llvm][AArch64] SVE2 is an optional feature in ARMv9.0a (PR #96007)

2024-06-20 Thread Jon Roelofs via cfe-commits
@@ -108,6 +108,12 @@ Changes to the AArch64 Backend in ``standard`` being equal to ``bti+pac-ret+pc`` when ``+pauth-lr`` is passed as part of ``-mcpu=`` options. +* SVE and SVE2 have been moved to the default extensions list for ARMv9.0, + making them optional per the Arm

[clang] [llvm] [llvm][AArch64] SVE2 is an optional feature in ARMv9.0a (PR #96007)

2024-06-20 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs closed https://github.com/llvm/llvm-project/pull/96007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AArch64][FMV] Stop emitting alias to ifunc. (PR #96221)

2024-06-20 Thread Jon Roelofs via cfe-commits
jroelofs wrote: cc @tahonermann https://github.com/llvm/llvm-project/pull/96221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AArch64][FMV] Stop emitting alias to ifunc. (PR #96221)

2024-06-20 Thread Jon Roelofs via cfe-commits
jroelofs wrote: I think this needs a release note. https://github.com/llvm/llvm-project/pull/96221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] set AppleA14 architecture version to v8.4-a (PR #92600)

2024-06-04 Thread Jon Roelofs via cfe-commits
@@ -286,7 +286,6 @@ void AArch64TargetInfo::getTargetDefinesARMV84A(const LangOptions &Opts, void AArch64TargetInfo::getTargetDefinesARMV85A(const LangOptions &Opts, MacroBuilder &Builder) const { Builder.defineMacro("__ARM_FEA

[clang] [compiler-rt] [llvm] [FMV] Remove useless features according the latest ACLE spec. (PR #88965)

2024-04-16 Thread Jon Roelofs via cfe-commits
jroelofs wrote: Mind listing which ones are affected in the commit summary? https://github.com/llvm/llvm-project/pull/88965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [FMV] Remove useless features according the latest ACLE spec. (PR #88965)

2024-04-16 Thread Jon Roelofs via cfe-commits
@@ -67,57 +67,42 @@ enum CPUFeatures { FEAT_FP, FEAT_SIMD, FEAT_CRC, - FEAT_SHA1, FEAT_SHA2, FEAT_SHA3, FEAT_AES, - FEAT_PMULL, FEAT_FP16, - FEAT_DIT, FEAT_DPB, FEAT_DPB2, FEAT_JSCVT, FEAT_FCMA, FEAT_RCPC, FEAT_RCPC2, FEAT_FRINTTS, - F

[clang] [llvm] [FMV] Rectify incomplete ExtensionInfo entries in TargetParser. (PR #89106)

2024-04-17 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/89106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] Reland "[FMV] Remove useless features according the latest ACLE spec." (PR #89232)

2024-04-18 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/89232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-07-24 Thread Jon Roelofs via cfe-commits
@@ -4699,7 +4699,7 @@ class FunctionEffect { private: LLVM_PREFERRED_TYPE(Kind) - unsigned FKind : 3; + uint8_t FKind : 3; jroelofs wrote: I'd split this into it's own NFC PR, and land it before the rest. https://github.com/llvm/llvm-project/pull/99656 _

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-07-24 Thread Jon Roelofs via cfe-commits
@@ -4699,7 +4699,7 @@ class FunctionEffect { private: LLVM_PREFERRED_TYPE(Kind) - unsigned FKind : 3; + uint8_t FKind : 3; jroelofs wrote: also, github won't let me comment on the correct lines, but: ``` - FunctionEffect() : FKind(unsigned(Kind::None))

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-07-24 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,194 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -verify %s +// These are in a separate file because errors (e.g. incompatible attributes) currently prevent +// the AnalysisBasedWarnings pass from running at all. + +// This diagnostic is re-enabled an

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-07-24 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,194 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -verify %s +// These are in a separate file because errors (e.g. incompatible attributes) currently prevent +// the AnalysisBasedWarnings pass from running at all. + +// This diagnostic is re-enabled an

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-07-24 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,194 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -verify %s +// These are in a separate file because errors (e.g. incompatible attributes) currently prevent +// the AnalysisBasedWarnings pass from running at all. + +// This diagnostic is re-enabled an

<    1   2   3   4   5   >