[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83492/new/ https://reviews.llvm.org/D83492 _

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert updated this revision to Diff 278952. jdoerfert added a comment. Reuse builder Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82470/new/ https://reviews.llvm.org/D82470 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp llvm/include/llvm/Front

[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

jdoerfert added a comment. In D81031#2159895 , @jhuber6 wrote: > Fixing errors caused by unused attribute sets. Adding missing attributes to > barrier_codegen.cpp. > > Should I go ahead and commit this considering the previous was temporarily > reverted?

[PATCH] D83398: [OPENMP50]Perform data mapping analysis only for explicitly mapped data.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83398/new/ https://reviews.llvm.org/D83398 _

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

jdoerfert resigned from this revision. jdoerfert added a comment. This revision is now accepted and ready to land. My concerns have been addressed. I am not the right one to look at the clang changes but what we merged into LLVM was really useful, thanks again for working on this! Repository:

[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

jdoerfert added a comment. In D81031#2160281 , @jhuber6 wrote: > In D81031#2159943 , @jdoerfert wrote: > > > In D81031#2159895 , @jhuber6 wrote: > > > > > Fixing errors cause

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the generalization. We'll add update_test support next for the opt case, e.g., for D83635 . Comment at: llvm/utils/up

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

jdoerfert added a comment. In D84364#2168036 , @tra wrote: > E.g. > > __host__ __device__ static void hd() { > no_such_type_t t; > } > > > We obviously can never compile this function on either side of the > compilation and clang currently does d

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. Due to D82995 I realized we should have a test of this in `llvm/test/tools/UpdateTestChecks` as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/ https://reviews.llvm.org/D8

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

jdoerfert added a comment. FWIW, OpenMP does also defer some diagnostics. It feels like a mess we can't avoid. That means, I think there is merit in generalizing this. I haven't reviewed this in any detail though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84364/new/ https://review

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

jdoerfert added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83281/new/ https://reviews.llvm.org/D83281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

jdoerfert updated this revision to Diff 280148. jdoerfert marked 6 inline comments as done. jdoerfert added a comment. Addressed @ABataev comments, thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83281/new/ https://reviews.llvm.org/D83281 Files

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

jdoerfert updated this revision to Diff 280151. jdoerfert marked an inline comment as done. jdoerfert added a comment. Add virtual Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83281/new/ https://reviews.llvm.org/D83281 Files: clang/include/clan

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

jdoerfert updated this revision to Diff 280327. jdoerfert added a comment. minor fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83281/new/ https://reviews.llvm.org/D83281 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/B

[PATCH] D84506: [tools] Add paranthesese for print in Python

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Seems NFC and towards the right syntax, thx :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84506/new/ https://reviews.llvm.org/D84

[PATCH] D84476: Make hip math headers easier to use from C

jdoerfert added a comment. I'm fine with this @yaxunl should accept though. Comment at: clang/lib/Headers/__clang_hip_math.h:561 inline double abs(double __x) { return __ocml_fabs_f64(__x); } +#endif __DEVICE__ Nit: You mix the C and C++ math declarations in

[PATCH] D83909: [OPENMP] Fix PR46730: Fix compiler crash on taskloop over constructible loop counters.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83909/new/ https://reviews.llvm.org/D83909 _

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

jdoerfert added a comment. In D83268#2172748 , @protze.joachim wrote: > I carefully made sure, that the freshly built clang was used to execute the > test. I opened https://bugs.llvm.org/show_bug.cgi?id=46836 to track the issue > and made it release blo

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

jdoerfert added reviewers: tra, MaskRay. jdoerfert added subscribers: MaskRay, tra. jdoerfert added a comment. I like this. I hope this is the start of splitting the `__cuda` headers into generic and specific code, right? @tra @MaskRay any objections on the direction? Commen

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

jdoerfert added a comment. In D84743#2179441 , @tra wrote: > I'm not sure it's particularly useful, to be honest. CUDA code still needs to > be compatible with NVCC so it can't be used in portable code like TF or other > currently used CUDA libraries. >

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

jdoerfert added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83281/new/ https://reviews.llvm.org/D83281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

jdoerfert added a comment. In D84743#2181044 , @MaskRay wrote: > In D84743#2181031 , @jdoerfert wrote: > >> In D84743#2179441 , @tra wrote: >> >>> I'm not sure it's particula

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

jdoerfert added inline comments. Comment at: clang/lib/Headers/offload_macros.h:1 +//===--- offload_macros.h - Universal _DEVICE Offloading Macros Header ---===// +// After @MaskRay noticed this, I think this should be `__offload_macros.h` to make it clear this

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee05167cc42b: [OpenMP] Allow traits for the OpenMP context selector `isa` (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.o

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

jdoerfert added a comment. In D83281#2182507 , @thakis wrote: > This breaks check-clang on Windows: http://45.33.8.238/win/20850/step_7.txt > > Please take a look, and revert while you investigate if it takes a while to > fix. Should be fixed by 8723280b

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

jdoerfert added a comment. In D83281#2183100 , @thakis wrote: > Looks like it's still failing with that change: > http://45.33.8.238/win/20885/step_7.txt dso_local is *before* the void,.. 2 min Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19756ef53a49: [OpenMP][IRBuilder] Support allocas in nested parallel regions (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebad64dfe133: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions.

jdoerfert created this revision. jdoerfert added reviewers: mikerice, kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim, aaron.ballman. Herald added subscribers: guansong, bollu, hiraditya, yaxunl. Herald added a project: clang. By defa

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

jdoerfert added a comment. I'm fine with this. I would hope a C/C++/Clang person will also take a look though. Comment at: llvm/docs/LangRef.rst:1398 +This attribute is similar to ``alwaysinline``, but also applies recursively to +all inlined function calls. ``builti

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1698 + auto *CE = cast(R.get()); + return SemaRef.ActOnOpenMPCall(R, nullptr, CE->getRParenLoc(), + MultiExprArg(C

[PATCH] D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions.

jdoerfert updated this revision to Diff 254983. jdoerfert added a comment. Allow the new match clauses to be used in `begin/end declare variant` as well (with their respective effect) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77414/new/ https:

[PATCH] D77113: [OpenMP][NFC] Move and simplify directive -> allowed clause mapping

jdoerfert updated this revision to Diff 255041. jdoerfert added a comment. Herald added subscribers: yaxunl, mgorny. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77113/new/ https://reviews.llvm.org/D77113 Files: clang/include/clang/ASTMa

[PATCH] D71739: [WIP] Use operand bundles to encode alignment assumptions

jdoerfert added a comment. @lebedev.ri We'd need to identify other uses of the alignment encoding in-tree so we can replace them as well. Also, this patch uses not only the alignment but also the offset in the operand bundle. We can either allow that or encode the offset via a gep in the IR. I

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert updated this revision to Diff 255043. jdoerfert edited the summary of this revision. jdoerfert added a comment. Rebase on D77252 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77290/new/ https://reviews.ll

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

jdoerfert updated this revision to Diff 255050. jdoerfert added a comment. Cleanup and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75788/new/ https://reviews.llvm.org/D75788 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Heade

[PATCH] D77252: [OpenMP] Try to find an existing base for `omp begin/end declare variant`

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5512 + + if (!BaseFD) { +// TODO: Determine if we can reuse the declarator to create a declaration mikerice wrote: > I think if you do the

[PATCH] D77252: [OpenMP] Try to find an existing base for `omp begin/end declare variant`

jdoerfert added a comment. In D77252#1961913 , @mikerice wrote: > [...] > >[...] > TypeSourceInfo *TInfo = GetTypeForDeclarator(D, S); > QualType FType = TInfo->getType(); > [...] > I think this is a key part of what I was missing. I'll try

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert updated this revision to Diff 255210. jdoerfert added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77290/new/ https://reviews.llvm.org/D77290 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp clang/test/AST/ast-dum

[PATCH] D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions.

jdoerfert updated this revision to Diff 255212. jdoerfert added a comment. Rebase and fix a problem with evaluation of non-constants Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77414/new/ https://reviews.llvm.org/D77414 Files: clang/include/cl

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1693 +ExprResult TemplateInstantiator::TransformCallExpr(CallExpr *E) { + ExprResult R = TreeTransform::TransformCallExpr(E); + if (!SemaRef.getLa

[PATCH] D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions.

jdoerfert marked an inline comment as done. jdoerfert added a comment. Will fix the other two nits too. Comment at: clang/lib/Parse/ParseOpenMP.cpp:1823 ASTContext &ASTCtx = Actions.getASTContext(); -TI.getAsVariantMatchInfo(ASTCtx, VMI, /* DeviceSetOnly */ true); +

[PATCH] D77112: [OpenMP][NFCI] Move OpenMP clause information to `lib/Frontend/OpenMP`

jdoerfert added a comment. In D77112#1962936 , @thakis wrote: > Broke clang-tools-extra again: > http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/46759/steps/build%20stage%201/logs/stdio Fixed in 8ea07f62a6f06bdb7da981425227995423867a4d

[PATCH] D77113: [OpenMP][NFC] Move and simplify directive -> allowed clause mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rG931c0cd713ee: [OpenMP][NFC] Move and simplify directive -> allowed clause mapping (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7711

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

jdoerfert created this revision. jdoerfert added a reviewer: lebedev.ri. Herald added subscribers: martong, guansong, bollu, yaxunl, mgorny. Herald added a project: clang. lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG ASTMatche

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

This revision was automatically updated to reflect the committed changes. Closed by commit rG97aa593a8387: [OpenMP] Fix layering problem with FrontendOpenMP (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77574/new/ https://re

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert updated this revision to Diff 255524. jdoerfert added a comment. Move code as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77290/new/ https://reviews.llvm.org/D77290 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/AST/ast

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

jdoerfert added a comment. In D74387#1964483 , @Fznamznon wrote: > In D74387#1950593 , @jdoerfert wrote: > > > This is needed for OpenMP as well. Does it make sense to include it in this > > patch or in another one

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8260 } -return Result; + +if (!SemaRef.getLangOpts().OpenMP || !Result.isUsable() || mikerice wrote: > I was expecting the code wo

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert added a comment. I figured in TreeTransform everyone would get this behavior but actually only template instantiation wants it so I put it there instead. Do you think it is better placed in the generic TreeTransform code after all? At least this time I verified the test passes. Sorry

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert updated this revision to Diff 255560. jdoerfert added a comment. Override `RebuildCallExpr` in the template instantiation and specialize calls only there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77290/new/ https://reviews.llvm.org/

[PATCH] D77654: [OpenMP] Modify library linkage to resolved PR28433

jdoerfert created this revision. jdoerfert added reviewers: sylvestre.ledru, lebedev.ri. Herald added subscribers: guansong, bollu, yaxunl, mgorny. Herald added a project: clang. This is a try that works locally but the problem did not occur locally (even though shared libraries were enabled). R

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

jdoerfert added a comment. In D77574#1967141 , @aheejin wrote: > Could you revert this patch? This is causing an error like this whenever I > run `clang` binary: > > : CommandLine Error: Option 'openmp-ir-builder-optimistic-attributes' > registered mor

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert updated this revision to Diff 255709. jdoerfert added a comment. Move specializtion to the TreeTransformer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77290/new/ https://reviews.llvm.org/D77290 Files: clang/lib/Sema/TreeTransform.h

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert updated this revision to Diff 255729. jdoerfert added a comment. Reuse ActOnCallExpr, which contains the necessary logic (and a warning which we tried to avoid before). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77290/new/ https://rev

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:2414 Expr *ExecConfig = nullptr) { -return getSema().BuildCallExpr(/*Scope=*/nullptr, Callee, LParenLoc, Args, -

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

jdoerfert added a comment. In D74387#1967289 , @Fznamznon wrote: > In D74387#1965634 , @jdoerfert wrote: > > > In D74387#1964483 , @Fznamznon > > wrote: > > > > > In D74387#

[PATCH] D77666: [OpenMP] "UnFix" layering problem with FrontendOpenMP

jdoerfert created this revision. jdoerfert added reviewers: sylvestre.ledru, lebedev.ri. Herald added subscribers: martong, usaxena95, kadircet, arphaman, jkorous, MaskRay, guansong, bollu, kbarton, yaxunl, mgorny, nemanjai. Herald added a project: clang. This reverts commit 97aa593a8387586095b7e

[PATCH] D77654: [OpenMP] Modify library linkage to resolve PR45453

jdoerfert abandoned this revision. jdoerfert added a comment. This doesn't work either :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77654/new/ https://reviews.llvm.org/D77654 ___ cfe-commits mailin

[PATCH] D77666: [OpenMP] "UnFix" layering problem with FrontendOpenMP

jdoerfert added a comment. In D77666#1967506 , @aheejin wrote: > I don't know much about how this part works, but if this is purely a revert > of the previous patch, I don't think you need a review for that. It is not, as stated in the commit message. A

[PATCH] D77666: [OpenMP] "UnFix" layering problem with FrontendOpenMP

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9d558c87133: [OpenMP] "UnFix" layering problem with FrontendOpenMP (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77666/new/ https:

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jdoerfert created this revision. jdoerfert added reviewers: hfinkel, ABataev, dblaikie, mehdi_amini, aaron.ballman, modocache, lattner, MaskRay, hubert.reinterpretcast, jhenderson, rengolin, kristina. Herald added a subscriber: bollu. Herald added a project: LLVM. jdoerfert updated this revision

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jdoerfert updated this revision to Diff 255830. jdoerfert added a comment. Add comma Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77683/new/ https://reviews.llvm.org/D77683 Files: llvm/docs/CodeReview.rst Index: llvm/docs/CodeReview.rst =

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/docs/CodeReview.rst:34 +uncertainty, a patch should be reviewed prior to being committed. If pre-commit +code reviewes in a particular area have been requested, code should clear a +sign

[PATCH] D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa19eb1de726c: [OpenMP] Add match_{all,any,none} declare variant selector extensions. (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D77414?vs=255212&id=255895#toc Repository

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb5a16efbf59: [OpenMP] Specialize OpenMP calls after template instantiation (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77290/new/

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

This revision was automatically updated to reflect the committed changes. Closed by commit rGf85ae058f580: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D75788?vs=255050&id=255897#toc Reposit

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jdoerfert updated this revision to Diff 256108. jdoerfert added a comment. Use @lattern 's wording which is more specific and has less spelling errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77683/new/ https://reviews.llvm.org/D77683 Files:

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jdoerfert added a comment. I did like @lattner 's solution so I use that now. Wdyt? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77683/new/ https://reviews.llvm.org/D77683 ___ cfe-commits mailing list

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

jdoerfert added a comment. In D70366#1970299 , @LevitatingLion wrote: > While adding tests to clang I realized the attribute is not working as > intended when using an optimization level of zero, because clang adds the > noinline attribute to all functi

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

jdoerfert added a comment. In D74387#1969891 , @Fznamznon wrote: > In D74387#1967386 , @jdoerfert wrote: > > > In D74387#1967289 , @Fznamznon > > wrote: > > > > > In D74387#

[PATCH] D77751: [OPENMP50] Fix PR45469: Consider variable-category of defaultmap clause as optional.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77751/new/ https://reviews.llvm.org/D77751 _

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

jdoerfert accepted this revision. jdoerfert added a comment. Apologies for my delay. LGTM. Wait for @lebedev.ri though. Comment at: clang-tools-extra/docs/clang-tidy/checks/openmp-use-default-none.rst:56 + // ``parallel`` directive can have ``default`` clause, and said claus

[PATCH] D77731: [OPENMP]Fix capturing of global variables in OpenMP regions.

jdoerfert added a subscriber: fghanim. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2117 +if (VD && !VD->hasLocalStorage() && DVarPrivate.CKind == OMPC_unknown && +(DSAStack->getDefaultDSA() != DSA_none || DVarTop.CKind == OMPC_shared))

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

jdoerfert added a comment. In D70366#1970526 , @dexonsmith wrote: > In D70366#1970299 , @LevitatingLion > wrote: > > > Maybe we can add an additional string attribute when adding the noinline > > attribute to func

[PATCH] D77731: [OPENMP]Fix capturing of global variables in OpenMP regions.

jdoerfert accepted this revision. jdoerfert added a subscriber: atmnpatel. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2117 +if (VD && !VD->hasLocalStorage() && DVarPrivate.CKind == OMPC_unknown

[PATCH] D77774: [OpenMP] Allow to go first in C++-mode in target regions

jdoerfert created this revision. jdoerfert added a reviewer: hfinkel. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: clang. If we are in C++ mode and include (not ) first, we still need to make sure is read first. The problem otherwise is that we haven't seen the decl

[PATCH] D77633: [Parser] Improve diagnostic and error recovery when C++ keywords are used as identifiers.

jdoerfert added a comment. This is cool, thx! One case I stumbled upon recently is: `void explicit() {}` Which results in these rather confusing messages: /tmp/test.cpp:1:14: warning: explicit(bool) is a C++20 extension [-Wc++20-extensions] void explicit() { } ^ /tmp/test.

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

jdoerfert added a comment. In D70366#1972880 , @LevitatingLion wrote: > In D70366#1971137 , @dexonsmith > wrote: > > > In D70366#1970758 , @jdoerfert > > wrote: > > > > >

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

jdoerfert added a subscriber: probinson. jdoerfert added a comment. Found the commit: dcbe35bad518 The way I see it we just have to teach the inliner about `optnone` so we can uncouple the two (`optnone` and `noinline`). @probinson WDTY? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70

[PATCH] D77774: [OpenMP] Allow to go first in C++-mode in target regions

This revision was automatically updated to reflect the committed changes. Closed by commit rG17d83342235f: [OpenMP] Allow to go first in C++-mode in target regions (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jdoerfert added a comment. In D77683#1970826 , @mehdi_amini wrote: > I am still not sure what "if someone has asked for extra review of a specific > area" refers to? As said earlier >> If I understand this correctly, this is meant to cover situations

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

jdoerfert added a comment. As I mentioned before. As long as the type is not "used" you can treat it as a sequence of bytes just as well. So we can lower `__float128` to `char [16]` with the right alignment. SPIRV will never see unsupported types and the code works because we never access it as

[PATCH] D77918: [OpenMP] Avoid crash in preparation for diagnose of unsupported type

jdoerfert created this revision. jdoerfert added reviewers: hfinkel, ABataev, JonChesterfield. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: clang. This was reported as PR45231 but occurs even without `cmath` in C++17 mode if we have an expression involving unsupported

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/test/Headers/nvptx_device_math_macro.cpp:11 + double a(0); +// CHECK-NOT: call +// CHECK: call double @llvm.fabs.f64(double sammccall wrote: > Hmm, this fails if the

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

jdoerfert added a comment. I think this is fine. Two comments to consider below. Comment at: llvm/include/llvm/IR/IRBuilder.h:1600 +return CreateAlignedLoad(Ty, Ptr, DL.getABITypeAlign(Ty), isVolatile, Name); } Can't we just pawn of the alignment stuf

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77984/new/ https://reviews.llvm.org/D77984 _

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen

jdoerfert added a comment. You need to update the tests too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D77918: [OpenMP] Avoid crash in preparation for diagnose of unsupported type

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1831 "OpenMP device compilation mode is expected."); + // TODO: Do not check outside of functions for now as the targetDiag below + // requires

[PATCH] D78155: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in wrapper headers

jdoerfert created this revision. jdoerfert added reviewers: tra, hfinkel. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: clang. Due to recent changes we cannot use OpenMP in CUDA files anymore (PR45533) as the math handling of CUDA is different when _OPENMP is defined.

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jdoerfert added a comment. The problem I want to address is with code owners. TBH, I would like our overall description of that role to be (more) like @hfinkel described it. In case there is no controversy, that is not really different from @dblaikie vision (I think). If there is controversy, a

[PATCH] D80936: [OPENMP]Fix PR46146: Do not consider globalized variables as NRVO candidates.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80936/new/ https://reviews.llvm.org/D80936 ___

[PATCH] D78637: [OPENMP]Fix PR45383: type dependent array subscripts are diagnosed erroneously.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78637/new/ https://reviews.llvm.org/D78637 _

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

jdoerfert added reviewers: kkwli0, dreachem. jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7630 +// OMPC_MAP_MODIFIER_last is used to identify data members used in +// used_device_adddr clause. +bool IsMemberPointerOrAd

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Headers/__clang_cuda_complex_builtins.h:42 +#define _LOGBf _LOGBd +#else +#define _ISNANd isnan This will actually not work right now as we do not overload isinf/i

[PATCH] D79948: [OPENMP50]Codegen for inscan reductions in worksharing directives.

jdoerfert added a comment. Looks good, puzzled about the one changed mentioned below. Comment at: clang/lib/Sema/SemaOpenMP.cpp:14900 } -continue; } Why would we continue after this error? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:202 + const unsigned *GridValues; + const uint64_t *LongGridValues; I would recommend adding a descriptive comment, even though that seems not to be the norm here. Why do we

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jdoerfert added a comment. In D80735#2071897 , @jhuber6 wrote: > I'm just investigating migrating D80222 > away from the static methods. When I try to just add an OpenMPIRBuilder type > and initialize it I get failures o

[PATCH] D79948: [OPENMP50]Codegen for inscan reductions in worksharing directives.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Thx for the explanation. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79948/new/ https://reviews.llvm.org/D79948 ___

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

jdoerfert added a subscriber: RaviNarayanaswamy. jdoerfert added a comment. I was hoping @dreachem and maybe @RaviNarayanaswamy would look at this. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7630 +// OMPC_MAP_MODIFIER_last is used to identify data members used in

<    1   2   3   4   5   6   7   8   9   10   >