Re: r262838 - Implement __builtin_eh_return_data_regno for SPARC and SPARC64.

2016-05-01 Thread Joerg Sonnenberger via cfe-commits
On Mon, Mar 07, 2016 at 06:30:52PM +0100, Joerg Sonnenberger via cfe-commits wrote: > On Mon, Mar 07, 2016 at 05:19:16PM -0000, Joerg Sonnenberger via cfe-commits > wrote: > > Author: joerg > > Date: Mon Mar 7 11:19:15 2016 > > New Revision: 262838 > > > &

Re: r261717 - Default vaarg lowering should support indirect struct types.

2016-05-01 Thread Joerg Sonnenberger via cfe-commits
On Wed, Feb 24, 2016 at 08:38:24AM -0800, Hans Wennborg via cfe-commits wrote: > On Wed, Feb 24, 2016 at 5:11 AM, Joerg Sonnenberger via cfe-commits > wrote: > > On Wed, Feb 24, 2016 at 03:03:32AM -, James Y Knight via cfe-commits > > wrote: > >> Author: jyknight

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

2016-03-29 Thread Joerg Sonnenberger via cfe-commits
On Tue, Mar 29, 2016 at 06:47:24PM +, Adrian Prantl via cfe-commits wrote: > This code in this patch listens to the driver option -gfull, and lowers it to > the new cc1 option -debug-retain-types (1). > When -debug-retain-types is present, CGDebugInfo will retain every(2) type it > creates.

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

2016-03-30 Thread Joerg Sonnenberger via cfe-commits
On Tue, Mar 29, 2016 at 12:03:46PM -0700, Adrian Prantl via cfe-commits wrote: > > > On Mar 29, 2016, at 12:00 PM, Joerg Sonnenberger > > wrote: > > > > On Tue, Mar 29, 2016 at 06:47:24PM +, Adrian Prantl via cfe-commits > > wrote: > >> This code in this patch listens to the driver option

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

2016-03-30 Thread Joerg Sonnenberger via cfe-commits
On Wed, Mar 30, 2016 at 10:54:32AM -0700, Adrian Prantl via cfe-commits wrote: > > Let's take a kernel as example. I want to include certain types for > > dtrace-like use with /dev/kmem, but not all the 100KB+ of boring types. > > Enough for doing some basic post-mortem debugging even on embedded >

Re: [PATCH] D18783: [clang-tidy] add new checker for string literal with NUL character.

2016-04-06 Thread Joerg Sonnenberger via cfe-commits
On Tue, Apr 05, 2016 at 05:27:45PM +, Ben Craig via cfe-commits wrote: > bcraig added a subscriber: bcraig. > bcraig added a comment. > > Is this checker able to connect a std::string with a pre-declared string > literal (i.e. constant propagation)? For example... > > const char *bad_char

Re: [PATCH] D15524: [GCC] Attribute ifunc support in clang

2016-04-08 Thread Joerg Sonnenberger via cfe-commits
joerg added a subscriber: joerg. Comment at: include/clang/Basic/AttrDocs.td:2066 @@ -2065,3 +2065,3 @@ let Content = [{ Clang supports the GNU style ``__attribute__((interrupt))`` attribute on x86/x86-64 targets.The compiler generates function entry and exit sequences --

Re: [PATCH] D18970: Add functions in ctype.h to builtin function database

2016-04-11 Thread Joerg Sonnenberger via cfe-commits
joerg added a subscriber: joerg. joerg added a comment. ctype.h functions are only pure, not const? http://reviews.llvm.org/D18970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18970: Add functions in ctype.h to builtin function database

2016-04-14 Thread Joerg Sonnenberger via cfe-commits
On Wed, Apr 13, 2016 at 03:02:09PM +, Taewook Oh wrote: > Sure, I'll take a look. > Thanks! Please provide two versions of the test, one hard-coded for an architecture with signed char, one hard-coded for an architecture with unsigned char. That should cover the difference. Joerg

Re: [PATCH] D18970: Add functions in ctype.h to builtin function database

2016-04-14 Thread Joerg Sonnenberger via cfe-commits
On Thu, Apr 14, 2016 at 03:02:31PM +, Taewook Oh via cfe-commits wrote: > Thank you for your comments. I submitted a new patch > (http://reviews.llvm.org/D19062) with a new test that checks attributes > but not types. I think this should cover both cases. What do you think? I think just pickin

r271801 - Add PIE magic for NetBSD. Add tests for the correct flags for

2016-06-04 Thread Joerg Sonnenberger via cfe-commits
Author: joerg Date: Sat Jun 4 15:03:26 2016 New Revision: 271801 URL: http://llvm.org/viewvc/llvm-project?rev=271801&view=rev Log: Add PIE magic for NetBSD. Add tests for the correct flags for non-shared, PIE and shared output mode. Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test

[cfe-commitsatlists.llvm.org: r271801 - Add PIE magic for NetBSD. Add tests for the correct flags for]

2016-06-05 Thread Joerg Sonnenberger via cfe-commits
Hi Tom, I'd like to merge this change for getting rid of the stupid '-pie is nont used' warnings and to actual make it do the right thing :) This doesn't affect any other targets. Joerg - Forwarded message from Joerg Sonnenberger via cfe-commits - Author: joerg Da

Re: r271801 - Add PIE magic for NetBSD. Add tests for the correct flags for

2016-06-06 Thread Joerg Sonnenberger via cfe-commits
On Mon, Jun 06, 2016 at 02:21:37PM +0300, Ismail Donmez wrote: > This seems to fail for me on Windows: > $ "C:/cygwin64/home/ismail/src/llvm/dist/./bin/clang.EXE" > "-no-canonical-prefixes" "-target" "x86_64--netbsd" > "--sysroot=C:\cygwin64\home\ismail\src\llvm\tools\clang\test\Driver/Inputs/basic

r271893 - Give FileCheck a hint on which ld to match. Under Windows, the preferred

2016-06-06 Thread Joerg Sonnenberger via cfe-commits
Author: joerg Date: Mon Jun 6 08:13:12 2016 New Revision: 271893 URL: http://llvm.org/viewvc/llvm-project?rev=271893&view=rev Log: Give FileCheck a hint on which ld to match. Under Windows, the preferred match was the ld.elf_so that should be matched in a second step. Add one of the ever-present-

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-09 Thread Joerg Sonnenberger via cfe-commits
On Wed, Jun 08, 2016 at 01:12:31AM +, Hans Wennborg via cfe-commits wrote: > There has been a patch for this before (http://reviews.llvm.org/D2972), > but this one is more general, as it works on the virtual filesystem > layer, and also supports case-insensitive lookups of parent directories >

Re: Add support for musl-libc on Linux

2016-06-11 Thread Joerg Sonnenberger via cfe-commits
On Sat, Jun 11, 2016 at 03:14:38PM +0800, Lei Zhang via llvm-commits wrote: > Hi, > > The first patch introduces musl as a new environment type in LLVM; the > second helps clang to find musl's dynamic linker, which has a > different naming scheme from glibc's. > > The two patches together enable

Re: Add support for musl-libc on Linux

2016-06-12 Thread Joerg Sonnenberger via cfe-commits
On Sun, Jun 12, 2016 at 10:51:11AM +0800, Lei Zhang via llvm-commits wrote: > Hi, > > I'm replying to this thread; sorry I wasn't subscribed to the list, > thus cannot reply to it directly. > > http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160606/161733.html > > Joerg, thanks for you

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-12 Thread Joerg Sonnenberger via cfe-commits
On Fri, Jun 10, 2016 at 10:35:26AM -0700, Hans Wennborg wrote: > On Thu, Jun 9, 2016 at 5:31 PM, Joerg Sonnenberger via cfe-commits > wrote: > > On Wed, Jun 08, 2016 at 01:12:31AM +, Hans Wennborg via cfe-commits > > wrote: > >> There has been a patch for this befo

Re: [libcxx] r272632 - Ignore depricated warnings from and

2016-06-14 Thread Joerg Sonnenberger via cfe-commits
On Tue, Jun 14, 2016 at 03:26:11AM -, Eric Fiselier via cfe-commits wrote: > Author: ericwf > Date: Mon Jun 13 22:26:11 2016 > New Revision: 272632 > > URL: http://llvm.org/viewvc/llvm-project?rev=272632&view=rev > Log: > Ignore depricated warnings from and Commit message and change don't a

Re: r272782 - [Sparc] Change to let clang know that setjmp and longjmp intrinsics are implemented in the back-end.

2016-06-15 Thread Joerg Sonnenberger via cfe-commits
On Wed, Jun 15, 2016 at 12:44:48PM -, Chris Dewhurst via cfe-commits wrote: > Modified: cfe/trunk/lib/Basic/Targets.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=272782&r1=272781&r2=272782&view=diff > ==

Re: [PATCH] Restructure the propagation of -fPIC/-fPIE.

2016-06-21 Thread Joerg Sonnenberger via cfe-commits
On Tue, Jun 21, 2016 at 06:53:03PM -0400, Rafael Espíndola via cfe-commits wrote: > diff --git a/lib/Frontend/InitPreprocessor.cpp > b/lib/Frontend/InitPreprocessor.cpp > index 27ef59a..6b93c69 100644 > --- a/lib/Frontend/InitPreprocessor.cpp > +++ b/lib/Frontend/InitPreprocessor.cpp > @@ -873,10

Re: [PATCH] Restructure the propagation of -fPIC/-fPIE.

2016-06-22 Thread Joerg Sonnenberger via cfe-commits
On Wed, Jun 22, 2016 at 08:06:06AM -0400, Rafael Espíndola wrote: > On 21 June 2016 at 19:04, Joerg Sonnenberger via cfe-commits > wrote: > > On Tue, Jun 21, 2016 at 06:53:03PM -0400, Rafael Espíndola via cfe-commits > > wrote: > >> diff --git a/lib/Frontend/InitP

Re: [PATCH] D21637: [libcxx] Don't use pthread initializers in constexpr constructors

2016-06-23 Thread Joerg Sonnenberger via cfe-commits
On Thu, Jun 23, 2016 at 02:27:12PM +, Ben Craig via cfe-commits wrote: > bcraig added subscribers: joerg, bcraig. > bcraig added a comment. > > @joerg. I think this has been fixed in newer versions of NetBSD. > > Sure would be nice if someone could fix this on the MUSL side of things. > > S

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

2016-06-29 Thread Joerg Sonnenberger via cfe-commits
joerg added a subscriber: joerg. joerg added a comment. On the topic of __cxa_thread_atexit, was it ever specified how it interacts with things like thread cancellation? http://reviews.llvm.org/D21803 ___ cfe-commits mailing list cfe-commits@lists.

Re: [PATCH] D21830: Remove -mrelax-all from Clang -O0

2016-06-29 Thread Joerg Sonnenberger via cfe-commits
On Wed, Jun 29, 2016 at 11:00:26AM -0400, Rafael Espíndola via cfe-commits wrote: > We need to benchmark this to see if it still makes a difference. > > My canonical test is the .s of a lto of clang. That won't exercise it? Assembler sources are exempt from this. Joerg _

Re: [cfe-dev] RFC: Default language standard mode policy

2016-06-29 Thread Joerg Sonnenberger via cfe-commits
On Wed, Jun 29, 2016 at 12:09:37PM -0700, Richard Smith via cfe-dev wrote: > Hi all! > > I'd like to establish a policy for Clang's default language standard (if > none is specified with -std), as follows: > > Clang defaults to the most recent published standard for the selected > language that

Re: [cfe-dev] RFC: Default language standard mode policy

2016-06-29 Thread Joerg Sonnenberger via cfe-commits
On Wed, Jun 29, 2016 at 03:07:33PM -0700, Richard Smith wrote: > On Wed, Jun 29, 2016 at 2:48 PM, Joerg Sonnenberger via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On Wed, Jun 29, 2016 at 12:09:37PM -0700, Richard Smith via cfe-dev wrote: > > > H

Re: [PATCH] D21637: [libcxx] Don't use pthread initializers in constexpr constructors

2016-06-30 Thread Joerg Sonnenberger via cfe-commits
On Thu, Jun 30, 2016 at 06:37:59AM +, Eric Fiselier wrote: > EricWF requested changes to this revision. > EricWF added a comment. > This revision now requires changes to proceed. > > C++03 does not support default member initializers but libc++ provides both > of these classes an extensions i

Re: [cfe-dev] RFC: Default language standard mode policy

2016-07-01 Thread Joerg Sonnenberger via cfe-commits
On Thu, Jun 30, 2016 at 01:41:00PM -0700, Richard Smith wrote: > On Thu, Jun 30, 2016 at 2:02 AM, David Chisnall > wrote: > > > On 29 Jun 2016, at 23:07, Richard Smith via cfe-dev < > > cfe-...@lists.llvm.org> wrote: > > > > > > Yes, those are real problems, but it's not reasonable for us to keep

Re: [libcxx] r275114 - Don't compute modulus of hash if it is smaller than the bucket count.

2016-07-18 Thread Joerg Sonnenberger via cfe-commits
On Sun, Jul 17, 2016 at 01:54:57PM -0700, Arthur O'Dwyer via cfe-commits wrote: > IMHO, if replacing "%" with "fastmod" in general-purpose code like this > were a good idea, > (A) libc++ should introduce a helper function __fastmod(m,n) for the > purpose, not repeat the same patch everywhere there'

Re: r262200 - [X86] Enabling xsave should not enable AVX. I seem to have done this, but I don't know why.

2016-02-29 Thread Joerg Sonnenberger via cfe-commits
On Mon, Feb 29, 2016 at 06:51:34AM -, Craig Topper via cfe-commits wrote: > Author: ctopper > Date: Mon Feb 29 00:51:34 2016 > New Revision: 262200 > > URL: http://llvm.org/viewvc/llvm-project?rev=262200&view=rev > Log: > [X86] Enabling xsave should not enable AVX. I seem to have done this, bu

Re: [PATCH] D17286: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB

2016-02-29 Thread Joerg Sonnenberger via cfe-commits
joerg added a comment. I dislike the value `default`, since with `CLANG_DEFAULT_CXX_STDLIB` it is not. Otherwise, it should be fine. http://reviews.llvm.org/D17286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [PATCH] D17286: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB

2016-02-29 Thread Joerg Sonnenberger via cfe-commits
joerg added a comment. I was thinking about something like `-stdlib=platform` to reflect that it is the target choice. http://reviews.llvm.org/D17286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

2016-02-29 Thread Joerg Sonnenberger via cfe-commits
joerg added a subscriber: joerg. joerg added a comment. I've added functionality like that to NetBSD's GCC a long time ago. That functionality is useful for a variety of situations, cutting down file space or canonicalization are two uses.

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

2016-03-03 Thread Joerg Sonnenberger via cfe-commits
On Thu, Mar 03, 2016 at 07:39:04PM +, Weiming Zhao via cfe-commits wrote: > Change the option name to -ffile-macro-prefix-to-remove This still sounds to me like a solution for a very restricted part of a much more generic problem... Joerg ___ cfe-co

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

2016-03-03 Thread Joerg Sonnenberger via cfe-commits
On Thu, Mar 03, 2016 at 02:09:17PM -0800, Nico Weber via cfe-commits wrote: > On Thu, Mar 3, 2016 at 1:50 PM, Joerg Sonnenberger via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On Thu, Mar 03, 2016 at 07:39:04PM +, Weiming Zhao via cfe-commits > > wro

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

2016-03-04 Thread Joerg Sonnenberger via cfe-commits
On Thu, Mar 03, 2016 at 04:50:11PM -0800, Nico Weber via cfe-commits wrote: > On Thu, Mar 3, 2016 at 4:28 PM, Joerg Sonnenberger via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On Thu, Mar 03, 2016 at 02:09:17PM -0800, Nico Weber via cfe-commits wrote: > >

r262837 - Describe the magic numbers returned by getEHDataRegisterNumber.

2016-03-07 Thread Joerg Sonnenberger via cfe-commits
Author: joerg Date: Mon Mar 7 11:18:41 2016 New Revision: 262837 URL: http://llvm.org/viewvc/llvm-project?rev=262837&view=rev Log: Describe the magic numbers returned by getEHDataRegisterNumber. Modified: cfe/trunk/include/clang/Basic/TargetInfo.h Modified: cfe/trunk/include/clang/Basic/Tar

r262838 - Implement __builtin_eh_return_data_regno for SPARC and SPARC64.

2016-03-07 Thread Joerg Sonnenberger via cfe-commits
Author: joerg Date: Mon Mar 7 11:19:15 2016 New Revision: 262838 URL: http://llvm.org/viewvc/llvm-project?rev=262838&view=rev Log: Implement __builtin_eh_return_data_regno for SPARC and SPARC64. Added: cfe/trunk/test/CodeGen/builtins-sparc.c Modified: cfe/trunk/lib/Basic/Targets.cpp Mod

Re: r262838 - Implement __builtin_eh_return_data_regno for SPARC and SPARC64.

2016-03-07 Thread Joerg Sonnenberger via cfe-commits
On Mon, Mar 07, 2016 at 05:19:16PM -, Joerg Sonnenberger via cfe-commits wrote: > Author: joerg > Date: Mon Mar 7 11:19:15 2016 > New Revision: 262838 > > URL: http://llvm.org/viewvc/llvm-project?rev=262838&view=rev > Log: > Implement __builtin_eh_return_data_re

Re: [PATCH] D17950: Implement is_always_lock_free

2016-03-19 Thread Joerg Sonnenberger via cfe-commits
On Thu, Mar 17, 2016 at 05:56:17PM +, JF Bastien via cfe-commits wrote: > C++ atomics are explicitly designed to avoid problems with touching > adjacent bytes: if `atomic` where `sizeof(T) == 1` requires a 4-byte > `cmpxchg` then it's up to the frontend to make sure `sizeof> >= 4` > (or somethi

Re: [PATCH] D17746: Fix PR26741 -- __builtin_object_size is not consistently conservative with C++ inheritance

2016-03-20 Thread Joerg Sonnenberger via cfe-commits
On Fri, Mar 18, 2016 at 05:11:19PM +, Richard Smith via cfe-commits wrote: > rsmith added a comment. > > Can you explain a bit more about the problem? It seems to me that if I have: > > struct Base { > char k[1]; > }; > struct Derived : Base {}; > > ... then the 'k' subobject of a

Re: [PATCH] D17950: Implement is_always_lock_free

2016-03-20 Thread Joerg Sonnenberger via cfe-commits
On Fri, Mar 18, 2016 at 12:11:22PM -0500, Craig, Ben via cfe-commits wrote: > A lot of it is a frontend decision. What goes in the libcall feels an awful > lot like the 386 vs 486 example that I hear a lot. If I want one binary > that can run on both a 386 (very limited atomic support) and a 486

Re: r256596 - Emit a -Wmicrosoft warning when treating ^Z as EOF in MS mode.

2015-12-30 Thread Joerg Sonnenberger via cfe-commits
On Tue, Dec 29, 2015 at 11:17:28PM -, Nico Weber via cfe-commits wrote: > Author: nico > Date: Tue Dec 29 17:17:27 2015 > New Revision: 256596 > > URL: http://llvm.org/viewvc/llvm-project?rev=256596&view=rev > Log: > Emit a -Wmicrosoft warning when treating ^Z as EOF in MS mode. Do they reall

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Joerg Sonnenberger via cfe-commits
On Tue, Jan 05, 2016 at 08:12:34PM +, Dimitry Andric via cfe-commits wrote: > In rL256641, @davide turned off movt generation by default for FreeBSD. > This was because our ld is very old, and did not support the relocations > for it. However, Ian Lepore added the support very recently, so we

Re: r256920 - Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-06 Thread Joerg Sonnenberger via cfe-commits
On Wed, Jan 06, 2016 at 07:42:18AM -, Dimitry Andric via cfe-commits wrote: > Author: dim > Date: Wed Jan 6 01:42:18 2016 > New Revision: 256920 > > URL: http://llvm.org/viewvc/llvm-project?rev=256920&view=rev > Log: > Add -fno-movt frontend option, to disable movt/movw on ARM Commit message

Re: r256967 - [WebAssembly] Add --gc-sections to the link line.

2016-01-06 Thread Joerg Sonnenberger via cfe-commits
On Wed, Jan 06, 2016 at 07:43:32PM -, Dan Gohman via cfe-commits wrote: > Author: djg > Date: Wed Jan 6 13:43:32 2016 > New Revision: 256967 > > URL: http://llvm.org/viewvc/llvm-project?rev=256967&view=rev > Log: > [WebAssembly] Add --gc-sections to the link line. Can you make sure it is add

Re: r257357 - [Sema] Issue a warning for integer overflow in struct initializer

2016-01-11 Thread Joerg Sonnenberger via cfe-commits
On Mon, Jan 11, 2016 at 05:22:01PM -, Akira Hatanaka via cfe-commits wrote: > Author: ahatanak > Date: Mon Jan 11 11:22:01 2016 > New Revision: 257357 > > URL: http://llvm.org/viewvc/llvm-project?rev=257357&view=rev > Log: > [Sema] Issue a warning for integer overflow in struct initializer >

Re: r257357 - [Sema] Issue a warning for integer overflow in struct initializer

2016-01-11 Thread Joerg Sonnenberger via cfe-commits
On Mon, Jan 11, 2016 at 12:28:36PM -0800, Akira Hatanaka via cfe-commits wrote: > It triggers in dead branches and so does an initialization of an integer > variable declared in a function. I'm more interested in the case of global initialisers here. There is a long standing history of not checki

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

2016-01-14 Thread Joerg Sonnenberger via cfe-commits
On Thu, Jan 14, 2016 at 02:05:21AM +, Weiming Zhao via cfe-commits wrote: > r255371 errors on redeclaring with a conflicting asm label. > This patch changes errors to warnings to prevent breaking existing codes. I'm not sure I agree with this. We have triggered this in NetBSD in two different

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

2016-01-14 Thread Joerg Sonnenberger via cfe-commits
On Thu, Jan 14, 2016 at 03:05:26PM -0800, Zhao, Weiming via cfe-commits wrote: > I agree what you said about different code generated with clang and GCC > generates. In this case, we should throw an error (err_late_asm_label). > > But in this example, there is no use of the function. They are just

r257947 - Avoid self-assignment of SmallString, trigger UB behavior down the road.

2016-01-15 Thread Joerg Sonnenberger via cfe-commits
Author: joerg Date: Fri Jan 15 16:29:34 2016 New Revision: 257947 URL: http://llvm.org/viewvc/llvm-project?rev=257947&view=rev Log: Avoid self-assignment of SmallString, trigger UB behavior down the road. Modified: cfe/trunk/tools/driver/driver.cpp Modified: cfe/trunk/tools/driver/driver.cpp

Re: r257947 - Avoid self-assignment of SmallString, trigger UB behavior down the road.

2016-01-15 Thread Joerg Sonnenberger via cfe-commits
On Fri, Jan 15, 2016 at 02:52:08PM -0800, David Blaikie via cfe-commits wrote: > On Fri, Jan 15, 2016 at 2:29 PM, Joerg Sonnenberger via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > Author: joerg > > Date: Fri Jan 15 16:29:34 2016 > > New Revision: 25

Re: r257947 - Avoid self-assignment of SmallString, trigger UB behavior down the road.

2016-01-16 Thread Joerg Sonnenberger via cfe-commits
Hello Richard, can this be merged into 3.8? It creates some trivial noise under valgrind. Joerg On Fri, Jan 15, 2016 at 10:29:34PM -, Joerg Sonnenberger via cfe-commits wrote: > Author: joerg > Date: Fri Jan 15 16:29:34 2016 > New Revision: 257947 > > URL: http://llvm.

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

2016-01-18 Thread Joerg Sonnenberger via cfe-commits
On Tue, Jan 05, 2016 at 05:27:34AM +, Timon Van Overveldt via cfe-commits wrote: > Adds a number of constants, defined in the ARM EHABI spec, to the Clang > lib/Headers/unwind.h header. This is prerequisite for landing > http://reviews.llvm.org/D15781, as previously discussed there. IMO they

Re: r257947 - Avoid self-assignment of SmallString, trigger UB behavior down the road.

2016-01-23 Thread Joerg Sonnenberger via cfe-commits
On Sat, Jan 16, 2016 at 03:51:11PM +0100, Joerg Sonnenberger via cfe-commits wrote: > Hello Richard, > can this be merged into 3.8? It creates some trivial noise under > valgrind. Ping? Joerg ___ cfe-commits mailing list cfe-commits@lists

Re: [PATCH] D16533: Bug 20796 - GCC's -Wstrict-prototypes warning not implemented in Clang

2016-01-25 Thread Joerg Sonnenberger via cfe-commits
Thanks for working on this! On Mon, Jan 25, 2016 at 03:18:31PM +, Paul Titei via cfe-commits wrote: > +// function definition with 0 params(for both cases), valid according to > 6.7.5.3/14 > +void foo1() {} I still want to get a warning for this. At best it is inconsistent. > +// Function d

Re: [PATCH] D15897: [libc++] Silence warning about padding inserted at the tail of struct _Rep_base

2016-01-26 Thread Joerg Sonnenberger via cfe-commits
joerg added a comment. As I said on IRC, it might be useful to set -Wpadding -Wno-error=padding, but I don't think the current state adds value. So removing the option is certainly an acceptable step forward to me. http://reviews.llvm.org/D15897 _

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

2016-01-26 Thread Joerg Sonnenberger via cfe-commits
On Mon, Jan 25, 2016 at 09:14:52PM -, Ehsan Akhgari via cfe-commits wrote: > Author: ehsan > Date: Mon Jan 25 15:14:52 2016 > New Revision: 258720 > > URL: http://llvm.org/viewvc/llvm-project?rev=258720&view=rev > Log: > [MSVC Compat] Only warn for unknown clang-cl arguments > > Summary: > MS

Re: [PATCH] D15897: [libc++] Silence warning about padding inserted at the tail of struct _Rep_base

2016-01-26 Thread Joerg Sonnenberger via cfe-commits
On Tue, Jan 26, 2016 at 07:43:03PM +, Akira Hatanaka via cfe-commits wrote: > ahatanak added a comment. > > Do you mean "-Wpadded -Wno-error=padded" instead of padding? > > I'm looking for a way to silence the warning, so that isn't enough. If > we need more time to decide whether we want to

Re: [PATCH] D16613: Introduce a cmake module to figure out whether we need to link with libatomic.

2016-01-28 Thread Joerg Sonnenberger via cfe-commits
joerg added a comment. Thanks for working on it. I think it might be slightly better to explicitly test uintmax_t and uintptr_t as well. They could be larger than long long int and there are tests depending on the existance. Do we have any test cases for arbitrary sized trivally copyable struct

Re: [PATCH] D14760: Resolve build problem on NetBSD

2015-11-18 Thread Joerg Sonnenberger via cfe-commits
joerg added a comment. Are you sure your sources are up-to-date? That file is newly generated in LLVM and no changes outside should be necessary. Are you using cmake or gmake? Repository: rL LLVM http://reviews.llvm.org/D14760 ___ cfe-commits ma

Re: [libcxx] r254050 - Silence a -Wmissing-braces warning in the tests; mbstate_t is defined differently on different C libraries.

2015-11-25 Thread Joerg Sonnenberger via cfe-commits
On Tue, Nov 24, 2015 at 05:38:23PM -0800, David Blaikie via cfe-commits wrote: > Could this initialization just be written as "mbstate_t mb = {}" & avoid > the warning entirely (I'm not entirely sure what the warning was, but I > imagine that'd avoid it) Or even better, just use the portable memse

r254199 - Revert Sparc and SparcV9 to external assembler. Now that the CPU

2015-11-27 Thread Joerg Sonnenberger via cfe-commits
Author: joerg Date: Fri Nov 27 07:16:33 2015 New Revision: 254199 URL: http://llvm.org/viewvc/llvm-project?rev=254199&view=rev Log: Revert Sparc and SparcV9 to external assembler. Now that the CPU handling is corrected, the primary reason for forcing IAS as default is gone and the remaining issues

Re: r254143 - Fix for merging decls in pragma weak

2015-12-02 Thread Joerg Sonnenberger via cfe-commits
On Thu, Nov 26, 2015 at 09:34:31AM -, Alexander Musman via cfe-commits wrote: > Author: amusman > Date: Thu Nov 26 03:34:30 2015 > New Revision: 254143 > > URL: http://llvm.org/viewvc/llvm-project?rev=254143&view=rev > Log: > Fix for merging decls in pragma weak > Calling CheckFunctionDeclara

Re: [PATCH] D15166: Fix C++ support on recent DragonFly BSD releases

2015-12-02 Thread Joerg Sonnenberger via cfe-commits
On Thu, Dec 03, 2015 at 12:15:25AM +, Dimitry Andric wrote: > This patch updates the Clang driver to use libstdc++ from GCC 5.2 What about the abi tag mess? Or do you actually mean GCC 5.0? Joerg ___ cfe-commits mailing list cfe-commits@lists.llvm.o

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

2015-12-07 Thread Joerg Sonnenberger via cfe-commits
On Thu, Dec 03, 2015 at 01:36:22AM -, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Wed Dec 2 19:36:22 2015 > New Revision: 254574 > > URL: http://llvm.org/viewvc/llvm-project?rev=254574&view=rev > Log: > PR17381: Treat undefined behavior during expression evaluation as an unm

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

2015-12-08 Thread Joerg Sonnenberger via cfe-commits
On Mon, Dec 07, 2015 at 01:32:14PM -0800, Richard Smith via cfe-commits wrote: > C11 6.3.1.5/1: "If the value being converted is outside the range of values > that can be represented, the behavior is undefined." The value of 1e100 can be represented as +inf, even if not precisely. This is a bit di

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

2015-12-08 Thread Joerg Sonnenberger via cfe-commits
On Mon, Dec 07, 2015 at 01:32:14PM -0800, Richard Smith via cfe-commits wrote: > Worse, it seems > > even using __builtin_nan() for example doesn't work. > > > > __builtin_nan() works fine for me, can you provide a testcase? I take this part back, pilot error. Joerg _

Re: [PATCH] D15455: [Driver] Let -static override the toolchain default PIC setting.

2015-12-11 Thread Joerg Sonnenberger via cfe-commits
joerg added a comment. As before, I don't see why a linker flag should change code generation. That seems to be a gross violation of layering and quite surprising. http://reviews.llvm.org/D15455 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

Re: [PATCH] D15455: [Driver] Let -static override the toolchain default PIC setting.

2015-12-11 Thread Joerg Sonnenberger via cfe-commits
On Fri, Dec 11, 2015 at 07:49:25PM +, Frederic Riss wrote: > friss added a comment. > > Just because it makes the behavior more intuitive? If you toolchain > does PIC by default, it's because you are mostly building shared > objects. When you are building a static object, it's highly likely >

Re: [PATCH] D15455: [Driver] Let -static override the toolchain default PIC setting.

2015-12-17 Thread Joerg Sonnenberger via cfe-commits
On Wed, Dec 16, 2015 at 11:59:10PM +, Bob Wilson via cfe-commits wrote: > We can change this to be Darwin-specific if you prefer, but we should > maintain compatibility with GCC and previous Clang releases in this behavior. Who is really affected by this? I don't care too much about obscure Da

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-18 Thread Joerg Sonnenberger via cfe-commits
On Fri, Dec 18, 2015 at 01:53:58PM +, James Molloy wrote: > The gold plugin understands -O0..-O3, but these are not currently being > passed to it. Is this about generic optimizer flags in the sense of things that get back to LLVM or about linker-style optimizations? Joerg __

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-18 Thread Joerg Sonnenberger via cfe-commits
On Fri, Dec 18, 2015 at 03:59:03PM +, James Molloy via cfe-commits wrote: > This is about the standard generic optimizer flags. Currently when using > -flto, the backend behaves always as if "-O2" were passed (because this is > the default codegen optimization level inside the gold plugin and i

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

2015-12-18 Thread Joerg Sonnenberger via cfe-commits
On Fri, Dec 18, 2015 at 05:31:45PM +, James Molloy via cfe-commits wrote: > Evidently not, at least not completely. I see codegen differences with this > patch (and at least one significant improvement). I don't mind the patch as is, but it seems to be a move in the wrong direction by hiding t

Re: [PATCH] D15455: [Driver] Let -static override the toolchain default PIC setting.

2015-12-18 Thread Joerg Sonnenberger via cfe-commits
On Fri, Dec 18, 2015 at 12:45:47PM -0800, Bob Wilson via cfe-commits wrote: > > > On Dec 17, 2015, at 10:59 AM, Bob Wilson via cfe-commits > > wrote: > > > > > >> On Dec 17, 2015, at 10:16 AM, Joerg Sonnenberger via cfe-commits > >> wrote: > &

Re: r256468 - On {mips, mipsel, mips64, mips64el}-freebsd, we need to pass any -G option to the assembler.

2015-12-27 Thread Joerg Sonnenberger via cfe-commits
On Sun, Dec 27, 2015 at 10:36:44AM -, Dimitry Andric via cfe-commits wrote: > Author: dim > Date: Sun Dec 27 04:36:44 2015 > New Revision: 256468 > > URL: http://llvm.org/viewvc/llvm-project?rev=256468&view=rev > Log: > On {mips,mipsel,mips64,mips64el}-freebsd, we need to pass any -G option to

<    1   2   3