Author: joerg
Date: Sat Jul 1 14:36:21 2017
New Revision: 306965
URL: http://llvm.org/viewvc/llvm-project?rev=306965&view=rev
Log:
Add an option group for deprecated warnings. Add the removed
-fslp-vectorize-aggressive and -fno-slp-vectorize-aggressive flags back
under this group and test for the
On Tue, Jul 04, 2017 at 07:55:56PM -, Kamil Rytarowski via cfe-commits
wrote:
> Modified: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp?rev=307104&r1=307103&r2=307104&view=diff
> =
Author: joerg
Date: Tue Jul 11 08:49:45 2017
New Revision: 307664
URL: http://llvm.org/viewvc/llvm-project?rev=307664&view=rev
Log:
Run the preprocessor test as frontend test for NetBSD, since CC1 mode
doesn't get flags like the default target CPU. Update for test to
reflect the difference.
Modif
Author: joerg
Date: Tue Jul 11 08:50:48 2017
New Revision: 307665
URL: http://llvm.org/viewvc/llvm-project?rev=307665&view=rev
Log:
NetBSD uses soft-float by default, unless the environment is EABIHF or
GNUEABIHF.
Modified:
cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp
cfe/trunk/test/Prepr
On Fri, Jul 14, 2017 at 02:40:25PM +, Manuel Klimek via Phabricator via
cfe-commits wrote:
> klimek added a comment.
>
> In https://reviews.llvm.org/D34440#809581, @vladimir.plyashkun wrote:
>
> > > Are there any concerns using the alternative?
> >
> > I can't say that it's a big problems, b
On Sun, Jul 23, 2017 at 03:17:32PM -0400, Nico Weber via cfe-commits wrote:
> On Sun, Jul 23, 2017 at 3:08 PM, Joerg Sonnenberger via Phabricator via
> cfe-commits wrote:
>
> > joerg added a comment.
> >
> > I don't really like this.
>
> That's cool, you don't need to use the flag.
I'm not talk
On Sun, Jul 23, 2017 at 07:06:25PM -0400, Nico Weber via cfe-commits wrote:
> If you need this behavior for something, that sounds like something a
> -nodefaultlibs++ could do. -nostdlib++ is really meant to disable the c++
> stdlib and nothing else.
But the -lm is only there because -lc++ alone (
On Tue, Jul 25, 2017 at 03:09:00PM -0400, Nico Weber via cfe-commits wrote:
> On Tue, Jul 25, 2017 at 2:53 PM, Joerg Sonnenberger wrote:
>
> > On Sun, Jul 23, 2017 at 07:06:25PM -0400, Nico Weber via cfe-commits wrote:
> > > If you need this behavior for something, that sounds like something a
>
On Thu, Mar 02, 2017 at 04:20:47PM +, Simon Byrne via Phabricator via
cfe-commits wrote:
> simonbyrne created this revision.
>
> This is probably good to document, as the behaviour of `-fstrict-aliasing`
> differs from gcc in a quite important way (see
> https://bugs.llvm.org//show_bug.cgi?
joerg added a comment.
Besides "it triggers on SPEC", why should the warning be disabled here? I think
it is perfectly sensible to have a warning for all six conditional contexts
here.
https://reviews.llvm.org/D26636
___
cfe-commits mailing list
c
Author: joerg
Date: Wed Nov 23 19:24:38 2016
New Revision: 287847
URL: http://llvm.org/viewvc/llvm-project?rev=287847&view=rev
Log:
Spelling.
Modified:
cfe/trunk/include/clang/Tooling/JSONCompilationDatabase.h
Modified: cfe/trunk/include/clang/Tooling/JSONCompilationDatabase.h
URL:
http://l
Author: joerg
Date: Fri Nov 25 08:14:43 2016
New Revision: 287926
URL: http://llvm.org/viewvc/llvm-project?rev=287926&view=rev
Log:
Document the arguments form of commands.
Modified:
cfe/trunk/docs/JSONCompilationDatabase.rst
Modified: cfe/trunk/docs/JSONCompilationDatabase.rst
URL:
http://
Author: joerg
Date: Fri Nov 25 14:15:57 2016
New Revision: 287947
URL: http://llvm.org/viewvc/llvm-project?rev=287947&view=rev
Log:
Typo.
Modified:
cfe/trunk/lib/Tooling/ArgumentsAdjusters.cpp
Modified: cfe/trunk/lib/Tooling/ArgumentsAdjusters.cpp
URL:
http://llvm.org/viewvc/llvm-project/cf
Author: joerg
Date: Thu Dec 1 17:37:45 2016
New Revision: 288436
URL: http://llvm.org/viewvc/llvm-project?rev=288436&view=rev
Log:
Extend CompilationDatabase by a field for the output filename
In bigger projects like an Operating System, the same source code is
often compiled in slightly differe
Author: joerg
Date: Tue Dec 6 10:33:22 2016
New Revision: 288821
URL: http://llvm.org/viewvc/llvm-project?rev=288821&view=rev
Log:
Allow clang to write compilation database records.
When integrating compilation database output into existing build
systems, two approaches dominate so far. Ad-hoc i
Author: joerg
Date: Tue Dec 6 10:40:57 2016
New Revision: 288822
URL: http://llvm.org/viewvc/llvm-project?rev=288822&view=rev
Log:
If clang was configured for a DEFAULT_SYSROOT and no --sysroot argument
is seen, record one with the implicit default.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Author: joerg
Date: Tue Dec 6 10:47:00 2016
New Revision: 288823
URL: http://llvm.org/viewvc/llvm-project?rev=288823&view=rev
Log:
Make test case slightly more robust by explicitly passing --sysroot.
Otherwise it would change when DEFAULT_SYSROOT is provided.
Modified:
cfe/trunk/test/Driver/
Author: joerg
Date: Tue Dec 6 11:02:41 2016
New Revision: 288827
URL: http://llvm.org/viewvc/llvm-project?rev=288827&view=rev
Log:
Allow additional output since e.g. OSX appends flags like
"-mlinker-version=264.3.102" automatically. Wiring down a target on the
other hand is problematic as this ac
Author: joerg
Date: Tue Dec 6 11:06:33 2016
New Revision: 288828
URL: http://llvm.org/viewvc/llvm-project?rev=288828&view=rev
Log:
Fix FileCheck pattern.
Modified:
cfe/trunk/test/Driver/compilation_database.c
Modified: cfe/trunk/test/Driver/compilation_database.c
URL:
http://llvm.org/viewv
joerg added a comment.
I agree that leaving out the really complicated parts is acceptable for now.
Can you mark the comment as TODO?
https://reviews.llvm.org/D23657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
joerg accepted this revision.
joerg added a reviewer: joerg.
joerg added a comment.
This revision is now accepted and ready to land.
Commit the prototype fix separately, please.
https://reviews.llvm.org/D25431
___
cfe-commits mailing list
cfe-commit
joerg added a comment.
So the historical reason for the libgcc_s dance for glibc was the use of
unwinding for thread cancellation. With all the glibc versions I can find,
going back to SLES11 SP1, this is no longer the case. To check for yourself,
look for _Unwind* symbols in libc.so and libc.a
joerg added a comment.
Can we please avoid adding more (pseudo) keywords in the double-underscore name
space? Those tend to be used a lot by existing libc implementations and
existing attribute cases like __strong and __weak have created enough trouble.
https://reviews.llvm.org/D25204
_
joerg added a comment.
The __ namespace is shared between all parts of the implementation, not just
the compiler. The convention in the past was that compiler keywords will end in
a __ as well, but calling conventions and Objective C broke that convention. I
still think it is something that sho
On Fri, Oct 28, 2016 at 06:06:50AM -, Eric Fiselier via cfe-commits wrote:
> Author: ericwf
> Date: Fri Oct 28 01:06:50 2016
> New Revision: 285382
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285382&view=rev
> Log:
> Add __libcpp_version file and __libcpp_library_version function.
I real
On Sun, Oct 30, 2016 at 12:54:28PM -0600, Eric Fiselier wrote:
> Richard requested this change. Take a look at
> https://reviews.llvm.org/D26044 for more rational.
I don't see much rational and in fact, I disagree with some of the
mentioned items. E.g. presence of libc++ won't tell you if you can
On Sun, Oct 30, 2016 at 01:49:53PM -0600, Eric Fiselier via cfe-commits wrote:
> > E.g. presence of libc++ won't tell you if you can use sized deallocation
> > as that's a ABI library issue.
>
> The value of __libcpp_version could easily be updated by vendors to store
> the version of the system
On Mon, Oct 31, 2016 at 10:45:05AM -0700, Richard Smith via cfe-commits wrote:
> On Sun, Oct 30, 2016 at 12:32 PM, Joerg Sonnenberger wrote:
>
> > On Sun, Oct 30, 2016 at 12:54:28PM -0600, Eric Fiselier wrote:
> > > Richard requested this change. Take a look at
> > > https://reviews.llvm.org/D260
On Mon, Oct 31, 2016 at 01:25:19PM -0700, Richard Smith wrote:
> We could alternatively control the language features based only on the
> selected language mode, and only use version detection to power a warning
> for the (currently fairly common, but becoming less so) case where the
> selected run
joerg added a comment.
It works for me with the mentioned TODO item. But I'm not the right one to give
a full OK.
https://reviews.llvm.org/D23657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
On Wed, Nov 09, 2016 at 03:43:52PM -, Douglas Katzman via cfe-commits wrote:
> Author: dougk
> Date: Wed Nov 9 09:43:51 2016
> New Revision: 286376
>
> URL: http://llvm.org/viewvc/llvm-project?rev=286376&view=rev
> Log:
> [Sparc] LLONG is not lock-free atomic on v8
Technically, even 32bit is
joerg created this revision.
joerg added a reviewer: hfinkel.
joerg added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
Most of the PowerPC64 code generation already creates PIC access. This changes
to a full PIC default, similar to what GCC is doing.
Overall, a monolithic clan
On Fri, Aug 28, 2015 at 07:52:17PM +0200, Xan López via cfe-commits wrote:
> There is no __cxa_finalize symbol available on recent Solaris OS
> versions, so we need this flag to make non trivial C++ programs run.
What do you consider as recent Solaris? When I asked, I've been told
that Illumos has
On Mon, Sep 07, 2015 at 11:50:55PM +, Eric Fiselier via cfe-commits wrote:
> EricWF added a comment.
>
> Why would we not use "-isysroot" on other platforms as well?
Because otherwise you can't link in a cross-compiling setup?
Joerg
___
cfe-commits
On Tue, Sep 08, 2015 at 01:32:21PM +0200, Xan López via cfe-commits wrote:
> On Tue, Sep 08, 2015 at 01:27:42PM +0200, Xan López via cfe-commits wrote:
> > > What do you consider as recent Solaris? When I asked, I've been told
> > > that Illumos has been providing __cxa_atexit since 2013. As such,
Author: joerg
Date: Fri Sep 18 06:13:43 2015
New Revision: 247981
URL: http://llvm.org/viewvc/llvm-project?rev=247981&view=rev
Log:
Pass the relocation model to LLVM for assembler files.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
cfe/trunk/tools/driver/cc1as_main.cpp
Modified: cfe/t
On Tue, Sep 22, 2015 at 01:52:33PM -, Daniel Sanders via cfe-commits wrote:
> Author: dsanders
> Date: Tue Sep 22 08:52:32 2015
> New Revision: 248276
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248276&view=rev
> Log:
> [mips] Added support for using the command line options -Wa,-msoft-fl
On Tue, Sep 22, 2015 at 05:44:59PM +, Eric Fiselier via cfe-commits wrote:
> EricWF added a comment.
>
> Does anything actually need this? This interface was never really meant to be
> complete, just want was needed.
>
> > It's a shame that libc++ decided to reinvent the wheel here and not u
On Tue, Sep 22, 2015 at 07:26:46PM +, Jonathan Roelofs via cfe-commits
wrote:
> jroelofs added a comment.
>
> In http://reviews.llvm.org/D13051#250910, @EricWF wrote:
>
> > @jroelofs @dim, could we fallback to the __sync_* builtins on arm?
>
>
> @dim would need armv4-flavored implementatio
Author: joerg
Date: Wed Sep 23 09:06:52 2015
New Revision: 248379
URL: http://llvm.org/viewvc/llvm-project?rev=248379&view=rev
Log:
Refactor library decision for -fopenmp support from Darwin into a
function for sharing with other platforms.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified:
Author: joerg
Date: Wed Sep 23 15:07:56 2015
New Revision: 248424
URL: http://llvm.org/viewvc/llvm-project?rev=248424&view=rev
Log:
Push OpenMP linker flags after linker input on Darwin. Don't add any
libraries if -nostdlib is specified. Test.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/
Author: joerg
Date: Wed Sep 23 15:11:00 2015
New Revision: 248426
URL: http://llvm.org/viewvc/llvm-project?rev=248426&view=rev
Log:
Support linking against OpenMP runtime on NetBSD.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/fopenmp.c
Modified: cfe/trunk/lib/Driver/To
On Thu, Sep 24, 2015 at 10:22:29AM +, Daniel Sanders via cfe-commits wrote:
> I'm thinking something like:
I think we really want to have an outer case, platform specific -Wa
options are quite common. Only x86 is mostly getting by without them so
far. I also think the switch is not that diffic
On Tue, Sep 08, 2015 at 08:06:00AM -, John McCall via cfe-commits wrote:
> Author: rjmccall
> Date: Tue Sep 8 03:05:57 2015
> New Revision: 246985
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246985&view=rev
> Log:
> Compute and preserve alignment more faithfully in IR-generation.
This s
On Mon, Sep 28, 2015 at 09:54:53PM +, don hinton via cfe-commits wrote:
> Add -Wc, option (similar to -Wl,) to go along with -Xclang.
> This makes it easier to pass multiple options to cc1.
How is this better than -mllvm and -Xclang? There is no precendence case for
this with GCC really and I
On Wed, Sep 30, 2015 at 02:19:58PM +, Daniel Sanders via cfe-commits wrote:
> Hi,
>
> Sorry for the slow reply. I'm a bit behind on cfe-commits and it seems I
> dropped out of the CC list so it didn't land in my inbox.
>
> Do you mean something like this?:
> for (...) {
> ...
>
On Thu, Oct 01, 2015 at 09:00:46PM +, Alex Rosenberg via cfe-commits wrote:
> alexr added a subscriber: alexr.
> alexr added a comment.
>
> PowerPC has floating point hardware by definition. Is this some new variant?
e500MC for example only has SPE, not "normal" FPU.
Joerg
__
On Mon, Oct 05, 2015 at 07:36:08PM +, Aaron Ballman via cfe-commits wrote:
> C-style variadic functions (using an ellipsis) can be dangerous in C++
> due to the inherit lack of type safety with argument passing. Better
> alternatives exist, such as function currying (like STL stream objects
> u
On Tue, Oct 06, 2015 at 07:12:12PM -, Aaron Watry via cfe-commits wrote:
> Author: awatry
> Date: Tue Oct 6 14:12:12 2015
> New Revision: 249445
>
> URL: http://llvm.org/viewvc/llvm-project?rev=249445&view=rev
> Log:
> integer: remove explicit casts from _MIN definitions
Why do this definiti
On Tue, Oct 06, 2015 at 04:20:05PM -0400, Aaron Ballman via cfe-commits wrote:
> On Tue, Oct 6, 2015 at 4:12 PM, Joerg Sonnenberger via cfe-commits
> wrote:
> > On Mon, Oct 05, 2015 at 07:36:08PM +, Aaron Ballman via cfe-commits
> > wrote:
> >> C-style variadic f
On Tue, Oct 06, 2015 at 01:31:01PM -, Aaron Ballman via cfe-commits wrote:
> Log:
> Add a new module for the C++ Core Guidelines, and the first checker
> for those guidelines: cppcoreguidelines-pro-type-reinterpret-cast.
I wonder about the generality of this. Does it really make sense to flag
joerg added a subscriber: joerg.
joerg added a comment.
I'm against doing this unconditionally. IMO it creates bugs without reasonable
compensation. Just because glibc wants to hurt people doesn't mean anyone
should get hurt.
http://reviews.llvm.org/D11948
__
joerg added a comment.
No, it doesn't. It tells the compiler that it is free to make such assumptions.
Take a step back from the standard. Can you think of any reasonable and
efficient implementation of memcpy and friends, which fails for size 0? Adding
the annotations (whether here or in strin
joerg added a subscriber: joerg.
joerg added a comment.
I agree in principle. The "-static" thing is already in the initial code, but
doesn't make sense to me.
Comment at: lib/Driver/Tools.cpp:2928
@@ +2927,3 @@
+/// Parses the various -fpic/-fPIC/-fpie/-fPIE arguments. Then,
joerg added a comment.
LLVM makes the assumptions only if the prototype has them too? Attribute
nonnull is certainly changing optimiser behavior with GCC...
http://reviews.llvm.org/D11948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
On Tue, Aug 11, 2015 at 02:06:58PM -0700, Marshall Clow via cfe-commits wrote:
> On Tue, Aug 11, 2015 at 1:34 PM, Dan Albert wrote:
>
> > Yeah, those sound like exactly what we want. Helping people find UB is
> > good, but optimizing assuming we've fixed all of the UB isn't something we
> > can d
joerg added a subscriber: joerg.
joerg added a comment.
This feels a bit like a regression. Before, libc++ works fine by just pointing
into the include directory.
Repository:
rL LLVM
http://reviews.llvm.org/D11781
___
cfe-commits mailing list
cf
On Wed, Aug 12, 2015 at 07:18:05PM -0500, Hal Finkel via cfe-commits wrote:
> I could say the same thing about many optimizations -- I spend a lot
> of time tracking down bugs they expose -- the real thing to investigate
> here are the potential benefits to real code from performing the
> optimizat
Author: joerg
Date: Tue Aug 18 15:34:33 2015
New Revision: 245343
URL: http://llvm.org/viewvc/llvm-project?rev=245343&view=rev
Log:
GC empty directory.
Removed:
libcxx/trunk/src/support/newlib/
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
joerg accepted this revision.
joerg added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D12164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
On Thu, Aug 20, 2015 at 06:32:27PM -, Douglas Katzman via cfe-commits wrote:
> Modified: cfe/trunk/test/Driver/biarch.c
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/biarch.c?rev=245595&r1=245594&r2=245595&view=diff
> ===
joerg added a subscriber: joerg.
joerg requested changes to this revision.
joerg added a reviewer: joerg.
joerg added a comment.
This revision now requires changes to proceed.
Please don't commit this as is. Many platforms have posix_memalign or
equivalent, which makes this both simpler and poten
On Fri, Sep 04, 2015 at 09:28:39PM +, Eric Fiselier via cfe-commits wrote:
> EricWF added a comment.
>
> In http://reviews.llvm.org/D12512#237175, @joerg wrote:
>
> > Please don't commit this as is. Many platforms have posix_memalign or
> > equivalent, which makes this both simpler and poten
On Sat, Sep 05, 2015 at 07:29:43PM +, Dan Albert via cfe-commits wrote:
> danalbert added a comment.
>
> Android has posix_memalign too.
Yes, but people seem to be reluctant to use it. See the linked review.
Joerg
___
cfe-commits mailing list
cfe-c
On Tue, Oct 27, 2015 at 06:10:26PM +, Samuel Benzaquen via cfe-commits
wrote:
> sbenza added a comment.
>
> In http://reviews.llvm.org/D14096#275902, @xazax.hun wrote:
>
> > There is already a similar check in the Google package. What are the
> > differences between those two checks? What i
On Mon, Oct 26, 2015 at 12:58:46PM -0300, Ariel Arelovich via cfe-commits wrote:
> So this is what I wanted to know. I think understand what you are saying.
> You are saying that most of the work that I would need to do from the AST
> (I'm assuming that this stands from Abstract Syntax Tree) is all
On Sun, Nov 01, 2015 at 08:48:53PM -0500, Aaron Ballman via cfe-commits wrote:
> On Sun, Nov 1, 2015 at 2:31 PM, Joerg Sonnenberger via cfe-commits
> wrote:
> > On Tue, Oct 27, 2015 at 06:10:26PM +, Samuel Benzaquen via cfe-commits
> > wrote:
> >> sbenza added a
On Mon, Nov 02, 2015 at 06:30:07AM -0300, Ariel Arelovich via cfe-commits wrote:
> One question that I still can't answer is the whole standard libraries. Are
> these precompiled for a given backend? Do I need to write them for my
> proposed arquitecture?
>
> Or by simply writing a new backend ev
On Fri, Nov 06, 2015 at 06:30:12AM -, Eric Fiselier via cfe-commits wrote:
> Author: ericwf
> Date: Fri Nov 6 00:30:12 2015
> New Revision: 252274
>
> URL: http://llvm.org/viewvc/llvm-project?rev=252274&view=rev
> Log:
> Cleanup foo.h headers and __config to work in C
Why?
Joerg
___
Author: joerg
Date: Mon Nov 9 17:39:45 2015
New Revision: 252545
URL: http://llvm.org/viewvc/llvm-project?rev=252545&view=rev
Log:
Reorganise CPU handling for Sparc. When using -mcpu=v9 and co, __sparcv8
is not defined for 32bit mode, but __sparcv9 is. Pass down the correct
-target-cpu flags to t
Author: joerg
Date: Mon Nov 9 18:23:12 2015
New Revision: 252562
URL: http://llvm.org/viewvc/llvm-project?rev=252562&view=rev
Log:
Use the normal switch over getArch() approach and not a long if chain.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
h
Author: joerg
Date: Mon Nov 9 18:40:29 2015
New Revision: 252571
URL: http://llvm.org/viewvc/llvm-project?rev=252571&view=rev
Log:
Use the generic Sparc CPU handling for Linux, FreeBSD and OpenBSD, too.
This currently changes the default toward the more historic -Av8/-Av9,
but as discussed with J
Author: joerg
Date: Tue Nov 10 13:28:17 2015
New Revision: 252640
URL: http://llvm.org/viewvc/llvm-project?rev=252640&view=rev
Log:
Add the variant of __sparc_v9__ with five underscores, not just four.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/Preprocessor/predefined-arch-m
joerg added a comment.
The specific CPU was only chosen to match what the backend supported at the
time. As long as the feature set is identical, it doesn't really matter.
http://reviews.llvm.org/D14570
___
cfe-commits mailing list
cfe-commits@list
Author: joerg
Date: Mon Aug 10 11:58:04 2015
New Revision: 244462
URL: http://llvm.org/viewvc/llvm-project?rev=244462&view=rev
Log:
Protect template argument from user interference.
Modified:
libcxx/trunk/include/type_traits
Modified: libcxx/trunk/include/type_traits
URL:
http://llvm.org/vi
On Mon, Aug 10, 2015 at 04:58:04PM -, Joerg Sonnenberger via cfe-commits
wrote:
> Author: joerg
> Date: Mon Aug 10 11:58:04 2015
> New Revision: 244462
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244462&view=rev
> Log:
> Protect template argument from user i
On Thu, Jul 30, 2015 at 07:01:22PM +, Davide Italiano wrote:
> Index: test/CXX/basic/basic.start/basic.start.main/p3.cpp
> ===
> --- test/CXX/basic/basic.start/basic.start.main/p3.cpp
> +++ test/CXX/basic/basic.start/basic.start.ma
On Tue, Jul 26, 2016 at 10:30:22PM +, Laxman Sole via cfe-commits wrote:
> Currently basic_string's destructor is not getting inlined. So adding
> 'inline' attribute to ~basic_string().
Does this change the ABI?
Joerg
___
cfe-commits mailing list
c
On Thu, Jul 28, 2016 at 10:11:05PM +, Vedant Kumar wrote:
> - test/Driver/netbsd.c
>
> We see -mcpu=arm1022e instead of arm926ej-s in a single run.
Which one exactly?
Joerg
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
On Mon, Aug 01, 2016 at 08:50:59AM -0700, Vedant Kumar wrote:
>
> > On Jul 30, 2016, at 12:59 PM, Joerg Sonnenberger via cfe-commits
> > wrote:
> >
> > On Thu, Jul 28, 2016 at 10:11:05PM +, Vedant Kumar wrote:
> >> - test/Driver/netbsd.c
> >&
joerg added a subscriber: joerg.
joerg added a comment.
For what it is worth, this certainly seems to be misnamed. By nature, if it
doesn't preserve at least the stack pointer, there is no way to recover on
return, right?
https://reviews.llvm.org/D22045
_
On Sun, Aug 07, 2016 at 11:08:22AM +, Amjad Aboud via cfe-commits wrote:
> aaboud marked 3 inline comments as done.
> aaboud added a comment.
>
> In https://reviews.llvm.org/D22045#506996, @joerg wrote:
>
> > For what it is worth, this certainly seems to be misnamed. By nature, if it
> > doe
On Wed, Aug 10, 2016 at 06:34:47PM -, Bruno Cardoso Lopes via cfe-commits
wrote:
> Author: bruno
> Date: Wed Aug 10 13:34:47 2016
> New Revision: 278264
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278264&view=rev
> Log:
> Reapply [Sema] Add sizeof diagnostics for bzero
Given that bzero
On Wed, Aug 10, 2016 at 02:36:01PM -0700, Bruno Cardoso Lopes wrote:
> Hi Joerg,
>
> > Given that bzero is pretty much non-standard at this point, I strongly
> > dislike the approach of checking only the function name.
>
> Thanks for the feedback. bzero it's widely used though, I think it's a
> u
On Thu, Aug 11, 2016 at 08:03:22PM -, Ed Schouten via cfe-commits wrote:
> Modified: cfe/trunk/lib/Driver/ToolChains.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=278395&r1=278394&r2=278395&view=diff
> =
joerg added a comment.
This is missing a test case.
https://reviews.llvm.org/D22130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Wed, Feb 10, 2016 at 04:21:02PM +, Alexander Kornienko via cfe-commits
wrote:
> alexfh added a comment.
>
> Thank you for working on this check!
>
> I'd like to note that there is a library-side way to mitigate this
> issue using the `[[clang::warn_unused_result]]` attribute on
> `vector:
On Thu, Feb 11, 2016 at 12:18:49AM +, Eric Christopher via cfe-commits
wrote:
> Mostly that you didn't mention it in your commit message.
>
> I'd rather prefer the rest of the file be changed to match the __ rather
> than the other way around :)
Depends. If it is a macro, not using __ is fin
On Wed, Feb 10, 2016 at 07:09:16PM -, Reid Kleckner via cfe-commits wrote:
> Modified: cfe/trunk/lib/Sema/CodeCompleteConsumer.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/CodeCompleteConsumer.cpp?rev=260411&r1=260410&r2=260411&view=diff
> ===
On Thu, Feb 11, 2016 at 10:50:29AM -0500, Ed Maste via llvm-commits wrote:
> On 8 February 2016 at 18:08, Joseph Myers wrote:
> > On Mon, 8 Feb 2016, H.J. Lu wrote:
> >
> >> >> I was referring to program properties:
> >> >>
> >> >> https://groups.google.com/forum/#!topic/generic-abi/fyIXttIsYc8
>
Author: joerg
Date: Thu Feb 11 17:18:36 2016
New Revision: 260616
URL: http://llvm.org/viewvc/llvm-project?rev=260616&view=rev
Log:
Now that Sparc/Sparc64 backend is mostly usable, provide the same
linking defaults as other NetBSD targets, i.e. compiler_rt-in-libc and
libc++ as STL.
Modified:
On Wed, Feb 10, 2016 at 09:26:44PM -0500, Sidney San Martín via cfe-commits
wrote:
> > On Feb 10, 2016, at 8:05 PM, Joerg Sonnenberger
> > wrote:
> >
> > I'm not a big fan of this. Those calls are by the very definition
> > harmless, so they aggrevate the existing problem of stupid annotation.
Author: joerg
Date: Thu Feb 11 17:35:03 2016
New Revision: 260617
URL: http://llvm.org/viewvc/llvm-project?rev=260617&view=rev
Log:
Remove decision logic for old NetBSD development versions, the 7.0
release made this obsolete.
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Dr
On Thu, Feb 18, 2016 at 03:39:29PM +, Ben Craig via cfe-commits wrote:
> Unfortunately, I have no access to an AIX machine to build with, so
> this change has been made blind.
Any reason why this is not using "new" and "delete"? I think I would
prefer to not define uselocale, but that can be l
On Thu, Feb 18, 2016 at 10:32:11PM +, Ben Craig via cfe-commits wrote:
> The fallback locale functions are also useful on their own for other
> lightweight platforms. Putting these fallback implementations in
> support/xlocale should enable code sharing.
Shouldn't the fallback functions be usi
On Fri, Feb 19, 2016 at 06:14:18PM +, Ben Craig via cfe-commits wrote:
> Instead of checking _LIBCPP_LOCALE__L_EXTENSIONS all over, instead
> check it once, and define the various *_l symbols once.
If you want to rename using macros, please use the argument form. I find
that to provide better
On Sun, Feb 21, 2016 at 02:26:30AM +, Eugene Zelenko via cfe-commits wrote:
> Another idea: to replace limits.h with limits and also replace its
> defines with their C++ counterparts. For example, INT_MIN with
> numeric_limits::min().
I'm not sure how useful it is to write four times as much
On Mon, Feb 22, 2016 at 08:25:56AM -0600, Craig, Ben via cfe-commits wrote:
> On 2/19/2016 3:32 PM, Joerg Sonnenberger via cfe-commits wrote:
> >On Fri, Feb 19, 2016 at 06:14:18PM +, Ben Craig via cfe-commits wrote:
> >>Instead of checking _LIBCPP_LOCALE__L_EXTENSIONS
On Wed, Feb 24, 2016 at 03:03:32AM -, James Y Knight via cfe-commits wrote:
> Author: jyknight
> Date: Tue Feb 23 20:59:33 2016
> New Revision: 261717
>
> URL: http://llvm.org/viewvc/llvm-project?rev=261717&view=rev
> Log:
> Default vaarg lowering should support indirect struct types.
>
> Fix
joerg added a comment.
Looking again at the failure mode, I think the best approach is to go back to
the original test case and just select a fixed target. The problematic IR
difference is purely an ABI choice of the target and not even related to
-fsigned-char vs -funsigned-char. As such, the
101 - 200 of 277 matches
Mail list logo
