On Mon, Feb 22, 2016 at 08:25:56AM -0600, Craig, Ben via cfe-commits wrote: > On 2/19/2016 3:32 PM, Joerg Sonnenberger via cfe-commits wrote: > >On Fri, Feb 19, 2016 at 06:14:18PM +0000, Ben Craig via cfe-commits wrote: > >>Instead of checking _LIBCPP_LOCALE__L_EXTENSIONS all over, instead > >>check it once, and define the various *_l symbols once. > >If you want to rename using macros, please use the argument form. I find > >that to provide better self-documentation. > > > >Joerg > Would the following form address your concerns? > #define __libcxx_sscanf_l(...) sscanf_l(__VA_ARGS__) > > I think that getting more elaborate than that general form would be more > effort and more buggy without significant customer benefit.
For variadic functions, the above is fine. I don't think it is more complicated for the fixed argument-number versions. Joerg _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
