[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:64 + return OMPC_MAP_MODIFIER_unknown; +if (!LangOpts.OpenMPExtensions && Type == OMPC_MAP_MODIFIER_ompx_hold) return OMPC_MAP_MODIFIER_unknown; ABataev wrote: > I would ena

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:64 + return OMPC_MAP_MODIFIER_unknown; +if (!LangOpts.OpenMPExtensions && Type == OMPC_MAP_MODIFIER_ompx_hold) return OMPC_MAP_MODIFIER_unknown; ABataev wrote: > jdenny wrot

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

jdenny marked 4 inline comments as done. jdenny added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:64 + return OMPC_MAP_MODIFIER_unknown; +if (!LangOpts.OpenMPExtensions && Type == OMPC_MAP_MODIFIER_ompx_hold) return OMPC_MAP_MODIFIER_unknown;

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

jdenny added inline comments. Comment at: clang/include/clang/Driver/Options.td:2383 +defm openmp_extensions: BoolFOption<"openmp-extensions", + LangOpts<"OpenMPExtensions">, DefaultFalse, + PosFlag Why do you want to disable it by default? I thought that's what we agreed upon.

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

jdenny added inline comments. Comment at: clang/include/clang/Driver/Options.td:2383 +defm openmp_extensions: BoolFOption<"openmp-extensions", + LangOpts<"OpenMPExtensions">, DefaultFalse, + PosFlag jdenny wrote: > > ABataev wrote: > > > Why do you want to disable it by default

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

jdenny added a comment. Thanks! I'll wait for the D106510 review before trying to land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106509/new/ https://reviews.llvm.org/D106509 ___ cfe-commits mailing li

[PATCH] D107503: [clang][Rewriter] patch to fix bug with ReplaceText erasing too many characters when text has been inserted before the replace location.

jdenny added a comment. Thanks for working on this. I agree there's a bug. However, this patch doesn't fix the bug. It provides a workaround. That is, the current default `ReplaceText` behavior, as revealed in the first test added by this patch, doesn't make sense. `IncludeInsertsAtBeginOf

[PATCH] D107503: [clang][Rewriter] patch to fix bug with ReplaceText erasing too many characters when text has been inserted before the replace location.

jdenny added inline comments. Comment at: clang/lib/Rewrite/Rewriter.cpp:136 if (OrigLength != NewStr.size()) AddReplaceDelta(OrigOffset, NewStr.size() - OrigLength); } I think this needs to be fixed too. That is, the removal of the inserts requires up

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9eaf0d120d32: [UpdateCCTestChecks] Support --check-globals (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2841229 , @thakis wrote: > Oh I see this assumes that lit.site.cfg.py is below clang_obj_root. I guess > that's my problem, looking… Let me know if the patch isn't general enough, or if I can help in some other way.

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2841304 , @thakis wrote: > I landed a fix attempt for my thing in > fda790fbfa0cba426d5e3787429a51e09ec64c6d > . Thanks! Repository: rG LLVM Gi

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2841457 , @thakis wrote: > Another thing: https://reviews.llvm.org/harbormaster/unit/view/789318/ > > # command stderr: > > /var/lib/buildkite-agent/builds/llvm-project/clang/test/utils/update_cc_test_checks/check-g

[PATCH] D104742: [UpdateCCTestChecks] Implement --global-value-regex

jdenny updated this revision to Diff 355579. jdenny added a comment. Fix the new test for the race discussed at D104714#2841465 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104742/new/ https://reviews.llvm.org/D104742 Files: clang/test/ut

[PATCH] D104743: [UpdateCCTestChecks] Implement --global-hex-value-regex

jdenny updated this revision to Diff 355582. jdenny added a comment. Fix the new test for the race discussed at D104714#2841465 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104743/new/ https://reviews.llvm.org/D104743 Files: clang/test/ut

[PATCH] D104742: [UpdateCCTestChecks] Implement --global-value-regex

jdenny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104742/new/ https://reviews.llvm.org/D104742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D105873: Fix utils/update_cc_test_checks/check-globals.test on stand-alone builds

jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. Thanks for the fix. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105873/new/ https://reviews.llvm.org/D105873 _

[PATCH] D104742: [UpdateCCTestChecks] Implement --global-value-regex

jdenny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104742/new/ https://reviews.llvm.org/D104742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. Other than the additional comments I've requested, LGTM. Thanks for the explanations and the changes. Comment at: clang/lib/Sema/TreeTransform.h:8321 +TreeTransform::Transf

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added a comment. One property of this patch that has bothered me is that OMPCanonicalLoop is not a loop. Instead, it's an AST node that is sandwiched between a directive and a loop to contain extra information about the loop. The TreeTransform issues we've been discussing highlight how

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added a comment. In D94973#2591210 , @Meinersbur wrote: > In D94973#2590867 , @jdenny wrote: > >> One property of this patch that has bothered me is that OMPCanonicalLoop is >> not a loop. Instead, it's an

[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives

This revision was automatically updated to reflect the committed changes. Closed by commit rG28412d1800e3: [lit] Implement DEFINE and REDEFINE directives (authored by jdenny). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives

jdenny added a comment. It was a small battle to get the tests past the windows bots, but they eventually succeeded: https://lab.llvm.org/buildbot/#/builders/216/builds/10125 I pushed the following additional patches while trying to fix the tests for windows: - f47a5df92d488bdff418e3b1d249f40

[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives

jdenny added a comment. Thanks for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132513/new/ https://reviews.llvm.org/D132513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

jdenny created this revision. jdenny added reviewers: jdoerfert, ABataev. jdenny added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jdenny requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang

[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

jdenny added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4983 + CurrentRegion != OMPD_loop && + !(SemaRef.getLangOpts().OpenMPExtensions && +CurrentRegion == OMPD_atomic); ---

[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

jdenny added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4983 + CurrentRegion != OMPD_loop && + !(SemaRef.getLangOpts().OpenMPExtensions && +CurrentRegion == OMPD_atomic); ---

[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

jdenny updated this revision to Diff 431804. jdenny added a comment. Fixed a bug in the new tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126323/new/ https://reviews.llvm.org/D126323 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/nesting_of_regions.cpp openmp/libom

[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

jdenny marked 2 inline comments as done. jdenny added a comment. Thanks. Will try to push tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126323/new/ https://reviews.llvm.org/D126323 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG48ca3a5ebb15: [OpenMP] Extend omp teams to permit nested omp atomic (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126547: [OpenACC][OpenMP] Document atomic-in-teams extension

jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, clementval. jdenny added projects: OpenMP, OpenACC. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jdenny requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald ad

[PATCH] D126549: [Clang][OpenMP] Don't overload "extension" in status doc

jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, RaviNarayanaswamy. jdenny added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jdenny requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project

[PATCH] D126547: [OpenACC][OpenMP] Document atomic-in-teams extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a368136693b: [OpenACC][OpenMP] Document atomic-in-teams extension (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126547/new/ https://r

[PATCH] D126547: [OpenACC][OpenMP] Document atomic-in-teams extension

jdenny added a comment. Thanks for the quick review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126547/new/ https://reviews.llvm.org/D126547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D126619: [OpenMP][Clang] Fix atomic compare for signed vs. unsigned

jdenny created this revision. jdenny added reviewers: tianshilei1992, ABataev, jdoerfert. jdenny added projects: OpenMP, clang. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jdenny requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Withou

[PATCH] D126619: [OpenMP][Clang] Fix atomic compare for signed vs. unsigned

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2e3cb737417: [OpenMP][Clang] Fix atomic compare for signed vs. unsigned (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D126619: [OpenMP][Clang] Fix atomic compare for signed vs. unsigned

jdenny added a comment. Thanks for the quick review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126619/new/ https://reviews.llvm.org/D126619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

jdenny added a comment. If the `%>` feature is going to remain (depending on, for example, the answer to @tahonermann's question about modulemap), please: 1. Add it to the lit documentation at https://llvm.org/docs/TestingGuide.html#substitutions and

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

jdenny added a comment. 3. Extend lit's own test suite to cover it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154130/new/ https://reviews.llvm.org/D154130 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

jdenny added a comment. In D154130#4502036 , @MrTrillian wrote: > In D154130#4487292 , @jdenny wrote: > >> 3. Extend lit's own test suite to cover it. > > I submitted an update with your suggestions #1 and #2 but

[PATCH] D70349: [Attr] Fix `-ast-print` for `asm` attribute

jdenny created this revision. jdenny added reviewers: erichkeane, aaron.ballman. Herald added a project: clang. Without this fix, the tests introduced here produce the following assert fail: clang: /home/jdenny/llvm/clang/include/clang/Basic/AttributeCommonInfo.h:163: unsigned int clang::Attri

[PATCH] D70349: [Attr] Fix `-ast-print` for `asm` attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGc85fa79d3663: [Attr] Fix `-ast-print` for `asm` attribute (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70349/new/ https://reviews.llv

[PATCH] D52861: Driver: Prefer gcc toolchains with libgcc_s.so when not static linking libgcc

jdenny added a comment. This patch handles libgcc_s.so, but what about libatomic.so? It's also not provided by x86_64-linux-gnu, at least on CentOS Linux release 7.7.1908. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52861/new/ https://reviews.llvm.org/D52861

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

jdenny added a comment. This breaks the lit test suite. `llvm/utils/lit/tests/shtest-format.py` needs to be updated for the removed tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71408/new/ https://reviews.llvm.org/D71408 ___

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

jdenny added a comment. In D71408#1788582 , @thopre wrote: > This is embarrassing. It happens. > I presume ninja check-all includes those 2 tests so I'm not sure how I missed > it. It should. > On a related note, I used to receive mail notification w

[PATCH] D45093: [AST] Fix -ast-print for _Bool when have diagnostics

jdenny created this revision. jdenny added reviewers: rsmith, hfinkel. Diagnostics print _Bool as bool when the latter is defined as the former. However, diagnostics were altering the printing policy for -ast-print as well. The printed source was then invalid because the preprocessor eats the bo

[PATCH] D45093: [AST] Fix -ast-print for _Bool when have diagnostics

jdenny updated this revision to Diff 141715. jdenny added a comment. Rebased onto a more recent master. https://reviews.llvm.org/D45093 Files: include/clang/AST/ASTContext.h include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/Sema/Sema.cpp lib/Sema/SemaChecking.cpp lib/Sema/SemaCo

[PATCH] D45149: MallocChecker, adding specific BSD calls

jdenny added a comment. Hi David. While I did make some superficial changes here recently, I'm no authority on what belongs here. However, I would suggest that the refactoring patch be split from the original patch. Thanks. https://reviews.llvm.org/D45149

[PATCH] D45456: [Attr] Print enum attributes at correct position

jdenny created this revision. jdenny added reviewers: aaron.ballman, hfinkel. In enum declarations, enum attributes were always printed after the tag and any member list. When no member list was present but the enum was a type specifier in a variable declaration, the attribute then applied to the

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

jdenny created this revision. jdenny added reviewers: rsmith, nik, jbcoe, aaron.ballman, hfinkel. For example, given: void fn() { struct T *p0; struct T { int i; } *p1; } -ast-print produced: void fn() { struct T { int i; } *p0; struct T { int i; } *p1; } Compiling that

[PATCH] D45465: [AST] Fix printing tag decl groups in decl contexts

jdenny created this revision. jdenny added reviewers: rsmith, hfinkel. jdenny added a dependency: D45463: [AST] Print correct tag decl for tag specifier. For example, given: struct T1 { struct T2 *p0; }; -ast-print produced: struct T1 { struct T2; struct T2 *p0; }; Compil

[PATCH] D39694: [VerifyDiagnosticConsumer] support -verify=PREFIX

jdenny created this revision. This mimic's FileCheck's --check-prefix option. The default PREFIX is "expected". That is, "-verify" is equivalent to "-verify=expected". The goal is to permit exercising a single test suite source file with different compiler options producing different sets of di

[PATCH] D39694: [VerifyDiagnosticConsumer] support -verify=

jdenny updated this revision to Diff 122172. jdenny retitled this revision from "[VerifyDiagnosticConsumer] support -verify=PREFIX" to "[VerifyDiagnosticConsumer] support -verify=". jdenny edited the summary of this revision. jdenny added a comment. 1. Extended -verify to accept multiple prefixes

[PATCH] D39859: [OpenMP] diagnose assign to firstprivate const

jdenny created this revision. [OpenMP] diagnose assign to firstprivate const Clang does not diagnose assignments to const variables declared firstprivate. Furthermore, codegen is broken such that, at run time, such assignments simply have no effect. For example, the following prints 0 not 1: i

[PATCH] D39859: [OpenMP] diagnose assign to firstprivate const

jdenny updated this revision to Diff 122329. jdenny added a comment. Hi Alexey. Thanks for your comments. This update should address them all. https://reviews.llvm.org/D39859 Files: lib/Sema/SemaExpr.cpp test/OpenMP/parallel_firstprivate_messages.cpp Index: test/OpenMP/parallel_firstpri

[PATCH] D39859: [OpenMP] diagnose assign to firstprivate const

jdenny added a comment. Alexey: Thanks for accepting. I do not have commit privileges. Would you please commit for me? https://reviews.llvm.org/D39859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D39694: [VerifyDiagnosticConsumer] support -verify=

jdenny updated this revision to Diff 123027. jdenny added a comment. 1. Capitalized some of the new local variables according to coding standards. 2. Rebased on master/trunk fetched today. https://reviews.llvm.org/D39694 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Bas

[PATCH] D151350: [OpenMP] Extend omp teams to permit nested omp tile

jdenny created this revision. jdenny added reviewers: Meinersbur, ABataev, jhuber6, jdoerfert. jdenny added projects: OpenMP, OpenACC. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a reviewer: clementval. Herald added a project: All. jdenny requested review of this revision. H

[PATCH] D151350: [OpenMP] Extend omp teams to permit nested omp tile

jdenny updated this revision to Diff 525250. jdenny added a comment. Added phab review number to status doc. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151350/new/ https://reviews.llvm.org/D151350 Files: clang/docs/OpenMPSupport.rst clang/lib/Sema/SemaOpenMP.cpp openmp/docs/op

[PATCH] D151356: [OpenMP] Fix transformed loop's var privacy

jdenny created this revision. jdenny added reviewers: Meinersbur, ABataev. jdenny added a project: OpenMP. Herald added subscribers: sunshaoce, zzheng, guansong, yaxunl. Herald added a project: All. jdenny requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribe

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

jdenny added a comment. Thanks for working on this. I've been wanting something like it too. In downstream work, I've used a hack that seems to accomplish the same thing but probably shouldn't: `expected-error 0 {{}}`. Anyway, please add documentation for the new directive here: https://clan

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

jdenny added inline comments. Comment at: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h:186-202 +/// Additionally, you can use: +/// +/// \code +/// // expected-maybe-no-diagnostics +/// \endcode +/// +/// to specify that a file with no "expected-*" comments should pa

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. Thanks for addressing all my concerns. LGTM except for a test issue I just commented on. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = Ve

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

jdenny added inline comments. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) { Endill wrote: > j

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

jdenny accepted this revision. jdenny added inline comments. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) { ---

[PATCH] D151356: [OpenMP] Fix transformed loop's var privacy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19841e4dcaab: [OpenMP] Fix transformed loop's var privacy (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D151356: [OpenMP] Fix transformed loop's var privacy

jdenny added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151356/new/ https://reviews.llvm.org/D151356 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D151350: [OpenMP] Extend omp teams to permit nested omp tile

jdenny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151350/new/ https://reviews.llvm.org/D151350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D101564: [OpenMP] Fix second debug name from map clause

jdenny created this revision. jdenny added reviewers: jhuber6, jdoerfert. Herald added subscribers: guansong, yaxunl. jdenny requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. This patch fixes a bug from D89802 .

[PATCH] D101564: [OpenMP] Fix second debug name from map clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG82e99f50351d: [OpenMP] Fix second debug name from map clause (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101564/new/ https://reviews

[PATCH] D94261: [clang] Add powerpc64le-none-linux-gnu to gnu toolchain for PPC64

jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94261/new/ https://reviews.llvm.org/D94261 ___ c

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jdenny added a comment. This test is meant to check that the driver processes these options correctly. -cc1 isn't the driver and often ignores either the positive or negative version of an option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jdenny added a comment. In D109255#2983018 , @jsji wrote: > In D109255#2983017 , @jdenny wrote: > >> This test is meant to check that the driver processes these options >> correctly. -cc1 isn't the driver and of

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jdenny added a comment. In D109255#2983063 , @jsji wrote: > In D109255#2983052 , @ABataev wrote: > >> In D109255#2983017 , @jdenny wrote: >> >>> This test is meant to chec

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jdenny accepted this revision. jdenny added a comment. LGTM. Thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 ___ cfe-commits mailing list c

<    1   2   3   4   5