[PATCH] D110671: [AIX] Enable PGO without LTO

jsji created this revision. jsji added reviewers: PowerPC, Whitney. Herald added subscribers: wenlei, inglorion. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On AIX, we relied on LTO to merge the csects for profiling data/counter se

[PATCH] D110671: [AIX] Enable PGO without LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e48951c736c: [AIX] Enable PGO without LTO (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D110955: [AIX] Don't pass namedsects in LTO mode

jsji created this revision. jsji added reviewers: PowerPC, Whitney. Herald added a subscriber: inglorion. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LTO don't need binder option , don't pass it in LTO mode. Repository: rG LLVM

[PATCH] D110955: [AIX] Don't pass namedsects in LTO mode

jsji updated this revision to Diff 376595. jsji added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110955/new/ https://reviews.llvm.org/D110955 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c Index:

[PATCH] D110955: [AIX] Don't pass namedsects in LTO mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c31969e8df2: [AIX] Don't pass namedsects in LTO mode (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110955/new/ https://reviews.llvm.org

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji created this revision. jsji added reviewers: PowerPC, hubert.reinterpretcast, nemanjai. jsji requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch remove the override in AIX target, so the int128 is enabled in 64

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added inline comments. Comment at: llvm/test/CodeGen/PowerPC/int128_ldst.ll:31 ; CHECK-NEXT:mr 3, 5 ; CHECK-NEXT:blr entry: hubert.reinterpretcast wrote: > Confirming that this case matches GCC on AIX: > ``` > ld 4,8(3) > ld 3,0(3)

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

jsji added a comment. In D95753#2581150 , @phosek wrote: > In D95753#2578724 , @gregmiller > wrote: > >> Hello, we are seeing failures like below: >> >> Note: Google Test filter = >> ParameterizedCovMapTest/Covera

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

jsji added inline comments. Comment at: llvm/unittests/ProfileData/CoverageMappingTest.cpp:211 Expressions, Data.Regions); EXPECT_THAT_ERROR(Reader.read(), Succeeded()); } Somehow previous value of `Data.Filenames` wil

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

jsji added a comment. https://reviews.llvm.org/D97353 should fix the unitest failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 ___ cfe-commits mailing lis

[PATCH] D99483: [clang][AIX] Define __STDC_NO_ATOMICS__ for c11 and above

jsji added a comment. Done in https://reviews.llvm.org/D103707? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99483/new/ https://reviews.llvm.org/D99483 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

jsji added a comment. > The default Altivec ABI was implemented Please include the patches or commits that implement the default ABI. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4779 CmdArgs.push_back("-mabi=vec-extabi"); +else if (A->getOption().getID() == op

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

jsji added inline comments. Comment at: clang/test/Driver/aix-vec-extabi.c:3 +// RUN: FileCheck %s --check-prefix=EXTABI // RUN: %clang -### -target powerpc-unknown-aix -S -maltivec -mabi=vec-default %s 2>&1 | \ +// RUN: FileCheck %s --check-prefix=DFLTABI H

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Driver/aix-vec-extabi.c:12 +/ +// NOEXTABI-NOT: "-mabi=vec-extabi" Why not use `--implicit-check-not`?

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

jsji added inline comments. Comment at: clang/test/Driver/aix-vec-extabi.c:2 +// RUN: %clang -### -target powerpc-unknown-aix -S %s 2>&1 | \ +// RUN: FileCheck %s --implicit-check-not=-mabi=vec-extabi +// RUN: %clang -### -target powerpc-unknown-aix -S -maltivec %s 2>&1 | \ --

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

jsji created this revision. jsji added reviewers: PowerPC, lkail, w2yehia. Herald added subscribers: shchenz, jfb, kbarton, nemanjai. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prototype int __compare_and_swap (volatile int* addr,

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

jsji updated this revision to Diff 354360. jsji added a comment. Add {} to case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104837/new/ https://reviews.llvm.org/D104837 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Target

[PATCH] D107461: [PowerPC] Do not define __PRIVILEGED__

jsji added a comment. > x64 debian > Clang.Driver::ppc-mprivileged-support-check.c The changed test is failing ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107461/new/ https://reviews.llvm.org/D107461 __

[PATCH] D107786: [AIX]: Fix option processing for -b

jsji added a comment. Tests please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107786/new/ https://reviews.llvm.org/D107786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D107786: [AIX]: Fix option processing for -b

jsji accepted this revision as: jsji. jsji added a comment. LGTM, Thanks. Comment at: clang/test/Driver/Xlinker-args.c:26 // LINUX: "--no-demangle" "-e" "_start" "one" "two" "three" "four" "-z" "five" "-r" {{.*}} "-T" "a.lds" -// AIX: "-b" "one" +// AIX: "-b" "one" "-b" "two

[PATCH] D107786: [AIX]: Fix option processing for -b

jsji added inline comments. Comment at: clang/test/Driver/Xlinker-args.c:26 // LINUX: "--no-demangle" "-e" "_start" "one" "two" "three" "four" "-z" "five" "-r" {{.*}} "-T" "a.lds" -// AIX: "-b" "one" +// AIX: "-b" "one" "-b" "two" // NOT-AIX: error: unsupported option '-b' fo

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

jsji updated this revision to Diff 354410. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104837/new/ https://reviews.llvm.org/D104837 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Targ

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

jsji added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-cas.c:19 +// CHECK-NEXT:[[TMP2:%.*]] = cmpxchg weak volatile i32* [[A]], i32 [[TMP1]], i32 [[TMP0]] monotonic monotonic, align 4 +// CHECK-NEXT:[[TMP3:%.*]] = extractvalue { i32, i1 } [[TMP2

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3ef4f5bff26: [PowerPC] Add XL compat __compare_and_swap builtins (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D104991: [PowerPC] Add XL Compat fetch builtins

jsji created this revision. jsji added reviewers: PowerPC, w2yehia, lkail, shchenz, Whitney. Herald added subscribers: jfb, kbarton, nemanjai. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prototype unsigned int __fetch_and_add (vola

[PATCH] D104991: [PowerPC] Add XL Compat fetch builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb237ffca821: [PowerPC] Add XL Compat fetch builtins (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104991/new/ https://reviews.llvm.org/

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

jsji created this revision. jsji added reviewers: PowerPC, shchenz. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D105314 added the abibility choose to use AsmParser for parsing inline asm. -no-int

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5043 + // option to disable integrated-as explictly. + if (!TC.useIntegratedAs() && !TC.parseInlineAsmUsingAsmParser()) CmdArgs.push_back("-no-integrated-as"); shchenz wrote: > D

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG31d10ea10ee1: [AIX] Don't pass no-integrated-as by default (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105512/new/ https://reviews.llv

[PATCH] D112055: [PowerPC] Implement longdouble pack/unpack builtins

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM with some nits. Comment at: clang/lib/Sema/SemaChecking.cpp:3382 +if (&TI.getLongDoubleFormat() != &llvm::APFloat::PPCDoubleDouble()) + return Diag(TheCall

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

jsji added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:100 + static SmallDenseMap F128Builtins{ + {Builtin::BI__builtin_printf, "__printfieee128"}, + {Builtin::BI__builtin_vsnprintf, "__vsnprintfieee128"}, Why only these printf builtin

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

jsji added inline comments. Comment at: clang/test/Driver/ppc-float-abi-warning.cpp:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang -### -x c++ -target powerpc64le-unknown-linux-gnu %s -mabi=ieeelongdouble + Can we add RUN line to test when we are usin

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Please hold a few days to see whether there are inputs from other reviewers. Thanks. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:100 + static SmallDenseMap F128B

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for enabling this for FreeBSD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113451/new/ https://reviews.llvm.org/D113451 ___

[PATCH] D97823: Update default arch on AIX

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:405 + T.getOSVersion(major, minor, micro); + TargetCPUName = major == 7 && minor < 2 ? "pwr4" : "pw

[PATCH] D97823: Update default arch on AIX

jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:405 + T.getOSVersion(major, minor, micro); + TargetCPUName = major == 7 && minor < 2 ? "pwr4" : "pwr7"; +} else if (T.getArch() == llvm::Triple::ppc64le) jsji wrote:

[PATCH] D97823: Update default arch on AIX

jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:403 +if (T.isOSAIX()) { + unsigned major, minor, micro; + T.getOSVersion(major, minor, micro); `micro` unsed. Comment at: clang/lib/Driver/ToolChai

[PATCH] D97823: Update default arch on AIX

jsji accepted this revision. jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:403 +if (T.isOSAIX()) { + unsigned major, minor, micro; + T.getOSVersion(major, minor, micro); stevewan wrote: > jsji wrote: > > `micro`

[PATCH] D98010: [XCOFF] [DWARF] set default DWARF version to 3

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98010/new/ https://reviews.llvm.org/D98010 ___

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

jsji added a comment. If we use this workaround, can we also revert 561fb7f60ab631e712c3fb6bbeb47061222c6818 and 8dc70bdcd0fe4efb65876dce0144d9c3386a2f07

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. Can we use `UNSUPPORTED` instead of `XFAIL` since it is unsupported? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 ___ cfe-commits maili

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. In D113049#3140165 , @Jake-Egan wrote: > In D113049#3140160 , @jsji wrote: > >> Can we use `UNSUPPORTED` instead of `XFAIL` since it is unsupported? > > If 64-bit XCOFF object files will be s

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. In D113049#3140174 , @lkail wrote: > Is there any way to filter these tests out on AIX in `lit.local.cfg`? Agree, I would prefer we do something similar to https://reviews.llvm.org/rG666accf283311c5110ae4e2e5e4c4b99078eed15#change-

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

jsji added inline comments. Comment at: clang/test/CodeGen/ppc-mm-malloc-le.c:10 // RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm %s -fno-discard-value-names -mllvm -disable-llvm-optzns -o - | llvm-cxxfilt | FileCheck %s +// RUN: %clang -target powerpc64le-un

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e2fd879e6f9: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD (authored by adalava, committed by jsji). Changed prior to commit: https://reviews.llvm.org/D113451?vs=385985&id=389001#toc Re

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

jsji added a comment. In D113451#3148815 , @kamaub wrote: > Test case `clang/test/CodeGen/ppc-mm-malloc.c` fails on powerpc BE buildbots > with this changeset > https://lab.llvm.org/buildbot/#/builders/93/builds/6031 > https://lab.llvm.org/buildbot/#/bui

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. Thanks, looks much better now. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir there is no `fmodule-format=obj` here, why are we failing here? ===

[PATCH] D138234: [clang-format] Support new file formatting with vim

jsji created this revision. jsji added reviewers: djasper, klimek. Herald added a project: All. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The vim Formatonsave integration is not working if we create a new file directly using vim

[PATCH] D138234: [clang-format] Support new file formatting with vim

jsji updated this revision to Diff 476905. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138234/new/ https://reviews.llvm.org/D138234 Files: clang/tools/clang-format/clang-format.py Index: clang/tools/cl

[PATCH] D138234: [clang-format] Support new file formatting with vim

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86278114085b: [clang-format] Support new file formatting with vim (authored by jsji). Changed prior to commit: https://reviews.llvm.org/D138234?vs

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

jsji added a comment. This is also breaking test-suites in our internal buildbots .. This change is actually changing the default behavior: if user does NOT supply `-ffp-contract`, it becomes `-ffp-contract=on`. So this means any code without explicitly add `-ffp-contract=off` will have `-ffp-

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

jsji added a comment. In D74436#1875320 , @mibintc wrote: > @jsji Will your backend tolerate -ffp-contract=on if optimizations are not > disabled, e.g. -O2? We are proposing that the default floating point model > be -ffp-model=precise, and with precise

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

jsji added a comment. > We normally default to `-ffp-contract=on ` only for -O3 and above (for legacy > compilers XL/gcc on PowerPC). Correction: XL on PowerPC default to generate FMA at -O0 as well. The corresponding option is -qfloat=maf. https://www.ibm.com/support/knowledgecenter/SSXVZZ_16

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112906/new/ https://reviews.llvm.org/D112906 _

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117181/new/ https://reviews.llvm.org/D117181 _

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:76 + if (SupportIEEEFloat128(getDriver(), getTriple(), DriverArgs) && + !DriverArgs.hasArg(options::OPT_mabi_EQ)) +CC1Args.push_back("-mabi=ieeelongdouble"); What if we hav

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji added a comment. Can we just update `bool IEEELongDouble = false; ` to `bool IEEELongDouble = true;` in `clang/lib/Driver/ToolChains/Clang.cpp`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117181/new/ https://reviews.llvm.org/D117181 _

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji added a comment. > Would there be a way to query the GCC toolchain for what the default is for > `long double`? There would certainly be ways to query. But I don't think we should change the default *BASED* on the gcc toolchain installed. As you mentioned, `I would find it surprising i

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji added a comment. > Won't that end up producing a warning on ALL code built on any Linux distro > with a GCC toolchain older than 12.1? That would be terrible. Good point. Yes, so should be something like: IsDistroWithNewToolchain = ( Distro.IsRedhat() && Distro >= Distro::RHEL9 || (Di

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji added a comment. > Besides, would it be acceptable that we add a variable to cmake to determine > default long double semantics (like current GCC)? Yes, we can. But I think that can be in another patch, and we shouldn't rely on it -- as we shouldn't assume user will config/build clang/llvm

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

jsji added a comment. In D118110#3269450 , @nemanjai wrote: > It is probably not worth the effort since there won't be that many test cases > that test the front end's IR generation for `long double`, but there should > be a way to set up lit to know th

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118110/new/ https://reviews.llvm.org/D118110 _

[PATCH] D119309: [Driver][test] Clean up some AIX tests

jsji added subscribers: Xiangling_L, jasonliu, jsji. jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for cleaning up. BTW: @jasonliu and @Xiangling_L are no longer working on AIX. #powerpc

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

jsji added inline comments. Comment at: clang/lib/Headers/ppc_wrappers/xmmintrin.h:1332 +#ifdef _ARCH_PWR10 + return vec_extractm ((__vector unsigned int) __A); +#else Can we have some pwr10 tests to test all these P10 specific codegen? Repository: rG LLVM G

[PATCH] D120907: [docs] Add PowerPC release notes for LLVM 14

jsji accepted this revision. jsji added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120907/new/ https://reviews.llvm.org/D120907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407 _

[PATCH] D101130: [PowerPC] Provide XL-compatible builtins in altivec.h

jsji added inline comments. Comment at: clang/lib/Headers/altivec.h:3055 +#ifdef __XL_COMPAT_ALTIVEC__ +/* vec_ctf */ This only affects __VSX__ version right? If so, can we move `#ifdef __XL_COMPAT_ALTIVEC__` into `#ifdef __VSX__`？ Or even better only into the

[PATCH] D101130: [PowerPC] Provide XL-compatible builtins in altivec.h

jsji added inline comments. Comment at: clang/lib/Headers/altivec.h:3065 + (__b)), \ + vector unsigned long long \ + : (__builtin_vsx_xvcvuxdsp((v

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

jsji added a comment. Have we considered workaround this in `llvm/lib/Support/Unix/Path.inc` instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101323/new/ https://reviews.llvm.org/D101323 ___ cfe-co

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

jsji accepted this revision as: jsji. jsji added inline comments. Comment at: llvm/cmake/config-ix.cmake:285 +# The st_mtim.tv_nsec member of a `stat` structure is not reliable on some AIX +# environments. + set(HAVE_STRUCT_STAT_ST_MTIM_TV_NSEC 0) Maybe add a wa

[PATCH] D101918: [clang][Driver] Add -fintegrate-as to debug-pass-structure test

jsji created this revision. jsji added reviewers: evgeny777, tejohnson. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CGProfilePass is not always on, it will be disabled when using non-intergrated assemblers. // Only enable CGProf

[PATCH] D101918: [clang][Driver] Add -fintegrate-as to debug-pass-structure test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20d0aca43073: [clang][Driver] Add -fintegrate-as to debug-pass-structure test (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D114569: [PowerPC] Require htm feature for HTM builtins

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114569/new/ https://reviews.llvm.org/D114569 __

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

jsji added a comment. I also agree that consumer *SHOULD* handle the unexpected value better. eg: newer DBX will handle such failures better. However, there are situations that the end user might not get up to date debugger, then the user experiences will be BAD. If updating these tags uncond

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

jsji added a comment. In D99250#2651207 , @dblaikie wrote: > But if folks supporting previous builds of DBX are likely going to need a > bunch of other compatibility work - then maybe adding the debugger tuning may > be suitable/necessary/worthwhile at t

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

jsji added a comment. In D99250#2651335 , @dblaikie wrote: > In D99250#2651294 , @jsji wrote: > >> In D99250#2651207 , @dblaikie wrote: >> >>> But if folks supporting previou

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

jsji added a comment. > Our practice has been for a "tuning" option to, effectively, expand into > other options to control various bits of behavior. Basically, there should > never be behavior that can be controlled _only_ via the tuning option. This > is a design decision that was debated a

[PATCH] D99901: [Driver][test] Test intended target only

jsji created this revision. jsji added a reviewer: MaskRay. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 6fe7de90b9e4e466a5c2baadafd5f72d3203651d changed GNU to

[PATCH] D99901: [Driver][test] Test intended target only

jsji updated this revision to Diff 335499. jsji added a comment. Use -arch instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99901/new/ https://reviews.llvm.org/D99901 Files: clang/test/Driver/nostdincxx.cpp Index: clang/test/Driver/nostdi

[PATCH] D99901: [Driver][test] Test intended target only

jsji added inline comments. Comment at: clang/test/Driver/nostdincxx.cpp:4 // RUN: not %clangxx -nostdlibinc %s 2>&1 | FileCheck %s -// RUN: not %clangxx -fsyntax-only -nostdinc -nostdinc++ %s 2>&1 | FileCheck /dev/null --implicit-check-not=-Wunused-command-line-argument +// RU

[PATCH] D99901: [Driver][test] Test intended target only

jsji updated this revision to Diff 335500. jsji added a comment. Remove typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99901/new/ https://reviews.llvm.org/D99901 Files: clang/test/Driver/nostdincxx.cpp Index: clang/test/Driver/nostdincxx.

[PATCH] D99901: [Driver][test] Test intended target only

This revision was automatically updated to reflect the committed changes. Closed by commit rGa723310b419b: [Driver][test] Test intended target only (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99901/new/ https://reviews.llvm.org

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

jsji added a comment. In D100630#2694681 , @probinson wrote: > If DBX is going to be really pedantic about not recognizing tags or > attributes that don't align with the DWARF version, maybe we're better off > with really supporting `-gstrict-dwarf` and

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji updated this revision to Diff 377283. jsji added a comment. Herald added a subscriber: kbarton. Address comments -- adding AIX triples to more existing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111078/new/ https://reviews.llvm.org/D

[PATCH] D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. Thanks for working on this. Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCInstPrinter.cpp:161 // where th can be omitted when it is 0. dcbtst is the same. - i

[PATCH] D111406: [AIX][ZOS] Excluding merge-objc-interface.m from Tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75127bce6de7: [AIX][ZOS] Excluding merge-objc-interface.m from Tests (authored by qiongsiwu1, committed by jsji). Repository: rG LLVM Github Monor

[PATCH] D111482: [Clang] [PowerPC] Fix header include typo in smmintrin.h

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. Can you please add a testcase that include `smmintrin.h` but use SSSE3? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111482/new/ h

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added a comment. Ping @hubert.reinterpretcast Any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111078/new/ https://reviews.llvm.org/D111078 ___ cfe-commits mailing list cfe-commit

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji updated this revision to Diff 379485. jsji added a comment. Add AIX XCOFF triples to i128 tests, especially ppc64-i128-abi.ll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111078/new/ https://reviews.llvm.org/D111078 Files: clang/lib/Basic

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added a comment. ppc64-i128-abi.ll CHECK-P9 part depends on D94282 : [PowerPC] Support ppc-asm-full-reg-names for AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111078/new/ https://reviews.llvm.org/D11107

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added a comment. In D111078#3065552 , @hubert.reinterpretcast wrote: > In D111078#3063245 , @lkail wrote: > >> This LGTM as the start point to support int128 on AIX. We might need more >> patches involving

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42eea2b69bb9: [AIX] Enable int128 in 64 bit mode (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D109060: Disable LIT tests on AIX due to lack of Objective-C support

jsji added a comment. For `clang/test/CodeGenObjCXX` and `clang/test/CodeGenObjC`, can we add lit.local.cfg and add the unsupport there, no adding to every files in the folder? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109060/new/ https://rev

[PATCH] D109060: [AIX] Disable LIT tests on AIX due to lack of Objective-C support

jsji added a comment. In D109060#2976752 , @Jake-Egan wrote: > In D109060#2976745 , @jsji wrote: > >> For `clang/test/CodeGenObjCXX` and `clang/test/CodeGenObjC`, can we add >> lit.local.cfg and add the unsupport

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji created this revision. jsji added reviewers: jdenny, ABataev, jdoerfert. Herald added subscribers: guansong, yaxunl. jsji requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The test driver-fopenmp-extensions.c is failing on platf

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji updated this revision to Diff 370653. jsji added a comment. Use clang_cc1 instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 Files: clang/test/OpenMP/driver-fopenmp-extensions.c Index: clan

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. In D109255#2983002 , @ABataev wrote: > I think we can use just `clang_cc1` here instead of `%clang -c` Good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://re

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. In D109255#2983017 , @jdenny wrote: > This test is meant to check that the driver processes these options > correctly. -cc1 isn't the driver and often ignores either the positive or > negative version of an option. OK, I can reve

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji updated this revision to Diff 370658. jsji added a comment. Use driver + -fsyntax-only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 Files: clang/test/OpenMP/driver-fopenmp-extensions.c Index:

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. @ABataev Is this still OK for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

<    1   2   3   >