[PATCH] D49793: [AArch64] - return address signing

javed.absar added a comment. Maybe you can provide some more context to this patch (why you need this, or point to some document), if possible. Comment at: include/clang/Frontend/CodeGenOptions.h:111 + enum SignReturnAddressScope { None, Partial, All }; + P

[PATCH] D33412: Add support for #pragma clang section

javed.absar updated this revision to Diff 100846. javed.absar added a comment. Herald added a subscriber: kristof.beyls. Thanks Roger for the review and the suggestion to add documentation in LanguageExtensions.rst. I have done so now. --Javed https://reviews.llvm.org/D33412 Files: docs/Lan

[PATCH] D33721: [ARM] Add support for target("arm") and target("thumb").

javed.absar added a comment. Comment at: include/clang/Basic/Attr.td:1774 + +// Convert GNU target names for arm and thumb to thumb-mode target +// feature. Would this be a more accurate comment: "...arm and thumb to thumb-mode" => "arm and th

[PATCH] D33719: Add _Float16 as a C/C++ source language type

javed.absar added inline comments. Comment at: include/clang/Sema/DeclSpec.h:283 static const TST TST_double = clang::TST_double; + static const TST TST_Float16 = clang::TST_Float16; static const TST TST_float128 = clang::TST_float128; Any particular reaso

[PATCH] D33412: Add support for #pragma clang section

This revision was automatically updated to reflect the committed changes. Closed by commit rL304705: Add support for #pragma clang section (authored by javed.absar). Changed prior to commit: https://reviews.llvm.org/D33412?vs=100846&id=101383#toc Repository: rL LLVM https://reviews.llvm.org

[PATCH] D30326: [MS-ABI] Allow #pragma section to choose for ZI data

javed.absar abandoned this revision. javed.absar added a comment. Abandoning as there is a separate pragma clang section implementation now. https://reviews.llvm.org/D30326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D59879: [ARM][CMSE] Add commandline option and feature macro

javed.absar created this revision. javed.absar added a reviewer: dmgreen. Herald added a subscriber: kristof.beyls. Herald added a project: clang. This is first in series of patches following the RFC http://lists.llvm.org/pipermail/cfe-dev/2019-March/061834.html informing the community about pro

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

javed.absar created this revision. javed.absar added reviewers: DavidSpickett, olista01. Herald added a subscriber: kristof.beyls. This patch provides intrinsics support for Memory Tagging Extension (MTE), which was introduced with the Armv8.5-a architecture. These intrinsics are available whe

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

javed.absar updated this revision to Diff 195112. javed.absar added a comment. Tests merged as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60485/new/ https://reviews.llvm.org/D60485 Files: include/clang/Basic/BuiltinsAArch64.def include/clang/Basic/DiagnosticSemaKinds.

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

javed.absar marked 2 inline comments as done. javed.absar added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9566 +def err_memtag_arg_null_or_pointer : Error< + "%0 argument must be a null or a pointer (%1 invalid)">; +def err_memtag_any2arg_pointer :

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

javed.absar updated this revision to Diff 196297. javed.absar marked an inline comment as done. javed.absar added a comment. Hi Tim: Have made the changes as suggested. Please have a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60485/new/ https://reviews.llvm.org/D60485 Files:

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

javed.absar marked an inline comment as done. javed.absar added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:7129-7131 +// Although it is possible to supply a different return +// address (first arg) to this intrinsic, for now we set +// return address same

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rC359348: [AArch64] Add support for MTE intrinsics (authored by javed.absar, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60485?vs=196297&id=196915#toc

[PATCH] D51429: [AArch64] Return Address Signing B Key Support

javed.absar added inline comments. Comment at: include/clang/Frontend/CodeGenOptions.h:117 + enum SignReturnAddressKeyValue { AKey, BKey }; + Perhaps a line of comment on each enum-value would be useful (much like the code around). https://reviews.llvm.org/

[PATCH] D37454: [coroutines] Make sure auto return type of await_resume is properly handled

javed.absar added inline comments. Comment at: test/SemaCXX/coroutines.cpp:169 +void check_auto_await_suspend() { + co_await auto_await_suspend{}; // OK +} maybe change the comment to something more meaningful, or remove it. https://reviews.llvm.org/D37454

[PATCH] D59879: [ARM][CMSE] Add commandline option and feature macro

javed.absar marked 4 inline comments as done. javed.absar added inline comments. Comment at: lib/Basic/Targets/ARM.cpp:438 +} else if (Feature == "+8msecext") { + if ((CPUProfile != "M" && CPUProfile != "B") || ArchVersion != 8) { +Diags.Report(diag::err_target_u

[PATCH] D59879: [ARM][CMSE] Add commandline option and feature macro

javed.absar updated this revision to Diff 199819. javed.absar added a comment. Updated based on review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59879/new/ https://reviews.llvm.org/D59879 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D59879: [ARM][CMSE] Add commandline option and feature macro

This revision was automatically updated to reflect the committed changes. Closed by commit rC361261: [ARM][CMSE] Add commandline option and feature macro (authored by javed.absar, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59879/new/ https://rev

[PATCH] D62394: [ARM][CMSE] Add CMSE header & builtins

javed.absar created this revision. javed.absar added reviewers: snidertm, dmgreen. Herald added subscribers: kristof.beyls, mgorny. This is patch C2 as mentioned in RFC http://lists.llvm.org/pipermail/cfe-dev/2019-March/061834.html This adds cmse builtin functions, and introduces arm_cmse.h head

[PATCH] D62394: [ARM][CMSE] Add CMSE header & builtins

javed.absar added a comment. In D62394#1672551 , @sigvartmh wrote: > Maybe I'm doing something wrong tried to apply these patches but when trying > to build code which uses cmse I get > > Cannot select: intrinsic %llvm.arm.cmse.tt > fatal error: error in

[PATCH] D30326: [MS-ABI] Allow #pragma section to choose for ZI data

javed.absar created this revision. This patch enables the msvc pragma section to choose whether zero initialized variables are to be placed in data_seg or bss_seg. The current implementation ignores bss_seg directive for variables that are initialized (i.e. it does not check if the initializat

[PATCH] D30326: [MS-ABI] Allow #pragma section to choose for ZI data

javed.absar updated this revision to Diff 89897. javed.absar added a comment. Hi Roger: Thanks for the review. I have extended the test and fixed driver flag passing that you pointed out. Regarding the check in Sema::DeclarationIsZeroInitialized, the check if to keep the function return value c

[PATCH] D30326: [MS-ABI] Allow #pragma section to choose for ZI data

javed.absar added a comment. Hi Nico: This is for the case when using '#pragma bss_seg..' feature outside of msvc context. That's the reason for the flag. One could use attribute, but as attribute is attached to individual declaration, while pragma applies to whole file (unless superseded by an

[PATCH] D33412: Add support for #pragma clang section

javed.absar created this revision. Herald added a subscriber: aemerson. This patch adds support for a '#pragma clang section' directive in clang. An RFC was sent out earlier by my colleague James Molloy: http://lists.llvm.org/pipermail/cfe-dev/2017-March/053100.html Purpose: The pur