Author: Jacques Pienaar
Date: 2020-06-12T09:48:49-07:00
New Revision: 270d580a0e9ff2f2e1b6240fccedee7c25dc3bfa
URL:
https://github.com/llvm/llvm-project/commit/270d580a0e9ff2f2e1b6240fccedee7c25dc3bfa
DIFF:
https://github.com/llvm/llvm-project/commit/270d580a0e9ff2f2e1b6240fccedee7c25dc3bfa.dif
jpienaar added a comment.
Oh, sorry, I didn't see your response before I clicked abandoned. It has been a
while, so this patch is pretty stale.
https://reviews.llvm.org/D9168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
@Valentin: It would be great if you could give it a go. I tried
resurrecting it earlier today but noticed getDataLayout() had been removed
and then I got tied up with other pending work.
On Mon, Sep 19, 2016 at 5:11 PM, Valentin Churavy
wrote:
> vchuravy added a comment.
>
> @jpienaar are you pl
jpienaar added a comment.
Cool. I didn't know the review system allows having the patch updated like this
:) It still reports me as the author and you as a subscriber. I don't think
that matters.
Comment at: lib/Target/NVPTX/NVPTXISelLowering.cpp:1033
@@ +1032,3 @@
+
jpienaar accepted this revision.
jpienaar added a reviewer: jpienaar.
jpienaar added a comment.
This revision is now accepted and ready to land.
Looks good to me, do you need help submitting?
Comment at: lib/Target/NVPTX/NVPTXISelLowering.cpp:1032
@@ +1031,3 @@
+ if (!CS) {
+
@@ -15,6 +15,7 @@
#include "Utils.h"
#include "mlir/Dialect/GPU/IR/GPUDialect.h"
+#include "mlir/Dialect/SPIRV/IR/SPIRVAttributes.h"
jpienaar wrote:
This feels off: you have GPU dialect transforms depending on SPIRV
attributes/dialect (esp in header). Why is
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/79514
>From 06386cb0d21bb8e210e5ee3eef26df39680fc1d1 Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Sat, 21 Oct 2023 17:06:33 -0700
Subject: [PATCH] [mlir][tosa] Add dialect version.
This adds a singular number
jpienaar wrote:
> This lack some information to me:
>
> * What is the purpose of this?
To be able to flag incompatible bytecode files rather than have it fail later
in mysterious ways. E.g., allows for a more strict failure.
> * What kind of compatibility is this supposed to provide?
None to
https://github.com/jpienaar approved this pull request.
https://github.com/llvm/llvm-project/pull/80246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jpienaar wrote:
> > To be able to flag incompatible bytecode files rather than have it fail
> > later in mysterious ways. E.g., allows for a more strict failure.
>
> That would require some sort of principles and policy around the changes that
> affect the serialization of this and the mainten
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/69927
>From eea36708d838411d70eb99265c3a2f3aabb91460 Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Sun, 22 Oct 2023 09:33:40 -0700
Subject: [PATCH] [mlir] Add config for PDL
Make it so that PDL can be optional
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/69927
>From eea36708d838411d70eb99265c3a2f3aabb91460 Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Sun, 22 Oct 2023 09:33:40 -0700
Subject: [PATCH] [mlir] Add config for PDL
Make it so that PDL can be optional
https://github.com/jpienaar edited
https://github.com/llvm/llvm-project/pull/69927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jpienaar edited
https://github.com/llvm/llvm-project/pull/69927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jpienaar wrote:
> Can you expand on the motivation? Why is it a problem that PDL is always
> included? Your description isn’t very explicit on the impact.
Done. Its not PDL specific, I think it is a problem if any dialect is always
included even if not used :) The others just have a simple met
jpienaar wrote:
> Can you expand on the motivation? Why is it a problem that PDL is always
> included? Your description isn’t very explicit on the impact.
Done. Its not PDL specific, I think it is a problem if any dialect is always
included even if not used :) The others just have a simple met
How did you come to this conclusion?
https://buildkite.com/mlir/mlir-core/builds/2790#9ecce42d-5a20-4e52-8621-c7c0dcee7aa7
is
a clean build at e8e078c8bf7987b95298062a644bac9eed26f988 that is just
before 1b978ddba05cb15e22b4e75adb5e7362ad861987 (if I look at commits on
github) and at fb44b9db95a333
Author: Sprite
Date: 2022-12-16T10:51:26-08:00
New Revision: a9f9f3dff474b7bdb19129eaf625d3ef0084a975
URL:
https://github.com/llvm/llvm-project/commit/a9f9f3dff474b7bdb19129eaf625d3ef0084a975
DIFF:
https://github.com/llvm/llvm-project/commit/a9f9f3dff474b7bdb19129eaf625d3ef0084a975.diff
LOG: C
jpienaar added a comment.
Nice, so this will allow parsing/AST construction with builtins from 2
architectures but will fail to compile if a builtin for the host/device is
called from device/host.
You mention this is not generally possible. Can you give some examples?
Comment
jpienaar added a comment.
@jlebar: We defer it to your and Richard's approval. Thanks
http://reviews.llvm.org/D15305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jpienaar updated this revision to Diff 47408.
jpienaar added a comment.
Added clang-level tests.
http://reviews.llvm.org/D17002
Files:
lib/Basic/Targets.cpp
lib/CodeGen/TargetInfo.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/CodeGe
jpienaar marked 3 inline comments as done.
jpienaar added a comment.
Updated thanks.
Comment at: lib/CodeGen/TargetInfo.cpp:6498
@@ +6497,3 @@
+
+ Class classify(QualType Ty) const;
+
We only had one DefaultNumRegisterParameters that we supported
(DefaultNumRe
jpienaar updated the summary for this revision.
jpienaar updated this revision to Diff 48119.
jpienaar marked an inline comment as done.
jpienaar added a comment.
Herald added a subscriber: joker.eph.
Move mregparm check to Tools.cpp and correct triple used in test.
http://reviews.llvm.org/D1700
jpienaar added inline comments.
Comment at: test/CodeGen/lanai-arguments.c:1
@@ +1,2 @@
+// RUN: %clang_cc1 -triple wasm32-unknown-unknown %s -emit-llvm -o - \
+// RUN: | FileCheck %s -check-prefix=LANAI
eliben wrote:
> why wasm triple?
Fixed, thanks.
http://r
jpienaar added reviewers: eliben, jyknight, chandlerc.
jpienaar updated this revision to Diff 49119.
jpienaar added a comment.
Updated preprocessor test init.c to use -match-full-lines.
http://reviews.llvm.org/D17002
Files:
lib/Basic/Targets.cpp
lib/CodeGen/TargetInfo.cpp
lib/Driver/Drive
Author: jpienaar
Date: Mon Apr 25 19:09:29 2016
New Revision: 267496
URL: http://llvm.org/viewvc/llvm-project?rev=267496&view=rev
Log:
[lanai] Update handling of structs in arguments to be passed in registers.
Previously aggregate types were passed byval, change the ABI to pass these in
register
25, 2016 at 6:46 PM, Kostya Serebryany wrote:
>
>> +rnk
>>
>> On Mon, Apr 25, 2016 at 5:09 PM, Jacques Pienaar via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: jpienaar
>>> Date: Mon Apr 25 19:09:29 2016
>>> N
jpienaar updated this revision to Diff 49688.
jpienaar added a comment.
Removed unused variables in LanaiTargetInfo.
http://reviews.llvm.org/D17002
Files:
lib/Basic/Targets.cpp
lib/CodeGen/TargetInfo.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.cpp
lib/Driver/T
jpienaar updated this revision to Diff 49969.
jpienaar added a comment.
Updated to use resetDataLayout.
http://reviews.llvm.org/D17002
Files:
lib/Basic/Targets.cpp
lib/CodeGen/TargetInfo.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test
jpienaar added a comment.
Friendly ping.
http://reviews.llvm.org/D17002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jpienaar updated this revision to Diff 51806.
jpienaar marked 6 inline comments as done.
jpienaar added a comment.
Removed unnecessary floating point classification (only integer is supported)
and performed suggested cleanups.
http://reviews.llvm.org/D17002
Files:
lib/Basic/Targets.cpp
lib
jpienaar added a comment.
Updated, thanks
Comment at: lib/CodeGen/TargetInfo.cpp:6622-6626
@@ +6621,7 @@
+
+ if (const BuiltinType *BT = T->getAs()) {
+BuiltinType::Kind K = BT->getKind();
+if (K == BuiltinType::Float || K == BuiltinType::Double)
+ return Float;
+
Author: jpienaar
Date: Mon Mar 28 16:02:54 2016
New Revision: 264655
URL: http://llvm.org/viewvc/llvm-project?rev=264655&view=rev
Log:
[lanai] Add Lanai backend to clang driver.
Changes to clang to add Lanai backend. Adds a new target, ABI and toolchain.
General Lanai backend discussion on llvm-
This revision was automatically updated to reflect the committed changes.
jpienaar marked an inline comment as done.
Closed by commit rL264655: [lanai] Add Lanai backend to clang driver. (authored
by jpienaar).
Changed prior to commit:
http://reviews.llvm.org/D17002?vs=51806&id=51838#toc
Repos
jpienaar added a comment.
Looks good to me.
Comment at: lib/AST/RecordLayoutBuilder.cpp:2003
@@ +2002,3 @@
+return nullptr;
+ if (!Context.getLangOpts().CUDAIsDevice && !MD->hasAttr()
&&
+ MD->hasAttr())
Add a comment to explain asymmetry.
jpienaar accepted this revision.
jpienaar added a comment.
This revision is now accepted and ready to land.
Looks good, thanks
Comment at: test/CodeGenCUDA/device-vtable.cu:37
@@ +36,3 @@
+ virtual void h_method();
+ __device__ virtual void d_method();
+};
Doe
https://github.com/jpienaar created
https://github.com/llvm/llvm-project/pull/99770
These classes are not specific to clang and useful for other rewriter tools
(flagged in previous review).
>From 451a4c61066c4a433bc100ebc511dc6447f83ab0 Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Sat
https://github.com/jpienaar approved this pull request.
Nice!
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jpienaar edited
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1654,12 +1654,12 @@ void OperationFormat::genElementParser(FormatElement
*element, MethodBody &body,
dir->shouldBeQualified() ? qualifiedTypeParserCode : typeParserCode;
TypeSwitch(dir->getArg())
.Case([&](auto operand) {
-body << form
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/99770
>From ee91900dd42321ce1344a70df5f1baddf36bde9f Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Sat, 20 Jul 2024 16:25:14 +
Subject: [PATCH] [llvm][clang] Move RewriterBuffer to ADT.
These classes are n
https://github.com/jpienaar closed
https://github.com/llvm/llvm-project/pull/99770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jpienaar approved this pull request.
https://github.com/llvm/llvm-project/pull/138174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jpienaar approved this pull request.
https://github.com/llvm/llvm-project/pull/143297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/149148
>From f5d80596c0dc56086b585e9d59afa7472ff16321 Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Wed, 16 Jul 2025 17:37:53 +
Subject: [PATCH] [clang-tidy] Add MLIR check for old op builder usage.
Moving
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/149148
>From 05e7a590273c5e7a34038ded2cf4b6dd5fd6920d Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Wed, 16 Jul 2025 17:37:53 +
Subject: [PATCH] [clang-tidy] Add MLIR check for old op builder usage.
Moving
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/149148
>From 5c4ab5ae7cb18a3cc81ce0647da62a0d061957d9 Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Wed, 16 Jul 2025 17:37:53 +
Subject: [PATCH] [clang-tidy] Add MLIR check for old op builder usage.
Moving
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/149148
>From 99ce9442348dbc2b49f39306c4b16de8fab1203b Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Wed, 16 Jul 2025 17:37:53 +
Subject: [PATCH] [clang-tidy] Add MLIR check for old op builder usage.
Moving
jpienaar wrote:
Good question. I think there are a few style things we could flag, but nothing
planned. And this current one I'd assume lives for like 6-9 months and then we
remove it. Having this flagged on commits to both MLIR & Flang to reduce
migration need later. Well I know a couple of d
https://github.com/jpienaar created
https://github.com/llvm/llvm-project/pull/149148
Moving towards new create method invocation, add check to flag old usage.
>From 311e30ac75c7fcc0a13ad7908cc1eaa1f7cb1e07 Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Wed, 16 Jul 2025 17:37:53 +
Sub
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/149148
>From b24a881d3391e095fbf37f75ef8f0bd8bce12f74 Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Wed, 16 Jul 2025 17:37:53 +
Subject: [PATCH] [clang-tidy] Add MLIR check for old op builder usage.
Moving
jpienaar wrote:
I considered placing it in LLVM module instead given part of LLVM project.
https://github.com/llvm/llvm-project/pull/149148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/149148
>From c9b0b62c612aef1ff9deec748ac89f30749bb445 Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Wed, 16 Jul 2025 17:37:53 +
Subject: [PATCH] [clang-tidy] Add MLIR check for old op builder usage.
Moving
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/149148
>From 11335cdf95fbfe9679f7831d7a726767ed45dac2 Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Wed, 16 Jul 2025 17:37:53 +
Subject: [PATCH] [clang-tidy] Add MLIR check for old op builder usage.
Moving
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/149148
>From 291ca559c2ff55405c00c0db791c9b9fb312cd6c Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Wed, 16 Jul 2025 17:37:53 +
Subject: [PATCH] [clang-tidy] Add MLIR check for old op builder usage.
Moving
https://github.com/jpienaar ready_for_review
https://github.com/llvm/llvm-project/pull/149148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jpienaar edited
https://github.com/llvm/llvm-project/pull/149306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/149148
>From b404f5390ac5684c7452e69f6fe209e5215f8929 Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Wed, 16 Jul 2025 17:37:53 +
Subject: [PATCH 1/6] [clang-tidy] Add MLIR check for old op builder usage.
Mo
https://github.com/jpienaar closed
https://github.com/llvm/llvm-project/pull/149306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/149148
>From b404f5390ac5684c7452e69f6fe209e5215f8929 Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Wed, 16 Jul 2025 17:37:53 +
Subject: [PATCH 1/7] [clang-tidy] Add MLIR check for old op builder usage.
Mo
jpienaar wrote:
It seems it has been only https://github.com/llvm/llvm-project/pull/148018
submitted to it and that's not on the 21.x branch, and then its returning it to
https://github.com/llvm/llvm-project/blob/3bd3e06f3fe418e24af65457877f40cee0544f9d/clang-
https://github.com/jpienaar ready_for_review
https://github.com/llvm/llvm-project/pull/149306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jpienaar wrote:
Something like
https://github.com/llvm/llvm-project/compare/main...jpienaar:llvm-project:cleanout?expand=1
https://github.com/llvm/llvm-project/pull/149148
___
cfe-commits mailing list
cfe-commits@l
https://github.com/jpienaar created
https://github.com/llvm/llvm-project/pull/149306
Move over change post 21.x branch cut.
>From 8606cc1decb335c92f187ef5eb058f0bee5584ed Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Thu, 17 Jul 2025 13:13:31 +
Subject: [PATCH] Cleanout clang-tools-
https://github.com/jpienaar edited
https://github.com/llvm/llvm-project/pull/149148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
65 matches
Mail list logo
