[libcxx] r280335 - Fix libc++ configuration with -fsanitize-coverage

Author: krasin Date: Wed Aug 31 20:38:32 2016 New Revision: 280335 URL: http://llvm.org/viewvc/llvm-project?rev=280335&view=rev Log: Fix libc++ configuration with -fsanitize-coverage Summary: a recent change (r280015) in libc++ configuration broke LibFuzzer bot: http://lab.llvm.org:8011/builders/

[libunwind] r299666 - Fix unused typedef. Follow up to r299575.

Author: krasin Date: Thu Apr 6 12:35:35 2017 New Revision: 299666 URL: http://llvm.org/viewvc/llvm-project?rev=299666&view=rev Log: Fix unused typedef. Follow up to r299575. Modified: libunwind/trunk/src/AddressSpace.hpp Modified: libunwind/trunk/src/AddressSpace.hpp URL: http://llvm.org/

r299671 - Fix unused lambda capture. Follow up to r299653.

Author: krasin Date: Thu Apr 6 12:42:05 2017 New Revision: 299671 URL: http://llvm.org/viewvc/llvm-project?rev=299671&view=rev Log: Fix unused lambda capture. Follow up to r299653. Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp URL:

Re: r296374 - [ubsan] Factor out logic to emit a range check. NFC.

Hi Vedant, not on top of my head. Dmitriy, can you please take a look? krasin On Mon, Feb 27, 2017 at 12:43 PM, Vedant Kumar wrote: > Hi Ivan, > > I saw a bot failure on your job after this commit: > > http://lab.llvm.org:8011/builders/sanitizer-x86_64- > linux-autoconf/builds/5467/steps/tsa

[PATCH] D26559: Insert a type check before reading vtable.

krasin updated this revision to Diff 77868. krasin added a comment. Add a regression test. https://reviews.llvm.org/D26559 Files: lib/CodeGen/CGExprCXX.cpp test/CodeGenCXX/ubsan-null.cpp Index: test/CodeGenCXX/ubsan-null.cpp

[PATCH] D26559: Insert a type check before reading vtable.

krasin added inline comments. Comment at: lib/CodeGen/CGExprCXX.cpp:93 + + EmitTypeCheck(CodeGenFunction::TCK_MemberCall, +CallLoc, This, C.getRecordType(DD->getParent())); pcc wrote: > pcc wrote: > > Is it correct to emit a type check at this po

[PATCH] D26559: Insert a type check before reading vtable.

krasin updated this revision to Diff 77941. krasin added a comment. Do better job with destructors. https://reviews.llvm.org/D26559 Files: lib/CodeGen/CGExprCXX.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGenCXX/ubsan-vtable-checks.cpp Index: test/CodeGenCXX/ubsan-vtable-checks.cpp

[PATCH] D26559: Insert a type check before reading vtable.

krasin added inline comments. Comment at: lib/CodeGen/CGExprCXX.cpp:93 + + EmitTypeCheck(CodeGenFunction::TCK_MemberCall, +CallLoc, This, C.getRecordType(DD->getParent())); pcc wrote: > krasin wrote: > > pcc wrote: > > > pcc wrote: > > > > Is it

[PATCH] D26559: Insert a type check before reading vtable.

krasin added a comment. Friendly ping. https://reviews.llvm.org/D26559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26559: Insert a type check before reading vtable.

krasin updated this revision to Diff 78104. krasin added a comment. Address comments. https://reviews.llvm.org/D26559 Files: lib/CodeGen/CGExprCXX.cpp test/CodeGenCXX/ubsan-vtable-checks.cpp Index: test/CodeGenCXX/ubsan-vtable-checks.cpp

[PATCH] D26559: Insert a type check before reading vtable.

krasin marked 2 inline comments as done. krasin added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1820-1833 + ASTContext &Context = getContext(); + SourceLocation CallLoc = CE ? CE->getLocStart() : SourceLocation(); + CGF.EmitTypeCheck(CodeGenFunction::TCK_Mem

Re: [PATCH] D26559: Insert a type check before reading vtable.

Thank you, Richard. Shall I merge the newly introduced test/CodeGenCXX/ubsan-vtable-checks.cpp into catch-undef-behavior.cpp or it's more clear when it's standalone? On Tue, Nov 15, 2016 at 5:51 PM, Richard Smith wrote: > On Fri, Nov 11, 2016 at 3:02 PM, Ivan Krasin via cfe-co

Re: [PATCH] D26559: Insert a type check before reading vtable.

h-undef-behavior.cpp is getting unwieldy, so a separate > test file doesn't seem like a bad thing. > > >> On Tue, Nov 15, 2016 at 5:51 PM, Richard Smith >> wrote: >> >>> On Fri, Nov 11, 2016 at 3:02 PM, Ivan Krasin via cfe-commits < >>> cfe-comm

Re: [PATCH] D26559: Insert a type check before reading vtable.

x27;t seem like a bad thing. >> >> >>> On Tue, Nov 15, 2016 at 5:51 PM, Richard Smith >>> wrote: >>> >>>> On Fri, Nov 11, 2016 at 3:02 PM, Ivan Krasin via cfe-commits < >>>> cfe-commits@lists.llvm.org> wrote: >>>&g

[PATCH] D26559: Insert a type check before reading vtable.

krasin updated this revision to Diff 78240. krasin marked an inline comment as done. krasin added a comment. Sync to Clang ToT. https://reviews.llvm.org/D26559 Files: lib/CodeGen/CGExprCXX.cpp test/CodeGenCXX/ubsan-vtable-checks.cpp Index: test/CodeGenCXX/ubsan-vtable-checks.cpp ==

[PATCH] D26559: Insert a type check before reading vtable.

krasin updated this revision to Diff 78276. krasin added a comment. Fix the test under -Asserts build. https://reviews.llvm.org/D26559 Files: lib/CodeGen/CGExprCXX.cpp test/CodeGenCXX/ubsan-vtable-checks.cpp Index: test/CodeGenCXX/ubsan-vtable-checks.cpp ===

[PATCH] D26559: Insert a type check before reading vtable.

krasin marked an inline comment as done. krasin added inline comments. Comment at: test/CodeGenCXX/ubsan-vtable-checks.cpp:23 + // CHECK-NULL: [[UBSAN_CMP_RES:%[0-9]+]] = icmp ne %struct.T* %{{[_a-z0-9]+}}, null + // CHECK-NULL-NEXT: br i1 [[UBSAN_CMP_RES]], label %cont, label

[PATCH] D26559: Insert a type check before reading vtable.

krasin updated this revision to Diff 78277. krasin added a comment. Address minor comment. https://reviews.llvm.org/D26559 Files: lib/CodeGen/CGExprCXX.cpp test/CodeGenCXX/ubsan-vtable-checks.cpp Index: test/CodeGenCXX/ubsan-vtable-checks.cpp ==

[PATCH] D26559: Insert a type check before reading vtable.

krasin updated this revision to Diff 78279. krasin added a comment. inline https://reviews.llvm.org/D26559 Files: lib/CodeGen/CGExprCXX.cpp test/CodeGenCXX/ubsan-vtable-checks.cpp Index: test/CodeGenCXX/ubsan-vtable-checks.cpp ==

r287181 - Insert a type check before reading vtable.

Author: krasin Date: Wed Nov 16 18:39:48 2016 New Revision: 287181 URL: http://llvm.org/viewvc/llvm-project?rev=287181&view=rev Log: Insert a type check before reading vtable. Summary: this is to prevent a situation when a pointer is invalid or null, but we get to reading from vtable before we ca

[PATCH] D26559: Insert a type check before reading vtable.

This revision was automatically updated to reflect the committed changes. Closed by commit rL287181: Insert a type check before reading vtable. (authored by krasin). Changed prior to commit: https://reviews.llvm.org/D26559?vs=78279&id=78288#toc Repository: rL LLVM https://reviews.llvm.org/D

r287185 - Explicitly specify that ubsan-vtable-checks is x86-64.

Author: krasin Date: Wed Nov 16 19:09:04 2016 New Revision: 287185 URL: http://llvm.org/viewvc/llvm-project?rev=287185&view=rev Log: Explicitly specify that ubsan-vtable-checks is x86-64. This should fix a failure on PowerPC introduced by r287181. Modified: cfe/trunk/test/CodeGenCXX/ubsan-vt

[PATCH] D26560: Add a test for vcall on a null ptr.

krasin updated this revision to Diff 78405. krasin added a comment. sync https://reviews.llvm.org/D26560 Files: test/ubsan/TestCases/TypeCheck/null.cpp Index: test/ubsan/TestCases/TypeCheck/null.cpp === --- test/ubsan/TestCases

[PATCH] D26560: Add a test for vcall on a null ptr.

krasin added inline comments. Comment at: test/ubsan/TestCases/TypeCheck/null.cpp:1 -// RUN: %clangxx -fsanitize=null %s -O3 -o %t -// RUN: %run %t l 2>&1 | FileCheck %s --check-prefix=CHECK-LOAD -// RUN: %expect_crash %run %t s 2>&1 | FileCheck %s --check-prefix=CHECK-STORE -//

[PATCH] D26560: Add a test for vcall on a null ptr.

krasin updated this revision to Diff 78557. krasin added a comment. sync & address the comments. https://reviews.llvm.org/D26560 Files: test/ubsan/TestCases/TypeCheck/null.cpp Index: test/ubsan/TestCases/TypeCheck/null.cpp ===

[PATCH] D26560: Add a test for vcall on a null ptr.

krasin added a comment. Ping. https://reviews.llvm.org/D26560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26559: Insert a type check before reading vtable.

krasin added a comment. All UBSan test cases happen to live in compiler-rt. I have added a couple of test cases in https://reviews.llvm.org/D26560. Also, I am not against adding Clang counterparts for them which would test IL instead of the output from running. But it probably deserves a separa

[PATCH] D26559: Insert a type check before reading vtable.

krasin added a comment. Small correction: all UBSan type checks tests live in compiler-rt. There is a test for UBsan + devirtualization inside tools/clang. My point still stands. https://reviews.llvm.org/D26559 ___ cfe-commits mailing list cfe-comm

[PATCH] D26559: Insert a type check before reading vtable.

krasin added a comment. Sounds reasonable. Will do on Monday. https://reviews.llvm.org/D26559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

krasin created this revision. krasin added subscribers: cfe-commits, pcc. Clang sanitizers, such as AddressSanitizer, ThreadSanitizer, MemorySanitizer, Control Flow Integrity and others, use blacklists to specify which types / functions should not be instrumented to avoid false positives or suppr

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

krasin added a comment. In http://reviews.llvm.org/D11968#222338, @pcc wrote: > We should also make blacklists appear in the `--show-includes` output. Is it about Windows compatibility? Do you mean that the output of bin/clang-cl /Zs /showIncludes ~/lala.cc -fsanitize=address should include

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

krasin updated this revision to Diff 31895. krasin marked an inline comment as done. krasin added a comment. Add more test cases. http://reviews.llvm.org/D11968 Files: include/clang/Frontend/DependencyOutputOptions.h lib/Frontend/CompilerInvocation.cpp lib/Frontend/DependencyFile.cpp te

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

krasin updated this revision to Diff 31979. krasin added a comment. Windows compat http://reviews.llvm.org/D11968 Files: include/clang/Frontend/DependencyOutputOptions.h include/clang/Frontend/Utils.h lib/Frontend/CompilerInstance.cpp lib/Frontend/CompilerInvocation.cpp lib/Frontend/D

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

krasin marked an inline comment as done. krasin added a comment. Please, take another look. The test for --show-includes is on the way. http://reviews.llvm.org/D11968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

krasin updated this revision to Diff 31983. krasin added a comment. More tests / fix tests. http://reviews.llvm.org/D11968 Files: include/clang/Frontend/DependencyOutputOptions.h include/clang/Frontend/Utils.h lib/Frontend/CompilerInstance.cpp lib/Frontend/CompilerInvocation.cpp lib/F

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

krasin added a comment. Thank you, Peter. I will commit once I have restored my password (the email to Chris is sent) http://reviews.llvm.org/D11968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

Author: krasin Date: Wed Aug 12 23:04:37 2015 New Revision: 244867 URL: http://llvm.org/viewvc/llvm-project?rev=244867&view=rev Log: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD. Summary: Clang sanitizers, such as AddressSanitizer, ThreadSanitizer, MemorySanitizer, Control

Re: r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

Thank you, Yaron. Sorry for breaking the build, it obviously passed locally and I didn't think about all the variety of the supported configs. :( Does LLVM have try bots, so that I can run the tests with my patch before committing it? krasin On Thu, Aug 13, 2015 at 3:40 AM, Renato Golin wrote:

Re: r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

Thank you, Yaron. Understood. On Thu, Aug 13, 2015 at 11:04 AM, Yaron Keren wrote: > There is great variety of OSs, compilers, configs in the bots. You can't > get the smae with try bots unless everything is duplicated which is a > waste. You test locally, commit, watch the bots here: > > http:

Re: r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

n Thu, Aug 13, 2015 at 4:09 PM, NAKAMURA Takumi wrote: > Tweaked a test in r244970. > Could you split it out if you would like to run it for the default target? > On Fri, Aug 14, 2015 at 5:07 AM Ivan Krasin via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Thank

[PATCH] D12021: Remove test cases, which rely on the default sanitizer blacklists.The default blacklists may vary across different architectures andconfigurations. It was not wise to include into http

krasin created this revision. krasin added a reviewer: chapuni. krasin added subscribers: pcc, cfe-commits. http://reviews.llvm.org/D12021 Files: test/Frontend/dependency-gen.c Index: test/Frontend/dependency-gen.c === --- test/Fr

Re: r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

lit it out if you would like to run it for the default target? >> On Fri, Aug 14, 2015 at 5:07 AM Ivan Krasin via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Thank you, Yaron. Understood. >>> >>> On Thu, Aug 13, 2015 at 11:04 AM, Yaron

Re: [PATCH] D12021: Remove test cases, which rely on the default sanitizer blacklists.

krasin added a comment. In http://reviews.llvm.org/D12021#224102, @pcc wrote: > You could create a fake resource directory which contains only the > `asan_blacklist.txt` file. See `test/Driver/Inputs/resource_dir` for an > example of this kind of thing. I believe it's unnecessary. The default

r244985 - Remove test cases, which rely on the default sanitizer blacklists.

Author: krasin Date: Thu Aug 13 18:37:28 2015 New Revision: 244985 URL: http://llvm.org/viewvc/llvm-project?rev=244985&view=rev Log: Remove test cases, which rely on the default sanitizer blacklists. Summary: The default blacklists may vary across different architectures and configurations. It wa

[PATCH] D12544: Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.

krasin created this revision. krasin added reviewers: pcc, rsmith. krasin added a subscriber: cfe-commits. Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output. Introduce a frontend option -fdepfile-entry, and only insert them for the user-defined sanitizer blacklists. In front

Re: [PATCH] D12544: Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.

krasin updated this revision to Diff 33764. krasin added a comment. Add a test for default blacklist. http://reviews.llvm.org/D12544 Files: include/clang/Driver/Options.td include/clang/Driver/SanitizerArgs.h lib/Driver/SanitizerArgs.cpp lib/Frontend/CompilerInvocation.cpp test/Driver

Re: [PATCH] D12544: Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.

krasin added a comment. In http://reviews.llvm.org/D12544#237819, @pcc wrote: > It's probably time to add something like the driver test I was talking about > in http://reviews.llvm.org/D12021. Without that, you will have no test > coverage for the functional change here. Done, please, take a

Re: [PATCH] D12544: Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.

krasin updated this revision to Diff 33849. krasin added a comment. Addressed a nit. http://reviews.llvm.org/D12544 Files: include/clang/Driver/Options.td include/clang/Driver/SanitizerArgs.h lib/Driver/SanitizerArgs.cpp lib/Frontend/CompilerInvocation.cpp test/Driver/Inputs/resource_

Re: [PATCH] D12544: Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.

krasin added inline comments. Comment at: test/Driver/fsanitize-blacklist.c:25 @@ -18,2 +24,3 @@ +// CHECK-DEFAULT-BLACKLIST: -fsanitize-blacklist={{.*}}asan_blacklist.txt // Ignore -fsanitize-blacklist flag if there is no -fsanitize flag. Good idea. Done. ht

r246700 - Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.

Author: krasin Date: Wed Sep 2 15:02:38 2015 New Revision: 246700 URL: http://llvm.org/viewvc/llvm-project?rev=246700&view=rev Log: Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output. Summary: Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output. Introduc

Re: [PATCH] D16175: Introduce -fsanitize-stats flag.

krasin1 added a subscriber: krasin1. krasin1 accepted this revision. krasin1 added a reviewer: krasin1. krasin1 added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Driver/SanitizerArgs.cpp:560 @@ +559,3 @@ + LinkerOptionFlag = "--linker-option

Re: [PATCH] D15921: [analyzer] Utility to match function calls.

krasin added a subscriber: krasin. krasin added a comment. FYI: this revision has likely broken the build: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/9561 FAIL: Clang :: Analysis/simple-stream-checks.c (367 of 8927) - TEST 'Clang :: Analysis/simple-stream-checks.c' FAI