Author: ibiryukov
Date: Fri Sep 22 12:07:37 2017
New Revision: 314019
URL: http://llvm.org/viewvc/llvm-project?rev=314019&view=rev
Log:
Set completion priority of destructors and operators to CCP_Unlikely.
Summary:
It will move destructors and operators to the end of completion list.
Destructors
Author: ibiryukov
Date: Fri Sep 22 12:07:45 2017
New Revision: 314020
URL: http://llvm.org/viewvc/llvm-project?rev=314020&view=rev
Log:
[clangd] Updated gold for completion tests after cfe changes.
Modified:
clang-tools-extra/trunk/test/clangd/completion-snippet.test
clang-tools-extra/tru
Author: ibiryukov
Date: Mon Jun 3 01:34:25 2019
New Revision: 362363
URL: http://llvm.org/viewvc/llvm-project?rev=362363&view=rev
Log:
[CodeComplete] Add a bit more whitespace to completed patterns
Summary:
E.g. we now turn `while(<#cond#>){` into `while (<#cond#>) {`
This slightly improves the
Author: ibiryukov
Date: Mon Jun 3 01:34:25 2019
New Revision: 362363
URL: http://llvm.org/viewvc/llvm-project?rev=362363&view=rev
Log:
[CodeComplete] Add a bit more whitespace to completed patterns
Summary:
E.g. we now turn `while(<#cond#>){` into `while (<#cond#>) {`
This slightly improves the
Author: ibiryukov
Date: Tue Jun 4 00:19:11 2019
New Revision: 362469
URL: http://llvm.org/viewvc/llvm-project?rev=362469&view=rev
Log:
[clangd] Fix a crash when clang-tidy is disabled
Added:
clang-tools-extra/trunk/clangd/test/diagnostics-no-tidy.test
Modified:
clang-tools-extra/trunk/cl
Author: ibiryukov
Date: Tue Jun 4 02:26:08 2019
New Revision: 362479
URL: http://llvm.org/viewvc/llvm-project?rev=362479&view=rev
Log:
[CodeComplete] Include more text into typed chunks of pattern completions
Summary:
To allow filtering on any of the words in the editors.
In particular, the foll
Author: ibiryukov
Date: Tue Jun 4 02:36:59 2019
New Revision: 362481
URL: http://llvm.org/viewvc/llvm-project?rev=362481&view=rev
Log:
[clangd] Support offsets for parameters in signatureHelp
Summary: Added to LSP in version 3.14
Reviewers: hokein
Reviewed By: hokein
Subscribers: MaskRay, jko
Thanks! And sorry about this in the first place, I did not have this
warning enabled locally.
On Tue, Jun 4, 2019 at 1:28 PM Simon Pilgrim via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rksimon
> Date: Tue Jun 4 04:31:45 2019
> New Revision: 362491
>
> URL: http://llvm.org/viewvc
Author: ibiryukov
Date: Tue Jun 4 09:19:11 2019
New Revision: 362517
URL: http://llvm.org/viewvc/llvm-project?rev=362517&view=rev
Log:
[clangd] Minor cleanup. NFC
Removed unused using declaration from TweakTests.cpp
Modified:
clang-tools-extra/trunk/clangd/unittests/TweakTests.cpp
Modified
Author: ibiryukov
Date: Tue Jun 4 10:15:48 2019
New Revision: 362530
URL: http://llvm.org/viewvc/llvm-project?rev=362530&view=rev
Log:
[Syntax] Do not depend on llvm targets for Syntax tests. NFC
They are not required and only slow down the build.
Modified:
cfe/trunk/unittests/Tooling/Synta
Author: ibiryukov
Date: Thu Jun 6 01:06:25 2019
New Revision: 362683
URL: http://llvm.org/viewvc/llvm-project?rev=362683&view=rev
Log:
Update AST matchers tutorial to use monorepo layout
The docs were inconsistent: requesting the user to clone the monorepo,
and then continuing with the `llvm/too
Author: ibiryukov
Date: Thu Jun 6 01:32:25 2019
New Revision: 362686
URL: http://llvm.org/viewvc/llvm-project?rev=362686&view=rev
Log:
[clangd] Remove unused signature help quality signal. NFC
ContainsActiveParameter is not used anywhere, set incorrectly (see the
removed FIXME) and has no unit t
Author: ibiryukov
Date: Fri Jun 7 09:24:38 2019
New Revision: 362811
URL: http://llvm.org/viewvc/llvm-project?rev=362811&view=rev
Log:
[clangd] Return empty results on spurious completion triggers
Summary:
We currently return an error, this causes `coc.nvim` and VSCode to
show an error message i
Author: ibiryukov
Date: Fri Jun 7 09:31:06 2019
New Revision: 362812
URL: http://llvm.org/viewvc/llvm-project?rev=362812&view=rev
Log:
AST Matchers tutorial requests to enable clang-tools-extra. NFC
Otherwise the examples do not build.
Modified:
cfe/trunk/docs/LibASTMatchersTutorial.rst
Mo
Author: ibiryukov
Date: Tue Jun 11 02:52:30 2019
New Revision: 363041
URL: http://llvm.org/viewvc/llvm-project?rev=363041&view=rev
Log:
[Frontend] Avoid creating auxilary files during a unit test. NFC
A test added in r363009 logs diagnostics into a file inside current
working directory. This brea
Hi Alex,
Just wanted to let you know that I removed logging of diagnostics into a
file inside the unit test in r363041 to unbreak our integrate.
On Tue, Jun 11, 2019 at 1:29 AM Alex Lorenz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: arphaman
> Date: Mon Jun 10 16:32:42 2019
>
Author: ibiryukov
Date: Tue Jun 11 05:05:03 2019
New Revision: 363052
URL: http://llvm.org/viewvc/llvm-project?rev=363052&view=rev
Log:
Make sure a test from r363036 does not write into a working directory
It breaks if build directory is not writable. This change is required
to fix our integrate.
Sure, that should work just fine. Could you also add a comment what events
setting the log file sets in motion? It is not obvious from the test code.
On Tue, Jun 11, 2019 at 6:51 PM Alex L wrote:
> Hmm, the logging was meant to exercise the creation of chained diagnostic
> consumer, so without i
Author: ibiryukov
Date: Wed Jun 12 05:03:24 2019
New Revision: 363150
URL: http://llvm.org/viewvc/llvm-project?rev=363150&view=rev
Log:
[clangd] Return TextEdits from ClangdServer::applyTweak
Summary:
Instead of `tooling::Replacements`. So that embedders do not need to store
the contents of the f
Author: ibiryukov
Date: Tue Jun 18 08:15:41 2019
New Revision: 363691
URL: http://llvm.org/viewvc/llvm-project?rev=363691&view=rev
Log:
[clangd] Return vector from applyTweak. NFC
For the same reasons as r363150, which got overwritten by changes in
r363680.
Sending without review to unbreak our
Author: ibiryukov
Date: Tue Jun 18 09:27:27 2019
New Revision: 363698
URL: http://llvm.org/viewvc/llvm-project?rev=363698&view=rev
Log:
[Syntax] Add a helper to find expansion by its first spelled token
Summary: Used in clangd for a code tweak that expands a macro.
Reviewers: sammccall
Reviewed
Author: ibiryukov
Date: Wed Jun 19 06:56:36 2019
New Revision: 363801
URL: http://llvm.org/viewvc/llvm-project?rev=363801&view=rev
Log:
[Syntax] Fix a crash when dumping empty token buffer
Modified:
cfe/trunk/lib/Tooling/Syntax/Tokens.cpp
cfe/trunk/unittests/Tooling/Syntax/TokensTest.cpp
Author: ibiryukov
Date: Wed Jun 19 07:03:19 2019
New Revision: 363803
URL: http://llvm.org/viewvc/llvm-project?rev=363803&view=rev
Log:
[clangd] Collect tokens of main files when building the AST
Summary:
The first use of this is a code tweak to expand macro calls.
Will later be used to build syn
Author: ibiryukov
Date: Wed Jun 19 10:25:24 2019
New Revision: 363843
URL: http://llvm.org/viewvc/llvm-project?rev=363843&view=rev
Log:
[clangd] Format changes produced by rename
Reviewers: hokein, kadircet, sammccall
Reviewed By: kadircet
Subscribers: MaskRay, jkorous, arphaman, cfe-commits
T
Author: ibiryukov
Date: Wed Jun 19 10:30:02 2019
New Revision: 363844
URL: http://llvm.org/viewvc/llvm-project?rev=363844&view=rev
Log:
[clangd] Consume error returned by cleanupAndFormat
When called by ClangdServer::applyTweak.
No idea how to actually trigger this in practice, so no tests.
Modi
Author: ibiryukov
Date: Wed Jul 17 08:22:14 2019
New Revision: 366337
URL: http://llvm.org/viewvc/llvm-project?rev=366337&view=rev
Log:
[clang-tidy] Adjust location of namespace comment diagnostic
Summary:
If there is no comment, place it at the closing brace of a namespace
definition. Previously
Hi Marco,
Your commit crashes clang when building the LLVM Support with libc++
library.
I'll revert the commit to unbreak our integrate.
See the details in the following bug:
https://bugs.llvm.org/show_bug.cgi?id=42665
On Thu, Jul 18, 2019 at 1:42 PM Ilya Biryukov wrote:
> Hi Marco,
>
> Your c
Author: ibiryukov
Date: Thu Jul 18 04:55:33 2019
New Revision: 366429
URL: http://llvm.org/viewvc/llvm-project?rev=366429&view=rev
Log:
Revert r366422: [OpenCL] Improve destructor support in C++ for OpenCL
Reason: this commit causes crashes in the clang compiler when building
LLVM Support with li
Author: ibiryukov
Date: Thu Jul 18 08:21:34 2019
New Revision: 366448
URL: http://llvm.org/viewvc/llvm-project?rev=366448&view=rev
Log:
[ASTUnit] Fix a regression in cached completions
Summary:
After r345152 cached completions started adding namespaces after
nested name specifiers, e.g. in `some_
Hi Balazs,
Your commit introduces a layering violation: ASTImporter (which is inside
clangAST library) cannot depend on ASTUnit (which is inside clangFrontend
library).
I'm afraid I'll have to revert the commit to unbreak our integrate.
On Thu, Jul 18, 2019 at 5:22 PM Balazs Keri via cfe-commits
Author: ibiryukov
Date: Thu Jul 18 08:43:26 2019
New Revision: 366453
URL: http://llvm.org/viewvc/llvm-project?rev=366453&view=rev
Log:
Revert r366449: [CrossTU] Add a function to retrieve original source location.
Reason: the commit breaks layering by adding a dependency on ASTUnit
(which is ins
Reverted in r366453
On Thu, Jul 18, 2019 at 5:38 PM Ilya Biryukov wrote:
> Hi Balazs,
>
> Your commit introduces a layering violation: ASTImporter (which is inside
> clangAST library) cannot depend on ASTUnit (which is inside clangFrontend
> library).
> I'm afraid I'll have to revert the commit
Author: ibiryukov
Date: Thu Jul 18 09:24:09 2019
New Revision: 366457
URL: http://llvm.org/viewvc/llvm-project?rev=366457&view=rev
Log:
[ASTUnit] Attempt to unbreak Windows buildbots after r366448
Modified:
cfe/trunk/test/Index/complete-qualified-cached.cpp
Modified: cfe/trunk/test/Index/com
Author: ibiryukov
Date: Fri Jul 19 06:51:01 2019
New Revision: 366577
URL: http://llvm.org/viewvc/llvm-project?rev=366577&view=rev
Log:
[clangd] Provide a way to publish highlightings in non-racy manner
Summary:
By exposing a callback that can guard code publishing results of
'onMainAST' callback
Author: ibiryukov
Date: Mon Jul 22 02:58:53 2019
New Revision: 366672
URL: http://llvm.org/viewvc/llvm-project?rev=366672&view=rev
Log:
[AST] Treat semantic form of InitListExpr as implicit code in traversals
Summary:
In particular, do not traverse the semantic form if shouldVisitImplicitCode()
r
Author: ibiryukov
Date: Mon Jul 22 03:05:11 2019
New Revision: 366674
URL: http://llvm.org/viewvc/llvm-project?rev=366674&view=rev
Log:
[clangd] Log input code of failed highlighting tests. NFC
Modified:
clang-tools-extra/trunk/clangd/unittests/SemanticHighlightingTests.cpp
Modified: clang-t
Author: ibiryukov
Date: Thu Aug 1 02:10:37 2019
New Revision: 367530
URL: http://llvm.org/viewvc/llvm-project?rev=367530&view=rev
Log:
[Preprocessor] Always discard body of #define if we failed to parse it
Summary:
Preivously we would only discard it if we failed to parse parameter lists.
If we
Author: ibiryukov
Date: Thu Aug 1 04:05:06 2019
New Revision: 367541
URL: http://llvm.org/viewvc/llvm-project?rev=367541&view=rev
Log:
[clangd] Add missing braces to completion tests. NFC
Modified:
clang-tools-extra/trunk/clangd/unittests/CodeCompleteTests.cpp
Modified: clang-tools-extra/tr
Author: ibiryukov
Date: Fri Aug 2 08:23:04 2019
New Revision: 367687
URL: http://llvm.org/viewvc/llvm-project?rev=367687&view=rev
Log:
[clangd] Fix a crash when presenting values for Hover
Summary:
We should pass the expression type, not a variable type when printing
the resulting value. Variabl
Author: ibiryukov
Date: Tue Aug 6 04:37:50 2019
New Revision: 368019
URL: http://llvm.org/viewvc/llvm-project?rev=368019&view=rev
Log:
[clangd] Compute scopes eagerly in IncludeFixer
Summary:
Computing lazily leads to crashes. In particular, computing scopes may
produce diagnostics (from inside
+Hans Wennborg , could we merge this into the release?
On Tue, Aug 6, 2019 at 1:36 PM Ilya Biryukov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ibiryukov
> Date: Tue Aug 6 04:37:50 2019
> New Revision: 368019
>
> URL: http://llvm.org/viewvc/llvm-projec
Author: ibiryukov
Date: Tue Aug 6 08:46:12 2019
New Revision: 368052
URL: http://llvm.org/viewvc/llvm-project?rev=368052&view=rev
Log:
[AST] Traverse attributes inside DEF_TRAVERSE_DECL macro
Summary:
Instead of traversing inside the TraverseDecl() function.
Previously the attributes were traver
Author: ibiryukov
Date: Tue Aug 6 10:07:58 2019
New Revision: 368062
URL: http://llvm.org/viewvc/llvm-project?rev=368062&view=rev
Log:
[Syntax] Do not add a node for 'eof' into the tree
Summary:
While useful as a sentinel value when iterating over tokens, having
'eof' in the tree, seems to do mo
Many thanks!
On Wed, Aug 7, 2019 at 10:31 AM Hans Wennborg wrote:
> Yes, merged in r368133.
>
> On Tue, Aug 6, 2019 at 4:33 PM Ilya Biryukov wrote:
> >
> > +Hans Wennborg, could we merge this into the release?
> >
> > On Tue, Aug 6, 2019 at 1:36 PM Ilya Biryuko
Author: ibiryukov
Date: Mon Aug 12 07:35:30 2019
New Revision: 368581
URL: http://llvm.org/viewvc/llvm-project?rev=368581&view=rev
Log:
[clangd] Separate chunks with a space when rendering markdown
Summary:
This results in better rendering of resulting markdown.
Especially noticeable in coc.nvim
+Hans Wennborg , could we merge this into the release?
On Mon, Aug 12, 2019 at 4:34 PM Ilya Biryukov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ibiryukov
> Date: Mon Aug 12 07:35:30 2019
> New Revision: 368581
>
> URL: http://llvm.org/viewvc/llvm-projec
Author: ibiryukov
Date: Wed Aug 14 03:49:32 2019
New Revision: 368824
URL: http://llvm.org/viewvc/llvm-project?rev=368824&view=rev
Log:
[clangd] Fix typos and grammar in a comment. NFC
Modified:
clang-tools-extra/trunk/clangd/FindSymbols.cpp
Modified: clang-tools-extra/trunk/clangd/FindSymbo
Author: ibiryukov
Date: Wed Aug 14 05:51:04 2019
New Revision: 368842
URL: http://llvm.org/viewvc/llvm-project?rev=368842&view=rev
Log:
[clangd] Print qualifiers of out-of-line definitions in document outline
Summary: To improve the UX around navigating and searching through the results.
Reviewe
Author: ibiryukov
Date: Fri Aug 16 02:20:01 2019
New Revision: 369089
URL: http://llvm.org/viewvc/llvm-project?rev=369089&view=rev
Log:
[clangd] Remove Bind, use C++14 lambda captures instead. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
clang-tools-extra/trunk/clangd/
Author: ibiryukov
Date: Fri Aug 16 05:46:41 2019
New Revision: 369100
URL: http://llvm.org/viewvc/llvm-project?rev=369100&view=rev
Log:
[clangd] Simplify code of ClangdLSPServer::onCommand
Summary:
By inlining a complicated lambda into its single call-site.
Also ensure we call Reply() exactly on
Author: ibiryukov
Date: Tue Aug 20 01:54:30 2019
New Revision: 369349
URL: http://llvm.org/viewvc/llvm-project?rev=369349&view=rev
Log:
[clangd] Skip function bodies inside processed files while indexing
Summary:
This significantly improves performance of background indexing.
We do not collect r
Author: ibiryukov
Date: Mon Jun 24 14:39:51 2019
New Revision: 364236
URL: http://llvm.org/viewvc/llvm-project?rev=364236&view=rev
Log:
[Syntax] Do not glue multiple empty PP expansions to a single mapping
Summary:
This change makes sure we have a single mapping for each macro expansion,
even if
Author: ibiryukov
Date: Mon Jul 8 08:25:16 2019
New Revision: 365331
URL: http://llvm.org/viewvc/llvm-project?rev=365331&view=rev
Log:
[clangd] A code tweak to expand a macro
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: mgorny, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Tag
Author: ibiryukov
Date: Mon Jul 8 08:25:16 2019
New Revision: 365331
URL: http://llvm.org/viewvc/llvm-project?rev=365331&view=rev
Log:
[clangd] A code tweak to expand a macro
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: mgorny, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Tag
Author: ibiryukov
Date: Mon Jul 8 10:25:02 2019
New Revision: 365355
URL: http://llvm.org/viewvc/llvm-project?rev=365355&view=rev
Log:
[Syntax] Introduce syntax trees
Summary:
A tooling-focused alternative to the AST. This commit focuses on the
memory-management strategy and the structure of the
Author: ibiryukov
Date: Tue Jul 9 04:32:13 2019
New Revision: 365466
URL: http://llvm.org/viewvc/llvm-project?rev=365466&view=rev
Log:
Reland r365355: [Syntax] Introduce syntax trees
With a fix to a PS4 buildbot crash.
Added:
cfe/trunk/include/clang/Tooling/Syntax/BuildTree.h
cfe/trunk/
Author: ibiryukov
Date: Tue Jul 9 06:31:43 2019
New Revision: 365479
URL: http://llvm.org/viewvc/llvm-project?rev=365479&view=rev
Log:
[Syntax] Move roles into a separate enum
To align with reviewer's suggestions.
Modified:
cfe/trunk/include/clang/Tooling/Syntax/Nodes.h
cfe/trunk/includ
Author: ibiryukov
Date: Wed Jul 10 01:24:42 2019
New Revision: 365599
URL: http://llvm.org/viewvc/llvm-project?rev=365599&view=rev
Log:
[Syntax] Add assertion to catch invalid tokens early. NFC
To help with identifiying root cause of a crash we are seeing.
Modified:
cfe/trunk/include/clang/T
Author: ibiryukov
Date: Wed Jul 10 02:18:09 2019
New Revision: 365606
URL: http://llvm.org/viewvc/llvm-project?rev=365606&view=rev
Log:
[clangd] Consume error to avoid assertion failures
When we fail to calculate #include insertion for a completion item.
Note that this change does not add a test,
Author: ibiryukov
Date: Wed Jul 10 02:28:35 2019
New Revision: 365607
URL: http://llvm.org/viewvc/llvm-project?rev=365607&view=rev
Log:
[clangd] Stop recording tokens before running clang-tidy
modernize-trailing-return-type runs the preprocessor, breaking the token
collection logic.
This lead to
Author: ibiryukov
Date: Thu May 16 09:06:57 2019
New Revision: 360912
URL: http://llvm.org/viewvc/llvm-project?rev=360912&view=rev
Log:
[CodeComplete] Complete enumerators when preferred type is an enum
Reviewers: kadircet
Reviewed By: kadircet
Subscribers: cfe-commits
Tags: #clang
Differenti
Author: ibiryukov
Date: Fri May 17 02:32:05 2019
New Revision: 361007
URL: http://llvm.org/viewvc/llvm-project?rev=361007&view=rev
Log:
[Lex] Allow to consume tokens while preprocessing
Summary:
By adding a hook to consume all tokens produced by the preprocessor.
The intention of this change is t
Author: ibiryukov
Date: Fri May 17 02:32:05 2019
New Revision: 361007
URL: http://llvm.org/viewvc/llvm-project?rev=361007&view=rev
Log:
[Lex] Allow to consume tokens while preprocessing
Summary:
By adding a hook to consume all tokens produced by the preprocessor.
The intention of this change is t
Author: ibiryukov
Date: Mon May 20 05:17:36 2019
New Revision: 361147
URL: http://llvm.org/viewvc/llvm-project?rev=361147&view=rev
Log:
[clangd] Fix naming warning from clang-tidy. NFC
Also remove newlines and braces.
Modified:
clang-tools-extra/trunk/clangd/unittests/ClangdTests.cpp
Modifi
Author: ibiryukov
Date: Mon May 20 06:00:42 2019
New Revision: 361148
URL: http://llvm.org/viewvc/llvm-project?rev=361148&view=rev
Log:
[Syntax] Introduce TokenBuffer, start clangToolingSyntax library
Summary:
TokenBuffer stores the list of tokens for a file obtained after
preprocessing. This is
Author: ibiryukov
Date: Mon May 20 10:30:46 2019
New Revision: 361178
URL: http://llvm.org/viewvc/llvm-project?rev=361178&view=rev
Log:
[clangd] Make it possible to use VFS from parsing for getting tidy options
Summary:
To give an option for clangd embedders with snapshotted filesystem to
read co
Author: ibiryukov
Date: Tue May 21 07:37:41 2019
New Revision: 361264
URL: http://llvm.org/viewvc/llvm-project?rev=361264&view=rev
Log:
[Syntax] Rename TokensTest to SyntaxTests. NFC
To be more consistent with conventions used in the codebase. The new
name will be a better fit when more bits of t
Author: ibiryukov
Date: Wed May 22 05:50:01 2019
New Revision: 361376
URL: http://llvm.org/viewvc/llvm-project?rev=361376&view=rev
Log:
[Frontend] Return an error on bad inputs to PrecompiledPreabmle
Summary:
Instead of failing with assertions. Fixes a crash found by oss-fuzz:
https://bugs.chromi
Author: ibiryukov
Date: Wed May 22 07:44:45 2019
New Revision: 361391
URL: http://llvm.org/viewvc/llvm-project?rev=361391&view=rev
Log:
Reland r361148 with a fix to the buildbot failure.
Reverted in r361377.
Also reland the '.gn' files (reverted in r361389).
Added:
cfe/trunk/include/clang/To
Author: ibiryukov
Date: Thu May 23 00:45:35 2019
New Revision: 361461
URL: http://llvm.org/viewvc/llvm-project?rev=361461&view=rev
Log:
[CodeComplete] Complete a lambda when preferred type is a function
Summary: Uses a heuristic to detect std::function and friends.
Reviewers: kadircet
Reviewed
Author: ibiryukov
Date: Thu May 23 01:06:24 2019
New Revision: 361464
URL: http://llvm.org/viewvc/llvm-project?rev=361464&view=rev
Log:
[clangd-vscode] Bump versions dependencies. NFC
Result of running 'npm audit fix', which tracks security vulnerabilities.
Modified:
clang-tools-extra/trunk/
Maybe go with a runtime parameter (of type llvm::function_ref) instead of
the template parameter?
In any non-trivial example, the runtime costs of another function pointer
should be negligible given that we need to parse the ASTs, run the
matchers, etc.
On Wed, May 22, 2019 at 10:48 PM Penzin, Pet
Author: ibiryukov
Date: Thu May 23 09:39:26 2019
New Revision: 361510
URL: http://llvm.org/viewvc/llvm-project?rev=361510&view=rev
Log:
[CodeComplete] Only show lambda completions if patterns are requested
This is a trivial follow-up to r361461, so sending without review.
Modified:
cfe/trunk
Author: ibiryukov
Date: Thu May 23 09:48:47 2019
New Revision: 361511
URL: http://llvm.org/viewvc/llvm-project?rev=361511&view=rev
Log:
[Index] Fix reported references in presence of template type aliases
Summary: See the added test for an example.
Reviewers: kadircet
Reviewed By: kadircet
Sub
Author: ibiryukov
Date: Thu May 23 09:48:47 2019
New Revision: 361511
URL: http://llvm.org/viewvc/llvm-project?rev=361511&view=rev
Log:
[Index] Fix reported references in presence of template type aliases
Summary: See the added test for an example.
Reviewers: kadircet
Reviewed By: kadircet
Sub
Either way looks good.
If we go with function_ref, we should definitely store a comment why
storing function_ref is fine there. Or use a function pointer to make it
even clearer that nothing cheesy is going on there.
On Thu, May 23, 2019 at 5:28 PM Yitzhak Mandelbaum
wrote:
> Actually, someone a
Author: ibiryukov
Date: Fri May 24 03:18:39 2019
New Revision: 361623
URL: http://llvm.org/viewvc/llvm-project?rev=361623&view=rev
Log:
[CodeComplete] Filter override completions by function name
Summary:
We put only part of the signature starting with a function name into "typed
text"
chunks no
Author: ibiryukov
Date: Fri May 24 03:18:39 2019
New Revision: 361623
URL: http://llvm.org/viewvc/llvm-project?rev=361623&view=rev
Log:
[CodeComplete] Filter override completions by function name
Summary:
We put only part of the signature starting with a function name into "typed
text"
chunks no
Author: ibiryukov
Date: Fri May 24 03:26:23 2019
New Revision: 361625
URL: http://llvm.org/viewvc/llvm-project?rev=361625&view=rev
Log:
[clangd] Limit the size of synthesized fix message
Summary: A temporary workaround until we figure out a better way to present
fixes.
Reviewers: kadircet
Revi
Author: ibiryukov
Date: Fri May 24 09:16:15 2019
New Revision: 361645
URL: http://llvm.org/viewvc/llvm-project?rev=361645&view=rev
Log:
[CodeComplete] Add whitespace around braces in lambda completions
This produces nicer output.
Trivial follow-up to r361461, so sending without review.
Modified:
This seems to produce warnings about unused variables:
…/llvm/clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:20:20:
warning: unused variable 'Case' [-Wunused-variable]
for (const auto &Case : Rule.Cases) {
Could you take a look?
On Fri, May 24, 2019 at 6:29 PM Yitzhak Mandelb
Author: ibiryukov
Date: Mon May 27 02:52:09 2019
New Revision: 361753
URL: http://llvm.org/viewvc/llvm-project?rev=361753&view=rev
Log:
[CodeComplete] Complete 'return true/false' in boolean functions
Reviewers: kadircet
Reviewed By: kadircet
Subscribers: cfe-commits
Tags: #clang
Differential
I don't think it's related. All the changes are in code completion code,
which is not run during normal compiles.
On Tue, May 28, 2019 at 2:36 AM Mike Lothian via Phabricator <
revi...@reviews.llvm.org> wrote:
> FireBurn added a comment.
>
> Could this commit be causing the following build failur
Author: ibiryukov
Date: Tue May 28 02:20:57 2019
New Revision: 361798
URL: http://llvm.org/viewvc/llvm-project?rev=361798&view=rev
Log:
[clangd] Rename -run-synchronously to -sync
Modified:
clang-tools-extra/trunk/clangd/test/delimited-input-comment-at-the-end.test
clang-tools-extra/trunk
Author: ibiryukov
Date: Tue May 28 02:31:27 2019
New Revision: 361800
URL: http://llvm.org/viewvc/llvm-project?rev=361800&view=rev
Log:
[clangd] Never end command-line flag description with a period. NFC
For consistency. Not having a period at the end is much more common and
seems to be the prefe
Author: ibiryukov
Date: Tue May 28 06:56:21 2019
New Revision: 361823
URL: http://llvm.org/viewvc/llvm-project?rev=361823&view=rev
Log:
[clangd] Compute expected type for templates
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits
Tags:
Author: ibiryukov
Date: Tue May 28 07:33:16 2019
New Revision: 361829
URL: http://llvm.org/viewvc/llvm-project?rev=361829&view=rev
Log:
[CodeComplete] Consistently break after '{' in multi-line patterns
Summary:
Completion can return multi-line patterns in some cases, e.g.
for (<#init#>; <#c
Author: ibiryukov
Date: Tue May 28 08:21:03 2019
New Revision: 361838
URL: http://llvm.org/viewvc/llvm-project?rev=361838&view=rev
Log:
[CodeComplete] Set preferred type for qualified-id
Reviewers: kadircet
Reviewed By: kadircet
Subscribers: cfe-commits
Tags: #clang
Differential Revision: htt
Author: ibiryukov
Date: Tue May 28 08:33:37 2019
New Revision: 361841
URL: http://llvm.org/viewvc/llvm-project?rev=361841&view=rev
Log:
[clangd] Place cursor better after completing patterns
Summary:
By producing the $0 marker in the snippets at the last placeholder.
This produces nicer results i
Author: ibiryukov
Date: Tue May 28 09:28:27 2019
New Revision: 361846
URL: http://llvm.org/viewvc/llvm-project?rev=361846&view=rev
Log:
[clangd] Fix test output for r361841
Modified:
clang-tools-extra/trunk/clangd/unittests/CodeCompleteTests.cpp
Modified: clang-tools-extra/trunk/clangd/unitt
This broke buildbots due to a failing test.
r361846 should fit it.
Sorry for the inconvenience.
On Tue, May 28, 2019 at 5:30 PM Ilya Biryukov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ibiryukov
> Date: Tue May 28 08:33:37 2019
> New Revision: 361841
>
>
Author: ibiryukov
Date: Wed May 29 03:01:00 2019
New Revision: 361940
URL: http://llvm.org/viewvc/llvm-project?rev=361940&view=rev
Log:
[clangd] Represent Hover result using FormattedString
Reviewers: sammccall, kadircet
Reviewed By: kadircet
Subscribers: MaskRay, jkorous, arphaman, kadircet, c
Author: ibiryukov
Date: Wed May 29 03:11:14 2019
New Revision: 361941
URL: http://llvm.org/viewvc/llvm-project?rev=361941&view=rev
Log:
[Index] Correctly set symbol kind of IndirectFieldDecl
Summary: The kind has been 'unknown' before, now it is 'field'.
Reviewers: kadircet
Reviewed By: kadirce
Author: ibiryukov
Date: Wed May 29 03:11:14 2019
New Revision: 361941
URL: http://llvm.org/viewvc/llvm-project?rev=361941&view=rev
Log:
[Index] Correctly set symbol kind of IndirectFieldDecl
Summary: The kind has been 'unknown' before, now it is 'field'.
Reviewers: kadircet
Reviewed By: kadirce
Author: ibiryukov
Date: Wed May 29 08:10:19 2019
New Revision: 361969
URL: http://llvm.org/viewvc/llvm-project?rev=361969&view=rev
Log:
[clangd] Map typedefs to the same LSP completion kind as VSCode
For consistency and, more importantly, to get a nicer icon for those in VSCode.
Modified:
cl
Author: ibiryukov
Date: Wed May 29 08:32:17 2019
New Revision: 361974
URL: http://llvm.org/viewvc/llvm-project?rev=361974&view=rev
Log:
[CodeComplete] Add semicolon when completing patterns for 'static_assert' and
'typedef
This is a trivial follow-up to r360042, which added semicolons to other
p
Author: ibiryukov
Date: Wed May 29 10:49:30 2019
New Revision: 361996
URL: http://llvm.org/viewvc/llvm-project?rev=361996&view=rev
Log:
[Index] Compute correct symbol kind for variable templates
Summary:
The index library itself seems to never pass variable templates as
input, however clangd does
Author: ibiryukov
Date: Wed May 29 10:49:30 2019
New Revision: 361996
URL: http://llvm.org/viewvc/llvm-project?rev=361996&view=rev
Log:
[Index] Compute correct symbol kind for variable templates
Summary:
The index library itself seems to never pass variable templates as
input, however clangd does
Author: ibiryukov
Date: Thu Dec 13 07:36:32 2018
New Revision: 349050
URL: http://llvm.org/viewvc/llvm-project?rev=349050&view=rev
Log:
[CodeComplete] Set preferred type to bool on conditions
Reviewers: kadircet
Reviewed By: kadircet
Subscribers: cfe-commits
Differential Revision: https://revi
Author: ibiryukov
Date: Thu Dec 13 08:06:11 2018
New Revision: 349053
URL: http://llvm.org/viewvc/llvm-project?rev=349053&view=rev
Log:
[CodeComplete] Fill preferred type on binary expressions
Reviewers: kadircet
Reviewed By: kadircet
Subscribers: arphaman, cfe-commits
Differential Revision: h
301 - 400 of 1460 matches
Mail list logo
