Thanks! And sorry about this in the first place, I did not have this warning enabled locally.
On Tue, Jun 4, 2019 at 1:28 PM Simon Pilgrim via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rksimon > Date: Tue Jun 4 04:31:45 2019 > New Revision: 362491 > > URL: http://llvm.org/viewvc/llvm-project?rev=362491&view=rev > Log: > Fix -Wparentheses warning. NFCI. > > Modified: > clang-tools-extra/trunk/clangd/Protocol.cpp > > Modified: clang-tools-extra/trunk/clangd/Protocol.cpp > URL: > http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/Protocol.cpp?rev=362491&r1=362490&r2=362491&view=diff > > ============================================================================== > --- clang-tools-extra/trunk/clangd/Protocol.cpp (original) > +++ clang-tools-extra/trunk/clangd/Protocol.cpp Tue Jun 4 04:31:45 2019 > @@ -832,8 +832,8 @@ llvm::json::Value toJSON(const Completio > } > > llvm::json::Value toJSON(const ParameterInformation &PI) { > - assert(PI.labelOffsets.hasValue() || > - !PI.labelString.empty() && "parameter information label is > required"); > + assert((PI.labelOffsets.hasValue() || !PI.labelString.empty()) && > + "parameter information label is required"); > llvm::json::Object Result; > if (PI.labelOffsets) > Result["label"] = > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > -- Regards, Ilya Biryukov
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
