[PATCH] D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: mclow.lists, EricWF, jasonliu. Herald added subscribers: ldionne, christof. When a seed sequence would lead to having no non-zero significant bits in the initial state of a `mersenne_twister_engine`, the fallbac

[PATCH] D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback

hubert.reinterpretcast added a comment. In https://reviews.llvm.org/D50736#1200761, @mclow.lists wrote: > Is this test that's being added libc++ specific, or would it apply to other > implementations as well? The test can apply to other implementations as well (although I am not sure how the

[PATCH] D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback

hubert.reinterpretcast added a comment. In https://reviews.llvm.org/D50736#1200774, @hubert.reinterpretcast wrote: > In https://reviews.llvm.org/D50736#1200761, @mclow.lists wrote: > > > Is this test that's being added libc++ specific, or would it apply to other > > implementations as well? > >

[PATCH] D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback

hubert.reinterpretcast updated this revision to Diff 160923. hubert.reinterpretcast added a comment. Address review comments by Marshall Add a line break after the template-head. Add a comment with the requested quote from the Standard. Move test from the `test/libcxx/` tree to the `test/std/`

[PATCH] D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX339969: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D50736?vs=160923&id=

[PATCH] D50055: Update the coding standard about NFC changes and whitespace

hubert.reinterpretcast added inline comments. Comment at: docs/DeveloperPolicy.rst:395-408 +Commits with No Functional Change +- + +It may be permissible to commit changes without prior review when the changes +have no semantic impact on the code i

[PATCH] D33833: Fix PR 33189: Clang assertion on template destructor declaration

hubert.reinterpretcast added inline comments. Comment at: lib/AST/DeclCXX.cpp:1420 DeclContext::lookup_result R = lookup(Name); - if (R.empty()) + if (R.empty() || !isa(R.front())) return nullptr; As it is, ``` return R.empty() ? nullptr : dyn_cast(R.fr

[PATCH] D33833: Fix PR 33189: Clang assertion on template destructor declaration

hubert.reinterpretcast added a comment. In https://reviews.llvm.org/D33833#789436, @kuang_he wrote: > Can we get this patch reviewed by any chance? @kuang_he; it is customary to "ping". In this case, "Ping 2". Comment at: lib/AST/DeclCXX.cpp:1421 - CXXDestructorDecl *Dtor

[PATCH] D41544: Use backslash escape, replacing xargs -0 in test macro-multiline.c

hubert.reinterpretcast created this revision. xargs supports escaping of newline characters with backslash. xargs -0 is neither part of POSIX nor the LSB. This patch removes the -0 option and adjusts the input to xargs accordingly; that is, the input is a text file not ending in an incomplete l

[PATCH] D41545: Replace cp -a in various Clang tests

hubert.reinterpretcast created this revision. `cp -a` is neither part of POSIX nor the LSB; this patch uses `cp -RPp`, the nearest equivalent under POSIX. The tree being copied in each case currently contains only directories and regular files; so the `-P` is superfluous. `test/Modules/crash-v

[PATCH] D41544: Use backslash escape, replacing xargs -0 in test macro-multiline.c

hubert.reinterpretcast added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D41544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41545: Replace cp -a in various Clang tests

hubert.reinterpretcast added a comment. Maybe `cp -R` is sufficient? `cp -RPp` was the just-to-be-safe "minimal change". Repository: rC Clang https://reviews.llvm.org/D41545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D41545: Replace cp -a in various Clang tests

hubert.reinterpretcast added a comment. I'll commit with `cp -R` tomorrow then; thanks. Repository: rC Clang https://reviews.llvm.org/D41545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D41545: Replace cp -a in various Clang tests

hubert.reinterpretcast updated this revision to Diff 128584. hubert.reinterpretcast added a comment. Use cp -R, which is sufficient instead of cp -RPp Repository: rC Clang https://reviews.llvm.org/D41545 Files: test/Modules/crash-vfs-path-emptydir-entries.m test/Modules/crash-vfs-path-sy

[PATCH] D41545: Replace cp -a in various Clang tests

This revision was automatically updated to reflect the committed changes. Closed by commit rC321778: Replace cp -a in various Clang tests (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D41545?vs=128584&id=128586#toc Repository: rC Clang

[PATCH] D41544: Use backslash escape, replacing xargs -0 in test macro-multiline.c

This revision was automatically updated to reflect the committed changes. Closed by commit rC321828: Use backslash escape, replacing xargs -0 in test macro-multiline.c (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D41544?vs=128034&id=1286

[PATCH] D41217: [Concepts] Concept Specialization Expressions

hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprCXX.cpp:1478 + { +// We do not want error diagnostics escaping here. +Sema::SFINAETrap Trap(S); saar.raz wrote: > faisalv wrote: > > Hubert: This needs a TODO: the idea is not to drop

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3908 + QualType ToType) { +assert(FromType->isVectorType() && "FromType should be a vector type"); +assert(ToType->isVectorType() &&

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/test/Sema/altivec-generic-overload.c:3 + +typedef signed char __v4sc __attribute__((__vector_size__(16))); +typedef unsigned char __v4uc __attribute__((__vector_size__(16))); `__v4sc` is suspicious.

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast requested changes to this revision. hubert.reinterpretcast added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaOverload.cpp:3920 + + // Prefer a compatible vector conversion to lax vector conversion + // Fo

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/test/Sema/altivec-generic-overload.c:3 + +typedef signed char __v4sc __attribute__((__vector_size__(16))); +typedef unsigned char __v4uc __attribute__((__vector_size__(16))); wuzish wrote: > hubert.r

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; Considering that this is

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; wuzish wrote: > hubert.re

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; wuzish wrote: > hubert.re

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; wuzish wrote: > hubert.re

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; hubert.reinterpretcast wr

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; wuzish wrote: > hubert.re

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; wuzish wrote: > hubert.re

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; wuzish wrote: > hubert.re

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added a comment. > some test points check the error report for ambiguous call because of too > many implicit cast choices from ext_vector_type to vector type. It appears the answer is to update these tests and remove the restriction on the type class. https://reviews.ll

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/altivec-generic-overload.c:74 + convert1(gv1); + // CHECK: call void @_Z8convert1Dv16_a(<16 x i8> %{{[0-9]+}}) + convert1(gv2); Checking that the call is to the expected target in ter

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/altivec-generic-overload.c:74 + convert1(gv1); + // CHECK: call void @_Z8convert1Dv16_a(<16 x i8> %{{[0-9]+}}) + convert1(gv2); wuzish wrote: > hubert.reinterpretcast wrote: > > Check

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Sema/altivec-generic-overload.c:73 + + __v16sc *gv1_p = convert1(gv1); + __v16uc *gv2_p = convert1(gv2); --

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: rsmith, aaron.ballman, hfinkel. `memchr` and `memcmp` operate upon the character units of the object representation; that is, the `size_t` parameter expresses the number of character units. The constant folding

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprConstant.cpp:6159-6160 +// Give up on byte-oriented matching against multibyte elements. +if (IsRawByte && Info.Ctx.getTypeSize(CharTy) > Info.Ctx.getCharWidth()) + return false; // Figure out

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast updated this revision to Diff 177597. hubert.reinterpretcast marked 11 inline comments as done. hubert.reinterpretcast added a comment. Make an initial pass at addressing the review comments Address comments on style and code comments Repository: rC Clang CHANGES SINCE

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast updated this revision to Diff 177618. hubert.reinterpretcast marked 6 inline comments as done. hubert.reinterpretcast added a comment. Use lvalue designator, add assertions for type matching Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5551

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprConstant.cpp:6147-6148 + return ZeroInitialization(E); +if (!Result.checkNullPointerForFoldAccess(Info, E, AK_Read)) + return false; +Q

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast updated this revision to Diff 177656. hubert.reinterpretcast marked 3 inline comments as done. hubert.reinterpretcast added a comment. Address remaining ExprConstant.cpp review comments Use BytesRemaining/BytesPerElement to improve readability; tweak FIXME comment to refer

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast added a comment. I'll update the tests to be in terms of constant/variable array length tomorrow. I think I've gotten through the rest of the comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55510/new/ https://reviews.llvm.org/D5551

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/Support/Triple.cpp:537 return StringSwitch(EnvironmentName) +// FIXME: We have to put XCOFF before COFF; +// perhaps an order-independent pattern matching is desired? If the conclusion

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; JDevlieghere wrote: >

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; davide wrote: > hubert

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added a subscriber: rsmith. hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:626 + +// FIXME: Define AIX OS-Version Macros +Builder.defineMacro("_AIX"); Comments should be full senten

[PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

hubert.reinterpretcast added a comment. D59048 has been posted with some initial `OSTargetInfo` changes. Noticeable differences include not defining `_ALL_SOURCE` and focus on 64-bit long double. This is consistent with the invocation provided with the recent v

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:626 + +// FIXME: Define AIX OS-Version Macros +Builder.defineMacro("_AIX"); apaprocki wrote: > hubert.reinterpretcast wrote: > > Comments should be full sent

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: clang/test/Preprocessor/init.c:6420 +// PPC64-AIX:#define _LONG_LONG 1 +// PPC64-AIX:#define _POWER 1 +// PPC64-AIX:#define __64BIT__ 1 hubert.reinterpretcast wrote: > apaprocki wrote: > > XL on AIX emits

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added a comment. @jasonliu, you have had a number of patches committed into the project already (D22698 , D22702 , D34649 ). Please go ahead with requesting commit access, a

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:640 + +// Define _WCHAR_T when it is a fundamental type (i.e., for C++ without -fno-wchar). +if (Opts.CPlusPlus && Opts.WChar) { Line is longer than 80 characte

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a subscriber: WuZhao. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. I think all comments have been addressed or otherwise responded to. @jasonliu: Since this patch is dependent on

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: sfertile, xingxue, jasonliu. Herald added a subscriber: arphaman. Herald added a project: clang. `dladdr` is not available on AIX. Similar functionality is presented through `loadquery`. This patch replaces a us

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast added a comment. I believe that the conditions being checked for with `llvm_unreachable` in this patch are of the debug-only variety; however, some input would be appreciated regarding the choice of using `llvm_unreachable` instead of `report_fatal_error` or `assert`.

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: test/Headers/max_align.c:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s +// expected-no-diagnostics We may need to explicitly specify C11. It also seems that we should XFAIL Windows targets. Repository:

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: test/Headers/max_align.c:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s +// expected-no-diagnostics lebedev.ri wrote: > hubert.reinterpretcast wrote: > > We may need to explicitly specify C11. It also seem

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast added subscribers: asb, majnemer, lhames. hubert.reinterpretcast added a comment. @asb @lhames @majnemer, based on D36826 , I believe that your guidance would be helpful here regarding the use of `llvm_unreachable`, `report_fatal_error`, an

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast marked 6 inline comments as done. hubert.reinterpretcast added a comment. Herald added a subscriber: jsji. Thanks @xingxue for the review. I will update for the error handling before committing. Comment at: tools/libclang/CIndexer.cpp:61 +if (errno !

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

This revision was automatically updated to reflect the committed changes. hubert.reinterpretcast marked 3 inline comments as done. Closed by commit rC356843: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library (authored by hubert.reinterpretcast, committed by ). Changed prior to com

[PATCH] D59741: [lit] Set shlibpath_var on AIX

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: xingxue, jasonliu, sfertile. Herald added a reviewer: serge-sans-paille. Herald added subscribers: cfe-commits, jsji. Herald added a project: clang. When building the `check-all` target on AIX, lit produces wa

[PATCH] D59741: [lit] Set shlibpath_var on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rC357334: [lit] Set shlibpath_var on AIX (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D59741?vs=192014&id=192942#toc Repository: rC Clang CHAN

[PATCH] D57896: Variable names rule

hubert.reinterpretcast added a comment. I am generally in favour of this direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57896/new/ https://reviews.llvm.org/D57896 ___ cfe-commits mailing list

[PATCH] D57896: Variable names rule

hubert.reinterpretcast added a comment. In D57896#1391611 , @zturner wrote: > Is this actually any better? Whereas before we can’t differentiate type > names and variable names, under this proposal we can’t differentiate type > names and function names.

[PATCH] D58128: [PowerPC] Stop defining _ARCH_PWR6X on POWER7 and up

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: echristo, hfinkel, kbarton, nemanjai, wschmidt. Herald added a subscriber: jsji. Herald added a project: clang. The predefined macro `_ARCH_PWR6X` is associated with GCC's `-mcpu=power6x` option, which enables

[PATCH] D58128: [PowerPC] Stop defining _ARCH_PWR6X on POWER7 and up

This revision was automatically updated to reflect the committed changes. Closed by commit rC353975: [PowerPC] Stop defining _ARCH_PWR6X on POWER7 and up (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D58128?vs=186480&id=186715#toc Reposi

[PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

hubert.reinterpretcast added a comment. Herald added subscribers: jdoerfert, arphaman. @apaprocki, as mentioned in our recent RFC ( http://lists.llvm.org/pipermail/llvm-dev/2019-February/130175.html ), IBM is working on AIX support for Clang and LLVM. We would like to continue the work on this

[PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

hubert.reinterpretcast added a comment. In D18360#1406455 , @apaprocki wrote: > @hubert.reinterpretcast Yes, this patch is available under the new license. Thank you, @apaprocki. We will be splitting this into updated and more granular patches. CHANGE

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM with minor comment. Comment at: libcxx/test/std/depr/depr.c.headers/stdint_h.sh.cpp:21 +// Test that limits macros are available when is included with +// or without macro _XOPEN_SOUECE

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. @daltenty, I believe that you have had a good number of patches committed into the project already (rL360898 , rL361410

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

hubert.reinterpretcast added a subscriber: cfe-commits. https://reviews.llvm.org/rL358949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

hubert.reinterpretcast added inline comments. /cfe/trunk/lib/Driver/ToolChains/PPCLinux.cpp:26 I'm not particularly concerned about the scoping of the work; however, the `ppc_wrappers` directory is not at all indicative of that scoping. It neither indicates the scope in terms of purpose (provid

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

hubert.reinterpretcast added a comment. > I think the name `ppc_wrappers` is accurate to describe its meaning that > wrapping the headers under standard library path or standard header search > path. Thanks for clarifying this for me. In the case where all of the headers are expected to be pre

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added subscribers: jsji, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: cla

[PATCH] D62950: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added subscribers: jsji, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: cla

[PATCH] D62951: [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases)

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added subscribers: jsji, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: cla

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added subscribers: jsji, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: cla

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. In D62949#1533574 , @NoQ wrote: > I think we should: > > - Pre-normalize our expected outputs so that we didn't have to normalize them > in every run-line. Okay; I think this might be possible to do in a separate

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. In D62949#1533605 , @NoQ wrote: > Ok! I'll be happy to have this addressed incrementally. I think it should be safe to at least commit the pre-normalization directly first. I'll take a look, and update the patch i

[PATCH] D63029: [NFC][CUDA] Avoid undefined grep in cuda-types.cu

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: jlebar, daltenty, xingxue, jasonliu. Herald added subscribers: jsji, jfb. Herald added a project: clang. vertical-line is not a BRE special character. POSIX.1-2017 XBD Section 9.3.2 indicates that the interpreta

[PATCH] D63029: [NFC][CUDA] Avoid undefined grep in cuda-types.cu

hubert.reinterpretcast added inline comments. Comment at: test/Preprocessor/cuda-types.cu:11 // RUN: %clang --cuda-host-only -nocudainc -target i386-unknown-linux-gnu -x cuda -E -dM -o - /dev/null \ -// RUN: | grep 'define __[^ ]*\(TYPE\|MAX\|SIZEOF|WIDTH\)\|define __GCC_ATO

[PATCH] D63029: [NFC][CUDA] Avoid undefined grep in cuda-types.cu

hubert.reinterpretcast updated this revision to Diff 203659. hubert.reinterpretcast added a comment. Fix grep pattern in cuda-types.cu As requested, further fix so that the `SIZEOF` and `WIDTH` macros are checked. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D630

[PATCH] D63029: [CUDA] Fix grep pattern in cuda-types.cu

hubert.reinterpretcast marked 3 inline comments as done. hubert.reinterpretcast added inline comments. Comment at: test/Preprocessor/cuda-types.cu:11 // RUN: %clang --cuda-host-only -nocudainc -target i386-unknown-linux-gnu -x cuda -E -dM -o - /dev/null \ -// RUN: | grep 'def

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. I've tested the pre-normalization and it looks like I can commit it tomorrow. I noticed that the following three files appear to be unreferenced: clang/test/Analysis/Inputs/expected-plists/cstring-plist.c.plist clang/test/Analysis/Inputs/expected-plist

[PATCH] D63041: [PlistSupport] Produce a newline to end plist output files

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added a subscriber: jsji. Herald added a project: clang. As suggested in the review of D62949 , this patch updates the plist o

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. @aaron.ballman, for similar cases in the plist output, it has been proposed - that the reference expected file be committed into the tree pre-normalized, and - that tool be modified such that the output file has a newline at the end of the file. Does tha

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

hubert.reinterpretcast added inline comments. Comment at: docs/ReleaseNotes.rst:79 - ``clang -dumpversion`` now returns the version of Clang itself. + Similarly, __VERSION__ returns the Clang version instead of 4.2.1. Use code font for `__VERSION__`. ==

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

hubert.reinterpretcast added inline comments. Comment at: docs/ReleaseNotes.rst:79 - ``clang -dumpversion`` now returns the version of Clang itself. + Similarly, `__VERSION__` returns the Clang version instead of 4.2.1. I think this needs double backquotes on

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast updated this revision to Diff 203706. hubert.reinterpretcast added a comment. Update based on review comments, building from rL362877 and D63041 Repository: rC Clang CHANGES SINCE LAST ACTION https

[PATCH] D62950: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)

hubert.reinterpretcast updated this revision to Diff 203707. hubert.reinterpretcast added a comment. Update based on review comments, building from rL362877 and D63041 Repository: rC Clang CHANGES SINCE LAST ACTION https

[PATCH] D62951: [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases)

hubert.reinterpretcast updated this revision to Diff 203708. hubert.reinterpretcast added a comment. Update based on review comments, building from rL362877 and D63041 Repository: rC Clang CHANGES SINCE LAST ACTION https

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. @NoQ, I've updated the patches based on the changes you suggested. This patch, D62950 , and D62951 now looks much cleaner. These are now dependent on the approval of D63041

[PATCH] D63029: [CUDA] Fix grep pattern in cuda-types.cu

This revision was automatically updated to reflect the committed changes. hubert.reinterpretcast marked an inline comment as done. Closed by commit rL362991: [CUDA] Fix grep pattern in cuda-types.cu (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a s

[PATCH] D63041: [PlistSupport] Produce a newline to end plist output files

This revision was automatically updated to reflect the committed changes. Closed by commit rL362992: [PlistSupport] Produce a newline to end plist output files (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

This revision was automatically updated to reflect the committed changes. Closed by commit rL362994: [analyzer][tests] Add normalize_plist to replace diff_plist (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D62950: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362996: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases) (authored by hubert.reinterpretcast, co

[PATCH] D62951: [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362998: [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases) (authored by hubert.reinterpretcast, c

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62952/new/ https://reviews.llvm.org/D62952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. In D62952#1548377 , @aaron.ballman wrote: > In general, that seems reasonable, but I would prefer to take care of more of > the work in lit.local.cfg than have to deal with that atrocious RUN line in > every test

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. In D62952#1548593 , @aaron.ballman wrote: > But is there a reason to not keep `%diff_sarif` and define it in terms of > `%normalize_sarif | diff -U1 -b` within lit.local.cfg? I guess I don't see > the benefit to e

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 ___ cfe-commits mai

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast updated this revision to Diff 205590. hubert.reinterpretcast added a comment. Update based on review comments from D62949 as confirmed in D62952 Normalized versions of the reference expected SARIF output f

[PATCH] D62952: [analyzer] SARIF: Add EOF newline; replace diff_sarif

This revision was automatically updated to reflect the committed changes. Closed by commit rL363822: [analyzer] SARIF: Add EOF newline; replace diff_sarif (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL L

  1   2   3   4   5   6   7   8   >