hubert.reinterpretcast added a comment.

> I think the name `ppc_wrappers` is accurate to describe its meaning that 
> wrapping the headers under standard library path or standard header search 
> path.

Thanks for clarifying this for me. In the case where all of the headers are 
expected to be present somewhere in the usual search path, I agree that the 
current directory structure would be okay given proper guards within the 
headers themselves.

> [ ... ] which I also prefer to use because it's easier to maintain headers 
> instead of modifying cpp code about toolchain class such as PPCLinuxToolChain 
> .



> We will use better way described above to guard those headers only in 64-bit 
> mode soon after other headers have been upstreamed.

That (controlling within the headers) sounds good to me. When that lands, then 
my understanding is that the `PPCLinuxToolChain` code would be adjusted to 
include `ppc_wrappers` in the search path in the general case. Please let me 
know if that's not the case. Thanks.


https://reviews.llvm.org/rL358949



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to