[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

hoy added a comment. In D96354#2554129 , @probinson wrote: >> the driver had a redundant pass-through of the option > > I could've sworn it worked to remove that, but it didn't when I rebased, so > that's gone from the final patch (i.e, the explicit pass-

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

hoy added a comment. In D96354#2566511 , @dblaikie wrote: > In D96354#2566502 , @hoy wrote: > >> In D96354#2554129 , @probinson >> wrote: >> the driver had a redundant

[PATCH] D103909: [CSSPGO] Emit mangled dwarf names for line tables debug option under -fpseudo-probe-for-profiling

hoy created this revision. Herald added a subscriber: wenlei. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103909 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/te

[PATCH] D103909: [CSSPGO] Emit mangled dwarf names for line tables debug option under -fpseudo-probe-for-profiling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64b2fb7967a7: [CSSPGO] Emit mangled dwarf names for line tables debug option under -fpseudo… (authored by hoy). Repository: rG LLVM Github Monorep

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

hoy created this revision. Herald added subscribers: modimo, wenlei, pengfei. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang requires a valid/compatible installation of gcc from which it includes some internal headers. Typically

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

hoy updated this revision to Diff 354135. hoy added a comment. Updating D104831 : [clang] Add x86_64-redhat-linux-gnu as a platform triplet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104831/new/ https://reviews

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

hoy added a comment. In D104831#2837712 , @MaskRay wrote: >> Adding the platform tripplet x86_64-redhat-linux-gnu the while list of >> supported x86_64 triplets so that it can be used with the --gcc-toolchain >> option to bypass this process and force-p

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

hoy added a comment. In D104831#2839301 , @tstellar wrote: > In D104831#2838835 , @hoy wrote: > >> In D104831#2837712 , @MaskRay >> wrote: >> Adding the platform tri

[PATCH] D107791: [InlineAdvisor] Add single quotes around caller/callee names

hoy added inline comments. Comment at: llvm/test/Transforms/SampleProfile/inline-replay.ll:7 ;; Check replay inline decisions ; RUN: opt < %s -passes=sample-profile -sample-profile-file=%S/Inputs/inline-topdown.prof -sample-profile-inline-replay=%S/Inputs/inline-replay.txt -

[PATCH] D107791: [InlineAdvisor] Add single quotes around caller/callee names

hoy accepted this revision. hoy added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107791/new/ https://reviews.llvm.org/D107791 ___ cfe-

[PATCH] D107876: [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for-profiling together

hoy created this revision. Herald added subscribers: modimo, wenlei. hoy requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Previoulsy debug-info-for-profiling and pseudo-probe-for-profiling are mutual exclusive because they

[PATCH] D107876: [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for-profiling together

hoy added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3896 - // These two forms of profiling info can't be used together. - if (const Arg *A1 = Args.getLastArg(options::OPT_fpseudo_probe_for_profiling)) -if (const Arg *A2 = Args.getLastArg(options::

[PATCH] D107876: [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for-profiling together

hoy added a comment. In D107876#2939624 , @wmi wrote: > Could you remind me the discriminator difference between debug info based > AFDO and pseudo probe based AFDO? I forgot it. I am sure it is described in > some patch but I havn't found it. Give me a

[PATCH] D107876: [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for-profiling together

This revision was automatically updated to reflect the committed changes. Closed by commit rGccb5b9bbfb5c: [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for… (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10787

[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

hoy added inline comments. Comment at: llvm/test/CodeGen/X86/fsafdo_test2.ll:3 +; RUN: llvm-profdata merge --sample -profile-isfs -o %t.afdo %S/Inputs/fsloader.afdo +; RUN: llc -enable-fs-discriminator -fs-profile-file=%t.afdo -show-fs-branchprob -disable-ra-fsprofile-loader=fa

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

hoy updated this revision to Diff 355012. hoy added a comment. Herald added a subscriber: modimo. Added tests for static ctor/dtor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102356/new/ https://reviews.llvm.org/D102356 Files: clang/lib/CodeG

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

This revision was automatically updated to reflect the committed changes. Closed by commit rG633ca3ff2f8f: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing… (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added a comment. In D98799#2860881 , @dblaikie wrote: > In D98799#2850700 , @dblaikie wrote: > >> In D98799#2850682 , @ahatanak wrote: >> >>> I think I've fixed all the p

[PATCH] D142994: [UsersManual] Add llvm-progen as an alternative tool for AutoFDO profile generation.

hoy created this revision. Herald added subscribers: modimo, wenlei. Herald added a project: All. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Test Plan: Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142994 File

[PATCH] D143123: [NFC] Add split-file as runtime test dependency

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d757177df47: [NFC] Add split-file as runtime test dependency (authored by yozhu, committed by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143123/new

[PATCH] D74814: IR printing for single function with the new pass manager.

hoyFB created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. hoyFB added a reviewer: wenlei. hoyFB added a subscriber: wenlei. The IR printing always prints out all functions in a module with the new pass manager, even with -filt

[PATCH] D74814: IR printing for single function with the new pass manager.

hoyFB added a comment. In D74814#1882064 , @wenlei wrote: > Thanks for fixing this. Could you use `.ll` IR file as test case and place it > alongside with `test/Other/module-pass-printer.ll` or just reuse that one? We > can also use `opt` to invoke new p

[PATCH] D74814: IR printing for single function with the new pass manager.

hoyFB updated this revision to Diff 245474. hoyFB added a comment. Updating D74814 : IR printing for single function with the new pass manager. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74814/new/ https://revie

[PATCH] D74814: IR printing for single function with the new pass manager.

hoyFB updated this revision to Diff 245484. hoyFB added a comment. Updating D74814 : IR printing for single function with the new pass manager. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74814/new/ https://revie

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

hoyFB added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsX86.td:2551 - Intrinsic<[llvm_v4f32_ty], [llvm_v8i16_ty], [IntrNoMem]>; - def int_x86_vcvtph2ps_256 : GCCBuiltin<"__builtin_ia32_vcvtph2ps256">, - Intrinsic<[llvm_v8f32_ty], [llvm_v

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

hoyFB added inline comments. Comment at: clang/test/Analysis/checker-plugins.c:120 +// CHECK-CHECKER-OPTION-HELP-SAME: example checker opt. (default: +// CHECK-CHECKER-OPTION-HELP-NEXT: false) LGTM, thanks for fixing this! Repository: rG LLVM Github Monorepo

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. > (Also, can the backend safely optimize an `invoke` to a `linkonce_odr` > function that's `nounwind` to a `call`? I thought it couldn't, in case the > function is de-refined to a version that's not `nounwind`. But the frontend > can do it since it has access to the sourc

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4180435 , @dexonsmith wrote: > Oh, de-refining is pretty nifty / evil. This patch has background: > https://reviews.llvm.org/D18634 > > Since 2016, the optimizer is not allowed to do IPA on functions that can be > de-refin

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4182287 , @dexonsmith wrote: > In C++, you get linkonce_odr all over the place. It's basically all functions > that are defined in C++ headers that are available for inlining. > On the other hand, the frontend knows the t

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4182476 , @dexonsmith wrote: > In D83906#4182428 , @hoy wrote: > >> In D83906#4182287 , @dexonsmith >> wrote: >> >>> In C++, you get linkonce_

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4182904 , @dexonsmith wrote: > In D83906#4182847 , @hoy wrote: > >> As far as I know, the optimizer IPO pass that infers function attributes >> (i..e `InferFunctionAttrsPass`) is plac

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4184916 , @dexonsmith wrote: > In D83906#4183453 , @hoy wrote: > >> Wondering if we can come up with a way to tell the optimizer about that, >> e.g., through a new module flag. When i

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4187872 , @dexonsmith wrote: > In D83906#4186887 , @hoy wrote: > >> In D83906#4184916 , @dexonsmith >> wrote: >> >>> In D83906#4183453

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

hoy added a comment. Hello, I'm seeing a build failure that seems related to this patch. I'm seeing the patch has been relanded and reverted a couple times and not sure where it is right now. Can you please confirm if the failure is related and fixed? Thanks. 2023-06-20T05:19:14.441-07:00] Std

[PATCH] D142994: [UsersManual] Add llvm-progen as an alternative tool for AutoFDO profile generation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56e36e47f504: [UsersManual] Add llvm-progen as an alternative tool for AutoFDO profile… (authored by hoy). Repository: rG LLVM Github Monorepo CH

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

hoy added a comment. In D144006#4437804 , @dzhidzhoev wrote: > In D144006#4435677 , @hoy wrote: > >> Hello, I'm seeing a build failure that seems related to this patch. I'm >> seeing the patch has been relanded

[PATCH] D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF

hoy added inline comments. Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1169-1171 + // On PowerPC and ARM/Thumb, if the address of a branch is the same as + // the target, it means that it's a function call. Do not mark the label + // for this case. ---

[PATCH] D142994: [UsersManual] Add llvm-progen as an alternative tool for AutoFDO profile generation.

hoy added a comment. In D142994#4094193 , @wenlei wrote: > Given llvm-profgen is in llvm tree, I'm wondering if it makes sense to treat > it first option instead of alternative to out of tree create_llvm_prof. wdyt > @davidxl @davidxl any thought on

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > dblaikie wrote: > > hoy wrote: > > > dblaikie wrote: > > > > hoy wrote: > > > > > dblaik

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > aaron.ballman wrote: > > dblaikie wrote: > > > aaron.ballman wrote: > > > > dblaikie wro

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > hoy wrote: > > dblaikie wrote: > > > aaron.ballman wrote: > > > > dblaikie wrote: > > >

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy created this revision. Herald added a subscriber: wenlei. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. C functions may be declared and defined in different prototypes like below. This patch unifies the checks for mangling names

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3525-3526 llvm::DINode::DIFlags &Flags) { - const auto *FD = cast(GD.getDecl()); + GlobalDecl CanonicalGD = GD.getCanonicalDecl(); + const auto *FD = cast(Canon

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy updated this revision to Diff 331660. hoy added a comment. Addresssing David's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98799/new/ https://reviews.llvm.org/D98799 Files: clang/lib/AST/ItaniumMangle.cpp clang/lib/CodeGen/CGDeb

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc1812a0ad75: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and… (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > hoy wrote: > > dblaikie wrote: > > > Does this need to be down here? Or would the code b

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > hoy wrote: > > dblaikie wrote: > > > hoy wrote: > > > > dblaikie wrote: > > > > > Does t

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > hoy wrote: > > dblaikie wrote: > > > hoy wrote: > > > > dblaikie wrote: > > > > > hoy wr

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > hoy wrote: > > dblaikie wrote: > > > hoy wrote: > > > > dblaikie wrote: > > > > > hoy wr

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added a subscriber: bruno. hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > hoy wrote: > > dblaikie wrote: > > > hoy wrote: > > > > d

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:48-49 +// LPIPELINE: Unique Internal Linkage Names +// NPIPELINE: Running pass: UniqueInternalLinkageNamesPass // PLAIN: @_ZL4glob = internal global dblaikie wrote: > h

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added inline comments. Comment at: llvm/tools/opt/NewPMDriver.cpp:136-138 +static cl::opt PseudoProbeForProfiling( +"new-pm-pseudo-probe-for-profiling", cl::init(false), cl::Hidden, +cl::desc("Emit pseudo probes to enable PGO profile generation.")); d

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy updated this revision to Diff 314043. hoy added a comment. Removing the checks of VerifierAnalysis in test code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/ https://reviews.llvm.org/D93656 Files: llvm/include/llvm/Passes/PassBui

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy marked an inline comment as done. hoy added inline comments. Comment at: llvm/tools/opt/NewPMDriver.cpp:136-138 +static cl::opt PseudoProbeForProfiling( +"new-pm-pseudo-probe-for-profiling", cl::init(false), cl::Hidden, +cl::desc("Emit pseudo probes to enable PGO prof

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy updated this revision to Diff 314200. hoy marked an inline comment as done. hoy added a comment. Adding a test for the new pseudo probe test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/ https://reviews.llvm.org/D93656 Files: llv

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added a comment. In D93656#2475856 , @dblaikie wrote: > Looks good - test cases might benefit from some descriptive comments > (explaining why the pseudo probe pass needs to be enabled to test the unique > linkage name pass - I guess to check that it

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy updated this revision to Diff 314257. hoy added a comment. Addressing comments from dblaikie. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/ https://reviews.llvm.org/D93656 Files: llvm/include/llvm/Passes/PassBuilder.h llvm/lib/P

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 314259. hoy added a comment. Adding a switch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoMetadata.h llvm/lib/Transforms/Utils/

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2475852 , @dblaikie wrote: > In D93747#2470504 , @hoy wrote: > >> In D93747#2470387 , @dblaikie wrote: >> >>> Please remove the clang test chan

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

This revision was automatically updated to reflect the committed changes. Closed by commit rG01f0d162d672: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines. (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 314393. hoy added a comment. Replacing linkage names for debug declaration as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoM

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

hoy created this revision. Herald added a subscriber: wenlei. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a follow-up to D93656 , I'm switching the Clang UniqueInternalLinkageNamesPass scheduling

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4034f9273eda: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one… (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

hoy added a comment. In D94019#2478045 , @dblaikie wrote: > Please add a clang test for this. There is the original clang test `unique-internal-linkage-names.cpp` that still works with the change here. What kind of new test would you like? Repository:

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

hoy added a comment. In D94019#2478048 , @dblaikie wrote: > In D94019#2478047 , @hoy wrote: > >> In D94019#2478045 , @dblaikie wrote: >> >>> Please add a clang test for this.

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

hoy added a comment. In D94019#2478253 , @dblaikie wrote: > In D94019#2478206 , @hoy wrote: > >> In D94019#2478048 , @dblaikie wrote: >> >>> In D94019#2478047

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

hoy added a comment. In D94019#2478284 , @dblaikie wrote: > In D94019#2478277 , @hoy wrote: > >> In D94019#2478253 , @dblaikie wrote: >> >>> In D94019#2478206

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2481053 , @tmsriram wrote: > In D93747#2480442 , @dblaikie wrote: > In D93747#2470178 , @tmsriram wrote: > In D93747#246955

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2481073 , @dblaikie wrote: > In D93747#2481053 , @tmsriram wrote: > >> In D93747#2480442 , @dblaikie wrote: >> >>> @tmsriram - any ideas what y

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2481304 , @tmsriram wrote: > In D93747#2481223 , @tmsriram wrote: > >> In D93747#2481163 , @dblaikie wrote: >> >>> In D93747#2481095

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2482519 , @tmsriram wrote: > In D93747#2481494 , @dblaikie wrote: > >> In D93747#2481383 , @hoy wrote: >> >>> In D93747#2481304

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 314955. hoy added a comment. Renaming debug linkage name if it preexisits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoMetadata.h

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2482730 , @tmsriram wrote: > In D93747#2482726 , @hoy wrote: > >> In D93747#2482519 , @tmsriram wrote: >> >>> In D93747#2481494

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

hoy added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:462 + if (!PIC->hasPassName(P)) +report_fatal_error("unrecognized pass name: " + P); +} @aeubanks This seems not working with MIR passes under newpm. Would it make sense to i

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e23fd676c39: [Driver] Add DWARF64 flag: -gdwarf64 (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2488399 , @dblaikie wrote: > In D93747#2488390 , @tmsriram wrote: > >> In D93747#2488387 , @dblaikie wrote: >> >>> Seems alright to me - I thin

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 315572. hoy added a comment. Removing the UniqueDebugLinakgeNames switch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoMetadata.h

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 315908. hoy added a comment. Rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoMetadata.h llvm/lib/Transforms/Utils/UniqueI

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

This revision was automatically updated to reflect the committed changes. Closed by commit rG32bcfcda4e28: Rename debug linkage name with -funique-internal-linkage-names (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ htt

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

hoy added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:41 // [18:3] - probe id - // [25:19] - reserved + // [25:19] - probe distribution factor // [28:26] - probe type, see PseudoProbeType wmi wrote: > The bits in discriminator is a

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

hoy added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:41 // [18:3] - probe id - // [25:19] - reserved + // [25:19] - probe distribution factor // [28:26] - probe type, see PseudoProbeType hoy wrote: > wmi wrote: > > The bits in dis

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

hoy updated this revision to Diff 316567. hoy added a comment. Adding support in the priority-based inliner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93264/new/ https://reviews.llvm.org/D93264 Files: clang/test/CodeGen/pseudo-probe-emit.c

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

hoy added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:41 // [18:3] - probe id - // [25:19] - reserved + // [25:19] - probe distribution factor // [28:26] - probe type, see PseudoProbeType wmi wrote: > hoy wrote: > > hoy wrote: > >

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

hoy added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:41 // [18:3] - probe id - // [25:19] - reserved + // [25:19] - probe distribution factor // [28:26] - probe type, see PseudoProbeType wmi wrote: > hoy wrote: > > wmi wrote: > >

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

hoy added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:41 // [18:3] - probe id - // [25:19] - reserved + // [25:19] - probe distribution factor // [28:26] - probe type, see PseudoProbeType wmi wrote: > hoy wrote: > > wmi wrote: > >

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

hoy updated this revision to Diff 317726. hoy marked an inline comment as done. hoy added a comment. Addressing Wei's feedbacks. Also prorating indirect callsite target count annotation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93264/new/ htt

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy created this revision. Herald added subscribers: modimo, wenlei, hiraditya. hoy requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Pseudo probe instrumentation was missing from O0 build. It is needed in cases where some

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy added a comment. In D109531#2992702 , @wenlei wrote: > The change makes sense given instr PGO also happens for O0. But practically, > if a file is being built with O0, do we care about its profile given we're > not really optimizing it anyways? Func

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy added a comment. In D109531#2993394 , @wmi wrote: > In D109531#2992721 , @hoy wrote: > >> In D109531#2992702 , @wenlei wrote: >> >>> The change makes sense given instr

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy added a comment. In D109531#2994823 , @wmi wrote: > In D109531#2993484 , @hoy wrote: > >> In D109531#2993394 , @wmi wrote: >> >>> In D109531#2992721

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy updated this revision to Diff 371942. hoy added a comment. Updating D109531 : [CSSPGO] Enable pseudo probe instrumentation in O0 mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109531/new/ https://reviews.

[PATCH] D109638: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy created this revision. Herald added subscribers: modimo, wenlei, hiraditya. hoy requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Pseudo probe instrumentation was missing from O0 build. It is needed in cases where some

[PATCH] D109638: [CSSPGO] Truncate stack samples with invalid return address.

hoy updated this revision to Diff 372042. hoy edited the summary of this revision. hoy added a comment. Updating D109638 : [CSSPGO] Truncate stack samples with invalid return address. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1930 + // mixed with an O0 prelink and an O2 postlink. Loading a sample profile in + // the postlink will require pseudo probe instrumentation in the prelink. + if (PGOOpt && PGOOpt->PseudoProbeForProfiling

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy added a comment. In D109638#3000682 , @wenlei wrote: >> It isn't common when the program is built with the frame pointer omission >> disabled, but can still happen with third-party static libs built with frame >> pointer omitted. > > Did you mean di

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy updated this revision to Diff 372604. hoy added a comment. Addressing Wenlei's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109638/new/ https://reviews.llvm.org/D109638 Files: llvm/test/tools/llvm-profgen/Inputs/cs-invalid-ret-addr

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG299b5d420df1: [CSSPGO] Enable pseudo probe instrumentation in O0 mode. (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy updated this revision to Diff 372615. hoy added a comment. Updating D109638 : [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109638/new/

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy added inline comments. Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:772 +void PerfReaderBase::emitAccumulatedWarnings() { + for (auto Address : InvalidReturnAddresses) { wenlei wrote: > nit: emitAccumulatedWarnings -> warnTruncatedStack Makes sense.

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0057c7185d1c: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address. (authored by hoy). Repository: rG LLVM Github Monorepo C

<    1   2   3   >