[clang-tools-extra] r368549 - [clangd] Drop diags from non-written #include.

2019-08-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Aug 12 02:35:04 2019 New Revision: 368549 URL: http://llvm.org/viewvc/llvm-project?rev=368549&view=rev Log: [clangd] Drop diags from non-written #include. Summary: This would fix that we show weird diagnostics on random lines of the main file. Reviewers: ilya-biryukov

r368808 - Fix the -Wunused-variable warning.

2019-08-14 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Aug 14 01:20:42 2019 New Revision: 368808 URL: http://llvm.org/viewvc/llvm-project?rev=368808&view=rev Log: Fix the -Wunused-variable warning. Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Mo

[clang-tools-extra] r368851 - [clangd][vscode] Surface the error when applying tweaks fails

2019-08-14 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Aug 14 06:38:52 2019 New Revision: 368851 URL: http://llvm.org/viewvc/llvm-project?rev=368851&view=rev Log: [clangd][vscode] Surface the error when applying tweaks fails Summary: The current behavior for a failed request is just to log it in the output panel. When applyTw

[clang-tools-extra] r369387 - [clangd] Fix one testcase in XRefsTests.

2019-08-20 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Aug 20 07:07:27 2019 New Revision: 369387 URL: http://llvm.org/viewvc/llvm-project?rev=369387&view=rev Log: [clangd] Fix one testcase in XRefsTests. Summary: The test didn't test anything actually -- it used "[]" as annotation which should be "[[]]". This patch also fix

[clang-tools-extra] r364010 - [clang-tidy] Fix a typo in the doc.

2019-06-21 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jun 21 00:58:19 2019 New Revision: 364010 URL: http://llvm.org/viewvc/llvm-project?rev=364010&view=rev Log: [clang-tidy] Fix a typo in the doc. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-duration-addition.rst Modified: clang-tools-extra/trunk/do

[clang-tools-extra] r364044 - [clangd] Add include-mapping for C symbols.

2019-06-21 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jun 21 06:32:18 2019 New Revision: 364044 URL: http://llvm.org/viewvc/llvm-project?rev=364044&view=rev Log: [clangd] Add include-mapping for C symbols. Summary: This resolves the issue of introducing c++-style includes for C files. - refactor the gen_std.py, make it reus

[clang-tools-extra] r364280 - [clangd] Cleanup the duplicated getTokenRange.

2019-06-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jun 25 01:01:46 2019 New Revision: 364280 URL: http://llvm.org/viewvc/llvm-project?rev=364280&view=rev Log: [clangd] Cleanup the duplicated getTokenRange. Summary: Also lift it to SourceCode.h, so that it can be used in other places (semantic code highlighting). Reviewer

r364283 - [clangd] Narrow rename to local symbols.

2019-06-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jun 25 01:43:17 2019 New Revision: 364283 URL: http://llvm.org/viewvc/llvm-project?rev=364283&view=rev Log: [clangd] Narrow rename to local symbols. Summary: Previously, we performed rename for all kinds of symbols (local, global). This patch narrows the scope by only re

[clang-tools-extra] r364283 - [clangd] Narrow rename to local symbols.

2019-06-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jun 25 01:43:17 2019 New Revision: 364283 URL: http://llvm.org/viewvc/llvm-project?rev=364283&view=rev Log: [clangd] Narrow rename to local symbols. Summary: Previously, we performed rename for all kinds of symbols (local, global). This patch narrows the scope by only re

[clang-tools-extra] r364392 - [clangd] Don't rename the namespace.

2019-06-26 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jun 26 01:10:26 2019 New Revision: 364392 URL: http://llvm.org/viewvc/llvm-project?rev=364392&view=rev Log: [clangd] Don't rename the namespace. Summary: Also fix a small bug -- the extra argument "-xc++" doesn't overwrite the language if the argument is present after the

[clang-tools-extra] r364528 - [clangd] No need to setTraversalScope in SemanticHighlighting.

2019-06-27 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jun 27 05:22:18 2019 New Revision: 364528 URL: http://llvm.org/viewvc/llvm-project?rev=364528&view=rev Log: [clangd] No need to setTraversalScope in SemanticHighlighting. Summary: We have already set it when the AST is being built, and setting TraversalScope is not free (

[clang-tools-extra] r364537 - [clangd] Fix a case where we fail to detect a header-declared symbol in rename.

2019-06-27 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jun 27 06:24:10 2019 New Revision: 364537 URL: http://llvm.org/viewvc/llvm-project?rev=364537&view=rev Log: [clangd] Fix a case where we fail to detect a header-declared symbol in rename. Summary: Failing case: ``` #include "foo.h" void fo^o() {} ``` getRenameDecl() r

[clang-tools-extra] r364731 - [clangd] Make FixIt message be consistent with the clang-tidy diagnostic message.

2019-07-01 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Jul 1 01:05:53 2019 New Revision: 364731 URL: http://llvm.org/viewvc/llvm-project?rev=364731&view=rev Log: [clangd] Make FixIt message be consistent with the clang-tidy diagnostic message. Summary: We strip the "[clang-tidy-check]" suffix from the clang-tidy diagnostics

[clang-tools-extra] r364735 - [clangd] Show better message when we rename macros.

2019-07-01 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Jul 1 02:26:48 2019 New Revision: 364735 URL: http://llvm.org/viewvc/llvm-project?rev=364735&view=rev Log: [clangd] Show better message when we rename macros. Summary: Previously, when we rename a macro, we get an error message of "there is no symbol found". This patch

[clang-tools-extra] r364893 - [clangd] Collect the refs when the main file is header.

2019-07-02 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jul 2 02:16:21 2019 New Revision: 364893 URL: http://llvm.org/viewvc/llvm-project?rev=364893&view=rev Log: [clangd] Collect the refs when the main file is header. Summary: Previously, we only collect refs of the symbols which are declared in the preamble and referenced i

[clang-tools-extra] r365130 - [clangd] Add a hidden tweak to annotate all highlighting tokens of the file.

2019-07-04 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jul 4 03:49:32 2019 New Revision: 365130 URL: http://llvm.org/viewvc/llvm-project?rev=365130&view=rev Log: [clangd] Add a hidden tweak to annotate all highlighting tokens of the file. Reviewers: sammccall, jvikstrom Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous,

[clang-tools-extra] r365135 - [clangd] Some tweaks on semantic highlighting lookuptable.

2019-07-04 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jul 4 05:27:21 2019 New Revision: 365135 URL: http://llvm.org/viewvc/llvm-project?rev=365135&view=rev Log: [clangd] Some tweaks on semantic highlighting lookuptable. Summary: - move toTextMateScope to SemanticHighlighting.h; - move the buildLookupTable to LSP layer (as L

[clang-tools-extra] r365204 - [clangd] Deduplicate clang-tidy diagnostic messages.

2019-07-05 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jul 5 05:57:56 2019 New Revision: 365204 URL: http://llvm.org/viewvc/llvm-project?rev=365204&view=rev Log: [clangd] Deduplicate clang-tidy diagnostic messages. Summary: Clang-tidy checks may emit duplicated messages (clang-tidy tool deduplicate them in its custom diagnos

[clang-tools-extra] r365631 - [clangd] Add a flag to clangdServer rename function to control whether we want format the replacements.

2019-07-10 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jul 10 06:44:22 2019 New Revision: 365631 URL: http://llvm.org/viewvc/llvm-project?rev=365631&view=rev Log: [clangd] Add a flag to clangdServer rename function to control whether we want format the replacements. Summary: This would allow clangd embedders to use the Clang

[clang-tools-extra] r365742 - Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class."

2019-07-11 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jul 11 01:54:28 2019 New Revision: 365742 URL: http://llvm.org/viewvc/llvm-project?rev=365742&view=rev Log: Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class." This reverts r365675 (git commit 43d75f977853c3ec891a440c362b2df

r365742 - Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class."

2019-07-11 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jul 11 01:54:28 2019 New Revision: 365742 URL: http://llvm.org/viewvc/llvm-project?rev=365742&view=rev Log: Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class." This reverts r365675 (git commit 43d75f977853c3ec891a440c362b2df

[clang-tools-extra] r365751 - [clangd] Add a missing "return nullptr; " to the SelectionTree::commonAncestor.

2019-07-11 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jul 11 03:06:24 2019 New Revision: 365751 URL: http://llvm.org/viewvc/llvm-project?rev=365751&view=rev Log: [clangd] Add a missing "return nullptr;" to the SelectionTree::commonAncestor. This would fix some mysterious crashes on codeAction in clangd. Modified: clang-

[clang-tools-extra] r365763 - [clangd] Fix an assertion crash in "ExtractVariable" tweak

2019-07-11 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jul 11 05:29:01 2019 New Revision: 365763 URL: http://llvm.org/viewvc/llvm-project?rev=365763&view=rev Log: [clangd] Fix an assertion crash in "ExtractVariable" tweak Summary: GetTypePtr requires that the type should not be null, otherwise we hit an assertion, we should u

[clang-tools-extra] r365764 - [clangd] Remove the extra ";", NFC

2019-07-11 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jul 11 05:31:18 2019 New Revision: 365764 URL: http://llvm.org/viewvc/llvm-project?rev=365764&view=rev Log: [clangd] Remove the extra ";", NFC Modified: clang-tools-extra/trunk/clangd/unittests/TestFS.cpp Modified: clang-tools-extra/trunk/clangd/unittests/TestFS.cpp

[clang-tools-extra] r365778 - [clangd] Remove an extra ";", NFC

2019-07-11 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jul 11 06:58:56 2019 New Revision: 365778 URL: http://llvm.org/viewvc/llvm-project?rev=365778&view=rev Log: [clangd] Remove an extra ";", NFC Modified: clang-tools-extra/trunk/clangd/index/Background.h Modified: clang-tools-extra/trunk/clangd/index/Background.h URL:

[clang-tools-extra] r361749 - [clang-tidy] Fix unused-variable warning after r361647.

2019-05-27 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon May 27 01:09:02 2019 New Revision: 361749 URL: http://llvm.org/viewvc/llvm-project?rev=361749&view=rev Log: [clang-tidy] Fix unused-variable warning after r361647. Summary: A range-for was added in r361647 where the range variable was only used in an assertion. As a resu

[clang-tools-extra] r361809 - [clang-tidy] Fix null pointer dereference in readability-identifier-naming

2019-05-28 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue May 28 04:54:01 2019 New Revision: 361809 URL: http://llvm.org/viewvc/llvm-project?rev=361809&view=rev Log: [clang-tidy] Fix null pointer dereference in readability-identifier-naming Summary: readability-identifier-naming causes a null pointer dereference when checking a

[clang-tools-extra] r361833 - [clang-tidy] Verify fix description for misc-unused-using-decl.

2019-05-28 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue May 28 07:47:39 2019 New Revision: 361833 URL: http://llvm.org/viewvc/llvm-project?rev=361833&view=rev Log: [clang-tidy] Verify fix description for misc-unused-using-decl. Reviewers: gribozavr Subscribers: xazax.hun, cfe-commits Tags: #clang Differential Revision: http

[clang-tools-extra] r361834 - [clang-tidy] Fix description for misc-definitions-in-headers.

2019-05-28 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue May 28 07:50:42 2019 New Revision: 361834 URL: http://llvm.org/viewvc/llvm-project?rev=361834&view=rev Log: [clang-tidy] Fix description for misc-definitions-in-headers. Reviewers: gribozavr Subscribers: xazax.hun, cfe-commits Tags: #clang Differential Revision: https:

[clang-tools-extra] r361951 - [clangd] Another improvement for std include mapping.

2019-05-29 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed May 29 05:03:41 2019 New Revision: 361951 URL: http://llvm.org/viewvc/llvm-project?rev=361951&view=rev Log: [clangd] Another improvement for std include mapping. Summary: Improve the way of checking a symbol name is in the first cell. The previous way is not very robost f

[clang-tools-extra] r361952 - [clangd] Remove the whitelist std symbols in CanonicalIncludes.

2019-05-29 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed May 29 05:08:11 2019 New Revision: 361952 URL: http://llvm.org/viewvc/llvm-project?rev=361952&view=rev Log: [clangd] Remove the whitelist std symbols in CanonicalIncludes. Summary: These symbols have been included via StdSymbolMap.inc. Reviewers: sammccall Subscribers:

[clang-tools-extra] r361960 - [clangd] Fix buildbot error.

2019-05-29 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed May 29 07:11:53 2019 New Revision: 361960 URL: http://llvm.org/viewvc/llvm-project?rev=361960&view=rev Log: [clangd] Fix buildbot error. Modified: clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp Modified: clang-tools-extra/trunk/clangd/index/CanonicalInclu

r362005 - Fix an unused-variable error.

2019-05-29 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed May 29 11:36:54 2019 New Revision: 362005 URL: http://llvm.org/viewvc/llvm-project?rev=362005&view=rev Log: Fix an unused-variable error. Modified: cfe/trunk/lib/StaticAnalyzer/Core/Environment.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/Environment.cpp URL: htt

[clang-tools-extra] r349031 - [clangd] Move the utility function to anonymous namespace, NFC.

2018-12-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Dec 13 05:07:29 2018 New Revision: 349031 URL: http://llvm.org/viewvc/llvm-project?rev=349031&view=rev Log: [clangd] Move the utility function to anonymous namespace, NFC. Modified: clang-tools-extra/trunk/clangd/index/Background.cpp Modified: clang-tools-extra/trunk

[clang-tools-extra] r349032 - [clangd] Avoid emitting Queued status when we are able to acquire the Barrier.

2018-12-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Dec 13 05:09:50 2018 New Revision: 349032 URL: http://llvm.org/viewvc/llvm-project?rev=349032&view=rev Log: [clangd] Avoid emitting Queued status when we are able to acquire the Barrier. Reviewers: ilya-biryukov Subscribers: javed.absar, ioeric, MaskRay, jkorous, arphama

[clang-tools-extra] r349033 - [clangd] Refine the way of checking a declaration is referenced by the written code.

2018-12-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Dec 13 05:17:04 2018 New Revision: 349033 URL: http://llvm.org/viewvc/llvm-project?rev=349033&view=rev Log: [clangd] Refine the way of checking a declaration is referenced by the written code. Summary: The previous solution (checking the AST) is not a reliable way to det

[clang-tools-extra] r349144 - [clangd] Fix an assertion failure in background index.

2018-12-14 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Dec 14 04:39:08 2018 New Revision: 349144 URL: http://llvm.org/viewvc/llvm-project?rev=349144&view=rev Log: [clangd] Fix an assertion failure in background index. Summary: When indexing a file which contains an uncompilable error, we will trigger an assertion failure -- t

[clang-tools-extra] r349145 - [clangd] Fix memory leak in ClangdTests.

2018-12-14 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Dec 14 05:19:38 2018 New Revision: 349145 URL: http://llvm.org/viewvc/llvm-project?rev=349145&view=rev Log: [clangd] Fix memory leak in ClangdTests. Summary: createInvocationFromCommandLine sets DisableFree to true by default, which leads memory leak in clangd. The fix is

[clang-tools-extra] r349148 - [clangd] Use buildCompilerInvocation to simplify the HeadersTests, NFC.

2018-12-14 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Dec 14 05:49:00 2018 New Revision: 349148 URL: http://llvm.org/viewvc/llvm-project?rev=349148&view=rev Log: [clangd] Use buildCompilerInvocation to simplify the HeadersTests, NFC. Modified: clang-tools-extra/trunk/unittests/clangd/HeadersTests.cpp Modified: clang-too

r349494 - [AST] Unify the code paths of traversing lambda expressions.

2018-12-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Dec 18 07:29:12 2018 New Revision: 349494 URL: http://llvm.org/viewvc/llvm-project?rev=349494&view=rev Log: [AST] Unify the code paths of traversing lambda expressions. Summary: This supposes to be a non-functional change. We have two code paths when traversing lambda exp

[clang-tools-extra] r349623 - [clang-tidy] use "const SourceManager&" parameter, NFC.

2018-12-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Dec 19 05:25:08 2018 New Revision: 349623 URL: http://llvm.org/viewvc/llvm-project?rev=349623&view=rev Log: [clang-tidy] use "const SourceManager&" parameter, NFC. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp Modified: clang-tools-extr

r349626 - [Index] Index paremeters in lambda expressions.

2018-12-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Dec 19 05:44:41 2018 New Revision: 349626 URL: http://llvm.org/viewvc/llvm-project?rev=349626&view=rev Log: [Index] Index paremeters in lambda expressions. Summary: This fixes clangd couldn't find references for lambda parameters. Reviewers: ilya-biryukov Subscribers: i

[clang-tools-extra] r349632 - [clangd] Fix a syntax error on the test.

2018-12-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Dec 19 06:51:07 2018 New Revision: 349632 URL: http://llvm.org/viewvc/llvm-project?rev=349632&view=rev Log: [clangd] Fix a syntax error on the test. Modified: clang-tools-extra/trunk/unittests/clangd/FindSymbolsTests.cpp Modified: clang-tools-extra/trunk/unittests/cl

[clang-tools-extra] r349750 - [clangd] Don't miss the expected type in merge.

2018-12-20 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Dec 20 05:05:46 2018 New Revision: 349750 URL: http://llvm.org/viewvc/llvm-project?rev=349750&view=rev Log: [clangd] Don't miss the expected type in merge. Reviewers: ilya-biryukov Subscribers: ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differential Revis

[clang-tools-extra] r349768 - [clangd] Expose FileStatus to LSP.

2018-12-20 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Dec 20 07:39:12 2018 New Revision: 349768 URL: http://llvm.org/viewvc/llvm-project?rev=349768&view=rev Log: [clangd] Expose FileStatus to LSP. Summary: Add an LSP extension "textDocument/clangd.fileStatus" to emit file-status information. Reviewers: ilya-biryukov Subsc

[clang-tools-extra] r349893 - [clangd] Cleanup syntax errors in the test, NFC.

2018-12-21 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Dec 21 01:32:49 2018 New Revision: 349893 URL: http://llvm.org/viewvc/llvm-project?rev=349893&view=rev Log: [clangd] Cleanup syntax errors in the test, NFC. Modified: clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp clang-tools-extra/trunk/unittests/

[clang-tools-extra] r350210 - [clangd] Show FileStatus in vscode-clangd.

2019-01-02 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jan 2 03:25:37 2019 New Revision: 350210 URL: http://llvm.org/viewvc/llvm-project?rev=350210&view=rev Log: [clangd] Show FileStatus in vscode-clangd. Summary: The file status will be shown in the status bar. Depends on D55363. Reviewers: ilya-biryukov Subscribers: ioer

[clang-tools-extra] r350324 - [clangd] Bump vscode-clangd v0.0.9

2019-01-03 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jan 3 07:28:38 2019 New Revision: 350324 URL: http://llvm.org/viewvc/llvm-project?rev=350324&view=rev Log: [clangd] Bump vscode-clangd v0.0.9 Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package.json Modified: clang-tools-extra/trunk/clangd/clients

[clang-tools-extra] r350325 - [clangd] Move helpers from global namespace into anonymous namespace, NFC.

2019-01-03 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jan 3 07:36:18 2019 New Revision: 350325 URL: http://llvm.org/viewvc/llvm-project?rev=350325&view=rev Log: [clangd] Move helpers from global namespace into anonymous namespace, NFC. Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp Modified: clang-tools-extr

[clang-tools-extra] r350515 - [clangd] Fix a regression issue caused by r348365.

2019-01-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Jan 7 04:35:02 2019 New Revision: 350515 URL: http://llvm.org/viewvc/llvm-project?rev=350515&view=rev Log: [clangd] Fix a regression issue caused by r348365. Summary: With r348365, we now detect libc++ dir using the actual compiler path (from the compilation command), ra

[clang-tools-extra] r350633 - [clangd] Fix a crash when reading an empty index file.

2019-01-08 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jan 8 07:24:47 2019 New Revision: 350633 URL: http://llvm.org/viewvc/llvm-project?rev=350633&view=rev Log: [clangd] Fix a crash when reading an empty index file. Summary: Unfortunately, yaml::Input::setCurrentDocument() and yaml::Input::nextDocument() are internal APIs,

[clang-tools-extra] r350720 - [clangd] Add a test for SignatureHelp on dynamic index.

2019-01-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jan 9 05:42:03 2019 New Revision: 350720 URL: http://llvm.org/viewvc/llvm-project?rev=350720&view=rev Log: [clangd] Add a test for SignatureHelp on dynamic index. Summary: This would catch regressions caused by future changes of the index. Reviewers: ilya-biryukov Subs

[clang-tools-extra] r350803 - [clangd] Don't store completion info if the symbol is not used for code completion.

2019-01-10 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jan 10 01:22:40 2019 New Revision: 350803 URL: http://llvm.org/viewvc/llvm-project?rev=350803&view=rev Log: [clangd] Don't store completion info if the symbol is not used for code completion. Summary: This would save us some memory and disk space: - Dex usage (261 MB v

[clang-tools-extra] r371495 - [clangd] some tweaks on the vscode readme, NFC

2019-09-10 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Sep 10 01:07:12 2019 New Revision: 371495 URL: http://llvm.org/viewvc/llvm-project?rev=371495&view=rev Log: [clangd] some tweaks on the vscode readme, NFC Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/README.md Modified: clang-tools-extra/trunk/clang

[clang-tools-extra] r371504 - [clangd] Collect location of macro definition in the ParsedAST

2019-09-10 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Sep 10 03:10:36 2019 New Revision: 371504 URL: http://llvm.org/viewvc/llvm-project?rev=371504&view=rev Log: [clangd] Collect location of macro definition in the ParsedAST allows semantic hightlighting macro definition Subscribers: ilya-biryukov, MaskRay, jkorous, arphama

[clang-tools-extra] r371963 - [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

2019-09-16 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Sep 16 01:54:10 2019 New Revision: 371963 URL: http://llvm.org/viewvc/llvm-project?rev=371963&view=rev Log: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field Summary: Finds calls that add element to protobuf repeated field in a loop with

[clang-tools-extra] r371968 - Fix the rst doc, unbreak buildbot.

2019-09-16 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Sep 16 02:46:53 2019 New Revision: 371968 URL: http://llvm.org/viewvc/llvm-project?rev=371968&view=rev Log: Fix the rst doc, unbreak buildbot. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/performance-inefficient-vector-operation.rst Modified: clang-tool

[clang-tools-extra] r371971 - [clangd] Fix a crash when renaming operator.

2019-09-16 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Sep 16 03:16:56 2019 New Revision: 371971 URL: http://llvm.org/viewvc/llvm-project?rev=371971&view=rev Log: [clangd] Fix a crash when renaming operator. Summary: The renamelib uses a tricky way to calculate the end location by relying on decl name, this is incorrect for t

r371971 - [clangd] Fix a crash when renaming operator.

2019-09-16 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Sep 16 03:16:56 2019 New Revision: 371971 URL: http://llvm.org/viewvc/llvm-project?rev=371971&view=rev Log: [clangd] Fix a crash when renaming operator. Summary: The renamelib uses a tricky way to calculate the end location by relying on decl name, this is incorrect for t

[clang-tools-extra] r371980 - [clangd] Bump vscode-clangd v0.0.17

2019-09-16 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Sep 16 05:51:07 2019 New Revision: 371980 URL: http://llvm.org/viewvc/llvm-project?rev=371980&view=rev Log: [clangd] Bump vscode-clangd v0.0.17 CHANGELOG: - added semantic highlighting support (under the clangd.semanticHighlighting flag); - better error message when cla

[clang-tools-extra] r371986 - [clangd][vscode] update the development doc.

2019-09-16 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Sep 16 07:03:06 2019 New Revision: 371986 URL: http://llvm.org/viewvc/llvm-project?rev=371986&view=rev Log: [clangd][vscode] update the development doc. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/DEVELOPING.md Modified: clang-tools-extra/trunk/cla

[clang-tools-extra] r372206 - [clang-tidy] Fix a potential infinite loop in readability-isolate-declaration check.

2019-09-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Sep 18 02:21:35 2019 New Revision: 372206 URL: http://llvm.org/viewvc/llvm-project?rev=372206&view=rev Log: [clang-tidy] Fix a potential infinite loop in readability-isolate-declaration check. Reviewers: ilya-biryukov Subscribers: xazax.hun, cfe-commits Tags: #clang D

[clang-tools-extra] r372617 - [clangd] Simplify the callside of URI::resolve, NFC.

2019-09-23 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Sep 23 07:39:37 2019 New Revision: 372617 URL: http://llvm.org/viewvc/llvm-project?rev=372617&view=rev Log: [clangd] Simplify the callside of URI::resolve, NFC. Summary: - Add a overrloded URI::resolve, which accepts a string URI; - also fixed some callside that don't che

[clang-tools-extra] r372725 - [clangd] Collect macros in the preamble region of the main file

2019-09-24 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Sep 24 04:14:06 2019 New Revision: 372725 URL: http://llvm.org/viewvc/llvm-project?rev=372725&view=rev Log: [clangd] Collect macros in the preamble region of the main file Summary: - store all macro references in the ParsedAST; - unify the two variants of CollectMainFileM

[clang-tools-extra] r372752 - [clangd] Save an unnecessary copy, NFC.

2019-09-24 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Sep 24 06:25:38 2019 New Revision: 372752 URL: http://llvm.org/viewvc/llvm-project?rev=372752&view=rev Log: [clangd] Save an unnecessary copy, NFC. Modified: clang-tools-extra/trunk/clangd/FileDistance.cpp Modified: clang-tools-extra/trunk/clangd/FileDistance.cpp URL

[clang-tools-extra] r372825 - [clangd] Fix the stale documentation about background indexing.

2019-09-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Sep 25 01:26:32 2019 New Revision: 372825 URL: http://llvm.org/viewvc/llvm-project?rev=372825&view=rev Log: [clangd] Fix the stale documentation about background indexing. Reviewers: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags: #cla

[clang-tools-extra] r372841 - [clangd] Move the existing heder-source-switch implemenation out of clangdServer.

2019-09-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Sep 25 03:30:22 2019 New Revision: 372841 URL: http://llvm.org/viewvc/llvm-project?rev=372841&view=rev Log: [clangd] Move the existing heder-source-switch implemenation out of clangdServer. Summary: This is a NFC change. Reviewers: kadircet Reviewed By: kadircet Subsc

[clang-tools-extra] r372860 - [clangd] Add missing header guard, NFC.

2019-09-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Sep 25 05:54:53 2019 New Revision: 372860 URL: http://llvm.org/viewvc/llvm-project?rev=372860&view=rev Log: [clangd] Add missing header guard, NFC. Modified: clang-tools-extra/trunk/clangd/FindTarget.h clang-tools-extra/trunk/clangd/HeaderSourceSwitch.h Modified:

[clang-tools-extra] r372953 - [clang-tidy] Make llvm-header-guard work on llvm git monorepo

2019-09-26 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Sep 26 02:56:37 2019 New Revision: 372953 URL: http://llvm.org/viewvc/llvm-project?rev=372953&view=rev Log: [clang-tidy] Make llvm-header-guard work on llvm git monorepo Reviewers: gribozavr Reviewed By: gribozavr Subscribers: xazax.hun, ilya-biryukov, MaskRay, jkorous,

[clang-tools-extra] r372969 - [clangd][vscode] Turn on the semantic highlighting by default.

2019-09-26 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Sep 26 04:34:11 2019 New Revision: 372969 URL: http://llvm.org/viewvc/llvm-project?rev=372969&view=rev Log: [clangd][vscode] Turn on the semantic highlighting by default. Summary: We have turned on the flag manually and used it for a while, and don't see any major issues,

[clang-tools-extra] r372970 - [clangd][vscode] Update vscode lsp dependencies to pickup the new changes in LSP v3.15.0.

2019-09-26 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Sep 26 04:35:34 2019 New Revision: 372970 URL: http://llvm.org/viewvc/llvm-project?rev=372970&view=rev Log: [clangd][vscode] Update vscode lsp dependencies to pickup the new changes in LSP v3.15.0. Summary: This would enable the newly-added semantic selection feature in

[clang-tools-extra] r372980 - [clangd][vscode] Add npm helper commands to package/release the extension.

2019-09-26 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Sep 26 07:04:52 2019 New Revision: 372980 URL: http://llvm.org/viewvc/llvm-project?rev=372980&view=rev Log: [clangd][vscode] Add npm helper commands to package/release the extension. Summary: Help to fix https://github.com/clangd/clangd/issues/159. Reviewers: ilya-biryuk

[clang-tools-extra] r372981 - [clangd] Bump vscode-clangd v0.0.18

2019-09-26 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Sep 26 07:11:23 2019 New Revision: 372981 URL: http://llvm.org/viewvc/llvm-project?rev=372981&view=rev Log: [clangd] Bump vscode-clangd v0.0.18 CHANGELOG: - enable semantic highlighting by default - upgrade the LSP dependencies to pickup the incoming LSP v3.15.0 Modified

[clang-tools-extra] r373079 - [clangd] Remove an unrelated comment, NFC.

2019-09-27 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Sep 27 05:32:19 2019 New Revision: 373079 URL: http://llvm.org/viewvc/llvm-project?rev=373079&view=rev Log: [clangd] Remove an unrelated comment, NFC. Modified: clang-tools-extra/trunk/clangd/SemanticHighlighting.cpp Modified: clang-tools-extra/trunk/clangd/SemanticH

[clang-tools-extra] r373197 - [clangd] Implement a smart version of HeaderSource switch.

2019-09-30 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Sep 30 03:48:02 2019 New Revision: 373197 URL: http://llvm.org/viewvc/llvm-project?rev=373197&view=rev Log: [clangd] Implement a smart version of HeaderSource switch. Summary: This patch implements another version header-source switch by incorporating the AST and index, i

[clang-tools-extra] r373320 - [clangd] Use the index-based API to do the header-source switch.

2019-10-01 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Oct 1 03:21:15 2019 New Revision: 373320 URL: http://llvm.org/viewvc/llvm-project?rev=373320&view=rev Log: [clangd] Use the index-based API to do the header-source switch. Summary: If the file heuristic fails, we try to use the index&AST to do the header/source inference

[clang-tools-extra] r373323 - [clangd] Implement getBeginning for overloaded operators.

2019-10-01 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Oct 1 04:03:56 2019 New Revision: 373323 URL: http://llvm.org/viewvc/llvm-project?rev=373323&view=rev Log: [clangd] Implement getBeginning for overloaded operators. Summary: This will fix some bugs where navigation doesn't work on cases like `std::cout <^< "hello"`. Rev

r373440 - [clang-rename] Better renaming the typedef decl.

2019-10-02 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 2 02:50:46 2019 New Revision: 373440 URL: http://llvm.org/viewvc/llvm-project?rev=373440&view=rev Log: [clang-rename] Better renaming the typedef decl. Summary: when renaming a typedef decl, we used to rename the underlying decl of the typedef, we should rename the t

[clang-tools-extra] r373444 - [clangd] Bail out early if we are sure that the symbol is used outside of the file.

2019-10-02 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 2 03:46:37 2019 New Revision: 373444 URL: http://llvm.org/viewvc/llvm-project?rev=373444&view=rev Log: [clangd] Bail out early if we are sure that the symbol is used outside of the file. Summary: This would reduce the false positive when the static index is in an un

[clang-tools-extra] r329997 - [clangd] Add line and column number to the index symbol.

2018-04-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Apr 13 01:30:39 2018 New Revision: 329997 URL: http://llvm.org/viewvc/llvm-project?rev=329997&view=rev Log: [clangd] Add line and column number to the index symbol. Summary: LSP is using Line & column as symbol position, clangd needs to transfer file offset to Line & colu

[clang-tools-extra] r330182 - [clangd] Fix "fail to create file URI" warnings in FileIndexTest.

2018-04-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Apr 17 01:34:50 2018 New Revision: 330182 URL: http://llvm.org/viewvc/llvm-project?rev=330182&view=rev Log: [clangd] Fix "fail to create file URI" warnings in FileIndexTest. Summary: When running the FileIndexTest, it shows "Failed to create an URI for file XXX: not a val

[clang-tools-extra] r330245 - [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file.

2018-04-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Apr 18 01:54:28 2018 New Revision: 330245 URL: http://llvm.org/viewvc/llvm-project?rev=330245&view=rev Log: [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file. Summary: Fix https://bugs.llvm.org/show_bug.cgi?id=34900. Reviewers: alexfh Reviewed By: a

[clang-tools-extra] r330327 - [clang-tidy] Fix unused-variable warning.

2018-04-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Apr 19 06:34:03 2018 New Revision: 330327 URL: http://llvm.org/viewvc/llvm-project?rev=330327&view=rev Log: [clang-tidy] Fix unused-variable warning. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyOptions.cpp Modified: clang-tools-extra/trunk/clang-tidy/ClangT

Re: [clang-tools-extra] r330245 - [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file.

2018-04-19 Thread Haojian Wu via cfe-commits
Thanks! I didn't see this warning when running check-clang-tools on my machine. Fixed in r330327. On Thu, Apr 19, 2018 at 7:39 AM, Mikael Holmén wrote: > Hi, > > > On 04/18/2018 10:54 AM, Haojian Wu via cfe-commits wrote: > >> Author: hokein >> Date: Wed Apr

[clang-tools-extra] r330835 - [clangd] Add "str()" method to SymbolID.

2018-04-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Apr 25 08:27:09 2018 New Revision: 330835 URL: http://llvm.org/viewvc/llvm-project?rev=330835&view=rev Log: [clangd] Add "str()" method to SymbolID. Summary: This is a convenient function when we try to get std::string of SymbolID. Reviewers: ioeric Subscribers: klimek,

[clang-tools-extra] r331168 - [clangd] Also use UTF-16 in index position.

2018-04-30 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Apr 30 04:40:02 2018 New Revision: 331168 URL: http://llvm.org/viewvc/llvm-project?rev=331168&view=rev Log: [clangd] Also use UTF-16 in index position. Reviewers: sammccall Subscribers: klimek, ilya-biryukov, ioeric, MaskRay, jkorous, cfe-commits Differential Revision:

[clang-tools-extra] r331189 - [clangd] Using index for GoToDefinition.

2018-04-30 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Apr 30 08:24:17 2018 New Revision: 331189 URL: http://llvm.org/viewvc/llvm-project?rev=331189&view=rev Log: [clangd] Using index for GoToDefinition. Summary: This patch adds index support for GoToDefinition -- when we don't get the definition from local AST, we query our

[clang-tools-extra] r373739 - [clangd] update the package-lock.json.

2019-10-04 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 4 05:35:16 2019 New Revision: 373739 URL: http://llvm.org/viewvc/llvm-project?rev=373739&view=rev Log: [clangd] update the package-lock.json. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package-lock.json Modified: clang-tools-extra/trunk/clang

r373748 - [clang-rename] Fix a crash when renaming a class without definition.

2019-10-04 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 4 07:09:31 2019 New Revision: 373748 URL: http://llvm.org/viewvc/llvm-project?rev=373748&view=rev Log: [clang-rename] Fix a crash when renaming a class without definition. Reviewers: sammccall Subscribers: cfe-commits Tags: #clang Differential Revision: https://re

[clang-tools-extra] r373889 - [clangd] Collect missing macro references.

2019-10-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 7 03:10:31 2019 New Revision: 373889 URL: http://llvm.org/viewvc/llvm-project?rev=373889&view=rev Log: [clangd] Collect missing macro references. Summary: Semantic highlghting is missing a few macro references. Reviewers: ilya-biryukov Subscribers: MaskRay, jkorous

[clang-tools-extra] r373897 - [clangd] Catch an unchecked "Expected" in HeaderSourceSwitch.

2019-10-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 7 04:37:25 2019 New Revision: 373897 URL: http://llvm.org/viewvc/llvm-project?rev=373897&view=rev Log: [clangd] Catch an unchecked "Expected" in HeaderSourceSwitch. Summary: Also fixes a potential user-after-scope issue of "Path". Reviewers: kadircet Subscribers: i

[clang-tools-extra] r375117 - [clangd] Use our own relation kind.

2019-10-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Oct 17 07:08:28 2019 New Revision: 375117 URL: http://llvm.org/viewvc/llvm-project?rev=375117&view=rev Log: [clangd] Use our own relation kind. Summary: Move the RelationKind from Serialization.h to Relation.h. This patch doesn't introduce any breaking changes. Reviewers

[clang-tools-extra] r375226 - [clangd] Report declaration references in findExplicitReferences.

2019-10-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 18 05:07:19 2019 New Revision: 375226 URL: http://llvm.org/viewvc/llvm-project?rev=375226&view=rev Log: [clangd] Report declaration references in findExplicitReferences. Reviewers: ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commit

[clang-tools-extra] bf71e4f - [clangd] Collect name references in the index.

2019-10-24 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2019-10-24T10:25:16+02:00 New Revision: bf71e4fe0a68085d29e9e883da1f17ae73945643 URL: https://github.com/llvm/llvm-project/commit/bf71e4fe0a68085d29e9e883da1f17ae73945643 DIFF: https://github.com/llvm/llvm-project/commit/bf71e4fe0a68085d29e9e883da1f17ae73945643.diff LO

[clang-tools-extra] 13fc899 - [clangd] Handle the missing constructor initializers in findExplicitReferences.

2019-10-24 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2019-10-24T10:38:37+02:00 New Revision: 13fc899cdecc85c944fc5b516a2bdfdd2f5f5903 URL: https://github.com/llvm/llvm-project/commit/13fc899cdecc85c944fc5b516a2bdfdd2f5f5903 DIFF: https://github.com/llvm/llvm-project/commit/13fc899cdecc85c944fc5b516a2bdfdd2f5f5903.diff LO

[clang] 3d9632a - [clang-rename] NFC, make getCanonicalSymbolDeclaration robust on nullptr input.

2019-10-25 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2019-10-25T14:33:04+02:00 New Revision: 3d9632a997fb3d59f0740bb00817b5c6115674cb URL: https://github.com/llvm/llvm-project/commit/3d9632a997fb3d59f0740bb00817b5c6115674cb DIFF: https://github.com/llvm/llvm-project/commit/3d9632a997fb3d59f0740bb00817b5c6115674cb.diff LO

[clang-tools-extra] 94cd2f0 - [clangd] Add missing highlights for using decls.

2019-10-29 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2019-10-29T09:49:42+01:00 New Revision: 94cd2f03032475e26767cf11eb81fefb00fc4dc0 URL: https://github.com/llvm/llvm-project/commit/94cd2f03032475e26767cf11eb81fefb00fc4dc0 DIFF: https://github.com/llvm/llvm-project/commit/94cd2f03032475e26767cf11eb81fefb00fc4dc0.diff LO

[clang-tools-extra] f821ab8 - [clangd] NFC, use URI::resolve to simplify the code.

2019-10-29 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2019-10-29T10:53:16+01:00 New Revision: f821ab807debdc973066ea43ac23173ef08dc2f5 URL: https://github.com/llvm/llvm-project/commit/f821ab807debdc973066ea43ac23173ef08dc2f5 DIFF: https://github.com/llvm/llvm-project/commit/f821ab807debdc973066ea43ac23173ef08dc2f5.diff LO

[clang-tools-extra] 80b0cdd - [clangd] Add a hidden tweak to dump symbol under the cursor.

2019-10-29 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2019-10-29T13:06:34+01:00 New Revision: 80b0cdde0ffc4ca59e99fed3dcb18412ff97568c URL: https://github.com/llvm/llvm-project/commit/80b0cdde0ffc4ca59e99fed3dcb18412ff97568c DIFF: https://github.com/llvm/llvm-project/commit/80b0cdde0ffc4ca59e99fed3dcb18412ff97568c.diff LO

[clang] c2c36c4 - [clang][index] Fix a crash for accessing a null field decl.

2020-05-21 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-05-21T09:47:36+02:00 New Revision: c2c36c4f4b69ade6d8610b1dc98ff9f02c94320d URL: https://github.com/llvm/llvm-project/commit/c2c36c4f4b69ade6d8610b1dc98ff9f02c94320d DIFF: https://github.com/llvm/llvm-project/commit/c2c36c4f4b69ade6d8610b1dc98ff9f02c94320d.diff LO

<    1   2   3   4   5   6   7   8   9   10   >