Author: hokein Date: Mon May 27 01:09:02 2019 New Revision: 361749 URL: http://llvm.org/viewvc/llvm-project?rev=361749&view=rev Log: [clang-tidy] Fix unused-variable warning after r361647.
Summary: A range-for was added in r361647 where the range variable was only used in an assertion. As a result, it warned for Release builds. This revision restructures the assertion to avoid the problem. Patch by Yitzhak Mandelbaum. Reviewers: ilya-biryukov Reviewed By: ilya-biryukov Subscribers: xazax.hun, cfe-commits Tags: #clang-tools-extra, #clang Differential Revision: https://reviews.llvm.org/D62412 Modified: clang-tools-extra/trunk/clang-tidy/utils/TransformerClangTidyCheck.cpp Modified: clang-tools-extra/trunk/clang-tidy/utils/TransformerClangTidyCheck.cpp URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/utils/TransformerClangTidyCheck.cpp?rev=361749&r1=361748&r2=361749&view=diff ============================================================================== --- clang-tools-extra/trunk/clang-tidy/utils/TransformerClangTidyCheck.cpp (original) +++ clang-tools-extra/trunk/clang-tidy/utils/TransformerClangTidyCheck.cpp Mon May 27 01:09:02 2019 @@ -7,21 +7,22 @@ //===----------------------------------------------------------------------===// #include "TransformerClangTidyCheck.h" +#include "llvm/ADT/STLExtras.h" namespace clang { namespace tidy { namespace utils { using tooling::RewriteRule; -TransformerClangTidyCheck::TransformerClangTidyCheck(tooling::RewriteRule R, +TransformerClangTidyCheck::TransformerClangTidyCheck(RewriteRule R, StringRef Name, ClangTidyContext *Context) : ClangTidyCheck(Name, Context), Rule(std::move(R)) { - for (const auto &Case : Rule.Cases) { - assert(Case.Explanation != nullptr && - "clang-tidy checks must have an explanation by default;" - " explicitly provide an empty explanation if none is desired"); - } + assert(llvm::all_of(Rule.Cases, [](const RewriteRule::Case &C) { + return C.Explanation != nullptr; + }) && + "clang-tidy checks must have an explanation by default;" + " explicitly provide an empty explanation if none is desired"); } void TransformerClangTidyCheck::registerMatchers( _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
