Author: hokein
Date: Fri Apr 1 02:57:30 2016
New Revision: 265117
URL: http://llvm.org/viewvc/llvm-project?rev=265117&view=rev
Log:
[clang-tidy] Don't delete unused parameter in class override method in
anonymous namespace.
Summary: Fixes PR26740.
Reviewers: alexfh
Subscribers: cfe-commits
D
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265117: [clang-tidy] Don't delete unused parameter in class
override method in… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D17926?vs=52332&id=52336#toc
Repository:
rL LLVM
hokein marked an inline comment as done.
hokein added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D17926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 52532.
hokein marked an inline comment as done.
hokein added a comment.
Address comments.
http://reviews.llvm.org/D18180
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/StaticDefiniti
hokein updated this revision to Diff 52533.
hokein marked 3 inline comments as done.
hokein added a comment.
Remove dump code.
http://reviews.llvm.org/D18180
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/StaticDefiniti
hokein updated this revision to Diff 52534.
hokein added a comment.
doc update.
http://reviews.llvm.org/D18180
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/StaticDefinitionInAnonymousNamespaceCheck.cpp
clang-tidy/re
hokein updated this revision to Diff 52549.
hokein marked 7 inline comments as done.
hokein added a comment.
Update.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain-confi
hokein updated this revision to Diff 52550.
hokein marked an inline comment as done.
hokein added a comment.
Remove redundant code.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Input
hokein marked an inline comment as done.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:329
@@ +328,3 @@
+for (const std::string& Check : EnabledChecks) {
+ for (const ClangTidyOptions::StringPair &CheckSource:
+ EffectiveOptions.CheckSources) {
hokein updated this revision to Diff 52552.
hokein marked 3 inline comments as done.
hokein added a comment.
Address comments.
http://reviews.llvm.org/D18180
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/StaticDefiniti
hokein added inline comments.
Comment at:
clang-tidy/readability/StaticDefinitionInAnonymousNamespaceCheck.cpp:52
@@ +51,3 @@
+ "anonymous namespace; static is redundant here")
+ << Def->getName();
+ Token Tok;
alexfh wrote:
>
hokein updated this revision to Diff 52661.
hokein added a comment.
Update
http://reviews.llvm.org/D18180
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/StaticDefinitionInAnonymousNamespaceCheck.cpp
clang-tidy/readabi
hokein marked 2 inline comments as done.
Comment at:
test/clang-tidy/readability-static-definition-in-anonymous-namespace.cpp:34
@@ +33,3 @@
+#define DEFINE_STATIC_VAR(x) static int x = 2
+DEFINE_STATIC_VAR(i);
+// CHECK-FIXES: {{^}}DEFINE_STATIC_VAR(i);
Oops. I
hokein updated this revision to Diff 52663.
hokein marked 2 inline comments as done.
hokein added a comment.
- fix inline code snippet in rst.
- Add check-message for macro in test code.
http://reviews.llvm.org/D18180
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/Reada
hokein added a comment.
Nice check! I like the check, it would be very helpful. (I have struggled with
this kind of bug before)
Comment at: clang-tidy/misc/MultipleStatementMacroCheck.cpp:33
@@ +32,3 @@
+
+namespace {
+
I think you can put this anonymous namesp
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL265384: [clang-tidy] Add a check to detect static
definitions in anonymous namespace. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D181
Author: hokein
Date: Tue Apr 5 06:42:08 2016
New Revision: 265384
URL: http://llvm.org/viewvc/llvm-project?rev=265384&view=rev
Log:
[clang-tidy] Add a check to detect static definitions in anonymous namespace.
Summary: Fixes PR26595
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revi
hokein updated this revision to Diff 52797.
hokein marked an inline comment as done.
hokein added a comment.
Correct the processing orders.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-ti
hokein updated this revision to Diff 52798.
hokein added a comment.
More comments.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain-config/.clang-tidy
test/clang-tidy/ex
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D18694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 53203.
hokein added a comment.
Use one vector storing checks details instead of three.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explai
hokein marked 5 inline comments as done.
hokein added a comment.
http://reviews.llvm.org/D18694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 53372.
hokein added a comment.
Keep track all the fields of ClangTidyOptions.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain-config/
hokein marked an inline comment as done.
hokein added a comment.
In http://reviews.llvm.org/D18694#396797, @alexfh wrote:
> I've just realized that the approach is artificially limited to just keeping
> track of the origin of the `Checks` option, while it could be easily extended
> to track the
hokein updated this revision to Diff 53373.
hokein added a comment.
Don't modify unrelevant code.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain-config/.clang-tidy
tes
hokein updated this revision to Diff 54042.
hokein added a comment.
Use a more elegant solution to track ClangTidyOptions.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain
hokein updated this revision to Diff 54043.
hokein added a comment.
Update.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain-config/.clang-tidy
test/clang-tidy/explain-c
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D18694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 54056.
hokein added a comment.
Export SourceType.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain-config/.clang-tidy
test/clang-tid
hokein added a subscriber: hokein.
hokein added a comment.
In http://reviews.llvm.org/D18584#404192, @michael_miller wrote:
> In http://reviews.llvm.org/D18584#403872, @alexfh wrote:
>
> > FYI, the check has started crashing after this patch. I'll try to provide a
> > minimal test case soon. The
hokein updated this revision to Diff 54168.
hokein added a comment.
Address code review comments.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain-config/.clang-tidy
tes
hokein marked 5 inline comments as done.
Comment at: clang-tidy/ClangTidyOptions.cpp:163
@@ +162,3 @@
+DefaultOptionsProvider::getRawOptions(llvm::StringRef FileName) {
+ std::vector Result;
+ Result.emplace_back(DefaultOptions, OptionsSourceTypeDefaultBinary);
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM with one nit.
Comment at: test/clang-tidy/readability-container-size-empty.cpp:44
@@ +43,3 @@
+;
+ // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: the 'empty' me
hokein accepted this revision.
hokein added a comment.
LGTM. Thanks.
http://reviews.llvm.org/D19270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266862: Fix a crash in
cppcoreguidelines-pro-type-member-init related to missing… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19270?vs=54210&id=54327#toc
Repository:
rL LL
Author: hokein
Date: Wed Apr 20 03:29:08 2016
New Revision: 266862
URL: http://llvm.org/viewvc/llvm-project?rev=266862&view=rev
Log:
Fix a crash in cppcoreguidelines-pro-type-member-init related to missing
constructor bodies.
Summary: Fixes a crash in cppcoreguidelines-pro-type-member-init when
Author: hokein
Date: Thu Apr 21 04:16:32 2016
New Revision: 266970
URL: http://llvm.org/viewvc/llvm-project?rev=266970&view=rev
Log:
Fix cast compiler warning message in include-fixer.
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D19323
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266970: Fix cast compiler warning message in include-fixer.
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19323?vs=54361&id=54473#toc
Repository:
rL LLVM
http://reviews.llv
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D19406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267155: [clang-tidy] fix link in Release Notes (authored by
hokein).
Changed prior to commit:
http://reviews.llvm.org/D19406?vs=54620&id=54649#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19406
Author: hokein
Date: Fri Apr 22 09:43:39 2016
New Revision: 267155
URL: http://llvm.org/viewvc/llvm-project?rev=267155&view=rev
Log:
[clang-tidy] fix link in Release Notes
Summary: This is intended to fix https://llvm.org/bugs/show_bug.cgi?id=27426
Patch by Kirill Bobyrev!
Reviewers: alexfh, Le
hokein added a comment.
In http://reviews.llvm.org/D19406#408893, @omtcyf0 wrote:
> @hokein
>
> Great, thanks!
>
> I'd be very grateful if you could land it!
Sure. Done.
Repository:
rL LLVM
http://reviews.llvm.org/D19406
___
cfe-commits mailin
hokein added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:49
@@ -47,1 +48,3 @@
CheckFactories.registerCheck("modernize-use-override");
+CheckFactories.registerCheck(
+"modernize-use-using");
You can put it in one-line,
hokein added a comment.
The patch looks almost good, some nits.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:1
@@ +1,2 @@
+
+//===--- MakeSmartPtrCheck.cpp -
clang-tidy===//
Extra blank line.
Comment a
hokein added a comment.
@michael_miller
You fixing is not completed. The crash still happens, the test case see
https://llvm.org/bugs/show_bug.cgi?id=27419.
Could you please take a look on it? Thanks very much.
Repository:
rL LLVM
http://reviews.llvm.org/D19270
_
hokein added inline comments.
Comment at: test/clang-tidy/modernize-make-shared.cpp:81
@@ +80,3 @@
+
+ std::shared_ptr R(new int());
+
Prazek wrote:
> hokein wrote:
> > Why can't this case convert to `std::shared_ptr R =
> > std::make_shared(new int())`?
> You
hokein updated this revision to Diff 54996.
hokein marked an inline comment as done.
hokein added a comment.
- VS2013 doesn't support constexpr.
- Don't make test read external .clang-tidy file.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOption
hokein updated this revision to Diff 55001.
hokein marked 8 inline comments as done.
hokein added a comment.
Address comments.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/exp
hokein added inline comments.
Comment at: clang-tidy/ClangTidyOptions.cpp:235
@@ +234,3 @@
+if (Iter != CachedOptions.end()) {
+ RawOptions.push_back(Iter->second);
+ break;
alexfh wrote:
> This seems to be changing the caching logic. Consider this d
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D18694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 55003.
hokein marked 3 inline comments as done.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D19482
Files:
include-fixer/CMakeLists.txt
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymb
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D19482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D20519
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cpp
==
hokein added inline comments.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:47
@@ +46,3 @@
+ return;
+// Ignores using-declarations defined in function definitions to avoid
+// arguement-dependent lookup.
alexfh wrote:
> I don't think using de
hokein added a subscriber: hokein.
Comment at: clang-tidy/llvm/HeaderGuardCheck.h:19
@@ -18,3 +18,3 @@
/// Finds and fixes header guards that do not adhere to LLVM style.
class LLVMHeaderGuardCheck : public utils::HeaderGuardCheck {
You should add a document f
hokein added inline comments.
Comment at: include-fixer/find-stl-symbols/STLSymbolsFinder.h:25
@@ +24,3 @@
+///
+/// To decide which symbols can be #include'd from each headear, we run
+/// FindSTLSymbolsAction on each header to retrieve all symbols in the
s/heade
hokein added inline comments.
Comment at: clang-tidy/llvm/HeaderGuardCheck.h:19
@@ -18,3 +18,3 @@
/// Finds and fixes header guards that do not adhere to LLVM style.
class LLVMHeaderGuardCheck : public utils::HeaderGuardCheck {
madsravn wrote:
> hokein wrote:
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D20581
Files:
include-fixer/IncludeFixer.cpp
Index: include-fixer/IncludeFixer.cpp
===
--- include-fix
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added subscribers: ioeric, cfe-commits.
Some changes in the patch:
* Add two commandline flags in clang-include-fixer.
* Introduce a IncludeFixerContext for the queried symbol.
* Pull out CreateReplacementsForHeader.
http://r
hokein added a comment.
Oh, sorry, I miss two separate commits here. This patch should not be ready
for review. I need to rebase it after commit http://reviews.llvm.org/D20581.
http://reviews.llvm.org/D20621
___
cfe-commits mailing list
cfe-commit
Author: hokein
Date: Wed May 25 09:06:12 2016
New Revision: 270700
URL: http://llvm.org/viewvc/llvm-project?rev=270700&view=rev
Log:
[include-fixer] Simplify the code since we won't handle multiple includes at
once.
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: http://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270700: [include-fixer] Simplify the code since we won't
handle multiple includes at… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20581?vs=58272&id=58412#toc
Repository:
r
hokein updated this revision to Diff 58415.
hokein added a comment.
Rebase
http://reviews.llvm.org/D20621
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/clang-include-fi
hokein updated this revision to Diff 58420.
hokein added a comment.
Fix a nit.
http://reviews.llvm.org/D20621
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/clang-includ
hokein updated this revision to Diff 58448.
hokein marked 6 inline comments as done.
hokein added a comment.
Update and address comments.
http://reviews.llvm.org/D20621
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.h
include-fixer/t
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
We should check whether a UsingDecl is defined in macros or in class
definition, not TargetDecls of the UsingDecl.
http://reviews.llvm.org/D20666
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.
hokein added inline comments.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:47
@@ +46,3 @@
+ return;
+// Ignores using-declarations defined in function definitions to avoid
+// arguement-dependent lookup.
alexfh wrote:
> hokein wrote:
> > alex
Author: hokein
Date: Mon May 30 02:42:22 2016
New Revision: 271199
URL: http://llvm.org/viewvc/llvm-project?rev=271199&view=rev
Log:
Fix a wrong check in misc-unused-using-decls
Summary:
We should check whether a UsingDecl is defined in macros or in class
definition, not TargetDecls of the UsingD
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271199: Fix a wrong check in misc-unused-using-decls
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20666?vs=58576&id=58937#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
hokein added a comment.
In http://reviews.llvm.org/D20621#439447, @bkramer wrote:
> Can you add some lit tests for the various command line modes
> clang-include-fixer has now. We can't reasonably test the vim integration but
> we can tests the bits it's composed of.
Done.
hokein updated this revision to Diff 58941.
hokein marked 9 inline comments as done.
hokein added a comment.
Address comments.
http://reviews.llvm.org/D20621
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIn
hokein updated this revision to Diff 58942.
hokein added a comment.
Remove unneeded headers.
http://reviews.llvm.org/D20621
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/too
hokein updated this revision to Diff 58955.
hokein marked an inline comment as done.
hokein added a comment.
Refactor createReplacementsForHeaders.
http://reviews.llvm.org/D20621
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.h
inclu
hokein updated this revision to Diff 58964.
hokein marked an inline comment as done.
hokein added a comment.
Use format::getStyle to get clang-format style.
http://reviews.llvm.org/D20621
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.
hokein added inline comments.
Comment at: include-fixer/IncludeFixer.h:80
@@ +79,3 @@
+unsigned FirstIncludeOffset=-1U,
+const clang::format::FormatStyle &Style=clang::format::getLLVMStyle());
+
Using a default argument in `Style` can simplify the code in
hokein updated this revision to Diff 59018.
hokein marked 2 inline comments as done.
hokein added a comment.
Fix code style.
http://reviews.llvm.org/D20621
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncl
hokein updated this revision to Diff 59026.
hokein added a comment.
Update a out-of-date comment.
http://reviews.llvm.org/D20621
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixe
hokein updated this revision to Diff 59028.
hokein added a comment.
Add -1U comment back.
http://reviews.llvm.org/D20621
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/c
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D20621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Tue May 31 04:31:51 2016
New Revision: 271258
URL: http://llvm.org/viewvc/llvm-project?rev=271258&view=rev
Log:
[include-fixer] Create a mode in vim integration to show multiple potential
headers.
Summary:
Some changes in the patch:
* Add two commandline flags in clang-incl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271258: [include-fixer] Create a mode in vim integration to
show multiple potential… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20621?vs=59028&id=59030#toc
Repository:
rL
hokein added a comment.
In http://reviews.llvm.org/D20621#444050, @bkramer wrote:
> LG. Can't wait to use it myself :)
Currently, the header is only inserted at the first line of the file because we
don't output the FirstIncludeOffset to py script. A follow-up patch will come
soon.
Reposito
Author: hokein
Date: Tue May 31 05:06:12 2016
New Revision: 271261
URL: http://llvm.org/viewvc/llvm-project?rev=271261&view=rev
Log:
[include-fixer] Add missing dependency.
Modified:
clang-tools-extra/trunk/include-fixer/tool/CMakeLists.txt
Modified: clang-tools-extra/trunk/include-fixer/too
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
* Abstract the DB setting code to a function.
* Remove the unused FallbackStyle.
http://reviews.llvm.org/D20808
Files:
include-fixer/IncludeFixer.cpp
include-fixer/tool/ClangIncludeFixer.c
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
Also some misc tweaks.
http://reviews.llvm.org/D20809
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/t
hokein updated this revision to Diff 59042.
hokein added a comment.
Rebase
http://reviews.llvm.org/D20809
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/clang-include-fixer.py
Index: include-fixer/to
Author: hokein
Date: Tue May 31 08:23:00 2016
New Revision: 271273
URL: http://llvm.org/viewvc/llvm-project?rev=271273&view=rev
Log:
[include-fixer] Code cleanup.
Summary:
* Abstract the DB setting code to a function.
* Remove the unused FallbackStyle.
Reviewers: bkramer
Subscribers: cfe-commit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271273: [include-fixer] Code cleanup. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20808?vs=59038&id=59052#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20808
Files:
hokein added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:29
@@ -28,3 +28,3 @@
class Action;
The forward declaration can be removed too.
Repository:
rL LLVM
http://reviews.llvm.org/D20816
___
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
And some improvements:
* Show better error messages on unfound symbols.
* Fix a typo.
http://reviews.llvm.org/D20827
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext
hokein updated this revision to Diff 59100.
hokein added a comment.
Remove unused code.
http://reviews.llvm.org/D20827
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/clang-include-fixer.py
test/incl
hokein abandoned this revision.
hokein added a comment.
Abandon this in favor of http://reviews.llvm.org/D20827.
http://reviews.llvm.org/D20809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
hokein updated this revision to Diff 59183.
hokein added a comment.
Get rid of yaml dependency, using json module.
http://reviews.llvm.org/D20827
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/clang-i
hokein marked 2 inline comments as done.
hokein added a comment.
http://reviews.llvm.org/D20827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 59184.
hokein added a comment.
Show error message when clang-include-fixer died with a fatal error.
http://reviews.llvm.org/D20827
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
incl
hokein updated this revision to Diff 59185.
hokein added a comment.
Use llvm::yaml::escape to escape double quote.
http://reviews.llvm.org/D20827
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/clang-i
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D20827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D20827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 59187.
hokein added a comment.
Always escape headers.
http://reviews.llvm.org/D20827
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/clang-include-fixer.py
test/i
Author: hokein
Date: Wed Jun 1 06:43:10 2016
New Revision: 271382
URL: http://llvm.org/viewvc/llvm-project?rev=271382&view=rev
Log:
[include-fixer] Use YAML format in -output-headers and -insert-header mode.
Summary:
And some improvements:
* Show better error messages on unfound symbols.
* Fix a
1801 - 1900 of 3165 matches
Mail list logo
