hokein added inline comments. ================ Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:47 @@ +46,3 @@ + return; + // Ignores using-declarations defined in function definitions to avoid + // arguement-dependent lookup. ---------------- alexfh wrote: > hokein wrote: > > alexfh wrote: > > > I don't think using declarations in functions are inherently related to > > > ADL. This check doesn't seem like a useful heuristic. > > Yeah, the current work around is only to ignore all using-decls in function > > context which is not perfect. I didn't find out a better way. > If we're talking about this pattern: > > using std::swap; > ... > ::ns::T x, y; > swap(x, y); // ::ns::swap() is used > > then for each function name resolved using ADL, we can find all using > declarations for the same name in different namespaces and mark them used. > WDYT? Great, this idea looks good to me. Will make the change.
http://reviews.llvm.org/D20519 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
