[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

hans added a comment. In D88680#2308601 , @zahen wrote: > This patch doesn't need a test case outside of the one that @rnk requested to > make sure that the flag flows from the clang-cl driver appropriately. > `pch-instantiate-templates` as authored doe

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

hans added inline comments. Comment at: clang/test/Driver/pch-instantiate-templates.c:2 +// CL driver test cases +// RUN: %clang_cl -### /Yc /Fpfoo.pch /Fofoo.obj %s 2>&1 | FileCheck --check-prefix=CLANG_CL_YC %s +// RUN: %clang -### --driver-mode=cl /Yc /Fpfoo.pch /Fofoo.obj %s

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66e4f0719876: Add ability to turn off -fpch-instantiate-templates in clang-cl (authored by shivanshu3, committed by hans). Repository: rG LLVM Gi

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

hans added a comment. I've committed this as 66e4f07198761bbb4dcd55235024c1081ed15c75 so it has a chance to make it into the 11.0.0 release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

hans added a comment. In D88680#2314415 , @hans wrote: > I've committed this as 66e4f07198761bbb4dcd55235024c1081ed15c75 > so it > has a chance to make it into the 11.0.0 release. Pus

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

hans added a comment. In D88831#2316453 , @lebedev.ri wrote: > @hans it would be nice if this could make it into the release, > removing stuff is usually a pretty safe thing to do :) I think it's too late for this release, sorry. I also don't see any part

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

hans added a comment. In D88949#2319392 , @yaxunl wrote: > I can help you commit it to trunk. For cherrypick to release branch, we may > need help of @hans It's most likely too late for 11.0.0, but I will put it on my list of 11.0.1 candidates. Reposi

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

hans added a comment. We're seeing the tests for this fail in Chromium's Clang builds: https://bugs.chromium.org/p/chromium/issues/detail?id=1137737 I'll try increasing the test's timeout for now and see if that helps. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D89309: [ThinLTO] In documentation, mention possible values for concurrency flags

hans added a comment. Thanks for documenting these! I wonder if including the "CPU sockets" part is more confusing than helpful (especially if the reader doesn't know about CPU sockets). The sockets don't really matter here anyway. Sometimes the term "physical core" is used in relation to hype

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

hans added a comment. The longer timeout didn't help :( I'm not sure what's different about the machine where this is failing. Maybe it's some filesystem issue due to being a VM? Any ideas for good printfs or similar that could be added to figure out exactly what part is failing? Repository:

[PATCH] D92028: Fix driver test from e16c0a9a689719

hans accepted this revision. hans added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/darwin-ld-demangle-lld.c:11 +// RUN: | FileCheck %s +// CHECK: "-demangle" nit: most tests have a blank line between the RUN

[PATCH] D92037: clang: Pass -platform-version to new MachO LLD

hans accepted this revision. hans added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/ToolChain.h:334 /// LLD's supported flags, error output, etc. - std::string GetLinkerPath(bool *LinkerIsLLD = nullptr) const; + //

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

hans added a comment. Seems reasonable to me, but someone who actually knows clang-scan-deps should take a look too. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:471 +#ifdef _WIN32 +const char *NullFile = "nul"; +#else these string constan

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Seems like a good idea to me. From the change description: > This allows us to use its value everywhere, rather than just llvm. Do you mean rather than just clang? Repository: rG LLVM Github

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

hans added a comment. In D85808#2424908 , @jansvoboda11 wrote: > I'm seeing build failures that might be triggered by this patch: > http://lab.llvm.org:8011/#/builders/109/builds/3714 It seems to affect a lot of the main bots (random example: http://la

[PATCH] D92357: clang/darwin: Don't use response files with ld64

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92357/new/ https://reviews.llvm.org/D92357 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D91904: [mac/arm] Fix rtti codegen tests when running on an arm mac

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91904/new/ https://reviews.llvm.org/D91904 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

hans added a comment. This broke Chromium's build, causing it to fail with "Cannot pop empty stack!" from one of the backend passes. That specific error is probably a perhaps a previously existing problem, but I think it was triggered by hot-cold-splitting getting enabled by this pass. This was

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

hans added inline comments. Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + akyrtzi wrote: > Hi Anastasia, apologies for not catching this earlier, but libclang is > intended to keep a stable ABI and changing the e

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

hans added a subscriber: tstellar. hans added inline comments. Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + Anastasia wrote: > hans wrote: > > akyrtzi wrote: > > > Hi Anastasia, apologies for not catching this ea

[PATCH] D90291: [clangd] Add lit tests for remote index

hans added inline comments. Comment at: clang-tools-extra/clangd/test/lit.site.cfg.py.in:11 config.host_triple = "@LLVM_HOST_TRIPLE@" +config.python_executable = "@Python3_EXECUTABLE@" Could this use `PYTHON_EXECUTABLE` instead? I see other tests using that, a

[PATCH] D90291: [clangd] Add lit tests for remote index

hans added inline comments. Comment at: clang-tools-extra/clangd/test/lit.site.cfg.py.in:11 config.host_triple = "@LLVM_HOST_TRIPLE@" +config.python_executable = "@Python3_EXECUTABLE@" kadircet wrote: > hans wrote: > > Could this use `PYTHON_EXECUTABLE` instea

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

hans added a comment. Interesting, I hadn't seen __identifier before. It seems like a pretty esoteric feature. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1817 +else if (Tok.is(tok::string_literal)) { + const StringRef StrData(Tok.getLiteralData() + 1, Tok.getLengt

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100252/new/ https://reviews.llvm.org/D100252 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

hans added a comment. Looking good overall, just a few nits. Out of curiosity, where would one run into this? Does MS use this in any library headers or such? Comment at: clang/lib/Parse/ParseDeclCXX.cpp:3314 if (getLangOpts().CPlusPlus && Tok.is(tok::identifier)) { -V

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5b3843f8d93: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete" (authored by super_concat, committed by hans). Repos

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

hans added a comment. Apologies for the slow reply, it was a long weekend here. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:3314 if (getLangOpts().CPlusPlus && Tok.is(tok::identifier)) { -VirtSpecifiers::Specifier Specifier = isCXX11VirtSpecifier(Tok); -assert((Spec

[PATCH] D103155: [clang-cl] Add driver support for /std:c++20 and bump /std:c++latest (PR50465)

hans created this revision. hans added reviewers: thakis, rnk. Herald added a subscriber: dang. hans requested review of this revision. Herald added a project: clang. VS 2019 16.11 (just released in Preview) is adding support for the /std:c++20 option and bumping /std:c++latest to "post-c++20". T

[PATCH] D103155: [clang-cl] Add driver support for /std:c++20 and bump /std:c++latest (PR50465)

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8f75d497daa: [clang-cl] Add driver support for /std:c++20 and bump /std:c++latest (PR50465) (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/ https://reviews.llvm.org/D102517 __

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

hans added a comment. We tried it, and the warning is still firing in a similar (but not exactly the same) way: In file included from ../../content/browser/accessibility/browser_accessibility_manager_win.cc:19: In file included from ../..\content/browser/renderer_host/legacy_render_widget_

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG818338add774: [clang] Add support for the "abstract" contextual keyword of MSVC (authored by AbbasSabra, committed by hans). Repository: rG LLVM

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

hans added a comment. Pushed as http://github.com/llvm/llvm-project/commit/818338add77411f5e9713247ea66142f332ef350 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/ https://reviews.llvm.org/D102517 ___

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG116179c2ee52: Re-commit [clang] Add support for the "abstract" con

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

hans added a comment. In D102517#2789593 , @AbbasSabra wrote: > In D102517#2789450 , @goncharov > wrote: > >> Sorry, had to revert it as this fails under sanitizer : >> https://lab.llvm.org/buildbot/#/builders/

[PATCH] D94355: [SimplifyCFG] Add relative switch lookup tables

hans added inline comments. Comment at: clang/test/CodeGen/switch-to-lookup-table.c:2 +// Check switch to lookup optimization in fPIC and fno-PIC mode +// RUN: %clang_cc1 %s -triple=aarch64-unknown-fuchsia -O2 -fno-PIC -S -emit-llvm -o - | FileCheck %s --check-prefix=CHECK --che

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

hans added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:75 + for (llvm::sys::fs::directory_iterator DirIt(Directory, EC), DirEnd; + DirIt != DirEnd && !EC; DirIt.increment(EC)) { +if (!llvm::sys::fs::is_directory(DirIt->path())) fo

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm (with test nit) Comment at: clang/test/Driver/cl-sysroot.cpp:10 + +// CHECK: "-internal-isystem" "[[ROOT]]/VC/Tools/MSVC/14.26.28801/include" +// CHECK: "-internal-isystem"

[PATCH] D95673: [dllimport] Honor always_inline when deciding whether a dllimport function should be available for inlining (PR48925)

hans created this revision. hans added a reviewer: rnk. hans requested review of this revision. Herald added a project: clang. Normally, Clang will not make dllimport functions available for inlining if they reference non-imported symbols, as this can lead to confusing link errors. But if the fu

[PATCH] D95673: [dllimport] Honor always_inline when deciding whether a dllimport function should be available for inlining (PR48925)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0479c53b6c52: [dllimport] Honor always_inline when deciding whether a dllimport function… (authored by hans). Repository: rG LLVM Github Monorepo

[PATCH] D95876: [clang-cl] Remove the /fallback option

hans created this revision. hans added reviewers: rnk, thakis. Herald added a subscriber: dang. Herald added a reviewer: jansvoboda11. hans requested review of this revision. Herald added a project: clang. As discussed in https://lists.llvm.org/pipermail/cfe-dev/2021-January/067524.html It doesn

[PATCH] D95876: [clang-cl] Remove the /fallback option

hans updated this revision to Diff 321080. hans marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95876/new/ https://reviews.llvm.org/D95876 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticDriverKinds.t

[PATCH] D95876: [clang-cl] Remove the /fallback option

hans added a comment. Please take another look. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:669 const InputInfoList &Inputs, const ArgList &Args, const char *LinkingOutput) const { ArgStringList CmdArgs; thakis wrote: > Doesn't this whole func

[PATCH] D95876: [clang-cl] Remove the /fallback option

This revision was automatically updated to reflect the committed changes. Closed by commit rG6625680a581c: [clang-cl] Remove the /fallback option (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95876/new/ https://reviews.llvm.org/D

[PATCH] D96016: Release notes: Deprecate the clang-cl /fallback flag (patch for the release/12.x branch)

hans created this revision. hans added a reviewer: tstellar. hans requested review of this revision. Herald added a project: clang. As discussed in https://lists.llvm.org/pipermail/cfe-dev/2021-January/067524.html The flag has been removed on the main branch in D95876

[PATCH] D96016: Release notes: Deprecate the clang-cl /fallback flag (patch for the release/12.x branch)

hans closed this revision. hans added a comment. Pushed as 72f12467ded52160d52025e13a6217f00fe25f68 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96016/new/ https://reviews.llvm

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. In D109828#3002495 , @thakis wrote: > In D109828#3002114 , @hans wrote: > >> The /winsysroot part makes sense to

[PATCH] D110458: [clang] Put original flags on 'Driver args:' crash report line

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Driver/Driver.cpp:1220 + for (const auto *A : Args) { +while (A->getAlias()) + A = A->getAlias(); Could put a comment here a

[PATCH] D110635: [clang] Let PPCallbacks::PragmaWarning() pass specifier as enum instead of string

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110635/new/ https://reviews.llvm.org/D110635 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

hans added a comment. Nice! Comment at: clang/lib/Basic/CLWarnings.cpp:17 + switch (CLWarningID) { + case 4005: return "macro-redefined"; + case 4018: return "sign-compare"; Would it be possible to reference the DiagGroup symbolically here somehow instead o

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Nice! lgtm Comment at: clang/include/clang/Basic/CLWarnings.h:18 +enum class Group; +}; + clang-tidy's comment about the extra semicolon seems valid CHANGES SI

[PATCH] D110770: [clang] Remove duplication in types::getCompilationPhases()

hans added inline comments. Comment at: clang/include/clang/Driver/Phases.h:25 IfsMerge, -LastPhase = IfsMerge, }; Any reason not to keep the LastPhase alias? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110770/new/ https://reviews.llvm.or

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, thanks for digging into this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110783/new/ https://reviews.llvm.org/D110783 ___ cfe-commits

[PATCH] D110770: [clang] Remove duplication in types::getCompilationPhases()

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Driver/Phases.h:25 IfsMerge, -LastPhase = IfsMerge, }; thakis wrote: > hans wrote: > > Any reason not to keep th

[PATCH] D94355: [Passes] Add relative lookup table generator pass

hans added a comment. Thanks for pushing this forward! I think this will be a nice transformation once all the details are worked out. Comment at: clang/test/CodeGen/switch-to-lookup-table.c:2 +// Check switch to lookup optimization in fPIC and fno-PIC mode +// RUN: %clang_cc1

[PATCH] D96777: [clang][driver] Set the input type to Fortran when reading from stdin

hans added a comment. In D96777#2578473 , @awarzynski wrote: > In D96777#2578153 , @SouraVX wrote: > >> Thanks! for the patch. >> This code touches some of the `clang` part, Anyway changes are pretty >> self-explan

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

hans added inline comments. Comment at: clang/test/SemaCXX/warn-unused-private-field.cpp:7 + +class EqDefaultCompare { + int unused_; The test case feels a little strange to me, I mean the member variable is still pretty unused even though I suppose the compari

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

hans added subscribers: rjmccall, hans. hans added a comment. We're seeing new build errors in Chromium after this (http://crbug.com/1219457). Here's a reduced example: $ cat /tmp/a.mm #include struct Callback { // Move-only! Callback(const Callback&) = delete; Callback& op

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

hans added a comment. > @hans: FYI, that looks related to the immediately following D99005 > , not D99696 > specifically. No, my test case passes at 0d9e8f5f4b68252c6caa1ef81a30777b2f5d7242

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

hans added a comment. Since it seems more discussion is needed here, I've reverted in c60dd3b2626a4d9eefd9f82f9a406b0d28d3fd72 . Since they were hard to tease apart, the revert is for both D99696

[PATCH] D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003)

hans created this revision. hans added a reviewer: thakis. Herald added a subscriber: dang. hans requested review of this revision. Herald added a project: clang. This patch does three things: - Map the /external:I flag to -isystem - Add support for the /external:env: flag which reads system inc

[PATCH] D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003)

hans updated this revision to Diff 352695. hans marked 2 inline comments as done. hans added a comment. Herald added a subscriber: ormris. More tests, add help text for command-line options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104387/new/ https://reviews.llvm.org/D104387 File

[PATCH] D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003)

hans added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:1255 +} + } + thakis wrote: > `/external:env` should happen after winsysroot I think. sysroots try to make > builds hermetic and env vars defeat that. > > I.e. this flag is more l

[PATCH] D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003)

hans added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:1273 + +if (include_var) { + StringRef(*include_var) thakis wrote: > Why not keep the definition of include_var in the if condition like it was on > the rhs? (And do it for ext

[PATCH] D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003)

This revision was automatically updated to reflect the committed changes. Closed by commit rG3063a5472266: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support… (authored by hans). Changed prior to commit: https://reviews.llvm.org/D104387?vs=352695&id=353354#toc Reposi

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78d404a11dd3: [clang][c++20] Fix false warning for unused private fields when a class has… (authored by Alexandru Octavian Butiu

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

hans added a comment. In D102186#2832900 , @predator5047 wrote: > @hans Can you commit on my behalf? > Email: Alexandru Octavian Butiu alexandru.octavian.butiu at gmail.com Sure! Pushed as https://github.com/llvm/llvm-project/commit/78d404a11dd33c8349

[PATCH] D104770: Add support for #pragma system_header with -fms-extensions

hans created this revision. hans added a reviewer: thakis. hans requested review of this revision. Herald added a project: clang. Clang already supports the pragma prefixed by "GCC" or "clang". MSVC has more recently added support for the pragma, but without any prefix; see https://devblogs.mic

[PATCH] D104770: Add support for #pragma system_header with -fms-extensions

hans added inline comments. Comment at: clang/test/Lexer/pragma-operators.cpp:22 #define pragma_L _Pragma(L"GCC diagnostic push") -#define pragma_u8 _Pragma(u8"system_header") +#define pragma_u8 _Pragma(u8"pack(1)") #define pragma_u _Pragma(u"GCC diagnostic pop") --

[PATCH] D104770: Add support for #pragma system_header with -fms-extensions

hans added a comment. In D104770#2835596 , @aaron.ballman wrote: > LGTM, though you could add a test that `#pragma system_header` gives a > diagnostic outside of `-fms-extensions` mode if you think that's valuable. Thanks! Yes, I'll do that, and I'll a

[PATCH] D104770: Add support for #pragma system_header with -fms-extensions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24037c37b6c4: Add support for #pragma system_header with -fms-extensions (authored by hans). Changed prior to commit: https://reviews.llvm.org/D10

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

hans added a comment. In D74436#2917395 , @mibintc wrote: > In D74436#2917357 , @haowei wrote: > >> We are seeing float related unit tests failing in Fuchsia after this patch. >> What flags should we add to our bui

[PATCH] D106790: prfchwintrin.h: Make _m_prefetchw take a pointer to volatile (PR49124)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12dc13b73cf8: prfchwintrin.h: Make _m_prefetchw take a pointer to volatile (PR49124) (authored by hans). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

hans added a subscriber: tstellar. hans added a comment. Also +@tstellar since I believe this went in before the 13 branch point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436

[PATCH] D21113: Add support for case-insensitive header lookup

hans added a comment. In D21113#2859165 , @Yoav wrote: > Any progress with this? @hans its been stale for a while now and this feature > is crucial No progress, I'm afraid. I'm not working on this, so someone would have to take over the patch to push it

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, just some nits. Comment at: clang/lib/Analysis/CFG.cpp:485 - // This can point either to a try or a __try block. The frontend forbids - // mixing both kinds in one func

[PATCH] D112542: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Nice! Do you think the ObjCAtTryStmt::Create and CreateEmpty methods could be simplified by using totalSizeToAlloc()? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112542/new/ https://r

[PATCH] D112543: [clang] Add range accessor for ObjCAtTryStmt catch_stmts and use it

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang/include/clang/AST/StmtObjC.h:279 + catch_stmt_iterator catch_stmts_end() { +return getStmts() + 1 + NumCatchStmts; + } i might have

[PATCH] D112704: Re-instate -Wweak-template-vtables as a no-op flag

hans created this revision. hans added reviewers: thakis, dblaikie. hans requested review of this revision. Herald added a project: clang. Follow-up to https://github.com/llvm/llvm-project/commit/8c136805242014b6ad9ff1afcac9d7f4a18bec3f to allow a less abrupt migration for users. Repository:

[PATCH] D112704: Re-instate -Wweak-template-vtables as a no-op flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d2765e9949f: Re-instate -Wweak-template-vtables as a no-op flag (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112704/new/ https://revie

[PATCH] D97695: [clang-cl] make -f(no-)ident a CoreOption

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Probably worth explaining in the description why this is useful from clang-cl (it being on by default, and we'd like a nice way to turn it off). CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D97693: [libclang] Remove LIBCLANG_INCLUDE_CLANG_TOOLS_EXTRA

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97693/new/ https://reviews.llvm.org/D97693 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

hans added a comment. The preprocessed source is attached to this comment: https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c26 good.s and bad.s are here: https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c28 And this shows the problematic difference between them: htt

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

hans added a comment. Reverted in https://github.com/llvm/llvm-project/commit/0a5dd067181dac2a8882a139ea3bd19bdea5fa44 until this can be fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

hans added a comment. In D92808#2601408 , @fhahn wrote: > In D92808#2600245 , @hans wrote: > >> Reverted in >> https://github.com/llvm/llvm-project/commit/0a5dd067181dac2a8882a139ea3bd19bdea5fa44 >> until this can

[PATCH] D98156: [clang/mac] Accept -why_load and make -whyload an alias for it

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm nit in the change description > So -why_load is the spelling preferred by the linker and -whyload and old second "and" -> "an" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98156/n

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

hans added a comment. We're seeing a diagnostic change in Chromium which looks funny. For the following code (span<> is our own class): int WontCompile() { const std::vector v; span s = make_span(v); } the diagnostic changes from: fatal error: no viable conversion from 'span' to

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

hans added a comment. > I am not sure how to reproduce this. Attaching preprocessed source. With Clang built at 508aa4fe0c82b3b409e2e194d591ee6d665c8623 it reproduces for me like this: $ clang++ -c /tmp/a.ii ../../base/containers/span_unittest.cc:11:13: error: no viable conversion from 'sp

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

hans added a comment. Sorry, the attached file is here: F20424768: a.ii Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 __

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Headers/x86gprintrin.h:29 #define __SSC_MARK(Tag) \ - __asm__ __volatile__("movl %%ebx, %%eax

[PATCH] D114660: [clang] Fix -Wreturn-type false positive in @try statements

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114660/new/ https://reviews.llvm.org/D114660 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D114867: [clang-cl] Set _MSVC_LANG to 202002L with /std:c++20

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114867/new/ https://reviews.llvm.org/D114867 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D114952: [clang-cl] Define _MSVC_LANG for -std=c++2b

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114952/new/ https://reviews.llvm.org/D114952 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

hans added a comment. In D135220#3862893 , @dexonsmith wrote: > In D135220#3862058 , @hans wrote: > >> The build system folks replied saying they're not using symlinks, but hard >> links for compiler inputs. Dro

[PATCH] D136700: clang: Add a cmake toggle to disable libclang's libxml2 dependency

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136700/new/ https://reviews.llvm.org/D136700 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

hans added inline comments. Comment at: clang/include/clang/Driver/Options.td:1253 +Flags<[NoXarchOption, CC1Option]>, Group, +HelpText<"Use profi to infer block and edge counts.">; def fno_profile_sample_accurate : Flag<["-"], "fno-profile-sample-accurate">, ---

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

hans added inline comments. Comment at: clang/include/clang/Driver/Options.td:1254 +HelpText<"Use profi to infer block and edge counts.">, +DocBrief<[{Profi - a flow-based profile inference algorithm is an extended + and significantly re-engineered classic M

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

hans added a comment. Relatedly, we ran into a problem with `clang-cl /showIncludes` not including all files in its output when they're linked: https://github.com/llvm/llvm-project/issues/58726 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135220/

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

hans added inline comments. Comment at: clang/include/clang/Driver/Options.td:1254 +HelpText<"Use profi to infer block and edge counts.">, +DocBrief<[{Profi - a flow-based profile inference algorithm is an extended + and significantly re-engineered classic M

[PATCH] D132258: clang/apple: Infer simulator env from -mios-simulator-version-min flag

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm since it matches xcode clang For the commit message, perhaps the "(Xcode's clang already behaves like this," part should be moved further down, probably to just after "This patch makes it so

<    1   2   3   4   5   6   7   8   9   10   >