[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

hankadusikova created this revision. hankadusikova added a reviewer: clang. hankadusikova requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Removes this warning: template struct StdArray { T contents[N]; }; template struct A

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

hankadusikova updated this revision to Diff 335892. hankadusikova added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100057/new/ https://reviews.llvm.org/D100057 Files: clang/lib/Sema/SemaInit.cpp clang/test/SemaCXX/aggre

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

hankadusikova marked an inline comment as done. hankadusikova added a comment. In D100057#2674820 , @lebedev.ri wrote: > This patch says what it does, but not why it does what it does. > Did the pattern become idiomatic so that we now want to not warn?

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

hankadusikova updated this revision to Diff 335922. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100057/new/ https://reviews.llvm.org/D100057 Files: clang/lib/Sema/SemaInit.cpp clang/test/SemaCXX/aggregate-initialization.cpp Index: clang/test/SemaCXX/aggregate-initialization.cpp =

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

hankadusikova marked 3 inline comments as done. hankadusikova added a comment. In D100057#2675085 , @jfb wrote: > A few nits, but this is good otherwise! Having an aggregate with multiple (empty) bases initialised with nonempty {} is a hard error, hence

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

hankadusikova updated this revision to Diff 337067. hankadusikova marked 3 inline comments as done. hankadusikova added a comment. changes suggested by @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100057/new/ https://reviews.llvm.org/D1000