hankadusikova marked an inline comment as done.
hankadusikova added a comment.

In D100057#2674820 <https://reviews.llvm.org/D100057#2674820>, @lebedev.ri 
wrote:

> This patch says what it does, but not why it does what it does.
> Did the pattern become idiomatic so that we now want to not warn?

Yes, using inheritance for strong typing with aggregates is quite common 
pattern. I checked GCC / EDG / MSVC and neither of them is emitting warning in 
this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100057/new/

https://reviews.llvm.org/D100057

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D1000... Hana Dusíková via Phabricator via cfe-commits
    • [PATCH] ... Michael Schellenberger Costa via Phabricator via cfe-commits
    • [PATCH] ... Hana Dusíková via Phabricator via cfe-commits
    • [PATCH] ... Roman Lebedev via Phabricator via cfe-commits
    • [PATCH] ... Hana Dusíková via Phabricator via cfe-commits
    • [PATCH] ... JF Bastien via Phabricator via cfe-commits
    • [PATCH] ... Hana Dusíková via Phabricator via cfe-commits
    • [PATCH] ... Hana Dusíková via Phabricator via cfe-commits
    • [PATCH] ... Louis Dionne via Phabricator via cfe-commits
    • [PATCH] ... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] ... Hana Dusíková via Phabricator via cfe-commits
    • [PATCH] ... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] ... Aaron Ballman via Phabricator via cfe-commits

Reply via email to