[PATCH] D63878: [CTU] Add missing statistics

martong created this revision. martong added a reviewer: xazax.hun. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63878 Files: clang/lib/CrossTU/CrossTranslationUnit.

[PATCH] D63878: [CTU] Add missing statistics

This revision was automatically updated to reflect the committed changes. Closed by commit rL364630: [CTU] Add missing statistics (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D63878

[PATCH] D63920: [CTU] Add support for virtual functions

martong created this revision. martong added reviewers: Szelethus, xazax.hun. Herald added subscribers: cfe-commits, gamesh411, dkrupp, rnkovacs. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63920 Files: clang/lib/StaticAnalyzer/Core/CallEvent.

[PATCH] D63920: [CTU] Add support for virtual functions

martong marked an inline comment as done. martong added inline comments. Comment at: clang/test/Analysis/ctu-main.cpp:112 + // We cannot decide about the dynamic type. + clang_analyzer_eval(obj->fvcl(1) == 8); // expected-warning{{FALSE}} expected-warning{{TRUE}} + clang

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

martong added a comment. @a_sidorin Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63603/new/ https://reviews.llvm.org/D63603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr

martong updated this revision to Diff 207063. martong marked 4 inline comments as done. martong added a comment. - Add further checks for the DeclarationName overload Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62329/new/ https://reviews.llvm.org

[PATCH] D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr

martong marked 8 inline comments as done. martong added inline comments. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:124 + case DeclarationName::CXXConversionFunctionName: +return true; + a_sidorin wrote: > Should we check the equivalence of getCX

[PATCH] D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr

martong added a comment. Alexei, thank you very much for the review, you caught quite a few missing things! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62329/new/ https://reviews.llvm.org/D62329 ___

[PATCH] D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter

martong marked 2 inline comments as done. martong added a comment. In D62131#1517634 , @a_sidorin wrote: > Hi Gabor, > Could you provide an example of an import sequence leading to this behavior? > It's hard for me to imagine such a situation. Alexei,

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

This revision was automatically updated to reflect the committed changes. Closed by commit rL364752: [ASTImporter] Propagate error from ImportDeclContext (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

martong added a comment. @shafik I've been looking for any lldb regression in our Mac machine, could not find any. Now I am looking at http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ . I don't expect regression because here we changed logic about the error handling only, so I'd expec

[PATCH] D62375: [ASTImporter] Mark erroneous nodes in from ctx

martong marked 3 inline comments as done. martong added a comment. > Thank you for the explanation. I got the idea of this patch anyway, but it > will be definitely useful for anyone digging into the code. Should we make it > a comment for ImportPathTy? Ok, I have added the explanation to `Impo

[PATCH] D62375: [ASTImporter] Mark erroneous nodes in from ctx

martong updated this revision to Diff 207288. martong marked an inline comment as done. martong added a comment. - Move ImportPathTy's funcitons in-class, add class comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62375/new/ https://reviews.ll

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

martong added a comment. Jenkins is green: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/29802/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63603/new/ https://reviews.llvm.org/D63603 ___ cfe-commits mail

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

martong added a comment. Comment at: clang/include/clang/AST/ASTImporter.h:331 +/// +/// \return the equivalent APValue in the "from" Constext or the import +/// error. typo: `Constext` -> `Context` Also, we return with the APValue in the "to" cont

[PATCH] D62375: [ASTImporter] Mark erroneous nodes in from ctx

This revision was automatically updated to reflect the committed changes. Closed by commit rL364771: [ASTImporter] Mark erroneous nodes in from ctx (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D62375: [ASTImporter] Mark erroneous nodes in from ctx

martong added a comment. @shafik I've been looking for any lldb regression in our Mac machine, could not find any. Now I am looking at http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ . I don't expect regression because here we changed logic about the error handling only, so I'd expec

[PATCH] D62375: [ASTImporter] Mark erroneous nodes in from ctx

martong added a comment. Jenkins is green: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/29809/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62375/new/ https://reviews.llvm.org/D62375 ___ cfe-commits mail

[PATCH] D62376: [ASTImporter] Mark erroneous nodes in shared st

This revision was automatically updated to reflect the committed changes. Closed by commit rL364785: [ASTImporter] Mark erroneous nodes in shared st (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D62376: [ASTImporter] Mark erroneous nodes in shared st

martong added a comment. @shafik I've been looking for any lldb regression in our Mac machine, could not find any. Now I am looking at http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ . I don't expect regression because here we changed logic about the error handling only, so I'd expec

[PATCH] D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr

martong updated this revision to Diff 207354. martong added a comment. - Handle ImplicitCastExpr. In Clang7 in the last two test cases we did not have any ImplicitCastExpr in the AST. With never Clang we have, so we must handle the cast expr too. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D62376: [ASTImporter] Mark erroneous nodes in shared st

martong added a comment. Jenkins had one unrelated failure at http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/29812/ Test Result (1 failure / +1) LLDB.Reproducer.TestGDBRemoteRepro.test After that the next build is green: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/2

[PATCH] D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL364889: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64073: [ASTImporter] Fix import of lambda in function param

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. The current import implementation fails to import t

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. The structural equivalence check reported false eq between lambda classes with diffe

[PATCH] D64078: [ASTImporter] Fix structural ineq of lambdas with different sloc

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Currently we do not differentiate lambda classes ba

[PATCH] D63920: [CTU] Add support for virtual functions

martong added a comment. In D63920#1566035 , @baloghadamsoftware wrote: > Try to set analyzer option `IPAMode` to something different from its default > value which is `dynamic-bifurcate` in the test file. Ok I set it to `ipa=inlining` and then we rece

[PATCH] D63920: [CTU] Add support for virtual functions

martong updated this revision to Diff 207738. martong added a comment. - Use -analyzer-config ipa=inlining in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63920/new/ https://reviews.llvm.org/D63920 Files: clang/lib/StaticAnalyzer/Core/

[PATCH] D59798: [analyzer] Add analyzer option to limit the number of imported TUs

martong accepted this revision. martong added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:297 +"for import when inlining functions during CTU analysis. " +"Lowe

[PATCH] D63920: [CTU] Add support for virtual functions

martong added a comment. In D63920#1568049 , @Szelethus wrote: > In D63920#1568031 , @martong wrote: > > > In D63920#1566035 , > > @baloghadamsoftware wrote: > > > > > Try t

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1182 + if (D1CXX->isLambda()) { +if (!D2CXX->isLambda()) a_sidorin wrote: > Should we return false if `D1CXX->isLambda()

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong updated this revision to Diff 207774. martong marked an inline comment as done. martong added a comment. - Add check for isLambda() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64075/new/ https://reviews.llvm.org/D64075 Files: clang/lib

[PATCH] D64073: [ASTImporter] Fix import of lambda in function param

martong marked 3 inline comments as done. martong added a comment. Thanks for the review Alexei! Comment at: clang/unittests/AST/ASTImporterTest.cpp:5103 + // count. + for (auto &D : ToL->decls()) { +(void)D; a_sidorin wrote: > Can we use std::distance in

[PATCH] D64073: [ASTImporter] Fix import of lambda in function param

martong updated this revision to Diff 207776. martong marked an inline comment as done. martong added a comment. - 'the ' -> 'the ' - Use std::distance() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64073/new/ https://reviews.llvm.org/D64073 Fil

[PATCH] D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr

martong marked 2 inline comments as done. martong added inline comments. Comment at: cfe/trunk/lib/AST/ASTStructuralEquivalence.cpp:173 +DE2->getQualifier()); + } else if (auto CastE1 = dyn_cast(E1)) { +auto *CastE2 = dyn_cast(E2); ---

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

martong added inline comments. Comment at: clang/include/clang/AST/ASTImporter.h:331 +/// +/// \return the equivalent APValue in the "from" Constext or the import +/// error. martong wrote: > typo: `Constext` -> `Context` > Also, we return with the AP

[PATCH] D62960: Add SVE opaque built-in types

martong added a comment. The ASTImporter and the test for it looks good to me, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62960/new/ https://reviews.llvm.org/D62960 ___ cfe-commits mailing list cfe-commits

[PATCH] D63920: [CTU] Add support for virtual functions

martong updated this revision to Diff 208002. martong added a comment. - Remove ipa mode from the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63920/new/ https://reviews.llvm.org/D63920 Files: clang/lib/StaticAnalyzer/Core/CallEvent.cpp

[PATCH] D63920: [CTU] Add support for virtual functions

martong added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63920/new/ https://reviews.llvm.org/D63920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D63920: [CTU] Add support for virtual functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL365133: [CTU] Add support for virtual functions (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. We falsely state inequivalence if the template parameter is a qualified/nonquialifie

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8503 +llvm::Expected ASTImporter::Import(const APValue &FromValue) { + APValue Result; Tyker wrote: > martong wrote: > > Tyker wrote: > > > martong wrote: > > > > Looks okay, but could we

[PATCH] D64073: [ASTImporter] Fix import of lambda in function param

This revision was automatically updated to reflect the committed changes. Closed by commit rL365315: [ASTImporter] Fix import of lambda in function param (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong updated this revision to Diff 208727. martong added a comment. Herald added a reviewer: shafik. - Add test which crashes in baseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64075/new/ https://reviews.llvm.org/D64075 Files: clang/li

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong added a comment. In D64075#1572676 , @a_sidorin wrote: > Hi Gabor, > The patch looks good, but it looks to me that it has a relation to > https://reviews.llvm.org/D64078 that is kind of questionable to me. Let's > delay landing this patch until

[PATCH] D64494: [analyzer]Add user docs rst

martong created this revision. martong added a reviewer: dkrupp. Herald added subscribers: cfe-commits, Charusso, gamesh411, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang. Add user documentation page.

[PATCH] D64494: [analyzer]Add user docs rst

martong added a comment. In D64494#1578373 , @dkrupp wrote: > I guess this is a placeholder for the subpages of "User Manual" @ > https://clang-analyzer.llvm.org, which will be ported in follow-up patches. Yes. Repository: rG LLVM Github Monorepo C

[PATCH] D64494: [analyzer]Add user docs rst

This revision was automatically updated to reflect the committed changes. Closed by commit rL365639: [analyzer]Add user docs rst (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D64494?

[PATCH] D64494: [analyzer]Add user docs rst

martong added a comment. > In any case, LGTM, if this really is a beginning of porting the already > existing documentation to sphinx. This is really the beginning of porting the existing docs to sphinx which is supposedly going to be done by @dkrupp. And I am planning to add new user manual d

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong marked an inline comment as done. martong added inline comments. Comment at: clang/include/clang/AST/ASTImporter.h:203 /// context, or the import error. -llvm::Expected Import_New(TypeSourceInfo *FromTSI); -// FIXME: Remove this version. -TypeSourceInfo *

[PATCH] D61786: [ASTImporter] Separate unittest files

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs, mgorny. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Move generic redecl chain tests and visibi

[PATCH] D61790: [C++20] add consteval specifier

martong resigned from this revision. martong added a comment. Herald added a subscriber: rnkovacs. ASTImporter.cpp looks good to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61790/new/ https://reviews.llvm.org/D61790 __

[PATCH] D61786: [ASTImporter] Separate unittest files

martong marked 8 inline comments as done. martong added a comment. Thanks for the review Alexei! Comment at: clang/unittests/AST/ASTImporterGenericRedeclTest.cpp:20 + +// FIXME put these structs and the tests rely on them into their own separate +// test file!

[PATCH] D61786: [ASTImporter] Separate unittest files

martong updated this revision to Diff 199225. martong marked 2 inline comments as done. martong added a comment. - Address Alexei's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61786/new/ https://reviews.llvm.org/D61786 Files: clang/un

[PATCH] D61786: [ASTImporter] Separate unittest files

This revision was automatically updated to reflect the committed changes. Closed by commit rC360572: [ASTImporter] Separate unittest files (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D61786?vs=199225&id=199226#toc Repository: rC Clang CHANGES SINC

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong added a comment. @aprantl Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong marked an inline comment as done. martong added inline comments. Comment at: clang/include/clang/AST/ASTImporter.h:203 /// context, or the import error. -llvm::Expected Import_New(TypeSourceInfo *FromTSI); -// FIXME: Remove this version. -TypeSourceInfo *

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong added a comment. Thank you guys for the review! In D61438#1501457 , @aprantl wrote: > Alright, thanks for taking the time to walk me through the thought process! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 199569. martong added a comment. - Rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 Files: clang/include/clang/AST/ASTImporter.h clang/lib/AST/ASTIm

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

This revision was automatically updated to reflect the committed changes. Closed by commit rL360760: [ASTImporter] Use llvm::Expected and Error in the importer API (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong updated this revision to Diff 199629. martong marked 13 inline comments as done. martong added a comment. - Address Shafik's comments and update assertions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44100/new/ https://reviews.llvm.org/D4

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:1643 +if (!ImportedOrErr) { + // For RecordDecls, failed import of a field will break the layout of the + // structure. Handle it as an error. shafik wrote: > What cases are failed i

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong updated this revision to Diff 200031. martong added a comment. - Rebase to master - Rebase to D62061 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 Files: clang/

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong marked an inline comment as done. martong added inline comments. Comment at: lldb/source/Symbol/ClangASTImporter.cpp:922 + + Log *log_ast(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_AST)); + if (log_ast) { shafik wrote: > I am going to sa

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong updated this revision to Diff 200033. martong added a comment. - se -> so Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest

[PATCH] D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. In most cases the FriendDecl contains the declarati

[PATCH] D62066: [ASTImporter] Enable disabled but passing tests

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Currently ASTImporter::NonEquivalentDecls member ke

[PATCH] D62066: [ASTImporter] Enable disabled but passing tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL361139: [ASTImporter] Enable disabled but passing tests (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:4259 static const RecordDecl * getRecordDeclOfFriend(FriendDecl *FD) { QualType Ty = FD->getFriendType()->getType(); + if (auto *Inner = dyn_cast(Ty.g

[PATCH] D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable

martong updated this revision to Diff 200435. martong marked an inline comment as done. martong added a comment. - Remove getUnderlyingType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62064/new/ https://reviews.llvm.org/D62064 Files: clang/lib

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

martong added a comment. The `ASTImporter.cpp` looks good to me. (Becasue the `BranchHint` is a simple an enum, so we don't need to specifically import that as we would in case of e.g. an `Expr`.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467

[PATCH] D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Structural equivalence did not handle dependent template args properly when the arg

[PATCH] D62373: [ASTImporter] Store import errors for Decls

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. We add a new member which is a mapping from the alr

[PATCH] D62375: [ASTImporter] Mark erroneous nodes in from ctx

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. During import of a specific Decl D, it may happen t

[PATCH] D62376: [ASTImporter] Mark erroneous nodes in shared st

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. This is the third step of the full error handling.

[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

martong added a comment. @shafik > We need to make sure we are running the lldb test suite before committing and > watching the bots to make sure the commit does not break them. I just have tested this patch on macOS and there seems to be no regression. Linux also seems to be without any regr

[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL348923: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull (authored by martong, committed by ). Hera

[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default

martong added a comment. The primary reason why want these to be Warnings instead of Errors because there are many false positive ODR Errors at the moment. These are not fatal errors but there is a maximum error count which once reached the whole process (analysis) is aborted. Usually, such fal

[PATCH] D53699: [ASTImporter] Fix inequality of functions with different attributes

martong updated this revision to Diff 178060. martong marked 2 inline comments as done. martong added a comment. - Add more tests and simplify comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53699/new/ https://reviews.llvm.org/D53699 Files: lib/AST/ASTSt

[PATCH] D53699: [ASTImporter] Fix inequality of functions with different attributes

martong marked 4 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTStructuralEquivalence.cpp:302 +/// is inspired by ASTContext::mergeFunctionTypes(), we compare calling +/// conventions bits but must not compare some other bits, e.g. the noreturn +//

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

martong added a comment. Hi Rafael, This is a great patch and good improvement, thank you! I had a few minor comments. (Also, I was thinking about what else could we import in the future, maybe definitions of C++11 enum classes would be also worth to be handled by CTU.) Comm

[PATCH] D55280: [CTU] Make loadExternalAST return with non nullptr on success

martong added a comment. Ping @a_sidorin Could you please take another look and consider my previous comment? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55280/new/ https://reviews.llvm.org/D55280 ___ cfe-commits

[PATCH] D53699: [ASTImporter] Fix inequality of functions with different attributes

martong added a comment. Ping @shafik, I have addressed you comments, could you please take another look? If you don't have any objections, could you please approve? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53699/new/ https://reviews.llvm.org/D53699

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

This revision was automatically updated to reflect the committed changes. Closed by commit rC349349: [ASTImporter] Fix redecl chain of classes and class templates (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D53655?vs=175641&id=178450#toc Repository:

[PATCH] D53708: [ASTImporter] Add importer specific lookup

martong updated this revision to Diff 178452. martong added a comment. - Rebase to master (trunk) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53708/new/ https://reviews.llvm.org/D53708 Files: include/clang/AST/ASTImporter.h include/clang/AST/ASTImporterLoo

[PATCH] D53708: [ASTImporter] Add importer specific lookup

This revision was automatically updated to reflect the committed changes. Closed by commit rL349351: [ASTImporter] Add importer specific lookup (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D53708: [ASTImporter] Add importer specific lookup

martong added a comment. > This is a perhaps a naive comment, but why is localUncachedLookup used instead of noload_lookup ? There is a fixme dating from 2013 stating that noload_lookup should be used instead. This is not a naive question. I was wondering myself on the very same thing when I st

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added a comment. Alexey, simply put, the crux of the problem is this: The imported decl context is different than what we get by calling the `getDeclContext()` on an imported field/friend of the "from" decl context. With other words: `import(cast(FromDC)` gives us a different value than

[PATCH] D53708: [ASTImporter] Add importer specific lookup

martong added a comment. In D53708#1332922 , @riccibruno wrote: > In D53708#1332868 , @martong wrote: > > > > This is a perhaps a naive comment, but why is localUncachedLookup used > > > instead of noload_lookup ?

[PATCH] D55280: [CTU] Make loadExternalAST return with non nullptr on success

This revision was automatically updated to reflect the committed changes. Closed by commit rC350521: [CTU] Make loadExternalAST return with non nullptr on success (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D55280?vs=176779&id=180479#toc Repository:

[PATCH] D56441: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external functions

martong accepted this revision. martong added a comment. Looks good to me (but xazax's comments are valid)! Thank you. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56441/new/ https://reviews.llvm.org/D56441 ___ cfe-

[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default

martong added a comment. Just a quick note. We are pretty sure that `StructuralEquivalency` can have false positive results, i.e. it can report two decls as nonequivalent falsely. My understanding is that we should report an error only if we are absolutely certain that an error has happened, th

[PATCH] D66336: [ASTImporter] Add development internals docs

This revision was automatically updated to reflect the committed changes. Closed by commit rL371839: [ASTImporter] Add development internals docs (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong updated this revision to Diff 220104. martong marked an inline comment as done. martong added a comment. - Initialize the variable template in test - Clean up tests for fun templates and for specializations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong marked 3 inline comments as done. martong added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:118 + template + constexpr T X; + )"; shafik wrote: > shafik wrote: > > Note this is not well-formed b/c it i

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong updated this revision to Diff 220130. martong added a comment. - Reorganize ODRStrategy independent behaviour tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 Files: clang/unittests/AST/ASTI

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong added a comment. I have reorganized the tests to group the ones which test ODR violation strategy independent behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 __

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong updated this revision to Diff 220338. martong marked 2 inline comments as done. martong added a comment. - PrevF->ImportedF, remove braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 Files: cl

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:274 +// There may be a hidden fwd spec decl before a function spec decl. +if (auto *PrevF = dyn_cast(ImportedD)) { + if (PrevF->getTemplatedKind() == bala

<    1   2   3   4   5   6   7   8   9   10   >