martong marked 3 inline comments as done. martong added a comment. > Thank you for the explanation. I got the idea of this patch anyway, but it > will be definitely useful for anyone digging into the code. Should we make it > a comment for ImportPathTy?
Ok, I have added the explanation to `ImportPathTy` as a class comment. ================ Comment at: clang/lib/AST/ASTImporter.cpp:8682 + +void ASTImporter::ImportPathTy::push(Decl *D) { + Nodes.push_back(D); ---------------- a_sidorin wrote: > I think these definitions are small enough to move them into the class > definitions. Ok, I have made them in-class defined. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62375/new/ https://reviews.llvm.org/D62375 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits