https://github.com/spaits created
https://github.com/llvm/llvm-project/pull/79881
Previously I worked on #78449 . I added tests in my solution #79371, but I
think there should be other scenarios that should be tested and these tests
deserve their namespace. In this PR I would like to make thes
https://github.com/spaits closed https://github.com/llvm/llvm-project/pull/79881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spaits wrote:
@steakhal we have also run the checker on multiple open source projects (a few
weeks ago) and it did not crash. (It did not have any findings. There were only
two C++ 17 projects and they had retrieved value from std::variant at most 20
times).
Could you please take another look
@@ -0,0 +1,104 @@
+//===- TaggedUnionModeling.h -*- C++
-*-==//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,104 @@
+//===- TaggedUnionModeling.h -*- C++
-*-==//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,104 @@
+//===- TaggedUnionModeling.h -*- C++
-*-==//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,104 @@
+//===- TaggedUnionModeling.h -*- C++
-*-==//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/66481
From ce62d3e1924b497b3e7160579a87557119c9e35d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 15 Sep 2023 10:21:30 +0200
Subject: [PATCH 1/3] [analyzer] Add std::variant checker
Adding a checker that check
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/66481
From ce62d3e1924b497b3e7160579a87557119c9e35d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 15 Sep 2023 10:21:30 +0200
Subject: [PATCH 1/4] [analyzer] Add std::variant checker
Adding a checker that check
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/66481
From ce62d3e1924b497b3e7160579a87557119c9e35d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 15 Sep 2023 10:21:30 +0200
Subject: [PATCH 1/4] [analyzer] Add std::variant checker
Adding a checker that check
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/66481
From 1948d226de16bda2899ca562276370d20ceba236 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 15 Sep 2023 10:21:30 +0200
Subject: [PATCH 1/4] [analyzer] Add std::variant checker
Adding a checker that check
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/66481
From 1948d226de16bda2899ca562276370d20ceba236 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 15 Sep 2023 10:21:30 +0200
Subject: [PATCH 1/5] [analyzer] Add std::variant checker
Adding a checker that check
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/66481
From 1948d226de16bda2899ca562276370d20ceba236 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 15 Sep 2023 10:21:30 +0200
Subject: [PATCH 1/6] [analyzer] Add std::variant checker
Adding a checker that check
@@ -0,0 +1,312 @@
+//===- StdVariantChecker.cpp -*- C++
-*-==//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/66481
From 91bc14998e08c60c1e425f141dbcf44c8579d166 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 15 Sep 2023 10:21:30 +0200
Subject: [PATCH] [analyzer] Add std::variant checker
Adding a checker that checks fo
spaits wrote:
Thank you for your time and effort for editing my commit @Szelethus and for
reviewing my commit @DonatNagyE @steakhal .
I have edited my commit based on your comments. These are the thing I have
added or changed:
+ Added a function to decide 'a' or 'an' should be used in the rep
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/66481
From da6f21f1d69814082cfcc0272c62445004276b07 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 15 Sep 2023 10:21:30 +0200
Subject: [PATCH] [analyzer] Add std::variant checker
Adding a checker that checks fo
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/66481
From ce62d3e1924b497b3e7160579a87557119c9e35d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 15 Sep 2023 10:21:30 +0200
Subject: [PATCH] [analyzer] Add std::variant checker
Adding a checker that checks fo
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/66481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spaits wrote:
@steakhal what do you think about the current version of this commit?
https://github.com/llvm/llvm-project/pull/66481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits created
https://github.com/llvm/llvm-project/pull/68691
In the following code
`
int main() {
struct Wrapper {char c; int &ref; };
Wrapper w = {.c = 'a', .ref = *(int *)0 };
w.ref = 1;
}`
The clang static analyzer will produce the following warnings and note
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/68691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/68691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits ready_for_review
https://github.com/llvm/llvm-project/pull/68691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/68691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/68691
From bb9cb77cab7b073d45c0b998c926a0b60a75a35e Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Tue, 10 Oct 2023 13:40:05 +0200
Subject: [PATCH 1/2] [analyzer] Fix note for member reference
---
.../Core/BugRepor
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/68691
From bb9cb77cab7b073d45c0b998c926a0b60a75a35e Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Tue, 10 Oct 2023 13:40:05 +0200
Subject: [PATCH 1/3] [analyzer] Fix note for member reference
---
.../Core/BugRepor
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/68691
From bb9cb77cab7b073d45c0b998c926a0b60a75a35e Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Tue, 10 Oct 2023 13:40:05 +0200
Subject: [PATCH 1/4] [analyzer] Fix note for member reference
---
.../Core/BugRepor
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/68691
From bb9cb77cab7b073d45c0b998c926a0b60a75a35e Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Tue, 10 Oct 2023 13:40:05 +0200
Subject: [PATCH 1/5] [analyzer] Fix note for member reference
---
.../Core/BugRepor
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/68691
From bb9cb77cab7b073d45c0b998c926a0b60a75a35e Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Tue, 10 Oct 2023 13:40:05 +0200
Subject: [PATCH 1/6] [analyzer] Fix note for member reference
---
.../Core/BugRepor
https://github.com/spaits created
https://github.com/llvm/llvm-project/pull/66481
As my BSc thesis I've implemented a checker for std::variant and std::any, and
in the following weeks I'll upload a revised version of them here.
# Prelude
@Szelethus and I sent out an email with our initial pla
https://github.com/spaits ready_for_review
https://github.com/llvm/llvm-project/pull/66481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/66481
From 5472e377f9a4b51a8c400f1cc1703aa83fa45d1b Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 15 Sep 2023 10:21:30 +0200
Subject: [PATCH] [analyzer] Add std::variant checker
Adding a checker that checks fo
@@ -0,0 +1,312 @@
+//===- StdVariantChecker.cpp -*- C++
-*-==//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/66481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/66481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits approved this pull request.
It looks good to me.
https://github.com/llvm/llvm-project/pull/82614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits closed https://github.com/llvm/llvm-project/pull/96407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits created
https://github.com/llvm/llvm-project/pull/87886
None
From b9d22d9ebc152ac0bccc7e196f8bbecc9302d833 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Sat, 13 Jan 2024 21:06:52 +0100
Subject: [PATCH 1/2] [analyzer] Implement modeling of std::swap and bind to
SV
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/87886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/87886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/87886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits created
https://github.com/llvm/llvm-project/pull/94752
This PR would solve issue #62925.
The following code:
```cpp
#include
int main() {
std::map m1 = {std::pair{"foo", 2}, {"bar", 3}}; // guide #2
std::map m2(m1.begin(), m1.end()); // guide #1
}
```
Is rejec
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/94752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spaits wrote:
@zyn0217 Thank you for checking my PR. I was able to simplify the
`std::initializer_list` definition. I have also created two different
"categories" for the test. One test contains almost the exact code as the one
in the reported issue with the same class names. The other one is
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/94752
From 8e1f3aa676b891c9566344ad2be046898df34a3a Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 7 Jun 2024 14:38:08 +0200
Subject: [PATCH 1/2] [CTAD] Allow user defined conversion
---
clang/include/clang/Se
spaits wrote:
@zyn0217 @cor3ntin Sorry to ping you. Could you please take another look at
this PR? Are my assumptions about the standard correct? Are the tests good now
or I should make other changes?
https://github.com/llvm/llvm-project/pull/94752
_
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/94752
From 8e1f3aa676b891c9566344ad2be046898df34a3a Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Fri, 7 Jun 2024 14:38:08 +0200
Subject: [PATCH 1/4] [CTAD] Allow user defined conversion
---
clang/include/clang/Se
spaits wrote:
> thanks, looks good.
Thank you for reviewing. When the CI run finishes and it is successful I will
merge this PR.
https://github.com/llvm/llvm-project/pull/94752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
https://github.com/spaits closed https://github.com/llvm/llvm-project/pull/94752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10892,8 +10892,6 @@ QualType
Sema::DeduceTemplateSpecializationFromInitializer(
// FIXME: The "second phase of [over.match.list] case can also
// theoretically happen here, but it's not clear whether we can
// ever have a parameter of the right type.
--
@@ -199,6 +199,12 @@ C++20 Feature Support
to update the ``__cpp_concepts`` macro to `202002L`. This enables
from libstdc++ to work correctly with Clang.
+- User defined constructors are allowed for copy-list-initialization with CTAD.
+ The example code for deduction
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/94752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits created
https://github.com/llvm/llvm-project/pull/96407
As discussed before with @cor3ntin before
(https://github.com/llvm/llvm-project/pull/94752) here is the simplification of
the release note written for the previously mentioned PR and the removal of a
comment th
https://github.com/spaits created
https://github.com/llvm/llvm-project/pull/112166
This PR would fix #16855 .
I think the correct lookup to use for class names is Tag name lookup, because
it does not take namespaces into account. The current lookup does and because
of this some valid programs
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/112166
From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Mon, 14 Oct 2024 10:12:42 +0200
Subject: [PATCH 1/3] Use tag name lookup for class names
This PR would fix #16855 .
https://github.com/spaits edited
https://github.com/llvm/llvm-project/pull/112166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/112166
From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Mon, 14 Oct 2024 10:12:42 +0200
Subject: [PATCH 1/2] Use tag name lookup for class names
This PR would fix #16855 .
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/112166
From 4afa9c58b3e662b8acab65f8afed820c3cbf54b5 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Mon, 14 Oct 2024 10:12:42 +0200
Subject: [PATCH] Use tag name lookup for class names
This PR would fix #16855 .
I
https://github.com/spaits closed
https://github.com/llvm/llvm-project/pull/112166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spaits wrote:
The windows CI passes. The linux CI fails, but it also fails on other clang
fronted PRs (see https://github.com/llvm/llvm-project/pull/112289 for example).
I think this failure is unrelated to this PR. I will merge this.
https://github.com/llvm/llvm-project/pull/112166
__
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/112166
From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Mon, 14 Oct 2024 10:12:42 +0200
Subject: [PATCH 01/11] Use tag name lookup for class names
This PR would fix #16855
@@ -357,10 +357,13 @@ ParsedType Sema::getTypeName(const IdentifierInfo &II,
SourceLocation NameLoc,
return nullptr;
}
- // FIXME: LookupNestedNameSpecifierName isn't the right kind of
- // lookup for class-names.
- LookupNameKind Kind = isClassName ? LookupNestedN
https://github.com/spaits edited
https://github.com/llvm/llvm-project/pull/112166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/112166
From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Mon, 14 Oct 2024 10:12:42 +0200
Subject: [PATCH 1/9] Use tag name lookup for class names
This PR would fix #16855 .
spaits wrote:
Thank you @Sirraide for reviewing. I will wait a few hours if other also want
to take a look at this, then I will squash the commits and merge the changes.
https://github.com/llvm/llvm-project/pull/112166
___
cfe-commits mailing list
cfe
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/112166
From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Mon, 14 Oct 2024 10:12:42 +0200
Subject: [PATCH 01/10] Use tag name lookup for class names
This PR would fix #16855
@@ -357,10 +357,13 @@ ParsedType Sema::getTypeName(const IdentifierInfo &II,
SourceLocation NameLoc,
return nullptr;
}
- // FIXME: LookupNestedNameSpecifierName isn't the right kind of
- // lookup for class-names.
- LookupNameKind Kind = isClassName ? LookupNestedN
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/112166
From 64aa2ad0fa41ac93db311c70d4113886fd4d6ffd Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Mon, 14 Oct 2024 10:12:42 +0200
Subject: [PATCH] Use tag name lookup for class names
This PR would fix #16855 .
I
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/112166
From 6935e90c94679129422cb00a7b05913b1ae83a5e Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Mon, 14 Oct 2024 10:12:42 +0200
Subject: [PATCH] Use tag name lookup for class names
This PR would fix #16855 .
I
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/112166
From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Mon, 14 Oct 2024 10:12:42 +0200
Subject: [PATCH 1/6] Use tag name lookup for class names
This PR would fix #16855 .
spaits wrote:
Thank you @Sirraide for reviewing my PR. I have added this change to the
release notes and addressed the other comments.
https://github.com/llvm/llvm-project/pull/112166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/112166
From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Mon, 14 Oct 2024 10:12:42 +0200
Subject: [PATCH 1/7] Use tag name lookup for class names
This PR would fix #16855 .
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/112166
From e9d43ef25b882071822cf3f16a988197c07967b1 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Mon, 14 Oct 2024 10:12:42 +0200
Subject: [PATCH 1/8] Use tag name lookup for class names
This PR would fix #16855 .
@@ -151,6 +151,8 @@ C++ Language Changes
- The builtin type alias ``__builtin_common_type`` has been added to improve
the
performance of ``std::common_type``.
+- During the lookup for a base class name, non-type names are ignored.
+
spaits wrote:
Sorry I d
101 - 175 of 175 matches
Mail list logo
