[PATCH] D132742: [X86][BF16] Add type mangling for Windows

FreddyYe accepted this revision. FreddyYe added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132742/new/ https://reviews.llvm.org/D132742 __

[PATCH] D133094: [X86] Add missing key feature for core2

FreddyYe created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D133094: [X86] Add missing key feature for core2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66f332bc1ac0: [X86] Add missing key feature for core2 (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D130964: Enable __bf16 for x86 targets.

FreddyYe created this revision. Herald added subscribers: luke957, pengfei, s.egerton, simoncook. Herald added a project: All. FreddyYe requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, pcwang-thead. Herald added projects: clang, LLVM. X86 psABI has updated to

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

FreddyYe added a comment. In D130964#3694540 , @bkramer wrote: > In D130964#3694473 , @rjmccall > wrote: > >> How are you actually implementing `__bf16` on these targets? There isn't >> even hardware support fo

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

FreddyYe added a comment. > Right, but this patch is adding x86 support whenever SSE2 is available. > AVX512BF16 is available on a *very* small slice of processors. In contrast, > e.g. F16C is relatively broadly available, although I understand that we > formally support `_Float16` all the wa

[PATCH] D106849: [NFC][X86] add missing tests in clang/test/CodeGen/attr-target-mv.c

FreddyYe created this revision. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106849 Files: clang/test/CodeGen/attr-target-mv.c Index: clang/test/CodeGen/attr-

[PATCH] D106849: [NFC][X86] add missing tests in clang/test/CodeGen/attr-target-mv.c

FreddyYe updated this revision to Diff 361908. FreddyYe added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106849/new/ https://reviews.llvm.org/D106849 Files: clang/test/CodeGen/attr-target-mv.c Index: clang/test/CodeGen/attr-t

[PATCH] D106849: [NFC][X86] add missing tests in clang/test/CodeGen/attr-target-mv.c

FreddyYe updated this revision to Diff 361919. FreddyYe added a comment. lowering pre-merge issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106849/new/ https://reviews.llvm.org/D106849 Files: clang/test/CodeGen/attr-target-mv.c Index: cl

[PATCH] D106849: [NFC][X86] add missing tests in clang/test/CodeGen/attr-target-mv.c

FreddyYe updated this revision to Diff 361935. FreddyYe added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106849/new/ https://reviews.llvm.org/D106849 Files: clang/test/CodeGen/attr-target-mv.c Index: clang/test/CodeGen/att

[PATCH] D106849: [NFC][X86] add missing tests in clang/test/CodeGen/attr-target-mv.c

FreddyYe updated this revision to Diff 362596. FreddyYe added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106849/new/ https://reviews.llvm.org/D106849 Files: clang/test/CodeGen/attr-target-mv.c Index: clang/test/CodeGen/att

[PATCH] D106849: [NFC][X86] add missing tests in clang/test/CodeGen/attr-target-mv.c

This revision was automatically updated to reflect the committed changes. Closed by commit rG58712987e56f: [NFC][X86] add missing tests in clang/test/CodeGen/attr-target-mv.c (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10684

[PATCH] D86503: [X86] Support -march=sapphirerapids

FreddyYe created this revision. FreddyYe added reviewers: craig.topper, pengfei, LuoYuanke. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, hiraditya. Herald added projects: clang, Sanitizers, LLVM. FreddyYe requested review of this revision. Support -march=sapphirerapids for x86.

[PATCH] D86503: [X86] Support -march=sapphirerapids

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe02d081f2b60: [X86] Support -march=sapphirerapids (authored by FreddyYe). Changed prior to commit: https://reviews.llvm.org/D86503?vs=287547&id=28

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

FreddyYe created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. FreddyYe requested review of this revision. Tremont microarchitecture only has GFNI(SSE) version, not AVX and AVX512 version. This patch is to avoid compiling fail on Windows when using -march=tr

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

FreddyYe added a comment. The fails are all unknown type errors on Windows, since those typedefs are declared in other header files. The error message goes like: $ clang -march=tremont gfni.c .. ...\lib\clang\12.0.0\include\gfniintrin.h:129:37: error: unknown type name '__mmask

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

FreddyYe added a comment. In D90822#2375423 , @pengfei wrote: > Craig's method sounds good. > @FreddyYe , Why we check AVX512BW instead of AVX512F. I saw SDM says it > depends on AVX512F. I was referring to the old implement and test case. Seems like a e

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

FreddyYe updated this revision to Diff 303047. FreddyYe added a comment. Use header file macros instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews.llvm.org/D90822 Files: clang/lib/Headers/gfniintrin.h Index: clang

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

FreddyYe updated this revision to Diff 303073. FreddyYe added a comment. Reorganize intrinsic orders to avoid using nested macros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews.llvm.org/D90822 Files: clang/lib/Headers/

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

FreddyYe marked 3 inline comments as done. FreddyYe added inline comments. Comment at: clang/lib/Headers/gfniintrin.h:131-138 #define _mm512_mask_gf2p8affine_epi64_epi8(S, U, A, B, I) \ (__m512i)__builtin_ia32_selectb_512((__mmask64)(U), \

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

FreddyYe updated this revision to Diff 303087. FreddyYe marked an inline comment as done. FreddyYe added a comment. Refine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews.llvm.org/D90822 Files: clang/lib/Headers/gfniintr

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e312e004197: [X86] use macros to split GFNI intrinsics into different kinds (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D95421: [NFC] Refine some uninitialized used variables.

FreddyYe created this revision. Herald added subscribers: pengfei, tpr, hiraditya, qcolombet, MatzeB. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. These warning are reported by static code analysis tool: Klocwo

[PATCH] D95421: [NFC] Refine some uninitialized used variables.

FreddyYe updated this revision to Diff 319216. FreddyYe added a comment. refine according to Lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95421/new/ https://reviews.llvm.org/D95421 Files: clang/lib/CodeGen/CGBlocks.cpp llvm/lib/CodeGen/R

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D95421: [NFC] Refine some uninitialized used variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3b0acdc6fb5: [NFC] Refine some uninitialized used variables. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95421/new/ https://revie

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2490 + continue; +std::string::size_type position1 = Constraints.find("={eax}"); +if (position1 != std::string::npos) { pengfei wrote: > If `Clobber` is `edx` only,

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe updated this revision to Diff 319282. FreddyYe added a comment. If Clobber is edx only, don't change "={eax}" to "=&{eax}". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGe

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe updated this revision to Diff 319284. FreddyYe added a comment. refine clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/ms-inl

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

This revision was automatically updated to reflect the committed changes. Closed by commit rG1edb76cc91e7: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

FreddyYe created this revision. Herald added subscribers: s.egerton, simoncook, fedor.sergeev. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110798 Files: clang/

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

FreddyYe added a comment. I found the old way cannot verify if there are some extra outputs between two different CHECK-SAME. So I changed to CHECK-NEXT. But it will introduce bad format issue. Anyway, the old way has broken clang-format already. So I would prefer the CHECK-NEXT. WDYT? Reposi

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

FreddyYe added inline comments. Comment at: clang/test/Misc/target-invalid-cpu-note.c:33 -// X86_64: note: valid target CPU values are: nocona, core2, penryn, bonnell, -// X86_64-SAME: atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, -// X86_64

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

FreddyYe added a comment. > In principle I agree but did you have this failure mode actually happen? No failure happens for now, but may happen in the future if we continue to use -SAME. Pls read the example I gave in last comment. > Not sure I like crazy long lines, but I see that -NEXT then -

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe created this revision. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When __builtin_mul_overflow has input combination of (signed, signed, unsigned*) and arbitary width is larger than 64 bits, it will also generate i256

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe updated this revision to Diff 363950. FreddyYe added a comment. update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107420/new/ https://reviews.llvm.org/D107420 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D107420: [WIP][sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe added a comment. I just realized that LLVM has a gap with GCC due to the compiler-rt call. Check this example: https://gcc.godbolt.org/z/8Pf7zErr7 I need further investigation to know why this gap happens. Pls don't review the code. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D107420: [WIP][sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe updated this revision to Diff 363991. FreddyYe added a comment. rebase and refactor clang-format and clang-tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107420/new/ https://reviews.llvm.org/D107420 Files: clang/include/clang/Basic

[PATCH] D107420: [WIP][sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe updated this revision to Diff 364154. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comments. I'll refactor clang-format later. Pls help review the new condition and diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe marked an inline comment as done. FreddyYe added a comment. Addressed. THX review! Comment at: clang/test/Sema/builtins-overflow.c:45 +unsigned _ExtInt(128) result; +_Bool status = __builtin_mul_overflow(x, y, &result); // expected-error {{__builtin_mul_overfl

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8351-8353 +def err_overflow_builtin_special_combination_max_size : Error< + "__builtin_mul_overflow does not suport unsigned overflow check aft

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe updated this revision to Diff 364349. FreddyYe added a comment. update lit test, clang-format, if condition, diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107420/new/ https://reviews.llvm.org/D107420 Files: clang/include/clan

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe added a comment. In D107420#2927856 , @lebedev.ri wrote: > I don't personally care, but i think this diag doesn't make sense. > What is "backend"? Which one? All of them? What happens when one, but not all > of them supports it? > What if i don

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe added a comment. In D107420#2928975 , @craig.topper wrote: > I put up a patch for a simple fix for this in the backend. > https://reviews.llvm.org/D107581 The generated code is not optimal, but > maybe better than frontend workarounds. THX f

[PATCH] D107946: [X86] Reverse *_set_ph and *_setr_ph 's set order.

FreddyYe created this revision. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107946 Files: clang/lib/Headers/avx512fp16intrin.h clang/lib/Headers/avx512vlfp16

[PATCH] D107946: [X86] Reverse *_set_ph and *_setr_ph 's set order.

FreddyYe updated this revision to Diff 365923. FreddyYe added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107946/new/ https://reviews.llvm.org/D107946 Files: clang/lib/Headers/avx512fp16intrin.h clang/lib/Headers

[PATCH] D107946: [X86] Reverse *_set_ph and *_setr_ph 's set order.

FreddyYe marked an inline comment as done. FreddyYe added a comment. THX for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107946/new/ https://reviews.llvm.org/D107946 ___ cfe-commits mailing lis

[PATCH] D107946: [X86] Reverse *_set_ph and *_setr_ph 's set order.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c1468854d70: [X86] Reverse *_set_ph and *_setr_ph 's set order. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

FreddyYe created this revision. Herald added subscribers: jeroen.dobbelaere, pengfei. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. *_mul_pch is to align with *_mul_ps annd *_mul_pd Repository: rG LLVM Github Monorepo https:

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

FreddyYe added a comment. In D112777#3095847 , @pengfei wrote: >> *_mul_pch is to align with *_mul_ps annd *_mul_pd > > And *_mul_ph? Yes. Corrected in summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

FreddyYe updated this revision to Diff 383702. FreddyYe added a comment. clang-formats. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/ https://reviews.llvm.org/D112777 Files: clang/lib/Headers/avx512fp16intrin.h clang/lib/Headers/av

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

FreddyYe added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/ https://reviews.llvm.org/D112777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

FreddyYe added a comment. In D112777#3114502 , @craig.topper wrote: > Not directly related to this patch, but why is the suffix _pch and _sch when > the instruction names end in CPH and CSH? It kind of seems like the correct > intrinsic name would have

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

FreddyYe added a comment. Thx for review. I found I missed many intrinsics, including _fcmul_* series. they need to be aliased with cmul_*. pls wait for update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/ https://reviews.llvm.org/D11

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

FreddyYe added a comment. In D112777#3114566 , @craig.topper wrote: > In D112777#3114560 , @FreddyYe > wrote: > >> In D112777#3114502 , @craig.topper >> wrote: >> >>> N

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

FreddyYe updated this revision to Diff 385443. FreddyYe added a comment. address comments. add alias for 36 intrinsics in all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/ https://reviews.llvm.org/D112777 Files: clang/lib/Headers/av

[PATCH] D97832: [X86] Refine "Support -march=alderlake"

FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97832 Files: clang/

[PATCH] D97832: [X86] Refine "Support -march=alderlake"

FreddyYe updated this revision to Diff 327691. FreddyYe added a comment. delete extra spaces. THX for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97832/new/ https://reviews.llvm.org/D97832 Files: clang/test/Preprocessor/predefined-arch

[PATCH] D97832: [X86] Refine "Support -march=alderlake"

FreddyYe marked an inline comment as done. FreddyYe added a comment. THX for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97832/new/ https://reviews.llvm.org/D97832 ___ cfe-commits mailing list

[PATCH] D97832: [X86] Refine "Support -march=alderlake"

FreddyYe added a comment. No more comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97832/new/ https://reviews.llvm.org/D97832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D97832: [X86] Refine "Support -march=alderlake"

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f9489b75405: [X86] Refine "Support -march=alderlake" (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97832/new/ https://reviews.llvm.

[PATCH] D112777: [X86][FP16] add alias for f*mul_*ch intrinsics

FreddyYe added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/ https://reviews.llvm.org/D112777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D112777: [X86][FP16] add alias for f*mul_*ch intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG73c9cf820409: [X86][FP16] add alias for f*mul_*ch intrinsics (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/ https://revie

[PATCH] D114059: [X86] add 3 missing intrinsics: _mm_(mask/maskz)_cvtpbh_ps

FreddyYe created this revision. Herald added a subscriber: pengfei. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114059 Files: clang/lib/Headers/avx512vlbf16int

[PATCH] D114059: [X86] add 3 missing intrinsics: _mm_(mask/maskz)_cvtpbh_ps

FreddyYe updated this revision to Diff 387845. FreddyYe added a comment. convertion -> conversion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114059/new/ https://reviews.llvm.org/D114059 Files: clang/lib/Headers/avx512bf16intrin.h clang/lib

[PATCH] D114059: [X86] add 3 missing intrinsics: _mm_(mask/maskz)_cvtpbh_ps

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb9dc0c78f97: [X86] add 3 missing intrinsics: _mm_(mask/maskz)_cvtpbh_ps (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114059/new/ h

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe marked 2 inline comments as done. FreddyYe added a comment. In D135938#3864521 , @RKSimon wrote: > Can you fix the MC + disasm test file names - drop att/intel and ensure you > test both syntaxes for 32 and 64 bits. > > Ideally the 32/64 bit nam

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll:6 + +declare <4 x i32> @llvm.x86.avx2.vpdpbssd.128(<4 x i32>, <4 x i32>, <4 x i32>) + craig.topper wrote: > Are there tests for commuting? Hi Craig, Can you show an exampl

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll:6 + +declare <4 x i32> @llvm.x86.avx2.vpdpbssd.128(<4 x i32>, <4 x i32>, <4 x i32>) + craig.topper wrote: > FreddyYe wrote: > > craig.topper wrote: > > > Are there tests f

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:110 INTEL_COREI7_ROCKETLAKE, + ZHAOXIN_FAM7H_LUJIAZUI, + INTEL_COREI7_RAPTORLAKE, skan wrote: > typo ? (ZHAOXIN_FAM7H_LUJIAZUI) I thin

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:259 +"Support CMPCCXADD instructions", +[FeatureAVX2]>; def FeatureINVPCID : SubtargetFeature<"invpcid", "HasINVPCID", "true", -

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe marked 2 inline comments as done. FreddyYe added a comment. > Its not a priority, but if you are ever bored and want to do some cleaning > then it help! I see. Then we are on the same side. I'll clean if I had time after landing these patches. Repository: rG LLVM Github Monorepo C

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

FreddyYe marked 4 inline comments as done. FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86InstrCompiler.td:1026 +let Predicates = [HasCMPCCXADD, In64BitMode], Defs = [EFLAGS], +Constraints = "$dstsrc2 = $dst" in { craig.topper wrote: >

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

FreddyYe updated this revision to Diff 469529. FreddyYe marked 3 inline comments as done. FreddyYe added a comment. Address comments. THX for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932 Files:

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

FreddyYe added inline comments. Comment at: clang/lib/Headers/cmpccxaddintrin.h:19-34 + _CMPCCX_O, /* Overflow. */ + _CMPCCX_NO, /* No overflow. */ + _CMPCCX_B, /* Below. */ + _CMPCCX_NB, /* Not below. */ + _CMPCCX_Z, /* Zero. */ + _CMPCCX_NZ, /* Not zero. */

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp:1453-1455 +emitMemModRMByte(MI, CurOp + 1, getX86RegNum(MI.getOperand(0)), TSFlags, + HasREX, StartByte, OS, Fixups, STI, false); +CurOp = SrcRegNum + 3;

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

FreddyYe updated this revision to Diff 471014. FreddyYe marked 4 inline comments as done. FreddyYe added a comment. Address comments and update. THX for review: Added llvm/test/CodeGen/X86/stack-folding-int-avx512ifma.ll and llvm/test/CodeGen/X86/stack-folding-int-avxifma.ll. Repository: rG L

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

FreddyYe updated this revision to Diff 471022. FreddyYe added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/BuiltinsX8

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

FreddyYe added inline comments. Comment at: clang/lib/Headers/avxifmaintrin.h:36 +/// __m128i +/// _mm_madd52hi_avx_epu64 (__m128i __X, __m128i __Y, __m128i __Z) +/// \endcode pengfei wrote: > Should we provide unified intrinsic `_mm_madd52hi_epu64` like AVXVNNI?

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:205 X86_FEATURE (AVX512FP16, "avx512fp16") +X86_FEATURE (AVXVNNIINT8, "avxvnniint8") X86_FEATURE (AVXVNNI, "avxvnni") skan wrote: > Move

[PATCH] D135951: [X86][1/2] SUPPORT RAO-INT

FreddyYe added inline comments. Comment at: clang/docs/ReleaseNotes.rst:553 - Fix 32-bit ``__fastcall`` and ``__vectorcall`` ABI mismatch with MSVC. +- Add support for ``RAO-INT`` instructions. Add bullets for supported intrinsics. Comment a

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

FreddyYe updated this revision to Diff 471033. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932 Files: clang/docs/Rel

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

FreddyYe updated this revision to Diff 471350. FreddyYe added a comment. Rebase. THX for all of the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932 Files: clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e720e6adad1: [X86] Add AVX-IFMA instructions. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/avxneconvert-intrinsics.ll:4 +; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=i686-unknown-unknown --show-mc-encoding -mattr=+avxneconvert | FileCheck %s --check-prefixes=X86 + +define <4 x float> @test_int_x86

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:164 +#define _mm_cvtneps_pbh(A) \ + ((__m128bh)__builtin_ia32_vcvtneps2bf16128((__v4sf)(A))) pengfei wrote: > pengfei wrote: > > RKSim

[PATCH] D135937: [WIP][X86] Support -march=raptorlake, meteorlake

FreddyYe updated this revision to Diff 471938. FreddyYe marked an inline comment as done. FreddyYe added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135937/new/ https://reviews.llvm.org/D135937 Files: clang/docs/ReleaseNotes

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:164 +#define _mm_cvtneps_pbh(A) \ + ((__m128bh)__builtin_ia32_vcvtneps2bf16128((__v4sf)(A))) pengfei wrote: > FreddyYe wrote: > > peng

[PATCH] D135937: [WIP][X86] Support -march=raptorlake, meteorlake

FreddyYe updated this revision to Diff 472203. FreddyYe marked 7 inline comments as done. FreddyYe added a comment. Address comments and update to align with gcc. See my latest comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135937/new/ htt

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

FreddyYe added a comment. For saving capacity of ProcessorSubtypes, gcc decided to not support part of compiler features of these two cpus: __builtin_cpu_is("meteorlake") __attribute__((target("arch=raptorlake"))) ... some others I don't know. Updated to align with gcc first. Welcome opin

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

FreddyYe added a comment. In D135937#3898228 , @FreddyYe wrote: > For saving capacity of ProcessorSubtypes, gcc decided to not support part of > compiler features of these two cpus: > > __builtin_cpu_is("meteorlake") > __attribute__((target("arch=rap

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Githu

[PATCH] D135932: Add AVX-IFMA instructions.

FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. For more details about these instructions, please refer to

[PATCH] D135936: [X86] Support -march=raptorlake

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Githu

[PATCH] D135937: [X86] Support -march=meteorlake

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Githu

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe added a comment. I'm out of machines next two days. Sorry for late address in advance... I'll update next Monday. Thanks for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 _

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe marked 4 inline comments as done. FreddyYe added a comment. THX for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 ___ cfe-commits mailing lis

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

FreddyYe marked 5 inline comments as done. FreddyYe added a comment. THX for reviews! Comment at: clang/lib/Headers/immintrin.h:257 +/* FIXME: Change these When _Float16 type is supported */ +#if defined(__AVXNECONVERT__) && defined(__AVX512FP16__) pengfei wr

[PATCH] D135936: [X86] Support -march=raptorlake

FreddyYe marked 4 inline comments as done. FreddyYe added a comment. THX for review! Merged to https://reviews.llvm.org/D135937 and addressed there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135936/new/ https://reviews.llvm.org/D135936 ___

[PATCH] D135937: [X86] Support -march=meteorlake

FreddyYe updated this revision to Diff 468387. FreddyYe added a comment. Merge raptorlake patch and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135937/new/ https://reviews.llvm.org/D135937 Files: clang/docs/ReleaseNotes.rst

  1   2   3   4   >