FreddyYe added inline comments.
================ Comment at: clang/test/Misc/target-invalid-cpu-note.c:33 -// X86_64: note: valid target CPU values are: nocona, core2, penryn, bonnell, -// X86_64-SAME: atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, -// X86_64-SAME: sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, ---------------- I forgot to give an example, sorry. For example, if I delete the last target-cpu `bonnell,` here, this lit test can still pass. And if I delete any of the first or the last target-cpu on each of -SAME line in this file, the test can still pass. That is my concern. Fortunately, when I changed this file to -NEXT, no new fails happen this time, which means no missing CPUs between different -SAME in the old file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110798/new/ https://reviews.llvm.org/D110798 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
